48436 2010-10-27 10:20:51 -0700 REGRESSION (r70335): Incorrect article layout in Safari Reader 2010-12-14 17:57:21 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 mitz mitz oldest_to_newest 300334 0 mitz 2010-10-27 10:20:51 -0700 REGRESSION (r70335): Incorrect article layout in Safari Reader 300344 1 72054 mitz 2010-10-27 10:26:02 -0700 Created attachment 72054 Disable the cross-origin check in getMatchedCSSRules in versions of Safari lined against versions of WebKit that didn’t have the check 300366 2 72054 darin 2010-10-27 10:58:49 -0700 Comment on attachment 72054 Disable the cross-origin check in getMatchedCSSRules in versions of Safari lined against versions of WebKit that didn’t have the check View in context: https://bugs.webkit.org/attachment.cgi?id=72054&action=review > WebCore/ChangeLog:9 > + (WebCore::DOMWindow::getMatchedCSSRules): Return rules from all origins if the corss-origin Typo: corss > WebCore/page/DOMWindow.cpp:1257 > Document* doc = m_frame->document(); This local variable doesn’t seem to keep its weight. > WebCore/page/Settings.h:336 > + bool disableGetMatchedCSSRulesCrossOriginCheck() const { return m_disableGetMatchedCSSRulesCrossOriginCheck; } For functions that return booleans, I prefer that we not use verb phrases such as “disable”. > WebCore/page/Settings.h:425 > + bool m_disableGetMatchedCSSRulesCrossOriginCheck : 1; Same thing for data members. 300367 3 72054 darin 2010-10-27 11:00:55 -0700 Comment on attachment 72054 Disable the cross-origin check in getMatchedCSSRules in versions of Safari lined against versions of WebKit that didn’t have the check View in context: https://bugs.webkit.org/attachment.cgi?id=72054&action=review >> WebCore/page/DOMWindow.cpp:1257 >> Document* doc = m_frame->document(); > > This local variable doesn’t seem to keep its weight. Sorry, I meant to say “doesn’t improve readability or clarity and is only used once”. 300593 4 mitz 2010-10-27 14:39:19 -0700 Fixed in <http://trac.webkit.org/changeset/70714>. 307437 5 ap 2010-11-10 10:59:49 -0800 Marking as resolved per the above. 322407 6 ddkilzer 2010-12-14 17:57:21 -0800 <rdar://problem/8591336> 72054 2010-10-27 10:26:02 -0700 2010-10-27 11:00:55 -0700 Disable the cross-origin check in getMatchedCSSRules in versions of Safari lined against versions of WebKit that didn’t have the check 48436_r1.diff text/plain 5614 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDY2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMTAtMjcgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdS RVNTSU9OIChyNzAzMzUpOiBJbmNvcnJlY3QgYXJ0aWNsZSBsYXlvdXQgaW4gU2FmYXJpIFJlYWRl cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg0MzYK KworICAgICAgICAqIHBhZ2UvRE9NV2luZG93LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTVdp bmRvdzo6Z2V0TWF0Y2hlZENTU1J1bGVzKTogUmV0dXJuIHJ1bGVzIGZyb20gYWxsIG9yaWdpbnMg aWYgdGhlIGNvcnNzLW9yaWdpbgorICAgICAgICBjaGVjayBpcyBkaXNhYmxlZC4KKyAgICAgICAg KiBwYWdlL1NldHRpbmdzLmg6CisgICAgICAgIChXZWJDb3JlOjpTZXR0aW5nczo6c2V0RGlzYWJs ZUdldE1hdGNoZWRDU1NSdWxlc0Nyb3NzT3JpZ2luQ2hlY2spOiBBZGRlZCB0aGlzIGFjY2Vzc29y LgorICAgICAgICAoV2ViQ29yZTo6U2V0dGluZ3M6OmRpc2FibGVHZXRNYXRjaGVkQ1NTUnVsZXND cm9zc09yaWdpbkNoZWNrKTogRGl0dG8uCisKIDIwMTAtMTAtMjcgIExlYW5kcm8gR3JhY2lhIEdp bCAgPGxlYW5kcm9ncmFjaWFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKZXJl bXkgT3Jsb3cuCkluZGV4OiBXZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAkocmV2aXNpb24gNzA2NTcpCisrKyBXZWJDb3Jl L3BhZ2UvRE9NV2luZG93LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI1NSw3ICsxMjU1LDggQEAg UGFzc1JlZlB0cjxDU1NSdWxlTGlzdD4gRE9NV2luZG93OjpnZXRNYQogICAgICAgICByZXR1cm4g MDsKIAogICAgIERvY3VtZW50KiBkb2MgPSBtX2ZyYW1lLT5kb2N1bWVudCgpOwotICAgIHJldHVy biBkb2MtPnN0eWxlU2VsZWN0b3IoKS0+c3R5bGVSdWxlc0ZvckVsZW1lbnQoZWx0LCBhdXRob3JP bmx5LCBmYWxzZSwgU2FtZU9yaWdpbkNTU1J1bGVzT25seSk7CisgICAgU2V0dGluZ3MqIHNldHRp bmdzID0gbV9mcmFtZS0+c2V0dGluZ3MoKTsKKyAgICByZXR1cm4gZG9jLT5zdHlsZVNlbGVjdG9y KCktPnN0eWxlUnVsZXNGb3JFbGVtZW50KGVsdCwgYXV0aG9yT25seSwgZmFsc2UsIHNldHRpbmdz ICYmIHNldHRpbmdzLT5kaXNhYmxlR2V0TWF0Y2hlZENTU1J1bGVzQ3Jvc3NPcmlnaW5DaGVjaygp ID8gQWxsQ1NTUnVsZXMgOiBTYW1lT3JpZ2luQ1NTUnVsZXNPbmx5KTsKIH0KIAogUGFzc1JlZlB0 cjxXZWJLaXRQb2ludD4gRE9NV2luZG93Ojp3ZWJraXRDb252ZXJ0UG9pbnRGcm9tTm9kZVRvUGFn ZShOb2RlKiBub2RlLCBjb25zdCBXZWJLaXRQb2ludCogcCkgY29uc3QKSW5kZXg6IFdlYkNvcmUv cGFnZS9TZXR0aW5ncy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9TZXR0aW5ncy5oCShy ZXZpc2lvbiA3MDY1NykKKysrIFdlYkNvcmUvcGFnZS9TZXR0aW5ncy5oCSh3b3JraW5nIGNvcHkp CkBAIC0zMzIsNiArMzMyLDkgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB2b2lkIHNl dEh5cGVybGlua0F1ZGl0aW5nRW5hYmxlZChib29sIGZsYWcpIHsgbV9oeXBlcmxpbmtBdWRpdGlu Z0VuYWJsZWQgPSBmbGFnOyB9CiAgICAgICAgIGJvb2wgaHlwZXJsaW5rQXVkaXRpbmdFbmFibGVk KCkgY29uc3QgeyByZXR1cm4gbV9oeXBlcmxpbmtBdWRpdGluZ0VuYWJsZWQ7IH0KIAorICAgICAg ICB2b2lkIHNldERpc2FibGVHZXRNYXRjaGVkQ1NTUnVsZXNDcm9zc09yaWdpbkNoZWNrKGJvb2wg ZmxhZykgeyBtX2Rpc2FibGVHZXRNYXRjaGVkQ1NTUnVsZXNDcm9zc09yaWdpbkNoZWNrID0gZmxh ZzsgfQorICAgICAgICBib29sIGRpc2FibGVHZXRNYXRjaGVkQ1NTUnVsZXNDcm9zc09yaWdpbkNo ZWNrKCkgY29uc3QgeyByZXR1cm4gbV9kaXNhYmxlR2V0TWF0Y2hlZENTU1J1bGVzQ3Jvc3NPcmln aW5DaGVjazsgfQorCiAgICAgcHJpdmF0ZToKICAgICAgICAgUGFnZSogbV9wYWdlOwogCkBAIC00 MTksNiArNDIyLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBib29sIG1faW50ZXJh Y3RpdmVGb3JtVmFsaWRhdGlvbjogMTsKICAgICAgICAgYm9vbCBtX3VzZVByZUhUTUw1UGFyc2Vy UXVpcmtzOiAxOwogICAgICAgICBib29sIG1faHlwZXJsaW5rQXVkaXRpbmdFbmFibGVkIDogMTsK KyAgICAgICAgYm9vbCBtX2Rpc2FibGVHZXRNYXRjaGVkQ1NTUnVsZXNDcm9zc09yaWdpbkNoZWNr IDogMTsKIAogI2lmIFVTRShTQUZBUklfVEhFTUUpCiAgICAgICAgIHN0YXRpYyBib29sIGdTaG91 bGRQYWludE5hdGl2ZUNvbnRyb2xzOwpJbmRleDogV2ViS2l0L21hYy9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDcwNjY1KQorKysgV2ViS2l0 L21hYy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMC0y NyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04gKHI3MDMzNSk6IEluY29ycmVj dCBhcnRpY2xlIGxheW91dCBpbiBTYWZhcmkgUmVhZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODQzNgorCisgICAgICAgICogTWlzYy9XZWJLaXRW ZXJzaW9uQ2hlY2tzLmg6IEFkZGVkIFdFQktJVF9GSVJTVF9WRVJTSU9OX1dJVEhfR0VUX01BVENI RURfQ1NTX1JVTEVTX1JFU1RSSUNUSU9OUy4KKyAgICAgICAgKiBXZWJWaWV3L1dlYlZpZXcubW06 CisgICAgICAgICgtW1dlYlZpZXcgX25lZWRzVW5yZXN0cmljdGVkR2V0TWF0Y2hlZENTU1J1bGVz XSk6IEFkZGVkLiBSZXR1cm5zIFlFUyBmb3IgU2FmYXJpIGxpbmtlZCBhZ2FpbnN0CisgICAgICAg IHZlcnNpb25zIG9mIFdlYktpdCB0aGF0IGRpZCBub3QgaGF2ZSB0aGUgY3Jvc3Mtb3JpZ2luIHJl c3RyaWN0aW9ucyBpbiBnZXRNYXRjaGVkQ1NTUnVsZXMoKS4KKyAgICAgICAgKC1bV2ViVmlldyBf cHJlZmVyZW5jZXNDaGFuZ2VkTm90aWZpY2F0aW9uOl0pOiBDYWxsIFNldHRpbmdzOjpzZXREaXNh YmxlR2V0TWF0Y2hlZENTU1J1bGVzQ3Jvc3NPcmlnaW5DaGVjaygpCisgICAgICAgIGJhc2VkIG9u IHRoZSBhYm92ZS4KKwogMjAxMC0xMC0yNiAgSmVubiBCcmFpdGh3YWl0ZSAgPGplbm5iQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEbWl0cnkgVGl0b3YuCkluZGV4OiBXZWJL aXQvbWFjL01pc2MvV2ViS2l0VmVyc2lvbkNoZWNrcy5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9t YWMvTWlzYy9XZWJLaXRWZXJzaW9uQ2hlY2tzLmgJKHJldmlzaW9uIDcwNjU3KQorKysgV2ViS2l0 L21hYy9NaXNjL1dlYktpdFZlcnNpb25DaGVja3MuaAkod29ya2luZyBjb3B5KQpAQCAtNTUsNiAr NTUsNyBAQAogI2RlZmluZSBXRUJLSVRfRklSU1RfVkVSU0lPTl9XSVRIT1VUX0NPTlRFTlRfU05J RkZJTkdfRk9SX0ZJTEVfVVJMUyAweDAyMTIwQTAwIC8vIDUzMC4xMC4wCiAjZGVmaW5lIFdFQktJ VF9GSVJTVF9WRVJTSU9OX1dJVEhPVVRfTElOS19FTEVNRU5UX1RFWFRfQ1NTX1FVSVJLIDB4MDIx MzAyMDAgLy8gNTMxLjIuMAogI2RlZmluZSBXRUJLSVRfRklSU1RfVkVSU0lPTl9XSVRIX0hUTUw1 X1BBUlNFUiAweDAyMTYwOTAwIC8vIDUzNC45LjAKKyNkZWZpbmUgV0VCS0lUX0ZJUlNUX1ZFUlNJ T05fV0lUSF9HRVRfTUFUQ0hFRF9DU1NfUlVMRVNfUkVTVFJJQ1RJT05TIDB4MDIxNjBCMDAgLy8g NTM0LjExLjAKIAogI2lmZGVmIF9fY3BsdXNwbHVzCiBleHRlcm4gIkMiIHsKSW5kZXg6IFdlYktp dC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvV2ViVmll dy9XZWJWaWV3Lm1tCShyZXZpc2lvbiA3MDY1NykKKysrIFdlYktpdC9tYWMvV2ViVmlldy9XZWJW aWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMzk4LDYgKzEzOTgsMTIgQEAgLSAoQk9PTClfbmVl ZHNQcmVIVE1MNVBhcnNlclF1aXJrcwogICAgICAgICB8fCBbW3NlbGYgcHJlZmVyZW5jZXNdIHVz ZVByZUhUTUw1UGFyc2VyUXVpcmtzXTsKIH0KIAorLSAoQk9PTClfbmVlZHNVbnJlc3RyaWN0ZWRH ZXRNYXRjaGVkQ1NTUnVsZXMKK3sKKyAgICBzdGF0aWMgYm9vbCBuZWVkc1VucmVzdHJpY3RlZEdl dE1hdGNoZWRDU1NSdWxlcyA9ICFXZWJLaXRMaW5rZWRPbk9yQWZ0ZXIoV0VCS0lUX0ZJUlNUX1ZF UlNJT05fV0lUSF9HRVRfTUFUQ0hFRF9DU1NfUlVMRVNfUkVTVFJJQ1RJT05TKSAmJiBhcHBsaWNh dGlvbklzU2FmYXJpKCk7CisgICAgcmV0dXJuIG5lZWRzVW5yZXN0cmljdGVkR2V0TWF0Y2hlZENT U1J1bGVzOworfQorCiAtICh2b2lkKV9wcmVmZXJlbmNlc0NoYW5nZWROb3RpZmljYXRpb246KE5T Tm90aWZpY2F0aW9uICopbm90aWZpY2F0aW9uCiB7CiAgICAgV2ViUHJlZmVyZW5jZXMgKnByZWZl cmVuY2VzID0gKFdlYlByZWZlcmVuY2VzICopW25vdGlmaWNhdGlvbiBvYmplY3RdOwpAQCAtMTQ5 Niw2ICsxNTAyLDcgQEAgLSAodm9pZClfcHJlZmVyZW5jZXNDaGFuZ2VkTm90aWZpY2F0aW9uOgog ICAgIHNldHRpbmdzLT5zZXRNZW1vcnlJbmZvRW5hYmxlZChbcHJlZmVyZW5jZXMgbWVtb3J5SW5m b0VuYWJsZWRdKTsKICAgICBzZXR0aW5ncy0+c2V0SHlwZXJsaW5rQXVkaXRpbmdFbmFibGVkKFtw cmVmZXJlbmNlcyBoeXBlcmxpbmtBdWRpdGluZ0VuYWJsZWRdKTsKICAgICBzZXR0aW5ncy0+c2V0 VXNlUHJlSFRNTDVQYXJzZXJRdWlya3MoW3NlbGYgX25lZWRzUHJlSFRNTDVQYXJzZXJRdWlya3Nd KTsKKyAgICBzZXR0aW5ncy0+c2V0RGlzYWJsZUdldE1hdGNoZWRDU1NSdWxlc0Nyb3NzT3JpZ2lu Q2hlY2soW3NlbGYgX25lZWRzVW5yZXN0cmljdGVkR2V0TWF0Y2hlZENTU1J1bGVzXSk7CiAKICAg ICAvLyBBcHBsaWNhdGlvbiBDYWNoZSBQcmVmZXJlbmNlcyBhcmUgc3RvcmVkIG9uIHRoZSBnbG9i YWwgY2FjaGUgc3RvcmFnZSBtYW5hZ2VyLCBub3QgaW4gU2V0dGluZ3MuCiAgICAgW1dlYkFwcGxp Y2F0aW9uQ2FjaGUgc2V0RGVmYXVsdE9yaWdpblF1b3RhOltwcmVmZXJlbmNlcyBhcHBsaWNhdGlv bkNhY2hlRGVmYXVsdE9yaWdpblF1b3RhXV07Cg==