48435 2010-10-27 10:06:50 -0700 REGRESSION (r70655): Many plugins tests are failing on Qt 2010-10-27 14:04:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 aroben aroben abarth eric webkit.review.bot oldest_to_newest 300311 0 aroben 2010-10-27 10:06:50 -0700 REGRESSION (r70655): Many plugins tests are failing on Qt 300313 1 72050 aroben 2010-10-27 10:07:31 -0700 Created attachment 72050 Patch 300321 2 webkit.review.bot 2010-10-27 10:12:50 -0700 Attachment 72050 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:53: PluginTest::NPP_Destroy is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:58: NullNPPGetValuePointer::NPP_Destroy is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 300322 3 aroben 2010-10-27 10:14:07 -0700 Committed r70662: <http://trac.webkit.org/changeset/70662> 300544 4 webkit.review.bot 2010-10-27 14:04:03 -0700 http://trac.webkit.org/changeset/70662 might have broken GTK Linux 32-bit Debug 72050 2010-10-27 10:07:31 -0700 2010-10-27 10:09:27 -0700 Patch bug-48435-20101027130731.patch text/plain 6353 aroben ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1ZTBjMDA1MzY4NGI3ZjZiNDBmOTlkYjNjZjBhNTIwNTdmY2M3ZGNhLi4xODhkZDUy MzlmM2QxNTdhODg2OGI5MjhmY2VmMWM1MzRkNmI3ODhjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzMgQEAK IDIwMTAtMTAtMjcgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCisgICAgICAgIFJl c2V0IFRlc3ROZXRzY2FwZVBsdWdJbidzIE5QUF9HZXRWYWx1ZSBwb2ludGVyIHdoZW4KKyAgICAg ICAgTnVsbE5QUEdldFZhbHVlUG9pbnRlciBmaW5pc2hlcyBydW5uaW5nCisKKyAgICAgICAgRml4 ZXMgPGh0dHA6Ly93ZWJraXQub3JnL2IvNDg0MzU+IFJFR1JFU1NJT04gKHI3MDY1NSk6IE1hbnkg cGx1Z2lucworICAgICAgICB0ZXN0cyBhcmUgZmFpbGluZyBvbiBRdAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvVGVzdE5l dHNjYXBlUGx1Z0luL1BsdWdpblRlc3QuY3BwOgorICAgICAgICAoUGx1Z2luVGVzdDo6TlBQX0Rl c3Ryb3kpOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9QbHVn aW5UZXN0Lmg6CisgICAgICAgIEFkZGVkIGEgZG8tbm90aGluZyBOUFBfRGVzdHJveSBpbXBsZW1l bnRhdGlvbi4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9U ZXN0cy9OdWxsTlBQR2V0VmFsdWVQb2ludGVyLmNwcDoKKyAgICAgICAgKE51bGxOUFBHZXRWYWx1 ZVBvaW50ZXI6Ok51bGxOUFBHZXRWYWx1ZVBvaW50ZXIpOiBTYXZlIHRoZSBvcmlnaW5hbAorICAg ICAgICBOUFBfR2V0VmFsdWUgcG9pbnRlciBpbiBtX29yaWdpbmFsTlBQR2V0VmFsdWVQb2ludGVy IHNvIHdlIGNhbiByZXN0b3JlCisgICAgICAgIGl0IGxhdGVyLgorICAgICAgICAoTnVsbE5QUEdl dFZhbHVlUG9pbnRlcjo6TlBQX0Rlc3Ryb3kpOiBBZGRlZC4gUmVzdG9yZXMgdGhlIG9yaWdpbmFs CisgICAgICAgIE5QUF9HZXRWYWx1ZSBwb2ludGVyIHNvIGl0IGNhbiBiZSB1c2VkIGluIG90aGVy IHRlc3RzLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL21h aW4uY3BwOgorICAgICAgICAoTlBQX0Rlc3Ryb3kpOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVl L3VuaXgvVGVzdE5ldHNjYXBlUGx1Z2luL1Rlc3ROZXRzY2FwZVBsdWdpbi5jcHA6CisgICAgICAg ICh3ZWJraXRfdGVzdF9wbHVnaW5fZGVzdHJveV9pbnN0YW5jZSk6CisgICAgICAgIENhbGwgdGhy b3VnaCB0byB0aGUgUGx1Z2luVGVzdCB3aGVuIE5QUF9EZXN0cm95IGlzIGNhbGxlZC4KKworMjAx MC0xMC0yNyAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CisKICAgICAgICAgQ2hlY2sg aW4gZmlsZSBJIGZvcmdvdCBpbiByNzA2NTMKIAogICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3Vu aXgvVGVzdE5ldHNjYXBlUGx1Z2luL1Rlc3ROZXRzY2FwZVBsdWdpbi5jcHA6CmRpZmYgLS1naXQg YS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2luVGVz dC5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1 Z2luVGVzdC5jcHAKaW5kZXggOWViNDIxYzM3MDE5OTQ5ODVjODY0ODFmMTU2ZWRjODUyMzlkOWVk Mi4uZTQxZTZlNWVhZjgyNTY4Yjc5M2Q0ODJhY2NjZGE5ZmNhOThmNGIxYSAxMDA2NDQKLS0tIGEv V2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL1BsdWdpblRlc3Qu Y3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9Q bHVnaW5UZXN0LmNwcApAQCAtNTAsNiArNTAsMTEgQEAgUGx1Z2luVGVzdDo6flBsdWdpblRlc3Qo KQogewogfQogCitOUEVycm9yIFBsdWdpblRlc3Q6Ok5QUF9EZXN0cm95KE5QU2F2ZWREYXRhKiop Cit7CisgICAgcmV0dXJuIE5QRVJSX05PX0VSUk9SOworfQorCiBOUEVycm9yIFBsdWdpblRlc3Q6 Ok5QUF9EZXN0cm95U3RyZWFtKE5QU3RyZWFtICpzdHJlYW0sIE5QUmVhc29uIHJlYXNvbikKIHsK ICAgICByZXR1cm4gTlBFUlJfTk9fRVJST1I7CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1w UmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2luVGVzdC5oIGIvV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL1BsdWdpblRlc3QuaAppbmRleCAwMTAw ODI5OWZkMDc5MTVlMWYyYmNiYjhhMDYyOTY0NTcwOGE1ZjQ2Li4wNDk3NzY0ZDVjZGY2NDNiYWEz YjYxYTdmM2RlNjcxY2I1YWUxMGZiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVy VHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2luVGVzdC5oCisrKyBiL1dlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9QbHVnaW5UZXN0LmgKQEAgLTU1LDYgKzU1 LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgflBsdWdpblRlc3QoKTsKIAogICAgIC8vIE5QUCBm dW5jdGlvbnMuCisgICAgdmlydHVhbCBOUEVycm9yIE5QUF9EZXN0cm95KE5QU2F2ZWREYXRhKiop OwogICAgIHZpcnR1YWwgTlBFcnJvciBOUFBfRGVzdHJveVN0cmVhbShOUFN0cmVhbSogc3RyZWFt LCBOUFJlYXNvbiByZWFzb24pOwogICAgIHZpcnR1YWwgTlBFcnJvciBOUFBfR2V0VmFsdWUoTlBQ VmFyaWFibGUsIHZvaWQqIHZhbHVlKTsKICAgICB2aXJ0dWFsIE5QRXJyb3IgTlBQX1NldFdpbmRv dyhOUFAsIE5QV2luZG93Kik7CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJl ZS9UZXN0TmV0c2NhcGVQbHVnSW4vVGVzdHMvTnVsbE5QUEdldFZhbHVlUG9pbnRlci5jcHAgYi9X ZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vVGVzdHMvTnVsbE5Q UEdldFZhbHVlUG9pbnRlci5jcHAKaW5kZXggMmMzYWEzMDZlYzVhYzNlNGMzNjVlZDk3ZGY4YWM0 ZWZkNWNkNTQ3My4uOWU0ZTk3NmYwMGEzYjRjODNkOGEwYmY5ZThlMDZiY2NkNDY3NTM0NiAxMDA2 NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL1Rl c3RzL051bGxOUFBHZXRWYWx1ZVBvaW50ZXIuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5k ZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9UZXN0cy9OdWxsTlBQR2V0VmFsdWVQb2ludGVyLmNw cApAQCAtMzYsMTMgKzM2LDE3IEBAIHB1YmxpYzoKICAgICBOdWxsTlBQR2V0VmFsdWVQb2ludGVy KE5QUCwgY29uc3Qgc3RyaW5nJiBpZGVudGlmaWVyKTsKIAogcHJpdmF0ZToKKyAgICB2aXJ0dWFs IE5QRXJyb3IgTlBQX0Rlc3Ryb3koTlBTYXZlZERhdGEqKik7CiAgICAgdmlydHVhbCBOUEVycm9y IE5QUF9HZXRWYWx1ZShOUFBWYXJpYWJsZSwgdm9pZCogdmFsdWUpOworCisgICAgTlBQX0dldFZh bHVlUHJvY1B0ciBtX29yaWdpbmFsTlBQR2V0VmFsdWVQb2ludGVyOwogfTsKIAogc3RhdGljIFBs dWdpblRlc3Q6OlJlZ2lzdGVyPE51bGxOUFBHZXRWYWx1ZVBvaW50ZXI+IHJlZ2lzdHJhcigibnVs bC1ucHAtZ2V0dmFsdWUtcG9pbnRlciIpOwogCiBOdWxsTlBQR2V0VmFsdWVQb2ludGVyOjpOdWxs TlBQR2V0VmFsdWVQb2ludGVyKE5QUCBucHAsIGNvbnN0IHN0cmluZyYgaWRlbnRpZmllcikKICAg ICA6IFBsdWdpblRlc3QobnBwLCBpZGVudGlmaWVyKQorICAgICwgbV9vcmlnaW5hbE5QUEdldFZh bHVlUG9pbnRlcihwbHVnaW5GdW5jdGlvbnMtPmdldHZhbHVlKQogewogICAgIC8vIEJlIHNuZWFr eSBhbmQgbnVsbCBvdXQgdGhlIGdldHZhbHVlIHBvaW50ZXIgdGhlIGJyb3dzZXIgaXMgaG9sZGlu Zy4gVGhpcyBzaW11bGF0ZXMgYSBwbHVnaW4KICAgICAvLyB0aGF0IGRvZXNuJ3QgaW1wbGVtZW50 IE5QUF9HZXRWYWx1ZSAobGlrZSBTaG9ja3dhdmUgRGlyZWN0b3IgMTAuMyBvbiBXaW5kb3dzKS4g Tm90ZSB0aGF0IGlmCkBAIC01MSw2ICs1NSwxNCBAQCBOdWxsTlBQR2V0VmFsdWVQb2ludGVyOjpO dWxsTlBQR2V0VmFsdWVQb2ludGVyKE5QUCBucHAsIGNvbnN0IHN0cmluZyYgaWRlbnRpZmllcgog ICAgIHBsdWdpbkZ1bmN0aW9ucy0+Z2V0dmFsdWUgPSAwOwogfQogCitOUEVycm9yIE51bGxOUFBH ZXRWYWx1ZVBvaW50ZXI6Ok5QUF9EZXN0cm95KE5QU2F2ZWREYXRhKiopCit7CisgICAgLy8gU2V0 IHRoZSBOUFBfR2V0VmFsdWUgcG9pbnRlciBiYWNrIHRoZSB3YXkgaXQgd2FzIGJlZm9yZSB3ZSBt dWNrZWQgd2l0aCBpdCBzbyB3ZSBkb24ndCBtZXNzCisgICAgLy8gdXAgZnV0dXJlIHVzZXMgb2Yg dGhlIHBsdWdpbiBtb2R1bGUuCisgICAgcGx1Z2luRnVuY3Rpb25zLT5nZXR2YWx1ZSA9IG1fb3Jp Z2luYWxOUFBHZXRWYWx1ZVBvaW50ZXI7CisgICAgcmV0dXJuIE5QRVJSX05PX0VSUk9SOworfQor CiBOUEVycm9yIE51bGxOUFBHZXRWYWx1ZVBvaW50ZXI6Ok5QUF9HZXRWYWx1ZShOUFBWYXJpYWJs ZSwgdm9pZCopCiB7CiAgICAgcGx1Z2luTG9nKG1fbnBwLCAiTlBQX0dldFZhbHVlIHdhcyBjYWxs ZWQgYnV0IHNob3VsZCBub3QgaGF2ZSBiZWVuLiBNYXliZSBXZWJLaXQgY29waWVkIHRoZSBOUFBs dWdpbkZ1bmNzIHN0cnVjdCwgd2hpY2ggd291bGQgaW52YWxpZGF0ZSB0aGlzIHRlc3QuIik7CmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4v bWFpbi5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4v bWFpbi5jcHAKaW5kZXggMjRiYTNiODVkOGY3ZTYwZDEyZWRlMmE5ZjNmNjZhZmU3YjM4ODI2Zi4u NmFlNzcwZDIwZTBmMGI5YzI5NGNhZmIyN2RlODFhMDQ2MWNmNTc0ZiAxMDA2NDQKLS0tIGEvV2Vi S2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL21haW4uY3BwCisrKyBi L1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9tYWluLmNwcApA QCAtMjgzLDYgKzI4Myw4IEBAIE5QRXJyb3IgTlBQX0Rlc3Ryb3koTlBQIGluc3RhbmNlLCBOUFNh dmVkRGF0YSAqKnNhdmUpCiAgICAgICAgICAgICBDRlJlbGVhc2Uob2JqLT5jb3JlQW5pbWF0aW9u TGF5ZXIpOwogI2VuZGlmCiAKKyAgICAgICAgb2JqLT5wbHVnaW5UZXN0LT5OUFBfRGVzdHJveShz YXZlKTsKKwogICAgICAgICBicm93c2VyLT5yZWxlYXNlb2JqZWN0KCZvYmotPmhlYWRlcik7CiAg ICAgfQogICAgIHJldHVybiBOUEVSUl9OT19FUlJPUjsKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xz L0R1bXBSZW5kZXJUcmVlL3VuaXgvVGVzdE5ldHNjYXBlUGx1Z2luL1Rlc3ROZXRzY2FwZVBsdWdp bi5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS91bml4L1Rlc3ROZXRzY2FwZVBsdWdp bi9UZXN0TmV0c2NhcGVQbHVnaW4uY3BwCmluZGV4IDY2ZjY4MzFmMzljNDM0YTVjZjZkMmEzZTU0 NWJkNjkzOWU5NDQwYTUuLjE0YmI4ZWYyOTI1NTY4NWU2ZWY5MTRhZWI0MjZiNDY4NDYyZTExMDEg MTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3VuaXgvVGVzdE5ldHNjYXBl UGx1Z2luL1Rlc3ROZXRzY2FwZVBsdWdpbi5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRl clRyZWUvdW5peC9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLmNwcApAQCAt MTA1LDcgKzEwNSw3IEBAIHdlYmtpdF90ZXN0X3BsdWdpbl9uZXdfaW5zdGFuY2UoTlBNSU1FVHlw ZSAvKm1pbWV0eXBlKi8sCiB9CiAKIHN0YXRpYyBOUEVycm9yCi13ZWJraXRfdGVzdF9wbHVnaW5f ZGVzdHJveV9pbnN0YW5jZShOUFAgaW5zdGFuY2UsIE5QU2F2ZWREYXRhKiogLypzYXZlKi8pCit3 ZWJraXRfdGVzdF9wbHVnaW5fZGVzdHJveV9pbnN0YW5jZShOUFAgaW5zdGFuY2UsIE5QU2F2ZWRE YXRhKiogc2F2ZSkKIHsKICAgICBQbHVnaW5PYmplY3QqIG9iaiA9IHN0YXRpY19jYXN0PFBsdWdp bk9iamVjdCo+KGluc3RhbmNlLT5wZGF0YSk7CiAgICAgaWYgKG9iaikgewpAQCAtMTI5LDYgKzEy OSw4IEBAIHdlYmtpdF90ZXN0X3BsdWdpbl9kZXN0cm95X2luc3RhbmNlKE5QUCBpbnN0YW5jZSwg TlBTYXZlZERhdGEqKiAvKnNhdmUqLykKICAgICAgICAgaWYgKG9iai0+b25TZXRXaW5kb3cpCiAg ICAgICAgICAgICBmcmVlKG9iai0+b25TZXRXaW5kb3cpOwogCisgICAgICAgIG9iai0+cGx1Z2lu VGVzdC0+TlBQX0Rlc3Ryb3koc2F2ZSk7CisKICAgICAgICAgYnJvd3Nlci0+cmVsZWFzZW9iamVj dCgmb2JqLT5oZWFkZXIpOwogICAgIH0KIAo=