48427 2010-10-27 06:47:42 -0700 Wrong instruction form for BKPT 2010-10-28 00:23:51 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zherczeg webkit-unassigned barraclough webkit.review.bot oldest_to_newest 300179 0 zherczeg 2010-10-27 06:47:42 -0700 One 0 is missing. 300184 1 72029 zherczeg 2010-10-27 06:52:41 -0700 Created attachment 72029 patch 300185 2 webkit.review.bot 2010-10-27 06:56:04 -0700 Attachment 72029 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/assembler/ARMAssembler.h:209: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 300190 3 72029 kling 2010-10-27 07:03:36 -0700 Comment on attachment 72029 patch r=me 300191 4 72029 kling 2010-10-27 07:04:22 -0700 Comment on attachment 72029 patch Oh, please fix the style error before landing :) 300921 5 zherczeg 2010-10-28 00:23:51 -0700 Thanks for the review. Landed in http://trac.webkit.org/changeset/70752. Closing bug. 72029 2010-10-27 06:52:41 -0700 2010-10-27 07:04:22 -0700 patch 0001-breakpoint.patch text/plain 1818 zherczeg RnJvbSBmNmQ2N2NmZGNiYTRjZDcwMjc3ZGJmMWE4NmI1YzE0NmQ4Mjk5ZTI0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBXZWQsIDI3IE9jdCAyMDEwIDE1OjUxOjE0ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gYnJlYWtwb2ludAoKU2lnbmVkLW9mZi1ieTogWm9sdGFuIEhlcmN6ZWcgPHpoZXJjemVnQGlu Zi51LXN6ZWdlZC5odT4KLS0tCiBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgfCAgIDEyICsrKysrKysrKysrKwogSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFzc2Vt Ymxlci5oIHwgICAgNCArKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDIg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGJjYTMyNjUuLjU3ZjQwZjYgMTAwNjQ0Ci0tLSBh L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMC0yNyAgWm9sdGFuIEhlcmN6ZWcgIDx6aGVyY3plZ0B3 ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdyb25nIGluc3RydWN0aW9uIGZvcm0gZm9yIEJLUFQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4NDI3CisKKyAgICAgICAgT25lICcwJyBpcyBt aXNzaW5nIGZyb20gQktQVCBpbnN0cnVjdGlvbi4KKyAgICAgICAgVGhhbmtzIGZvciBKYWNvYiBC cmFtbGV5IGZvciByZXBvcnRpbmcgdGhpcyBlcnJvci4KKworICAgICAgICAqIGFzc2VtYmxlci9B Uk1Bc3NlbWJsZXIuaDoKKwogMjAxMC0xMC0yNSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpkaWZmIC0tZ2l0 IGEvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oIGIvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oCmluZGV4IGRmYTcyNmEuLmY2MDhlNTIgMTAwNjQ0 Ci0tLSBhL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJsZXIuaAorKysgYi9KYXZh U2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmgKQEAgLTE2NSw3ICsxNjUsNyBAQCBu YW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAgIFZNUlNfQVBTUiA9IDB4MGVmMWZhMTAsCiAjaWYg V1RGX0FSTV9BUkNIX0FUX0xFQVNUKDUpCiAgICAgICAgICAgICBDTFogPSAweDAxNmYwZjEwLAot ICAgICAgICAgICAgQktQVCA9IDB4ZTEyMDA3MCwKKyAgICAgICAgICAgIEJLUFQgPSAweGUxMjAw MDcwLAogICAgICAgICAgICAgQkxYID0gMHgwMTJmZmYzMCwKICNlbmRpZgogI2lmIFdURl9BUk1f QVJDSF9BVF9MRUFTVCg3KQpAQCAtMjA2LDcgKzIwNiw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAg ICAgICBlbnVtIHsKICAgICAgICAgICAgIHBhZEZvckFsaWduOCAgPSAweDAwLAogICAgICAgICAg ICAgcGFkRm9yQWxpZ24xNiA9IDB4MDAwMCwKLSAgICAgICAgICAgIHBhZEZvckFsaWduMzIgPSAw eGVlMTIwMDcwLAorICAgICAgICAgICAgcGFkRm9yQWxpZ24zMiA9IDB4ZTEyZmZmN2YgIC8vICdi a3B0IDB4ZmZmZicgaW5zdHJ1Y3Rpb24uCiAgICAgICAgIH07CiAKICAgICAgICAgc3RhdGljIGNv bnN0IEFSTVdvcmQgSU5WQUxJRF9JTU0gPSAweGYwMDAwMDAwOwotLSAKMS42LjAuNAoK