48426 2010-10-27 06:43:03 -0700 Add runtime flag check before enabling speech input in code. 2010-10-27 08:17:03 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 39485 0 satish webkit-unassigned commit-queue steveblock oldest_to_newest 300176 0 satish 2010-10-27 06:43:03 -0700 In https://bugs.webkit.org/show_bug.cgi?id=43146 I added a runtime flag for speech input and used that in the IDL where speech input attributes were declared. At that time I believed that was sufficient and no additions were necessary in the code. However I now find that only covers the V8/JSC bindings and not the inline attribute declarations in HTML. Hence this patch to add the runtime flag check in code. 300180 1 72028 satish 2010-10-27 06:48:02 -0700 Created attachment 72028 Patch 300218 2 72028 steveblock 2010-10-27 07:59:39 -0700 Comment on attachment 72028 Patch r=me 300219 3 72028 steveblock 2010-10-27 08:00:26 -0700 Comment on attachment 72028 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72028&action=review > WebCore/ChangeLog:6 > + https://bugs.webkit.org/show_bug.cgi?id=48426 Should add a comment about how this is tested. 300233 4 72028 commit-queue 2010-10-27 08:16:58 -0700 Comment on attachment 72028 Patch Clearing flags on attachment: 72028 Committed r70644: <http://trac.webkit.org/changeset/70644> 300234 5 commit-queue 2010-10-27 08:17:03 -0700 All reviewed patches have been landed. Closing bug. 72028 2010-10-27 06:48:02 -0700 2010-10-27 08:16:58 -0700 Patch bug-48426-20101027144801.patch text/plain 1486 satish ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjY1ZGU3NDFhYzJmMjE1OTVmZDU2ZGY4MWI4YjA4ZmFmMjQ0ZWZhYi4uMzYwYjk0OTI5ZmFmMGFi YmNmOTdiNDQ5MmMwODA4NzEwNzRiNmJiMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMC0yNyAgU2F0 aXNoIFNhbXBhdGggIDxzYXRpc2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBydW50aW1lIGZsYWcgY2hlY2sgYmVmb3Jl IGVuYWJsaW5nIHNwZWVjaCBpbnB1dCBpbiBjb2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg0MjYKKworICAgICAgICAqIGh0bWwvSFRNTElucHV0 RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50Ojppc1NwZWVj aEVuYWJsZWQpOiBBZGRlZCBydW50aW1lIGZsYWcgY2hlY2suCisKIDIwMTAtMTAtMjcgIEFkYW0g Um9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIE9ubHkgZGVjb21wcmVzcyBwaXhl bCBidWZmZXJzIHdoZW4gbmVlZGVkIChhbmQgZml4IGEgY3Jhc2ggaW4gdGhlCmRpZmYgLS1naXQg YS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAgYi9XZWJDb3JlL2h0bWwvSFRNTElu cHV0RWxlbWVudC5jcHAKaW5kZXggMmZmOGVjNWE4NTcyZDJkMDQzM2Y3ZjNmYmQzMzVhZTIwOWRl NGIwZC4uYjAzMDY1YzlhZmM0ODFiOWYzMThlNjMzMTQyZGUwZGMxYjE4MzllMiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9I VE1MSW5wdXRFbGVtZW50LmNwcApAQCAtNjEsNiArNjEsNyBAQAogI2luY2x1ZGUgIlJlbmRlclNs aWRlci5oIgogI2luY2x1ZGUgIlJlbmRlclRleHRDb250cm9sU2luZ2xlTGluZS5oIgogI2luY2x1 ZGUgIlJlbmRlclRoZW1lLmgiCisjaW5jbHVkZSAiUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oIgog I2luY2x1ZGUgIlNjcmlwdEV2ZW50TGlzdGVuZXIuaCIKICNpbmNsdWRlICJTZXR0aW5ncy5oIgog I2luY2x1ZGUgIlN0ZXBSYW5nZS5oIgpAQCAtMTk1MSw3ICsxOTUyLDcgQEAgYm9vbCBIVE1MSW5w dXRFbGVtZW50Ojppc1NwZWVjaEVuYWJsZWQoKSBjb25zdAogICAgIGNhc2UgU0VBUkNIOgogICAg IGNhc2UgVEVMRVBIT05FOgogICAgIGNhc2UgVEVYVDoKLSAgICAgICAgcmV0dXJuIGhhc0F0dHJp YnV0ZSh3ZWJraXRzcGVlY2hBdHRyKTsKKyAgICAgICAgcmV0dXJuIFJ1bnRpbWVFbmFibGVkRmVh dHVyZXM6OnNwZWVjaElucHV0RW5hYmxlZCgpICYmIGhhc0F0dHJpYnV0ZSh3ZWJraXRzcGVlY2hB dHRyKTsKICAgICBjYXNlIEJVVFRPTjoKICAgICBjYXNlIENIRUNLQk9YOgogICAgIGNhc2UgQ09M T1I6Cg==