48422 2010-10-27 05:55:20 -0700 [GTK] Use sentence boundaries instead of start/end sentence 2010-11-03 18:55:53 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 cgarcia webkit-unassigned commit-queue oldest_to_newest 300158 0 cgarcia 2010-10-27 05:55:20 -0700 From pango docs: /* There are two ways to divide sentences. The first assigns all * intersentence whitespace/control/format chars to some sentence, * so all chars are in some sentence; is_sentence_boundary denotes * the boundaries there. The second way doesn't assign * between-sentence spaces, etc. to any sentence, so * is_sentence_start/is_sentence_end mark the boundaries of those * sentences. */ ICU seems to use the first way while TextBreakIteratorGtk uses the second one. We should use is_sentence_boundary in TextBreakIteratorGtk to get the same results that ICU. 300162 1 72023 cgarcia 2010-10-27 06:07:17 -0700 Created attachment 72023 Patch It fixes test fast/dom/Range/range-expand.html, actually it doesn't pass, but sentence tests don't fail, only Chinese word tests are failing because of pango bug https://bugzilla.gnome.org/show_bug.cgi?id=97545 300305 2 72023 mrobinson 2010-10-27 10:02:43 -0700 Comment on attachment 72023 Patch Great. 300381 3 72023 commit-queue 2010-10-27 11:20:47 -0700 Comment on attachment 72023 Patch Rejecting patch 72023 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', 72023]" exit_code: 2 Last 500 characters of output: u'Martin Robinson', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/platform/text/gtk/TextBreakIteratorGtk.cpp Hunk #1 FAILED at 300. Hunk #2 FAILED at 315. 2 out of 2 hunks FAILED -- saving rejects to file WebCore/platform/text/gtk/TextBreakIteratorGtk.cpp.rej Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Martin Robinson', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/4775046 301804 4 72023 cgarcia 2010-10-29 09:09:39 -0700 Comment on attachment 72023 Patch It should apply now 304409 5 72023 commit-queue 2010-11-03 18:55:48 -0700 Comment on attachment 72023 Patch Clearing flags on attachment: 72023 Committed r71296: <http://trac.webkit.org/changeset/71296> 304410 6 commit-queue 2010-11-03 18:55:53 -0700 All reviewed patches have been landed. Closing bug. 72023 2010-10-27 06:07:17 -0700 2010-11-03 18:55:48 -0700 Patch sentences.diff text/plain 2587 cgarcia ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTU1OTc3Yy4uMzQ1ZDUyYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0xMC0yNyAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gVXNlIHNlbnRlbmNlIGJvdW5kYXJpZXMgaW5z dGVhZCBvZiBzdGFydC9lbmQgc2VudGVuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ4NDIyCisKKyAgICAgICAgVXNpbmcgc2VudGVuY2UgYm91bmRh cmllcyBhbGwgaW50ZXJzZW50ZW5jZQorICAgICAgICB3aGl0ZXNwYWNlL2NvbnRyb2wvZm9ybWF0 IGNoYXJhY3RlcnMgYXJlIGFzc2lnbmVkIHRvIGEKKyAgICAgICAgc2VudGVuY2UuIFRoaXMgaXMg d2hhdCBJQ1UgZG9lcywgc28gd2UgaGF2ZSB0byBkbyB0aGUgc2FtZSBpbgorICAgICAgICBvcmRl ciB0byBnZXQgdGhlIHNhbWUgcmVzdWx0cyB3aXRoIGdsaWIgdW5pY29kZSBiYWNrZW5kLiBJdCBm aXhlcworICAgICAgICB0aGUgc2VudGVuY2UgdGVzdHMgY2FzZXMgaW4gdGVzdCBmYXN0L2RvbS9S YW5nZS9yYW5nZS1leHBhbmQuaHRtbC4KKworICAgICAgICAqIHBsYXRmb3JtL3RleHQvZ3RrL1Rl eHRCcmVha0l0ZXJhdG9yR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnRleHRCcmVha05leHQp OgorICAgICAgICAoV2ViQ29yZTo6dGV4dEJyZWFrUHJldmlvdXMpOgorCiAyMDEwLTEwLTIxICBL d2FuZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgS2VudCBUYW11cmEuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvZ3RrL1Rl eHRCcmVha0l0ZXJhdG9yR3RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9ndGsvVGV4dEJy ZWFrSXRlcmF0b3JHdGsuY3BwCmluZGV4IGViNDhlNjEuLmYxYzEyYmMgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvcGxhdGZvcm0vdGV4dC9ndGsvVGV4dEJyZWFrSXRlcmF0b3JHdGsuY3BwCisrKyBiL1dl YkNvcmUvcGxhdGZvcm0vdGV4dC9ndGsvVGV4dEJyZWFrSXRlcmF0b3JHdGsuY3BwCkBAIC0zMDAs NyArMzAwLDcgQEAgaW50IHRleHRCcmVha05leHQoVGV4dEJyZWFrSXRlcmF0b3IqIGl0ZXJhdG9y KQogICAgICAgICBpZiAoKGl0ZXJhdG9yLT5tX3R5cGUgPT0gVUJSS19MSU5FICYmIGl0ZXJhdG9y LT5tX2xvZ0F0dHJzW2luZGV4XS5pc19saW5lX2JyZWFrKQogICAgICAgICAgICAgfHwgKGl0ZXJh dG9yLT5tX3R5cGUgPT0gVUJSS19XT1JEICYmIChpdGVyYXRvci0+bV9sb2dBdHRyc1tpbmRleF0u aXNfd29yZF9zdGFydCB8fCBpdGVyYXRvci0+bV9sb2dBdHRyc1tpbmRleF0uaXNfd29yZF9lbmQp KQogICAgICAgICAgICAgfHwgKGl0ZXJhdG9yLT5tX3R5cGUgPT0gVUJSS19DSEFSQUNURVIgJiYg aXRlcmF0b3ItPm1fbG9nQXR0cnNbaW5kZXhdLmlzX2N1cnNvcl9wb3NpdGlvbikKLSAgICAgICAg ICAgIHx8IChpdGVyYXRvci0+bV90eXBlID09IFVCUktfU0VOVEVOQ0UgJiYgKGl0ZXJhdG9yLT5t X2xvZ0F0dHJzW2luZGV4XS5pc19zZW50ZW5jZV9zdGFydCB8fCBpdGVyYXRvci0+bV9sb2dBdHRy c1tpbmRleF0uaXNfc2VudGVuY2VfZW5kKSkgKSB7CisgICAgICAgICAgICB8fCAoaXRlcmF0b3It Pm1fdHlwZSA9PSBVQlJLX1NFTlRFTkNFICYmIGl0ZXJhdG9yLT5tX2xvZ0F0dHJzW2luZGV4XS5p c19zZW50ZW5jZV9ib3VuZGFyeSkpIHsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAg ICAgfQpAQCAtMzE1LDcgKzMxNSw3IEBAIGludCB0ZXh0QnJlYWtQcmV2aW91cyhUZXh0QnJlYWtJ dGVyYXRvciogaXRlcmF0b3IpCiAgICAgICAgIGlmICgoaXRlcmF0b3ItPm1fdHlwZSA9PSBVQlJL X0xJTkUgJiYgaXRlcmF0b3ItPm1fbG9nQXR0cnNbaW5kZXhdLmlzX2xpbmVfYnJlYWspCiAgICAg ICAgICAgICB8fCAoaXRlcmF0b3ItPm1fdHlwZSA9PSBVQlJLX1dPUkQgJiYgKGl0ZXJhdG9yLT5t X2xvZ0F0dHJzW2luZGV4XS5pc193b3JkX3N0YXJ0IHx8IGl0ZXJhdG9yLT5tX2xvZ0F0dHJzW2lu ZGV4XS5pc193b3JkX2VuZCkpCiAgICAgICAgICAgICB8fCAoaXRlcmF0b3ItPm1fdHlwZSA9PSBV QlJLX0NIQVJBQ1RFUiAmJiBpdGVyYXRvci0+bV9sb2dBdHRyc1tpbmRleF0uaXNfY3Vyc29yX3Bv c2l0aW9uKQotICAgICAgICAgICAgfHwgKGl0ZXJhdG9yLT5tX3R5cGUgPT0gVUJSS19TRU5URU5D RSAmJiAoaXRlcmF0b3ItPm1fbG9nQXR0cnNbaW5kZXhdLmlzX3NlbnRlbmNlX3N0YXJ0IHx8IGl0 ZXJhdG9yLT5tX2xvZ0F0dHJzW2luZGV4XS5pc19zZW50ZW5jZV9lbmQpKSApIHsKKyAgICAgICAg ICAgIHx8IChpdGVyYXRvci0+bV90eXBlID09IFVCUktfU0VOVEVOQ0UgJiYgaXRlcmF0b3ItPm1f bG9nQXR0cnNbaW5kZXhdLmlzX3NlbnRlbmNlX2JvdW5kYXJ5KSkgewogICAgICAgICAgICAgYnJl YWs7CiAgICAgICAgIH0KICAgICB9Cg==