48414 2010-10-27 04:49:44 -0700 Warning when compiling the chromium port of DumpRenderShell with clang 2010-11-02 14:38:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P5 Trivial --- 1 sgjesse webkit-unassigned commit-queue ctruta hans oldest_to_newest 300125 0 72010 sgjesse 2010-10-27 04:49:44 -0700 Created attachment 72010 Simple patch Method javaScriptFlagsForLoad in TestShell.h compares a size_t argument >= 0 which causes a warning in clang 300195 1 hans 2010-10-27 07:08:23 -0700 Looks good to me, but I am not a reviewer. 300197 2 hans 2010-10-27 07:11:15 -0700 Looking closer, shouldn't the ChangeLog contain a link to this bug entry? I thought the tools put that in automatically... 301647 3 72304 sgjesse 2010-10-29 02:38:08 -0700 Created attachment 72304 Patch 301721 4 72304 kling 2010-10-29 06:35:00 -0700 Comment on attachment 72304 Patch r=me 302721 5 commit-queue 2010-11-01 08:49:44 -0700 The commit-queue encountered the following flaky tests while processing attachment 72304: http/tests/cache/subresource-expiration.html Please file bugs against the tests. These tests were authored by koivisto@iki.fi. The commit-queue is continuing to process your patch. 302722 6 72304 commit-queue 2010-11-01 08:50:29 -0700 Comment on attachment 72304 Patch Clearing flags on attachment: 72304 Committed r71030: <http://trac.webkit.org/changeset/71030> 302723 7 commit-queue 2010-11-01 08:50:34 -0700 All reviewed patches have been landed. Closing bug. 303677 8 ctruta 2010-11-02 14:38:57 -0700 *** Bug 48851 has been marked as a duplicate of this bug. *** 72010 2010-10-27 04:49:44 -0700 2010-10-29 02:38:02 -0700 Simple patch clang.patch text/plain 1588 sgjesse SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwNjM0KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTAtMjcgIFPDuHJlbiBHamVzc2UgIDxz Z2plc3NlQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBGaXggY29tcGlsZXIgd2FybmluZyB3aGVuIGNvbXBpbGluZyB3aXRoIGNs YW5nLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmg6Cisg ICAgICAgIChUZXN0U2hlbGw6OmphdmFTY3JpcHRGbGFnc0ZvckxvYWQpOgorCiAyMDEwLTEwLTI3 ICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkByaW0uY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhdmlkIEtpbHplci4KSW5kZXg6IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL1Rlc3RTaGVsbC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL0R1bXBSZW5k ZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5oCShyZXZpc2lvbiA3MDYzNCkKKysrIFdlYktpdFRv b2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5oCSh3b3JraW5nIGNvcHkpCkBA IC0xNDQsNyArMTQ0LDcgQEAgcHVibGljOgogICAgIC8vIFRoZSBKYXZhU2NyaXB0IGZsYWdzIGFy ZSBzcGVjaWZpZWQgYXMgYSB2ZWN0b3Igb2Ygc3RyaW5ncy4gRWFjaCBlbGVtZW50IG9mIHRoZSB2 ZWN0b3IgaXMgZnVsbCBmbGFncyBzdHJpbmcKICAgICAvLyB3aGljaCBjYW4gY29udGFpbiBtdWx0 aXBsZSBmbGFncyAoZS5nLiAiLS14eHggLS15eXkiKS4gV2l0aCBtdWx0aXBsZSBsb2FkIHRlc3Rp bmcgaXQgaXMgcG9zc2libGUgdG8gc3BlY2lmeQogICAgIC8vIHNlcGFyYXRlIHNldHMgb2YgZmxh Z3MgdG8gZWFjaCBsb2FkLgotICAgIHN0ZDo6c3RyaW5nIGphdmFTY3JpcHRGbGFnc0ZvckxvYWQo c2l6ZV90IGxvYWQpIHsgcmV0dXJuIChsb2FkID49IDAgJiYgbG9hZCA8IG1famF2YVNjcmlwdEZs YWdzLnNpemUoKSkgPyBtX2phdmFTY3JpcHRGbGFnc1tsb2FkXSA6ICIiOyB9CisgICAgc3RkOjpz dHJpbmcgamF2YVNjcmlwdEZsYWdzRm9yTG9hZChzaXplX3QgbG9hZCkgeyByZXR1cm4gKGxvYWQg PCBtX2phdmFTY3JpcHRGbGFncy5zaXplKCkpID8gbV9qYXZhU2NyaXB0RmxhZ3NbbG9hZF0gOiAi IjsgfQogICAgIHZvaWQgc2V0SmF2YVNjcmlwdEZsYWdzKFZlY3RvcjxzdGQ6OnN0cmluZz4gamF2 YVNjcmlwdEZsYWdzKSB7IG1famF2YVNjcmlwdEZsYWdzID0gamF2YVNjcmlwdEZsYWdzOyB9CiAK ICAgICAvLyBTZXQgd2hldGhlciB0byBkdW1wIHdoZW4gdGhlIGxvYWRlZCBwYWdlIGhhcyBmaW5p c2hlZCBwcm9jZXNzaW5nLiBUaGlzIGlzIHVzZWQgd2l0aCBtdWx0aXBsZSBsb2FkCg== 72304 2010-10-29 02:38:08 -0700 2010-11-01 08:50:29 -0700 Patch bug-48414-20101029113806.patch text/plain 1668 sgjesse SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwODUzKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTAtMjkgIFPDuHJlbiBHamVzc2UgIDxz Z2plc3NlQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBGaXggd2FybmluZyB3aGVuIGNvbXBpbGluZyB0aGUgY2hyb21pdW0gcG9y dCBvZiBEdW1wUmVuZGVyU2hlbGwKKyAgICAgICAgd2l0aCBjbGFuZy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4NDE0CisKKyAgICAgICAgKiBEdW1w UmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuaDoKKyAgICAgICAgKFRlc3RTaGVsbDo6amF2 YVNjcmlwdEZsYWdzRm9yTG9hZCk6CisKIDIwMTAtMTAtMjggIE9qYW4gVmFmYWkgIDxvamFuQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgpJbmRleDogV2Vi S2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmgJKHJldmlz aW9uIDcwODUzKQorKysgV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNo ZWxsLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0NCw3ICsxNDQsNyBAQCBwdWJsaWM6CiAgICAgLy8g VGhlIEphdmFTY3JpcHQgZmxhZ3MgYXJlIHNwZWNpZmllZCBhcyBhIHZlY3RvciBvZiBzdHJpbmdz LiBFYWNoIGVsZW1lbnQgb2YgdGhlIHZlY3RvciBpcyBmdWxsIGZsYWdzIHN0cmluZwogICAgIC8v IHdoaWNoIGNhbiBjb250YWluIG11bHRpcGxlIGZsYWdzIChlLmcuICItLXh4eCAtLXl5eSIpLiBX aXRoIG11bHRpcGxlIGxvYWQgdGVzdGluZyBpdCBpcyBwb3NzaWJsZSB0byBzcGVjaWZ5CiAgICAg Ly8gc2VwYXJhdGUgc2V0cyBvZiBmbGFncyB0byBlYWNoIGxvYWQuCi0gICAgc3RkOjpzdHJpbmcg amF2YVNjcmlwdEZsYWdzRm9yTG9hZChzaXplX3QgbG9hZCkgeyByZXR1cm4gKGxvYWQgPj0gMCAm JiBsb2FkIDwgbV9qYXZhU2NyaXB0RmxhZ3Muc2l6ZSgpKSA/IG1famF2YVNjcmlwdEZsYWdzW2xv YWRdIDogIiI7IH0KKyAgICBzdGQ6OnN0cmluZyBqYXZhU2NyaXB0RmxhZ3NGb3JMb2FkKHNpemVf dCBsb2FkKSB7IHJldHVybiAobG9hZCA8IG1famF2YVNjcmlwdEZsYWdzLnNpemUoKSkgPyBtX2ph dmFTY3JpcHRGbGFnc1tsb2FkXSA6ICIiOyB9CiAgICAgdm9pZCBzZXRKYXZhU2NyaXB0RmxhZ3Mo VmVjdG9yPHN0ZDo6c3RyaW5nPiBqYXZhU2NyaXB0RmxhZ3MpIHsgbV9qYXZhU2NyaXB0RmxhZ3Mg PSBqYXZhU2NyaXB0RmxhZ3M7IH0KIAogICAgIC8vIFNldCB3aGV0aGVyIHRvIGR1bXAgd2hlbiB0 aGUgbG9hZGVkIHBhZ2UgaGFzIGZpbmlzaGVkIHByb2Nlc3NpbmcuIFRoaXMgaXMgdXNlZCB3aXRo IG11bHRpcGxlIGxvYWQK