48401 2010-10-27 00:14:42 -0700 [Qt] Type mismatch while serializing/deserializing message id size 2010-10-27 14:03:09 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 kimmo.t.kinnunen webkit-unassigned abarth commit-queue eric webkit.review.bot oldest_to_newest 300040 0 kimmo.t.kinnunen 2010-10-27 00:14:42 -0700 In WebKit2/Platform/CoreIPC/qt/ConnectionQt.cpp, size of the sent buffer is calculated in two ways: 1) sizeof(uint32_t) when writing 2) sizeof(MessageId) when reading This doesn't cause problems at the moment, but might cause them later (or on some obscure compilers). 300042 1 71993 kimmo.t.kinnunen 2010-10-27 00:19:49 -0700 Created attachment 71993 use same type for sizeof() while reading and writing 300089 2 71993 kling 2010-10-27 02:59:51 -0700 Comment on attachment 71993 use same type for sizeof() while reading and writing LGTM. 300123 3 71993 commit-queue 2010-10-27 04:48:34 -0700 Comment on attachment 71993 use same type for sizeof() while reading and writing Clearing flags on attachment: 71993 Committed r70635: <http://trac.webkit.org/changeset/70635> 300124 4 commit-queue 2010-10-27 04:48:39 -0700 All reviewed patches have been landed. Closing bug. 300538 5 webkit.review.bot 2010-10-27 14:03:09 -0700 http://trac.webkit.org/changeset/70635 might have broken GTK Linux 32-bit Release 71993 2010-10-27 00:19:49 -0700 2010-10-27 04:48:34 -0700 use same type for sizeof() while reading and writing type-mismatch-01.patch text/plain 1686 kimmo.t.kinnunen ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ZTgzYjY1Yy4uZDA3Mjk4NSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMC0yNyAgS2ltbW8gS2lubnVu ZW4gIDxraW1tby50Lmtpbm51bmVuQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFR5cGUgbWlzbWF0Y2ggd2hpbGUgc2VyaWFs aXppbmcvZGVzZXJpYWxpemluZyBtZXNzYWdlIGlkIHNpemUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4NDAxCisKKyAgICAgICAgVXNlIGNvcnJlY3Qg dHlwZXMgd2hlbiByZWFkaW5nIGRhdGEgZnJvbSBjb25uZWN0aW9uIGJ1ZmZlci4KKworICAgICAg ICBUaGUgbWVzc2FnZSBpZCBpcyB3cml0dGVuIGFzIHVpbnQzMl90LCB0aHVzIHRoZSBidWZmZXIg c2l6ZSBzaG91bGQgYmUKKyAgICAgICAgY2FsY3VsYXRlZCBiYXNlZCBvbiBzaXplb2YodWludDMy X3QpIGFuZCBub3Qgc2l6ZW9mKE1lc3NhZ2VJRCkuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9Db3Jl SVBDL3F0L0Nvbm5lY3Rpb25RdC5jcHA6CisgICAgICAgIChDb3JlSVBDOjpDb25uZWN0aW9uOjpy ZWFkeVJlYWRIYW5kbGVyKToKKwogMjAxMC0xMC0yNiAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFt QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCmRpZmYgLS1naXQg YS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvcXQvQ29ubmVjdGlvblF0LmNwcCBiL1dlYktpdDIv UGxhdGZvcm0vQ29yZUlQQy9xdC9Db25uZWN0aW9uUXQuY3BwCmluZGV4IGI2NjEwYjMuLmVkY2Zj N2EgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9xdC9Db25uZWN0aW9uUXQu Y3BwCisrKyBiL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9xdC9Db25uZWN0aW9uUXQuY3BwCkBA IC03Miw4ICs3Miw4IEBAIHZvaWQgQ29ubmVjdGlvbjo6cmVhZHlSZWFkSGFuZGxlcigpCiAgICAg ICAgIEFTU0VSVF9VTlVTRUQobnVtYmVyT2ZCeXRlc1JlYWQsIG51bWJlck9mQnl0ZXNSZWFkKTsK IAogICAgICAgICAvLyBUaGUgbWVzc2FnZUlEIGlzIGVuY29kZWQgYXQgdGhlIGVuZCBvZiB0aGUg YnVmZmVyLgotICAgICAgICBzaXplX3QgcmVhbEJ1ZmZlclNpemUgPSBtX2N1cnJlbnRNZXNzYWdl U2l6ZSAtIHNpemVvZihNZXNzYWdlSUQpOwotICAgICAgICB1bnNpZ25lZCBtZXNzYWdlSUQgPSAq cmVpbnRlcnByZXRfY2FzdDx1bnNpZ25lZCo+KG1fcmVhZEJ1ZmZlci5kYXRhKCkgKyByZWFsQnVm ZmVyU2l6ZSk7CisgICAgICAgIHNpemVfdCByZWFsQnVmZmVyU2l6ZSA9IG1fY3VycmVudE1lc3Nh Z2VTaXplIC0gc2l6ZW9mKHVpbnQzMl90KTsKKyAgICAgICAgdWludDMyX3QgbWVzc2FnZUlEID0g KnJlaW50ZXJwcmV0X2Nhc3Q8dWludDMyX3QqPihtX3JlYWRCdWZmZXIuZGF0YSgpICsgcmVhbEJ1 ZmZlclNpemUpOwogCiAgICAgICAgIHByb2Nlc3NJbmNvbWluZ01lc3NhZ2UoTWVzc2FnZUlEOjpm cm9tSW50KG1lc3NhZ2VJRCksIGFkb3B0UHRyKG5ldyBBcmd1bWVudERlY29kZXIobV9yZWFkQnVm ZmVyLmRhdGEoKSwgcmVhbEJ1ZmZlclNpemUpKSk7CiAK