48400 2010-10-26 23:40:21 -0700 [Qt] WebKit2 UI process crashes if web process crashes 2010-10-27 05:07:51 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 kimmo.t.kinnunen webkit-unassigned commit-queue zoltan oldest_to_newest 300026 0 kimmo.t.kinnunen 2010-10-26 23:40:21 -0700 UI process crashes if web process crashes. Reproduce: 1) Start MiniBrowser 2) Run killall QtWebProcess 3) Focus MiniBrowser 4) Crash Failing assertion: ASSERTION FAILED: bytesWritten == arguments->bufferSize() (../../../WebKit2/Platform/CoreIPC/qt/ConnectionQt.cpp:126 bool CoreIPC::Connection::sendOutgoingMessage(CoreIPC::MessageID, WTF::PassOwnPtr<CoreIPC::ArgumentEncoder>)) Segmentation fault 300036 1 71989 kimmo.t.kinnunen 2010-10-27 00:02:25 -0700 Created attachment 71989 Avoid crashing the UI if write to socket fails 300094 2 71989 kling 2010-10-27 03:10:42 -0700 Comment on attachment 71989 Avoid crashing the UI if write to socket fails LGTM. 300135 3 71989 commit-queue 2010-10-27 05:07:46 -0700 Comment on attachment 71989 Avoid crashing the UI if write to socket fails Clearing flags on attachment: 71989 Committed r70637: <http://trac.webkit.org/changeset/70637> 300136 4 commit-queue 2010-10-27 05:07:51 -0700 All reviewed patches have been landed. Closing bug. 71989 2010-10-27 00:02:25 -0700 2010-10-27 05:07:46 -0700 Avoid crashing the UI if write to socket fails ui-crash-survival-01.patch text/plain 2358 kimmo.t.kinnunen ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ZTgzYjY1Yy4uY2NjZjkzMyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMC0xMC0yNiAgS2ltbW8gS2lubnVu ZW4gIDxraW1tby50Lmtpbm51bmVuQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFdlYktpdDIgVUkgcHJvY2VzcyBjcmFzaGVz IGlmIHdlYiBwcm9jZXNzIGNyYXNoZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQ4NDAwCisKKyAgICAgICAgQ2hlY2sgdGhlIHN1Y2Nlc3Mgb2Ygc29j a2V0IHdyaXRlIG9wZXJhdGlvbnMuCisgICAgICAgIEF2b2lkcyBjcmFzaGluZyB0aGUgVUkgcHJv Y2VzcyBpZiB3ZWIgcHJvY2VzcyBoYXMgY3Jhc2hlZC4KKyAgICAgICAgUXQgc29ja2V0IGNvZGUg c2VnZmF1bHRzIHdoZW4gd3JpdGUgaXMgY2FsbGVkIGZvciBhIHNvY2tldAorICAgICAgICB0aGF0 IGhhcyBoYWQgYW4gZXJyb3IuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9Db3JlSVBDL3F0L0Nvbm5l Y3Rpb25RdC5jcHA6CisgICAgICAgIChDb3JlSVBDOjpDb25uZWN0aW9uOjpwbGF0Zm9ybUludmFs aWRhdGUpOgorICAgICAgICBSZXNldCBtX3NvY2tldCBhZnRlciBkZWxldGlvbi4KKworICAgICAg ICAoQ29yZUlQQzo6Q29ubmVjdGlvbjo6c2VuZE91dGdvaW5nTWVzc2FnZSk6CisgICAgICAgIENo ZWNrIGVycm9yIHN0YXR1cyBvZiB3cml0ZSBvcGVyYXRpb25zIGFuZAorICAgICAgICBpbnZhbGlk YXRlIHNvY2tldCBpZiB3cml0ZXMgZmFpbC4KKwogMjAxMC0xMC0yNiAgQnJlbnQgRnVsZ2hhbSAg PGJmdWxnaGFtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCmRp ZmYgLS1naXQgYS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvcXQvQ29ubmVjdGlvblF0LmNwcCBi L1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9xdC9Db25uZWN0aW9uUXQuY3BwCmluZGV4IGI2NjEw YjMuLjdlNzZjODcgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9xdC9Db25u ZWN0aW9uUXQuY3BwCisrKyBiL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9xdC9Db25uZWN0aW9u UXQuY3BwCkBAIC01MSw2ICs1MSw3IEBAIHZvaWQgQ29ubmVjdGlvbjo6cGxhdGZvcm1Jbml0aWFs aXplKElkZW50aWZpZXIgaWRlbnRpZmllcikKIHZvaWQgQ29ubmVjdGlvbjo6cGxhdGZvcm1JbnZh bGlkYXRlKCkKIHsKICAgICBkZWxldGUgbV9zb2NrZXQ7CisgICAgbV9zb2NrZXQgPSAwOwogfQog CiB2b2lkIENvbm5lY3Rpb246OnJlYWR5UmVhZEhhbmRsZXIoKQpAQCAtMTE5LDExICsxMjAsMTgg QEAgYm9vbCBDb25uZWN0aW9uOjpzZW5kT3V0Z29pbmdNZXNzYWdlKE1lc3NhZ2VJRCBtZXNzYWdl SUQsIFBhc3NPd25QdHI8QXJndW1lbnRFbmMKIAogICAgIC8vIFdyaXRlIG1lc3NhZ2Ugc2l6ZSBm aXJzdAogICAgIC8vIEZJWE1FOiBTaG91bGQgIGp1c3QgZG8gYSBzaW5nbGUgd3JpdGUuCi0gICAg bV9zb2NrZXQtPndyaXRlKHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KCZidWZmZXJTaXplKSwgc2l6 ZW9mKGJ1ZmZlclNpemUpKTsKKyAgICBxaW50NjQgYnl0ZXNXcml0dGVuRm9yU2l6ZSA9IG1fc29j a2V0LT53cml0ZShyZWludGVycHJldF9jYXN0PGNoYXIqPigmYnVmZmVyU2l6ZSksIHNpemVvZihi dWZmZXJTaXplKSk7CisgICAgaWYgKGJ5dGVzV3JpdHRlbkZvclNpemUgIT0gc2l6ZW9mKGJ1ZmZl clNpemUpKSB7CisgICAgICAgIGNvbm5lY3Rpb25EaWRDbG9zZSgpOworICAgICAgICByZXR1cm4g ZmFsc2U7CisgICAgfQogCi0gICAgcWludDY0IGJ5dGVzV3JpdHRlbiA9IG1fc29ja2V0LT53cml0 ZShyZWludGVycHJldF9jYXN0PGNoYXIqPihhcmd1bWVudHMtPmJ1ZmZlcigpKSwgYXJndW1lbnRz LT5idWZmZXJTaXplKCkpOworICAgIHFpbnQ2NCBieXRlc1dyaXR0ZW5Gb3JCdWZmZXIgPSBtX3Nv Y2tldC0+d3JpdGUocmVpbnRlcnByZXRfY2FzdDxjaGFyKj4oYXJndW1lbnRzLT5idWZmZXIoKSks IGFyZ3VtZW50cy0+YnVmZmVyU2l6ZSgpKTsKKyAgICBpZiAoYnl0ZXNXcml0dGVuRm9yQnVmZmVy ICE9IGFyZ3VtZW50cy0+YnVmZmVyU2l6ZSgpKSB7CisgICAgICAgIGNvbm5lY3Rpb25EaWRDbG9z ZSgpOworICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQogCi0gICAgQVNTRVJUX1VOVVNFRChi eXRlc1dyaXR0ZW4sIGJ5dGVzV3JpdHRlbiA9PSBhcmd1bWVudHMtPmJ1ZmZlclNpemUoKSk7CiAg ICAgcmV0dXJuIHRydWU7CiB9CiAK