48393 2010-10-26 20:23:57 -0700 Spatial Navigation: Cannot focus on some ContainerNode 2010-11-12 18:26:29 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 46905 0 pgbasin webkit-unassigned abarth commit-queue eric hyatt webkit.review.bot yael oldest_to_newest 299946 0 pgbasin 2010-10-26 20:23:57 -0700 In the test page below, the node "llinker0" cannot be focused. ============================================== <html> <body> <a href="#">This is an element</a><br> <div> <a href="#" name="llinker0" id=llinker0> <img src="images/btn.gif" height="42" width="76" alt="llinker0" border="0"/> </a> </div> <div> <a href="#">This is an element</a><br> </div> <a href="#">This is an element</a><br> <a href="#" name="llinker1" id=llinker1> <img src="images/btn.gif" height="42" width="76" alt="llinker1" border="0"/> </a><br> <a href="#">This is an element</a><br> </body> </html> ============================================== 299947 1 pgbasin 2010-10-26 20:26:55 -0700 I traced the code, and found that Node::getRect() can return correct rect, however ContainerNode::getRect() cannot. And here is a workaround: svn diff WebCore/page/SpatialNavigation.cpp Index: WebCore/page/SpatialNavigation.cpp =================================================================== --- WebCore/page/SpatialNavigation.cpp (revision 70438) +++ WebCore/page/SpatialNavigation.cpp (working copy) @@ -105,7 +105,8 @@ { ASSERT(render && render->node()); - IntRect rect = render->node()->getRect(); + //IntRect rect = render->node()->getRect(); + IntRect rect = render->absoluteBoundingBoxRect(); // In cases when the |render|'s associated node is in a scrollable inner // document, we only consider its scrollOffset if it is not offscreen. 308545 2 yael 2010-11-12 07:51:51 -0800 This test is still failing, even with the patch at https://bugs.webkit.org/show_bug.cgi?id=49382. I am going to look at this failure. 308597 3 yael 2010-11-12 09:30:57 -0800 If you remove all the white spaces after the image, getRect() does return the image size correctly. The problem starts at ContainerNode::getLowerRightCorner(). It gets confused by the empty white space, with size 0, and thinks that there is no content at all. 308608 4 yael 2010-11-12 09:48:59 -0800 I can reproduce this problem with this code: <html> <body> <a href="#">This is an element</a><br> <div> <a href="#"><img src="images/btn.gif" height="42" width="76"/> </a> </div> <a href="#">This is an element</a> </body> </html> If I remove the space between the image and the closing anchor, the problem goes away, and getRect() on the anchor element reports the correct size. Dave, would you have some ideas about what is going on? thanks! 308784 5 73779 yael 2010-11-12 14:27:11 -0800 Created attachment 73779 Patch ContainerNode::getLowerRightCorner() assumes that the lowest right corner of its last child is its own lowest right corner. If that child is an empty text node after an image, it does not have size and position information, so we should go to the previous child. 308790 6 73779 hyatt 2010-11-12 14:51:50 -0800 Comment on attachment 73779 Patch r=me 308841 7 73779 commit-queue 2010-11-12 16:48:22 -0800 Comment on attachment 73779 Patch Clearing flags on attachment: 73779 Committed r71956: <http://trac.webkit.org/changeset/71956> 308842 8 commit-queue 2010-11-12 16:48:29 -0800 All reviewed patches have been landed. Closing bug. 308883 9 webkit.review.bot 2010-11-12 17:53:00 -0800 http://trac.webkit.org/changeset/71956 might have broken Leopard Intel Release (Tests) The following tests are not passing: svg/dom/SVGScriptElement/script-load-and-error-events.svg 308893 10 yael 2010-11-12 18:16:55 -0800 (In reply to comment #9) > http://trac.webkit.org/changeset/71956 might have broken Leopard Intel Release (Tests) > The following tests are not passing: > svg/dom/SVGScriptElement/script-load-and-error-events.svg All tests on Leopard Intel Release are passing after http://trac.webkit.org/changeset/71956, so I guess it was a false alarm. 308894 11 yael 2010-11-12 18:17:34 -0800 (In reply to comment #10) > (In reply to comment #9) > > http://trac.webkit.org/changeset/71956 might have broken Leopard Intel Release (Tests) > > The following tests are not passing: > > svg/dom/SVGScriptElement/script-load-and-error-events.svg > > All tests on Leopard Intel Release are passing after http://trac.webkit.org/changeset/71956, so I guess it was a false alarm. I meant http://trac.webkit.org/changeset/71958 :-) 308900 12 yael 2010-11-12 18:26:29 -0800 Re-opened by mistake. Sorry. 73779 2010-11-12 14:27:11 -0800 2010-11-12 16:48:22 -0800 Patch 48393.patch text/plain 10185 yael SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTk0MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMTEtMTIgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFNwYXRpYWwgTmF2aWdhdGlvbjogQ2Fubm90IGZvY3VzIG9uIHNvbWUgQ29udGFpbmVyTm9kZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDgzOTMKKwor ICAgICAgICBDb250YWluZXJOb2RlOjpnZXRMb3dlclJpZ2h0Q29ybmVyKCkgYXNzdW1lcyB0aGF0 IHRoZSBsb3dlc3QgcmlnaHQgY29ybmVyIG9mIGl0cyBsYXN0IGNoaWxkIAorICAgICAgICBpcyBp dHMgb3duIGxvd2VzdCByaWdodCBjb3JuZXIuIElmIHRoYXQgY2hpbGQgaXMgYW4gZW1wdHkgdGV4 dCBub2RlIGFmdGVyIGFuIGltYWdlLCBpdCBkb2VzIAorICAgICAgICBub3QgaGF2ZSBzaXplIGFu ZCBwb3NpdGlvbiBpbmZvcm1hdGlvbiwgc28gd2Ugc2hvdWxkIGdvIHRvIHRoZSBwcmV2aW91cyBj aGlsZC4KKworICAgICAgICBUZXN0czogZmFzdC9ldmVudHMvc3BhdGlhbC1uYXZpZ2F0aW9uL3Nu YXYtY29udGFpbmVyLW9ubHktd2hpdGUtc3BhY2UuaHRtbAorICAgICAgICAgICAgICAgZmFzdC9l dmVudHMvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtY29udGFpbmVyLXdoaXRlLXNwYWNlLmh0bWwK KworICAgICAgICAqIGRvbS9Db250YWluZXJOb2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNv bnRhaW5lck5vZGU6OmdldExvd2VyUmlnaHRDb3JuZXIpOgorCiAyMDEwLTExLTEyICBIZWxkZXIg Q29ycmVpYSAgPGhlbGRlckBzZW5jaGEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJl YXMgS2xpbmcuCkluZGV4OiBXZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcAkocmV2aXNpb24gNzE5MzQpCisrKyBX ZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODc2LDYgKzg3 Niw4IEBAIGJvb2wgQ29udGFpbmVyTm9kZTo6Z2V0TG93ZXJSaWdodENvcm5lcigKICAgICAgICAg ICAgIGlmIChvLT5pc1RleHQoKSkgewogICAgICAgICAgICAgICAgIFJlbmRlclRleHQqIHRleHQg PSB0b1JlbmRlclRleHQobyk7CiAgICAgICAgICAgICAgICAgSW50UmVjdCBsaW5lc0JveCA9IHRl eHQtPmxpbmVzQm91bmRpbmdCb3goKTsKKyAgICAgICAgICAgICAgICBpZiAoIWxpbmVzQm94Lngo KSAmJiAhbGluZXNCb3gud2lkdGgoKSAmJiAhbGluZXNCb3gueSgpICYmICFsaW5lc0JveC5oZWln aHQoKSkKKyAgICAgICAgICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgICAgICAgcG9p bnQubW92ZShsaW5lc0JveC54KCkgKyBsaW5lc0JveC53aWR0aCgpLCBsaW5lc0JveC55KCkgKyBs aW5lc0JveC5oZWlnaHQoKSk7CiAgICAgICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgICAg IFJlbmRlckJveCogYm94ID0gdG9SZW5kZXJCb3gobyk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA3MTk0 MikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1 IEBACisyMDEwLTExLTEyICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTcGF0aWFsIE5h dmlnYXRpb246IENhbm5vdCBmb2N1cyBvbiBzb21lIENvbnRhaW5lck5vZGUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4MzkzCisKKyAgICAgICAgKiBm YXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1jb250YWluZXItb25seS13aGl0ZS1z cGFjZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZXZlbnRzL3NwYXRpYWwt bmF2aWdhdGlvbi9zbmF2LWNvbnRhaW5lci1vbmx5LXdoaXRlLXNwYWNlLmh0bWw6IEFkZGVkLgor ICAgICAgICAqIGZhc3QvZXZlbnRzL3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LWNvbnRhaW5lci13 aGl0ZS1zcGFjZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZXZlbnRzL3Nw YXRpYWwtbmF2aWdhdGlvbi9zbmF2LWNvbnRhaW5lci13aGl0ZS1zcGFjZS5odG1sOiBBZGRlZC4K KwogMjAxMC0xMS0xMiAgTWloYWkgUGFycGFyaXRhICA8bWloYWlwQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBVbnJldmlld2VkIENocm9taXVtIGV4cGVjdGF0aW9ucyB1cGRhdGUuCkluZGV4OiBM YXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1jb250YWluZXIt b25seS13aGl0ZS1zcGFjZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv ZmFzdC9ldmVudHMvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtY29udGFpbmVyLW9ubHktd2hpdGUt c3BhY2UtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9ldmVu dHMvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtY29udGFpbmVyLW9ubHktd2hpdGUtc3BhY2UtZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDUgQEAKK1RoaXMgaXMgYW4gZWxlbWVu dAorVGhpcyBpcyBhbiBlbGVtZW50CitQQVNTIGdGb2N1c2VkRG9jdW1lbnQuYWN0aXZlRWxlbWVu dC5nZXRBdHRyaWJ1dGUoImlkIikgaXMgIjIiCitQQVNTIGdGb2N1c2VkRG9jdW1lbnQuYWN0aXZl RWxlbWVudC5nZXRBdHRyaWJ1dGUoImlkIikgaXMgInN0YXJ0IgorVGhpcyB0ZXN0IHRlc3RzIHRo YXQgYSBhbmNob3IgZWxlbWVudCB3aXRoIG9ubHkgd2hpdGUgc3BhY2VzIGdpdmVzIHRoZSBjb3Jy ZWN0IHNpemUgaW4gQ29udGFpbmVyTm9kZTo6Z2V0UmVjdCgpLgpJbmRleDogTGF5b3V0VGVzdHMv ZmFzdC9ldmVudHMvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtY29udGFpbmVyLW9ubHktd2hpdGUt c3BhY2UuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zcGF0aWFs LW5hdmlnYXRpb24vc25hdi1jb250YWluZXItb25seS13aGl0ZS1zcGFjZS5odG1sCShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYt Y29udGFpbmVyLW9ubHktd2hpdGUtc3BhY2UuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw3 NCBAQAorPGh0bWw+CisgIDwhLS0KKyAgICBUaGlzIHRlc3QgZW5zdXJlcyB0aGUgY29ycmVjdG5l c3Mgb2YgYSBiYXNpYyBhc3BlY3Qgb2Ygc3BhdGlhbCBuYXZpZ2F0aW9uIHRyYXZlcnNhbAorICAg IHJvdXRpbmVzOiBmb2N1c2FibGUgZWxlbWVudHMgaW4gc2Nyb2xsYWJsZSBjb250YWluZXJzIChl LmcuIDxkaXY+KSBzaG91bGQgYmUKKyAgICBhY2Nlc3NpYmxlLCBpbmNsdWRpbmcgb2Zmc2NyZWVu IGNvbnRlbnQuCisKKyAgICAqIFByZS1jb25kaXRpb25zOgorICAgIDEpIERSVCBzdXBwb3J0IGZv ciBzcGF0aWFsIG5hdml2YXRpb24gZW5hYmxlL2Rpc2FibGUuCisKKyAgICAqIE5hdmlnYXRpb24g c3RlcHM6CisgICAgMSkgTG9hZHMgdGhpcyBwYWdlLCBmb2N1cyBnb2VzIHRvICJzdGFydCIgYXV0 b21hdGljYWxseS4KKyAgICAyKSBNb3ZlIGZvY3VzIGRvd24gdG8gdGhlIHZpc2libGUgZm9jdXNh YmxlIGVsZW1lbnQgaW4KKyAgICAgICBzY3JvbGxhYmxlIGRpdi4KKyAgICAzKSBUcmF2ZXJzZSB0 aGUgcGFnZSB0aHJvdWdoIG90aGVyIGZvY3VzYWJsZSBlbGVtZW50cyBkb3duIHRoZSBwYWdlLgor ICAgICAgIGFuZCB0aGVuIGJhY2sgdXAuCisKKyAgICAqIEV4cGVjdGVkIHJlc3VsdHM6IEFsbCBm b2N1c2FibGUgZWxlbWVudCBpbiBzY3JvbGxhYmxlIGNvbnRlbnQsIGluY2x1ZGluZworICAgIG9m ZnNjcmVlbiBvbmVzLCBzaG91bGQgYmUgYWNjZXNzaWJsZSB2aWEgc3BhdGlhbCBuYXZpZ2F0aW9u LiAtLT4KKyAgPGhlYWQ+CisgICAgPHN0eWxlPgorICAgIDpmb2N1cyB7b3V0bGluZTogMXB4IHNv bGlkIGJsYWNrO30KKyAgICA8L3N0eWxlPgorICAgIDxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNv dXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorICAgIDxzY3JpcHQgc3JjPSJyZXNvdXJj ZXMvc3BhdGlhbC1uYXZpZ2F0aW9uLXV0aWxzLmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHR5 cGU9ImFwcGxpY2F0aW9uL2phdmFzY3JpcHQiPgorCisgICAgdmFyIHJlc3VsdE1hcCA9IFsKKyAg ICAgIFsiRG93biIsICIyIl0sCisgICAgICBbIlVwIiwgInN0YXJ0Il0sCisgICAgICBbIkRPTkUi LCAiRE9ORSJdCisgICAgXTsKKworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIp IHsKKyAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICAgIGxheW91 dFRlc3RDb250cm9sbGVyLnNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZCh0cnVlKTsKKyAgICAg IGxheW91dFRlc3RDb250cm9sbGVyLm92ZXJyaWRlUHJlZmVyZW5jZSgiV2ViS2l0VGFiVG9MaW5r c1ByZWZlcmVuY2VLZXkiLCAxKTsKKyAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRp bERvbmUoKTsKKyAgICB9CisKKyAgICBmdW5jdGlvbiBydW5UZXN0KCkKKyAgICB7CisgICAgICAv LyBzdGFydGluZyB0aGUgdGVzdCBpdHNlbGY6IGdldCB0byBhIGtub3duIHBsYWNlLgorICAgICAg ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInN0YXJ0IikuZm9jdXMoKTsKKworICAgICAgaW5pdFRl c3QocmVzdWx0TWFwLCB0ZXN0Q29tcGxldGVkKTsKKyAgICB9CisKKyAgICBmdW5jdGlvbiB0ZXN0 Q29tcGxldGVkKCkKKyAgICB7CisgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVy KQorICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAgfQorCisg ICAgd2luZG93Lm9ubG9hZCA9IHJ1blRlc3Q7CisKKyAgICA8L3NjcmlwdD4KKyAgICA8c2NyaXB0 IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+CisgIDwvaGVh ZD4KKyAgPGJvZHk+CisgICAgPGEgaHJlZj0iIyIgaWQ9InN0YXJ0Ij5UaGlzIGlzIGFuIGVsZW1l bnQ8L2E+PGJyPgorCisgICAgPGRpdj4KKyAgICAgIDxhIGhyZWY9IiMiIGlkPSIxIj4KKyAgICAg IDwvYT4KKyAgICA8L2Rpdj4KKworICAgIDxkaXY+CisgICAgICA8YSBocmVmPSIjIiBpZD0iMiI+ VGhpcyBpcyBhbiBlbGVtZW50PC9hPjxicj4KKyAgICA8L2Rpdj4KKyAgICA8ZGl2IGlkPSJjb25z b2xlIj48L2Rpdj4KKyAgICA8ZGl2PlRoaXMgdGVzdCB0ZXN0cyB0aGF0IGEgYW5jaG9yIGVsZW1l bnQgd2l0aCBvbmx5IHdoaXRlIHNwYWNlcyBnaXZlcyB0aGUgY29ycmVjdCBzaXplIGluIENvbnRh aW5lck5vZGU6OmdldFJlY3QoKS48L2Rpdj4KKyAgPC9ib2R5PgorPC9odG1sPgorCkluZGV4OiBM YXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1jb250YWluZXIt d2hpdGUtc3BhY2UtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LWNvbnRhaW5lci13aGl0ZS1zcGFjZS1leHBl Y3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zcGF0aWFs LW5hdmlnYXRpb24vc25hdi1jb250YWluZXItd2hpdGUtc3BhY2UtZXhwZWN0ZWQudHh0CShyZXZp c2lvbiAwKQpAQCAtMCwwICsxLDE3IEBACitUaGlzIGlzIGFuIGVsZW1lbnQKKyAKK1RoaXMgaXMg YW4gZWxlbWVudAorVGhpcyBpcyBhbiBlbGVtZW50CisgIAorVGhpcyBpcyBhbiBlbGVtZW50CitQ QVNTIGdGb2N1c2VkRG9jdW1lbnQuYWN0aXZlRWxlbWVudC5nZXRBdHRyaWJ1dGUoImlkIikgaXMg IjEiCitQQVNTIGdGb2N1c2VkRG9jdW1lbnQuYWN0aXZlRWxlbWVudC5nZXRBdHRyaWJ1dGUoImlk IikgaXMgIjIiCitQQVNTIGdGb2N1c2VkRG9jdW1lbnQuYWN0aXZlRWxlbWVudC5nZXRBdHRyaWJ1 dGUoImlkIikgaXMgIjMiCitQQVNTIGdGb2N1c2VkRG9jdW1lbnQuYWN0aXZlRWxlbWVudC5nZXRB dHRyaWJ1dGUoImlkIikgaXMgIjQiCitQQVNTIGdGb2N1c2VkRG9jdW1lbnQuYWN0aXZlRWxlbWVu dC5nZXRBdHRyaWJ1dGUoImlkIikgaXMgIjUiCitQQVNTIGdGb2N1c2VkRG9jdW1lbnQuYWN0aXZl RWxlbWVudC5nZXRBdHRyaWJ1dGUoImlkIikgaXMgIjQiCitQQVNTIGdGb2N1c2VkRG9jdW1lbnQu YWN0aXZlRWxlbWVudC5nZXRBdHRyaWJ1dGUoImlkIikgaXMgIjMiCitQQVNTIGdGb2N1c2VkRG9j dW1lbnQuYWN0aXZlRWxlbWVudC5nZXRBdHRyaWJ1dGUoImlkIikgaXMgIjIiCitQQVNTIGdGb2N1 c2VkRG9jdW1lbnQuYWN0aXZlRWxlbWVudC5nZXRBdHRyaWJ1dGUoImlkIikgaXMgIjEiCitQQVNT IGdGb2N1c2VkRG9jdW1lbnQuYWN0aXZlRWxlbWVudC5nZXRBdHRyaWJ1dGUoImlkIikgaXMgInN0 YXJ0IgorVGhpcyB0ZXN0IHRlc3RzIHRoYXQgYSBhbmNob3IgZWxlbWVudCB3aXRoIGluIGltYWdl IGluIGl0IGFuZCBhIHNwYWNlIGFmdGVyIHRoZSBpbWFnZSwgY2FuIHN0aWxsIGdpdmUgdGhlIGNv cnJlY3Qgc2l6ZSBpbiBDb250YWluZXJOb2RlOjpnZXRSZWN0KCkuCkluZGV4OiBMYXlvdXRUZXN0 cy9mYXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1jb250YWluZXItd2hpdGUtc3Bh Y2UuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zcGF0aWFsLW5h dmlnYXRpb24vc25hdi1jb250YWluZXItd2hpdGUtc3BhY2UuaHRtbAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LWNvbnRhaW5l ci13aGl0ZS1zcGFjZS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDkxIEBACis8aHRtbD4K KyAgPCEtLQorICAgIFRoaXMgdGVzdCBlbnN1cmVzIHRoZSBjb3JyZWN0bmVzcyBvZiBhIGJhc2lj IGFzcGVjdCBvZiBzcGF0aWFsIG5hdmlnYXRpb24gdHJhdmVyc2FsCisgICAgcm91dGluZXM6IGZv Y3VzYWJsZSBlbGVtZW50cyBpbiBzY3JvbGxhYmxlIGNvbnRhaW5lcnMgKGUuZy4gPGRpdj4pIHNo b3VsZCBiZQorICAgIGFjY2Vzc2libGUsIGluY2x1ZGluZyBvZmZzY3JlZW4gY29udGVudC4KKwor ICAgICogUHJlLWNvbmRpdGlvbnM6CisgICAgMSkgRFJUIHN1cHBvcnQgZm9yIHNwYXRpYWwgbmF2 aXZhdGlvbiBlbmFibGUvZGlzYWJsZS4KKworICAgICogTmF2aWdhdGlvbiBzdGVwczoKKyAgICAx KSBMb2FkcyB0aGlzIHBhZ2UsIGZvY3VzIGdvZXMgdG8gInN0YXJ0IiBhdXRvbWF0aWNhbGx5Lgor ICAgIDIpIE1vdmUgZm9jdXMgZG93biB0byB0aGUgdmlzaWJsZSBmb2N1c2FibGUgZWxlbWVudCBp bgorICAgICAgIHNjcm9sbGFibGUgZGl2LgorICAgIDMpIFRyYXZlcnNlIHRoZSBwYWdlIHRocm91 Z2ggb3RoZXIgZm9jdXNhYmxlIGVsZW1lbnRzIGRvd24gdGhlIHBhZ2UuCisgICAgICAgYW5kIHRo ZW4gYmFjayB1cC4KKworICAgICogRXhwZWN0ZWQgcmVzdWx0czogQWxsIGZvY3VzYWJsZSBlbGVt ZW50IGluIHNjcm9sbGFibGUgY29udGVudCwgaW5jbHVkaW5nCisgICAgb2Zmc2NyZWVuIG9uZXMs IHNob3VsZCBiZSBhY2Nlc3NpYmxlIHZpYSBzcGF0aWFsIG5hdmlnYXRpb24uIC0tPgorICA8aGVh ZD4KKyAgICA8c3R5bGU+CisgICAgOmZvY3VzIHtvdXRsaW5lOiAxcHggc29saWQgYmxhY2s7fQor ICAgIDwvc3R5bGU+CisgICAgPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0 LXByZS5qcyI+PC9zY3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9InJlc291cmNlcy9zcGF0aWFsLW5h dmlnYXRpb24tdXRpbHMuanMiPjwvc2NyaXB0PgorICAgIDxzY3JpcHQgdHlwZT0iYXBwbGljYXRp b24vamF2YXNjcmlwdCI+CisKKyAgICB2YXIgcmVzdWx0TWFwID0gWworICAgICAgWyJEb3duIiwg IjEiXSwKKyAgICAgIFsiRG93biIsICIyIl0sCisgICAgICBbIkRvd24iLCAiMyJdLAorICAgICAg WyJEb3duIiwgIjQiXSwKKyAgICAgIFsiRG93biIsICI1Il0sCisgICAgICBbIlVwIiwgIjQiXSwK KyAgICAgIFsiVXAiLCAiMyJdLAorICAgICAgWyJVcCIsICIyIl0sCisgICAgICBbIlVwIiwgIjEi XSwKKyAgICAgIFsiVXAiLCAic3RhcnQiXSwKKyAgICAgIFsiRE9ORSIsICJET05FIl0KKyAgICBd OworCisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIu c2V0U3BhdGlhbE5hdmlnYXRpb25FbmFibGVkKHRydWUpOworICAgICAgbGF5b3V0VGVzdENvbnRy b2xsZXIub3ZlcnJpZGVQcmVmZXJlbmNlKCJXZWJLaXRUYWJUb0xpbmtzUHJlZmVyZW5jZUtleSIs IDEpOworICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworICAgIH0K KworICAgIGZ1bmN0aW9uIHJ1blRlc3QoKQorICAgIHsKKyAgICAgIC8vIHN0YXJ0aW5nIHRoZSB0 ZXN0IGl0c2VsZjogZ2V0IHRvIGEga25vd24gcGxhY2UuCisgICAgICBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgic3RhcnQiKS5mb2N1cygpOworCisgICAgICBpbml0VGVzdChyZXN1bHRNYXAsIHRl c3RDb21wbGV0ZWQpOworICAgIH0KKworICAgIGZ1bmN0aW9uIHRlc3RDb21wbGV0ZWQoKQorICAg IHsKKyAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIGxheW91 dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKKyAgICB9CisKKyAgICB3aW5kb3cub25sb2Fk ID0gcnVuVGVzdDsKKworICAgIDwvc2NyaXB0PgorICAgIDxzY3JpcHQgc3JjPSIuLi9qcy9yZXNv dXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKyAgPC9oZWFkPgorICA8Ym9keT4KKyAg ICA8YSBocmVmPSIjIiBpZD0ic3RhcnQiPlRoaXMgaXMgYW4gZWxlbWVudDwvYT48YnI+CisKKyAg ICA8ZGl2PgorICAgICAgPGEgaHJlZj0iIyIgaWQ9IjEiPgorICAgICAgICA8aW1nIHNyYz0icmVz b3VyY2VzL2dyZWVuLnBuZyIgaGVpZ2h0PSI0MiIgd2lkdGg9Ijc2IiAgYm9yZGVyPSIwIi8+Cisg ICAgICA8L2E+CisgICAgPC9kaXY+CisKKyAgICA8ZGl2PgorICAgICAgPGEgaHJlZj0iIyIgaWQ9 IjIiPlRoaXMgaXMgYW4gZWxlbWVudDwvYT48YnI+CisgICAgPC9kaXY+CisKKyAgICA8YSBocmVm PSIjIiBpZD0iMyI+VGhpcyBpcyBhbiBlbGVtZW50PC9hPjxicj4KKworICAgIDxhIGhyZWY9IiMi IGlkPSI0Ij4KKyAgICAgIDxpbWcgc3JjPSJyZXNvdXJjZXMvZ3JlZW4ucG5nIiBoZWlnaHQ9IjQy IiB3aWR0aD0iNzYiIGFsdD0ibGxpbmtlcjEiIGJvcmRlcj0iMCIvPgorICAgIDwvYT48YnI+CisK KyAgICA8YSBocmVmPSIjIiBpZD0iNSI+VGhpcyBpcyBhbiBlbGVtZW50PC9hPjxicj4KKyAgICA8 ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKyAgICA8ZGl2PlRoaXMgdGVzdCB0ZXN0cyB0aGF0IGEg YW5jaG9yIGVsZW1lbnQgd2l0aCBpbiBpbWFnZSBpbiBpdCBhbmQgYSBzcGFjZSBhZnRlciB0aGUg aW1hZ2UsIGNhbiBzdGlsbCBnaXZlIHRoZSBjb3JyZWN0IHNpemUgaW4gQ29udGFpbmVyTm9kZTo6 Z2V0UmVjdCgpLjwvZGl2PgorICA8L2JvZHk+Cis8L2h0bWw+CisK