48367 2010-10-26 12:49:14 -0700 Post any pending messages to the Injected Bundle in WebContext::processDidFinishLaunching instead of in WebContext::ensureWebProcess 2010-10-26 13:53:05 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 jberlin jberlin andersca jberlin sam oldest_to_newest 299733 0 jberlin 2010-10-26 12:49:14 -0700 We currently post those pending Injected Bundle messages in WebContext::ensureWebProcess. However it is possible for messages to be sent to WebContext::postMessageToInjectedBundle in between the call to ensureWebProcess and the asychronous callback that results in WebProcessProxy::didFinishLaunching being called. During that time, the WebProcessProxy is invalid so messages in WebContext::postMessageToInjectedBundle get added to the m_pendingMessagesToPostToInjectedBundle and will never actually be sent. Instead, we should wait for the process to finish launching before we post the pending messages to the Injected Bundle (in WebContext::processDidFinishLaunching). <rdar://problem/8595623> 299739 1 71931 jberlin 2010-10-26 12:53:15 -0700 Created attachment 71931 Post pending messages to the Injected Bundle in WebContext::processDidFinishLaunching 299764 2 71931 darin 2010-10-26 13:30:42 -0700 Comment on attachment 71931 Post pending messages to the Injected Bundle in WebContext::processDidFinishLaunching View in context: https://bugs.webkit.org/attachment.cgi?id=71931&action=review > WebKit2/UIProcess/WebContext.cpp:192 > + pair<String, RefPtr<APIObject> >* message = &m_pendingMessagesToPostToInjectedBundle[i]; > + m_process->send(InjectedBundleMessage::PostMessage, 0, CoreIPC::In(message->first, WebContextUserMessageEncoder(message->second.get()))); You are just moving this code, and didn’t write it. I would have used a reference instead of a pointer here. 299772 3 jberlin 2010-10-26 13:40:09 -0700 (In reply to comment #2) > (From update of attachment 71931 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=71931&action=review > > > WebKit2/UIProcess/WebContext.cpp:192 > > + pair<String, RefPtr<APIObject> >* message = &m_pendingMessagesToPostToInjectedBundle[i]; > > + m_process->send(InjectedBundleMessage::PostMessage, 0, CoreIPC::In(message->first, WebContextUserMessageEncoder(message->second.get()))); > > You are just moving this code, and didn’t write it. I would have used a reference instead of a pointer here. Actually, I believe that was me in http://trac.webkit.org/changeset/67593. Changed to be: pair<String, RefPtr<APIObject> >& message = m_pendingMessagesToPostToInjectedBundle[i]; m_process->send(InjectedBundleMessage::PostMessage, 0, CoreIPC::In(message.first, WebContextUserMessageEncoder(message.second.get()))); Thanks for the review! 299781 4 71931 jberlin 2010-10-26 13:52:59 -0700 Comment on attachment 71931 Post pending messages to the Injected Bundle in WebContext::processDidFinishLaunching Committed in r70568 http://trac.webkit.org/changeset/70568 71931 2010-10-26 12:53:15 -0700 2010-10-26 13:52:59 -0700 Post pending messages to the Injected Bundle in WebContext::processDidFinishLaunching postPendingMessagesInProcessDidFinishLaunching.patch text/plain 2442 jberlin SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDU1NSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMTAtMjYgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQ b3N0IGFueSBwZW5kaW5nIG1lc3NhZ2VzIHRvIHRoZSBJbmplY3RlZCBCdW5kbGUgaW4gV2ViQ29u dGV4dDo6cHJvY2Vzc0RpZEZpbmlzaExhdW5jaGluZworICAgICAgICBpbnN0ZWFkIG9mIGluIFdl YkNvbnRleHQ6OmVuc3VyZVdlYlByb2Nlc3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00ODM2NworCisgICAgICAgIFNlbmQgcGVuZGluZyBpbmplY3Rl ZCBidW5kbGUgbWVzc2FnZXMgYWZ0ZXIgdGhlIHByb2Nlc3MgZmluaXNoZWQgbGF1bmNoaW5nIGlu c3RlYWQgb2Ygb2YKKyAgICAgICAgZGlyZWN0bHkgYWZ0ZXIgY3JlYXRpbmcgaXQuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvV2ViQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbnRl eHQ6OmVuc3VyZVdlYlByb2Nlc3MpOgorICAgICAgICBNb3ZlIHRoZSBsb2dpYyB0byBkaXNwYXRj aCBwZW5kaW5nIGluamVjdGVkIGJ1bmRsZSBtZXNzYWdlcyBmcm9tIGhlcmUgLi4uCisgICAgICAg IChXZWJLaXQ6OldlYkNvbnRleHQ6OnByb2Nlc3NEaWRGaW5pc2hMYXVuY2hpbmcpOgorICAgICAg ICAuLi4gdG8gaGVyZS4KKwogMjAxMC0xMC0yNiAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2Vy QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViQ29udGV4dC5jcHAJKHJldmlzaW9uIDcwNTI5KQorKysgV2ViS2l0Mi9VSVByb2Nl c3MvV2ViQ29udGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3OCwxMiArMTc4LDYgQEAgdm9p ZCBXZWJDb250ZXh0OjplbnN1cmVXZWJQcm9jZXNzKCkKICAgICBwbGF0Zm9ybUluaXRpYWxpemVX ZWJQcm9jZXNzKHBhcmFtZXRlcnMpOwogCiAgICAgbV9wcm9jZXNzLT5zZW5kKE1lc3NhZ2VzOjpX ZWJQcm9jZXNzOjpJbml0aWFsaXplV2ViUHJvY2VzcyhwYXJhbWV0ZXJzKSwgMCk7Ci0KLSAgICBm b3IgKHNpemVfdCBpID0gMDsgaSAhPSBtX3BlbmRpbmdNZXNzYWdlc1RvUG9zdFRvSW5qZWN0ZWRC dW5kbGUuc2l6ZSgpOyArK2kpIHsKLSAgICAgICAgcGFpcjxTdHJpbmcsIFJlZlB0cjxBUElPYmpl Y3Q+ID4qIG1lc3NhZ2UgPSAmbV9wZW5kaW5nTWVzc2FnZXNUb1Bvc3RUb0luamVjdGVkQnVuZGxl W2ldOwotICAgICAgICBtX3Byb2Nlc3MtPnNlbmQoSW5qZWN0ZWRCdW5kbGVNZXNzYWdlOjpQb3N0 TWVzc2FnZSwgMCwgQ29yZUlQQzo6SW4obWVzc2FnZS0+Zmlyc3QsIFdlYkNvbnRleHRVc2VyTWVz c2FnZUVuY29kZXIobWVzc2FnZS0+c2Vjb25kLmdldCgpKSkpOwotICAgIH0KLSAgICBtX3BlbmRp bmdNZXNzYWdlc1RvUG9zdFRvSW5qZWN0ZWRCdW5kbGUuY2xlYXIoKTsKIH0KIAogdm9pZCBXZWJD b250ZXh0Ojpwcm9jZXNzRGlkRmluaXNoTGF1bmNoaW5nKFdlYlByb2Nlc3NQcm94eSogcHJvY2Vz cykKQEAgLTE5Miw2ICsxODYsMTIgQEAgdm9pZCBXZWJDb250ZXh0Ojpwcm9jZXNzRGlkRmluaXNo TGF1bmNoaQogICAgIEFTU0VSVChwcm9jZXNzID09IG1fcHJvY2Vzcyk7CiAKICAgICBtX3Zpc2l0 ZWRMaW5rUHJvdmlkZXIucG9wdWxhdGVWaXNpdGVkTGlua3NJZk5lZWRlZCgpOworCisgICAgZm9y IChzaXplX3QgaSA9IDA7IGkgIT0gbV9wZW5kaW5nTWVzc2FnZXNUb1Bvc3RUb0luamVjdGVkQnVu ZGxlLnNpemUoKTsgKytpKSB7CisgICAgICAgIHBhaXI8U3RyaW5nLCBSZWZQdHI8QVBJT2JqZWN0 PiA+KiBtZXNzYWdlID0gJm1fcGVuZGluZ01lc3NhZ2VzVG9Qb3N0VG9JbmplY3RlZEJ1bmRsZVtp XTsKKyAgICAgICAgbV9wcm9jZXNzLT5zZW5kKEluamVjdGVkQnVuZGxlTWVzc2FnZTo6UG9zdE1l c3NhZ2UsIDAsIENvcmVJUEM6OkluKG1lc3NhZ2UtPmZpcnN0LCBXZWJDb250ZXh0VXNlck1lc3Nh Z2VFbmNvZGVyKG1lc3NhZ2UtPnNlY29uZC5nZXQoKSkpKTsKKyAgICB9CisgICAgbV9wZW5kaW5n TWVzc2FnZXNUb1Bvc3RUb0luamVjdGVkQnVuZGxlLmNsZWFyKCk7CiB9CiAKIHZvaWQgV2ViQ29u dGV4dDo6cHJvY2Vzc0RpZENsb3NlKFdlYlByb2Nlc3NQcm94eSogcHJvY2VzcykK