48347 2010-10-26 11:02:37 -0700 Calling the super class of RenderSVGImage::updateFromElement is missing 2010-10-27 14:04:54 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 rhodovan.u-szeged webkit-unassigned abarth commit-queue dglazkov eric kling krit mdelaney7 webkit.review.bot zherczeg zimmermann oldest_to_newest 299604 0 rhodovan.u-szeged 2010-10-26 11:02:37 -0700 Calling the super class of RenderSVGImage::updateFromElement is missing 299617 1 71914 rhodovan.u-szeged 2010-10-26 11:14:51 -0700 Created attachment 71914 Adding the missing super class call The patch fixes the failed dynamic-update tests of feConvolveMatrix as well (because they have SVGImage objects) 299620 2 kling 2010-10-26 11:16:58 -0700 (In reply to comment #1) > The patch fixes the failed dynamic-update tests of feConvolveMatrix as well (because they have SVGImage objects) This seems to imply that something should be unskipped and/or rebaselined. 299640 3 71914 zimmermann 2010-10-26 11:34:00 -0700 Comment on attachment 71914 Adding the missing super class call Looks good, great catch! You need to write a better ChangeLog, saying what's fixed though... 300032 4 71988 rhodovan.u-szeged 2010-10-26 23:45:59 -0700 Created attachment 71988 Adding the missing super class call 300055 5 krit 2010-10-27 01:10:04 -0700 (In reply to comment #4) > Created an attachment (id=71988) [details] > Adding the missing super class call I'd like to read a sentence in the ChangeLog that this is covered by dynamic updates of feConvolveMatrix, since every regression needs a regression test. 300057 6 71988 krit 2010-10-27 01:10:50 -0700 Comment on attachment 71988 Adding the missing super class call Sorry, but this sentence need to go in. It's WebKit policy. 300244 7 72039 rhodovan.u-szeged 2010-10-27 08:33:27 -0700 Created attachment 72039 Adding the missing super class call 300251 8 72039 krit 2010-10-27 08:47:37 -0700 Comment on attachment 72039 Adding the missing super class call r=me 300270 9 72039 commit-queue 2010-10-27 09:10:21 -0700 Comment on attachment 72039 Adding the missing super class call Clearing flags on attachment: 72039 Committed r70654: <http://trac.webkit.org/changeset/70654> 300271 10 commit-queue 2010-10-27 09:10:27 -0700 All reviewed patches have been landed. Closing bug. 300310 11 dglazkov 2010-10-27 10:06:21 -0700 (In reply to comment #10) > All reviewed patches have been landed. Closing bug. This patch affected a few pixel results, and they probably should be landed with the patch. 300324 12 zherczeg 2010-10-27 10:14:26 -0700 > This patch affected a few pixel results, and they probably should be landed with the patch. Chromium pixel tests are a difficult problem. Once I wanted to update some Chromium pixel tests, and asked Eric for help, but he said he use mac, and gave me some names. I wrote them, but they don't reply. The poblem is we couldn't compile a chromium port and run pixel tests, since we have no idea how it works :( 300335 13 dglazkov 2010-10-27 10:21:37 -0700 (In reply to comment #12) > > This patch affected a few pixel results, and they probably should be landed with the patch. > > Chromium pixel tests are a difficult problem. Once I wanted to update some Chromium pixel tests, and asked Eric for help, but he said he use mac, and gave me some names. I wrote them, but they don't reply. The poblem is we couldn't compile a chromium port and run pixel tests, since we have no idea how it works :( I'll take care of the Chromium pixel tests. However, I am positive this patch also affected platform/mac, for instance. 300348 14 zherczeg 2010-10-27 10:29:43 -0700 > I'll take care of the Chromium pixel tests. However, I am positive this patch also affected platform/mac, for instance. Exactly, in a good way. Those tests were working properly, until the patch mentioned in the ChangeLog made them wrong. So this patch just restores their oiginal state. Since the mac bots don't run pixel tests, this thing was hidden so far. 300351 15 zherczeg 2010-10-27 10:32:31 -0700 To be more precise: if you run mac pixel tests on the mainline, you get 10 fails. This patch restores 8 of them, and you get less fails. 300357 16 dglazkov 2010-10-27 10:45:11 -0700 (In reply to comment #15) > To be more precise: if you run mac pixel tests on the mainline, you get 10 fails. This patch restores 8 of them, and you get less fails. That's great! :) 300549 17 webkit.review.bot 2010-10-27 14:04:54 -0700 http://trac.webkit.org/changeset/70667 might have broken GTK Linux 32-bit Debug 71914 2010-10-26 11:14:51 -0700 2010-10-26 23:45:59 -0700 Adding the missing super class call missing_super_class.patch text/plain 1161 rhodovan.u-szeged SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDUzNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMTAtMjYgIFJlbmF0YSBIb2RvdmFuICA8cmVuaUBpbmYudS1z emVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkZWQgdGhlIG1pc3Npbmcgc3VwZXIgY2xhc3MgY2FsbCB0byB0aGUgdmlydHVhbCBSZW5k ZXJTVkdJbWFnZTo6dXBkYXRlRnJvbUVsZW1lbnQgbWV0aG9kLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDgzNDcKKworICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJTVkdJbWFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTVkdJbWFnZTo6 dXBkYXRlRnJvbUVsZW1lbnQpOgorCiAyMDEwLTEwLTI2ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRt YW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE5vdCByZXZpZXdlZC4gVG91Y2hpbmcgaW5zcGVj dG9yIGNvbnRyb2xsZXIgdG8ga2ljayBndGsgYnVpbGQsIHJlbW92aW5nIGNvbW1lbnRzLgpJbmRl eDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU1ZHSW1hZ2UuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR0ltYWdlLmNwcAkocmV2aXNpb24gNzA1MTQpCisrKyBX ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTVkdJbWFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEw MCw2ICsxMDAsNyBAQCB2b2lkIFJlbmRlclNWR0ltYWdlOjp1cGRhdGVGcm9tRWxlbWVudCgpCiAg ICAgICAgIG1fdXBkYXRlQ2FjaGVkUmVwYWludFJlY3QgPSB0cnVlOwogICAgICAgICBzZXROZWVk c0xheW91dCh0cnVlKTsKICAgICB9CisgICAgUmVuZGVyU1ZHTW9kZWxPYmplY3Q6OnVwZGF0ZUZy b21FbGVtZW50KCk7CiB9CiAKIHZvaWQgUmVuZGVyU1ZHSW1hZ2U6OnBhaW50KFBhaW50SW5mbyYg cGFpbnRJbmZvLCBpbnQsIGludCkK 71988 2010-10-26 23:45:59 -0700 2010-10-27 08:33:27 -0700 Adding the missing super class call missing_super_class.patch text/plain 1292 rhodovan.u-szeged SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDYxNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMTAtMjYgIFJlbmF0YSBIb2RvdmFuICA8cmVuaUBpbmYudS1z emVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ2FsbGluZyB0aGUgc3VwZXIgY2xhc3Mgb2YgUmVuZGVyU1ZHSW1hZ2U6OnVwZGF0ZUZyb21F bGVtZW50IGlzIG1pc3NpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQ4MzQ3CisKKyAgICAgICAgUmVuZGVyU1ZHSW1hZ2U6OnVwZGF0ZUZyb21FbGVt ZW50IGlzIGFuIGluaGVyaXRlZCBmdW5jdGlvbiBvZiBSZW5kZXJTVkdNb2RlbE9iamVjdCB3aGF0 IG5lZWRzIGNhbGxpbmcgaXRzIGFuY2VzdG9yLgorICAgICAgICBMYWNrIG9mIHRoaXMgY2FsbCBj YXVzZWQgZmlsdGVycyB3ZXJlbid0IGludmFsaWRhdGVkIGF0IFNWR0ltYWdlIG9iamVjdHMuCisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyU1ZHSW1hZ2UuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyU1ZHSW1hZ2U6OnVwZGF0ZUZyb21FbGVtZW50KToKKwogMjAxMC0xMC0yNiAgRGFp IE1pa3VydWJlICA8ZG1pa3VydWJlQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg S2VudCBUYW11cmEuCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTVkdJbWFnZS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU1ZHSW1hZ2UuY3BwCShyZXZp c2lvbiA3MDUxNCkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR0ltYWdlLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTAwLDYgKzEwMCw3IEBAIHZvaWQgUmVuZGVyU1ZHSW1hZ2U6OnVwZGF0 ZUZyb21FbGVtZW50KCkKICAgICAgICAgbV91cGRhdGVDYWNoZWRSZXBhaW50UmVjdCA9IHRydWU7 CiAgICAgICAgIHNldE5lZWRzTGF5b3V0KHRydWUpOwogICAgIH0KKyAgICBSZW5kZXJTVkdNb2Rl bE9iamVjdDo6dXBkYXRlRnJvbUVsZW1lbnQoKTsKIH0KIAogdm9pZCBSZW5kZXJTVkdJbWFnZTo6 cGFpbnQoUGFpbnRJbmZvJiBwYWludEluZm8sIGludCwgaW50KQo= 72039 2010-10-27 08:33:27 -0700 2010-10-27 09:10:21 -0700 Adding the missing super class call missing_super_class.patch text/plain 1444 rhodovan.u-szeged SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDY0MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMTAtMjcgIFJlbmF0YSBIb2RvdmFuICA8cmVuaUBpbmYudS1z emVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ2FsbGluZyB0aGUgc3VwZXIgY2xhc3Mgb2YgUmVuZGVyU1ZHSW1hZ2U6OnVwZGF0ZUZyb21F bGVtZW50IGlzIG1pc3NpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQ4MzQ3CisKKyAgICAgICAgUmVuZGVyU1ZHSW1hZ2U6OnVwZGF0ZUZyb21FbGVt ZW50IGlzIGFuIGluaGVyaXRlZCBmdW5jdGlvbiBvZiBSZW5kZXJTVkdNb2RlbE9iamVjdCB3aGF0 IG5lZWRzIGNhbGxpbmcgaXRzIGFuY2VzdG9yLgorICAgICAgICBMYWNrIG9mIHRoaXMgY2FsbCBj YXVzZWQgZmlsdGVycyB3ZXJlIG5vdCBpbnZhbGlkYXRlZCBhdCBTVkdJbWFnZSBvYmplY3RzLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVjYXVzZSB0aGlzIG1vZGlmaWNhdGlvbiBpcyBjb3Zl cmVkIGJ5IFNWR0ZFQ29udm9sdmVNYXRyaXhFbGVtZW50J3MgZHluYW1pYyB1cGRhdGUgdGVzdHMu CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyU1ZHSW1hZ2UuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyU1ZHSW1hZ2U6OnVwZGF0ZUZyb21FbGVtZW50KToKKwogMjAxMC0xMC0yNyAg QWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgT25seSBkZWNvbXByZXNz IHBpeGVsIGJ1ZmZlcnMgd2hlbiBuZWVkZWQgKGFuZCBmaXggYSBjcmFzaCBpbiB0aGUKSW5kZXg6 IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR0ltYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJTVkdJbWFnZS5jcHAJKHJldmlzaW9uIDcwNTE0KQorKysgV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyU1ZHSW1hZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDAs NiArMTAwLDcgQEAgdm9pZCBSZW5kZXJTVkdJbWFnZTo6dXBkYXRlRnJvbUVsZW1lbnQoKQogICAg ICAgICBtX3VwZGF0ZUNhY2hlZFJlcGFpbnRSZWN0ID0gdHJ1ZTsKICAgICAgICAgc2V0TmVlZHNM YXlvdXQodHJ1ZSk7CiAgICAgfQorICAgIFJlbmRlclNWR01vZGVsT2JqZWN0Ojp1cGRhdGVGcm9t RWxlbWVudCgpOwogfQogCiB2b2lkIFJlbmRlclNWR0ltYWdlOjpwYWludChQYWludEluZm8mIHBh aW50SW5mbywgaW50LCBpbnQpCg==