48327 2010-10-26 07:55:27 -0700 [Qt] Assert due to multiple initialization of WebPlatformStrategies 2010-10-27 08:24:36 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 1 zalan webkit-qt-unassigned ademar commit-queue kbalazs kenneth oldest_to_newest 299452 0 zalan 2010-10-26 07:55:27 -0700 https://bugs.webkit.org/show_bug.cgi?id=46078 introduced WebPlatformStrategies::initialize() in QWKPagePrivate::QWKPagePrivate() to initialize the platform strategies in the UI process. Initialization should be done only once, and not per page. Multiple initialization triggers assert in WebCore/PlatformStrategies. The code should mimic the web process side instead. (init is part of the webprocess constuct). I'll upload a patch soon, which removes the initialization, as it is not needed at all atm. 300037 1 71990 zalan 2010-10-27 00:02:30 -0700 Created attachment 71990 remove multiple init 300062 2 71990 commit-queue 2010-10-27 01:19:23 -0700 Comment on attachment 71990 remove multiple init Clearing flags on attachment: 71990 Committed r70620: <http://trac.webkit.org/changeset/70620> 300063 3 commit-queue 2010-10-27 01:19:29 -0700 All reviewed patches have been landed. Closing bug. 300161 4 kbalazs 2010-10-27 06:03:35 -0700 This makes Minibrowser crashing immediately. 300169 5 72024 kbalazs 2010-10-27 06:17:46 -0700 Created attachment 72024 second attempt to fix the original issue 300187 6 72024 kling 2010-10-27 06:57:10 -0700 Comment on attachment 72024 second attempt to fix the original issue View in context: https://bugs.webkit.org/attachment.cgi?id=72024&action=review r=me, one comment: > WebKit2/UIProcess/API/qt/qwkpage.cpp:55 > + if (!initialized) { Use early return. 300194 7 zalan 2010-10-27 07:06:44 -0700 oh, sorry. i was about to post the fix on that. 300200 8 kbalazs 2010-10-27 07:15:20 -0700 (In reply to comment #6) > (From update of attachment 72024 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=72024&action=review > > r=me, one comment: > > > WebKit2/UIProcess/API/qt/qwkpage.cpp:55 > > + if (!initialized) { > > Use early return. I will. I know that this is the preferred style, but personally I hate that. There are a lot situations where the early return makes the code harder to read. 300236 9 kbalazs 2010-10-27 08:24:16 -0700 Committed in http://trac.webkit.org/changeset/70645 71990 2010-10-27 00:02:30 -0700 2010-10-27 06:17:39 -0700 remove multiple init multiple_init.patch text/plain 1278 zalan SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDYxNykKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMTAtMjYgIFphbGFuIEJ1anRhcyAgPHpidWp0YXNAZ21haWwu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE11 bHRpcGxlIFdlYlBsYXRmb3JtU3RyYXRlZ3kgaW5pdGlhbGl6YXRpb24gdHJpZ2dlcnMgYXNzZXJ0 IGluIFdlYkNvcmUvUGxhdGZvcm1TdHJhdGVnaWVzLiAKKyAgICAgICAgUmVtb3ZlIHRoZSBjb2Rl IGZvciBub3csIGFzIGl0IGlzIG5vdCB1c2VkIGF0IGFsbC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4MzI3CisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL3F0L3F3a3BhZ2UuY3BwOgorICAgICAgICAoUVdLUGFnZVByaXZhdGU6OlFXS1BhZ2VQcml2 YXRlKToKKwogMjAxMC0xMC0yNiAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCkluZGV4OiBXZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvcXdrcGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3F3a3BhZ2UuY3BwCShyZXZpc2lvbiA3MDYxNykKKysrIFdlYktpdDIvVUlQcm9jZXNzL0FQ SS9xdC9xd2twYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTQsMTAgKzU0LDYgQEAgUVdLUGFn ZVByaXZhdGU6OlFXS1BhZ2VQcml2YXRlKFFXS1BhZ2UqIAogICAgICwgcHJlZmVyZW5jZXMoMCkK ICAgICAsIGNyZWF0ZU5ld1BhZ2VGbigwKQogewotICAgIC8vIFdlIHdhbnQgdG8gdXNlIHRoZSBM b2NhbGl6YXRpb25TdHJhdGVneSBhdCB0aGUgVUkgc2lkZSBhcyB3ZWxsLgotICAgIC8vIEZJWE1F OiB0aGlzIHNob3VsZCBiZSBhdm9pZGVkLgotICAgIFdlYlBsYXRmb3JtU3RyYXRlZ2llczo6aW5p dGlhbGl6ZSgpOwotCiAgICAgbWVtc2V0KGFjdGlvbnMsIDAsIHNpemVvZihhY3Rpb25zKSk7CiAg ICAgcGFnZSA9IHRvSW1wbChuYW1lc3BhY2VSZWYpLT5jcmVhdGVXZWJQYWdlKCk7CiAgICAgcGFn ZS0+c2V0UGFnZUNsaWVudCh0aGlzKTsK 72024 2010-10-27 06:17:46 -0700 2010-10-27 08:24:36 -0700 second attempt to fix the original issue bug-48327-20101027151744.patch text/plain 1769 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg Zjk0YzQ0M2MwMTY0MDVmYjZhZGIxODJlNzEyYzgxMTdkMjc0MWY1Ni4uZjYxZDgzNGVkMmVmYmI1 OGVmNDAzYzQ3Mzg4ODk2MjYyMjY3ZDcxMCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMC0yNyAgQmFs YXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBBc3NlcnQgZHVlIHRvIG11bHRpcGxlIGlu aXRpYWxpemF0aW9uIG9mIFdlYlBsYXRmb3JtU3RyYXRlZ2llcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDgzMjcKKworICAgICAgICBXZSBhcmUgdXNp bmcgdGhlIExvY2FsaXphdGlvblN0cmF0ZWd5IGluIHRoZSBVSSBwcm9jZXNzCisgICAgICAgIHNv IHRoZSBwcmV2aW91cyBhdHRlbXB0IHRvIGZpeCB0aGlzIChodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC83MDYyMCkKKyAgICAgICAgd2FzIHdyb25nLgorICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvcXQvcXdrcGFnZS5jcHA6CisgICAgICAgIChpbml0aWFsaXplUGxhdGZvcm1TdHJhdGVn aWVzSWZOZWVkZWQpOgorICAgICAgICBDYWxsIFdlYlBsYXRmb3JtU3RyYXRlZ2llczo6aW5pdGlh bGl6ZSBleGFjdGx5IG9uY2UuCisgICAgICAgIChRV0tQYWdlUHJpdmF0ZTo6UVdLUGFnZVByaXZh dGUpOgorCiAyMDEwLTEwLTI3ICBLaW1tbyBLaW5udW5lbiAgPGtpbW1vLnQua2lubnVuZW5Abm9r aWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRpZmYgLS1naXQg YS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAgYi9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvcXdrcGFnZS5jcHAKaW5kZXggYzAzYjg3YmU3OTg0YTYxNzQ1OTg3MzMyZGY4ZjM5 MDQ2NDE5NGI0Ni4uOTE3MDA1MzdhNjNmN2FmZWEzMDRhMGQ4NjNkYTE4NjFjYjJiNWM2MyAxMDA2 NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuY3BwCisrKyBiL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmNwcApAQCAtNDksMTEgKzQ5LDIxIEBACiB1c2lu ZyBuYW1lc3BhY2UgV2ViS2l0OwogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKK3N0YXRpYyBp bmxpbmUgdm9pZCBpbml0aWFsaXplUGxhdGZvcm1TdHJhdGVnaWVzSWZOZWVkZWQoKQoreworICAg IHN0YXRpYyBib29sIGluaXRpYWxpemVkID0gZmFsc2U7CisgICAgaWYgKCFpbml0aWFsaXplZCkg eworICAgICAgICBXZWJQbGF0Zm9ybVN0cmF0ZWdpZXM6OmluaXRpYWxpemUoKTsKKyAgICAgICAg aW5pdGlhbGl6ZWQgPSB0cnVlOworICAgIH0KK30KKwogUVdLUGFnZVByaXZhdGU6OlFXS1BhZ2VQ cml2YXRlKFFXS1BhZ2UqIHFxLCBXS1BhZ2VOYW1lc3BhY2VSZWYgbmFtZXNwYWNlUmVmKQogICAg IDogcShxcSkKICAgICAsIHByZWZlcmVuY2VzKDApCiAgICAgLCBjcmVhdGVOZXdQYWdlRm4oMCkK IHsKKyAgICBpbml0aWFsaXplUGxhdGZvcm1TdHJhdGVnaWVzSWZOZWVkZWQoKTsKICAgICBtZW1z ZXQoYWN0aW9ucywgMCwgc2l6ZW9mKGFjdGlvbnMpKTsKICAgICBwYWdlID0gdG9JbXBsKG5hbWVz cGFjZVJlZiktPmNyZWF0ZVdlYlBhZ2UoKTsKICAgICBwYWdlLT5zZXRQYWdlQ2xpZW50KHRoaXMp Owo=