48322 2010-10-26 07:04:00 -0700 Enable check-webkit-style on Qt files 2010-11-11 23:51:45 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 48258 1 ademar ademar abarth commit-queue eric jedrzej.nowacki webkit.review.bot oldest_to_newest 299419 0 ademar 2010-10-26 07:04:00 -0700 As discussed in the mailing list[1] and documented in the wiki[2], we should enable check-webkit-style on Qt files. 1. https://lists.webkit.org/pipermail/webkit-qt/2010-October/000908.html 2. http://trac.webkit.org/wiki/QtWebKitContrib Patch is on the way. 299424 1 71876 ademar 2010-10-26 07:12:33 -0700 Created attachment 71876 patch 299426 2 ademar 2010-10-26 07:14:42 -0700 Qt code implements a few operator+= and operator-=, so marking this bug as dependant of bug 48258 (there's a patch there) 299968 3 71876 levin 2010-10-26 21:29:11 -0700 Comment on attachment 71876 patch View in context: https://bugs.webkit.org/attachment.cgi?id=71876&action=review Just a few minor comments. > WebKitTools/Scripts/webkitpy/style/checkers/cpp.py:2517 > + and filename.find('/qt/') < 0 All the hardcoded checks here are for items that there isn't a generic mechanism for. There is a generic mechanism for excluding directories. You'll have to list each directory but there aren't that many. See _PATH_RULES_SPECIFIER in WebKitTools/Scripts/webkitpy/style/checker.py > WebKitTools/Scripts/webkitpy/style/checkers/cpp_unittest.py:3722 > + self.assert_lint('QWhatever * d_ptr;', '', 'WebKit/qt/whatever.cpp') I'm mildly confused. Why is there a space between * and QWhatever? I thought this was testing that the name d_ptr was let through (not that spacing around * is allowed). 300211 4 71876 ademar 2010-10-27 07:38:49 -0700 Comment on attachment 71876 patch View in context: https://bugs.webkit.org/attachment.cgi?id=71876&action=review Thanks for the review! >> WebKitTools/Scripts/webkitpy/style/checkers/cpp.py:2517 >> + and filename.find('/qt/') < 0 > > All the hardcoded checks here are for items that there isn't a generic mechanism for. > > There is a generic mechanism for excluding directories. You'll have to list each directory but there aren't that many. > > See _PATH_RULES_SPECIFIER in WebKitTools/Scripts/webkitpy/style/checker.py Got it. Fixing. I still would like to have these files checked against the "don't use the single letter 'l' as an identifier" rule, which is part of readability/naming... maybe split the rule in two? something for a future patch anyway. >> WebKitTools/Scripts/webkitpy/style/checkers/cpp_unittest.py:3722 >> + self.assert_lint('QWhatever * d_ptr;', '', 'WebKit/qt/whatever.cpp') > > I'm mildly confused. Why is there a space between * and QWhatever? I thought this was testing that the name d_ptr was let through (not that spacing around * is allowed). Ouch, that was a typo. Anyway, these changes in checkers/cpp* are not needed anymore since the directories are now properly skipped. 300213 5 72033 ademar 2010-10-27 07:39:54 -0700 Created attachment 72033 patch #2 with review fixes 303630 6 levin 2010-11-02 13:53:53 -0700 *** Bug 35143 has been marked as a duplicate of this bug. *** 308376 7 72033 hamaji 2010-11-11 22:20:49 -0800 Comment on attachment 72033 patch #2 with review fixes Looks good. 308389 8 commit-queue 2010-11-11 22:51:32 -0800 The commit-queue encountered the following flaky tests while processing attachment 72033: animations/suspend-resume-animation.html http/tests/appcache/remove-cache.html Please file bugs against the tests. These tests were authored by ap@webkit.org and cmarrin@apple.com. The commit-queue is continuing to process your patch. 308396 9 72033 commit-queue 2010-11-11 23:21:33 -0800 Comment on attachment 72033 patch #2 with review fixes Clearing flags on attachment: 72033 Committed r71894: <http://trac.webkit.org/changeset/71894> 308397 10 commit-queue 2010-11-11 23:21:38 -0800 All reviewed patches have been landed. Closing bug. 308410 11 webkit.review.bot 2010-11-11 23:51:45 -0800 http://trac.webkit.org/changeset/71894 might have broken Qt Linux Release The following tests are not passing: svg/dom/SVGScriptElement/script-clone-rerun-self.svg svg/dom/SVGScriptElement/script-clone-rerun.svg 71876 2010-10-26 07:12:33 -0700 2010-10-27 07:39:54 -0700 patch 0001-Enable-check-webkit-style-on-Qt-files.patch text/plain 6684 ademar RnJvbSAwY2Q3NDBjZmNhNjYwODZiZmRhMjRiNTM2OGY0MmNhMDljM2JmMDJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVtYXIgZGUgU291emEgUmVpcyBKciA8YWRlbWFyLnJlaXNA b3BlbmJvc3NhLm9yZz4KRGF0ZTogV2VkLCAyMCBPY3QgMjAxMCAxNzoyNjozNSAtMDMwMApTdWJq ZWN0OiBbUEFUQ0hdIEVuYWJsZSBjaGVjay13ZWJraXQtc3R5bGUgb24gUXQgZmlsZXMKCkVuYWJs ZSBjaGVjay13ZWJraXQtc3R5bGUgb24gUXQgZmlsZXMKaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQ4MzIyCgpBZGRpbmcgYSBmZXcgZXhjZXB0aW9ucyAocXRfIG1ldGhv ZHMsIHFfcHRyIGFuZCBkX3B0ciBuYW1pbmcpCmFuZCBpbmNsdWRpbmcgdW5pdC10ZXN0IGltcHJv dmVtZW50cwotLS0KIFdlYktpdFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysKIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlci5weSAgICAgIHwgICAgNiAtLS0tLS0KIC4uLi9TY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXJfdW5pdHRlc3QucHkgICAgIHwgICAgOCArKysrKy0tLQogV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgfCAgICAyICsrCiAu Li4vd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5ICAgICAgICB8ICAgIDgg KysrKysrKy0KIDUgZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hh bmdlTG9nCmluZGV4IGI4NTBmOWIuLjBiY2RiYWMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0No YW5nZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAx MC0xMC0yNiAgQWRlbWFyIGRlIFNvdXphIFJlaXMgSnIgIDxhZGVtYXIucmVpc0BvcGVuYm9zc2Eu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVu YWJsZSBjaGVjay13ZWJraXQtc3R5bGUgb24gUXQgZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4MzIyCisKKyAgICAgICAgQWRkaW5nIGEgZmV3 IGV4Y2VwdGlvbnMgKHF0XyBtZXRob2RzLCBxX3B0ciBhbmQgZF9wdHIgbmFtaW5nKQorICAgICAg ICBhbmQgaW5jbHVkaW5nIHVuaXQtdGVzdCBpbXByb3ZlbWVudHMKKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weTogZW5hYmxlIFF0IGRpcnMKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJfdW5pdHRlc3QucHk6IGFkZCB1bml0dGVzdHMK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weTogYWRkIGEg Y291cGxlIG9mIFF0IGV4Y2VwdGlvbnMKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcF91bml0dGVzdC5weTogYWRkIHVuaXR0ZXN0cworCiAyMDEwLTEwLTI1ICBB ZGVtYXIgZGUgU291emEgUmVpcyBKci4gIDxhZGVtYXIucmVpc0BvcGVuYm9zc2Eub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CmluZGV4IGY4ZWVmYTQuLjk2Mjg4YTcgMTAwNjQ0 Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQorKysg Yi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKQEAgLTIwMywx NSArMjAzLDkgQEAgX1RFWFRfRklMRV9FWFRFTlNJT05TID0gWwogIyBXZWJLaXQgbWFpbnRhaW5z IHNvbWUgZmlsZXMgaW4gTW96aWxsYSBzdHlsZSBvbiBwdXJwb3NlIHRvIGVhc2UKICMgZnV0dXJl IG1lcmdlcy4KIF9TS0lQUEVEX0ZJTEVTX1dJVEhfV0FSTklORyA9IFsKLSAgICAjIFRoZSBRdCBB UEkgYW5kIHRlc3RzIGRvIG5vdCBmb2xsb3cgV2ViS2l0IHN0eWxlLgotICAgICMgVGhleSBmb2xs b3cgUXQgc3R5bGUuIDopCiAgICAgImd0azJkcmF3aW5nLmMiLCAjIFdlYkNvcmUvcGxhdGZvcm0v Z3RrL2d0azJkcmF3aW5nLmMKICAgICAiZ3RrZHJhd2luZy5oIiwgIyBXZWJDb3JlL3BsYXRmb3Jt L2d0ay9ndGtkcmF3aW5nLmgKLSAgICAiSmF2YVNjcmlwdENvcmUvcXQvYXBpLyIsCiAgICAgIldl YktpdC9ndGsvdGVzdHMvIiwKLSAgICAiV2ViS2l0L3F0L0FwaS8iLAotICAgICJXZWJLaXQvcXQv dGVzdHMvIiwKLSAgICAiV2ViS2l0L3F0L2V4YW1wbGVzLyIsCiAgICAgIyBTb3VwIEFQSSB0aGF0 IGlzIHN0aWxsIGJlaW5nIGNvb2tlZCwgd2lsbCBiZSByZW1vdmVkIGZyb20gV2ViS2l0CiAgICAg IyBpbiBhIGZldyBtb250aHMgd2hlbiBpdCBpcyBtZXJnZWQgaW50byBzb3VwIHByb3Blci4gVGhl IHN0eWxlCiAgICAgIyBmb2xsb3dzIHRoZSBsaWJzb3VwIHN0eWxlIGNvbXBsZXRlbHkuCmRpZmYg LS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJfdW5pdHRl c3QucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJfdW5pdHRl c3QucHkKaW5kZXggNTI1NDI3NS4uY2JiOTYzMyAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyX3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcl91bml0dGVzdC5weQpAQCAtMjI4LDYgKzIy OCwxMSBAQCBjbGFzcyBHbG9iYWxWYXJpYWJsZXNUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAg ICAgICAgICAgICAgICAgICAgICAicmVhZGFiaWxpdHkvbmFtaW5nIikKICAgICAgICAgYXNzZXJ0 Tm9DaGVjaygiV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcCIsCiAgICAgICAgICAgICAgICAgICAg ICAgInJlYWRhYmlsaXR5L25hbWluZyIpCisgICAgICAgIGFzc2VydENoZWNrKCJXZWJLaXQvcXQv QXBpL3F3ZWJwYWdlLmNwcCIsCisgICAgICAgICAgICAgICAgICAgICAgInJlYWRhYmlsaXR5L25h bWluZyIpCisgICAgICAgIGFzc2VydENoZWNrKAorICAgICAgICAgICAgIkphdmFTY3JpcHRDb3Jl L3F0L2FwaS9xc2NyaXB0ZW5naW5lLmNwcCIsCisgICAgICAgICAgICAicmVhZGFiaWxpdHkvbmFt aW5nIikKICAgICAgICAgYXNzZXJ0Tm9DaGVjaygiV2ViS2l0L3F0L3Rlc3RzL3F3ZWJlbGVtZW50 L3RzdF9xd2ViZWxlbWVudC5jcHAiLAogICAgICAgICAgICAgICAgICAgICAgICJyZWFkYWJpbGl0 eS9uYW1pbmciKQogICAgICAgICBhc3NlcnROb0NoZWNrKApAQCAtMjgyLDEyICsyODcsOSBAQCBj bGFzcyBDaGVja2VyRGlzcGF0Y2hlclNraXBUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAg ICAgcGF0aHNfdG9fc2tpcCA9IFsKICAgICAgICAgICAgImd0azJkcmF3aW5nLmMiLAogICAgICAg ICAgICAiZ3RrZHJhd2luZy5oIiwKLSAgICAgICAgICAgIkphdmFTY3JpcHRDb3JlL3F0L2FwaS9x c2NyaXB0ZW5naW5lX3AuaCIsCiAgICAgICAgICAgICJXZWJDb3JlL3BsYXRmb3JtL2d0ay9ndGsy ZHJhd2luZy5jIiwKICAgICAgICAgICAgIldlYkNvcmUvcGxhdGZvcm0vZ3RrL2d0a2RyYXdpbmcu aCIsCiAgICAgICAgICAgICJXZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RhdGsuYyIsCi0gICAgICAgICAg ICJXZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmgiLAotICAgICAgICAgICAiV2ViS2l0L3F0L3Rlc3Rz L3F3ZWJzZWN1cml0eW9yaWdpbi90c3RfcXdlYnNlY3VyaXR5b3JpZ2luLmNwcCIsCiAgICAgICAg ICAgICBdCiAKICAgICAgICAgZm9yIHBhdGggaW4gcGF0aHNfdG9fc2tpcDoKZGlmZiAtLWdpdCBh L1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggMWE0 MWVhOC4uMmY1YzhkNiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2Vycy9jcHAucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2Vycy9jcHAucHkKQEAgLTI1MTMsNiArMjUxMyw4IEBAIGRlZiBjaGVja19pZGVu dGlmaWVyX25hbWVfaW5fZGVjbGFyYXRpb24oZmlsZW5hbWUsIGxpbmVfbnVtYmVyLCBsaW5lLCBl cnJvcik6CiAgICAgICAgIGlmIG1vZGlmaWVkX2lkZW50aWZpZXIuZmluZCgnXycpID49IDA6CiAg ICAgICAgICAgICAjIFZhcmlvdXMgZXhjZXB0aW9ucyB0byB0aGUgcnVsZTogSmF2YVNjcmlwdCBv cCBjb2RlcyBmdW5jdGlvbnMsIGNvbnN0X2l0ZXJhdG9yLgogICAgICAgICAgICAgaWYgKG5vdCAo ZmlsZW5hbWUuZmluZCgnSmF2YVNjcmlwdENvcmUnKSA+PSAwIGFuZCBtb2RpZmllZF9pZGVudGlm aWVyLmZpbmQoJ19vcF8nKSA+PSAwKQorICAgICAgICAgICAgICAgICMgUXQgY29kZSBtYXkgdXNl IHFfcHRyIGFuZCBkX3B0cgorICAgICAgICAgICAgICAgIGFuZCBmaWxlbmFtZS5maW5kKCcvcXQv JykgPCAwCiAgICAgICAgICAgICAgICAgYW5kIG5vdCBtb2RpZmllZF9pZGVudGlmaWVyLnN0YXJ0 c3dpdGgoJ3RzdF8nKQogICAgICAgICAgICAgICAgIGFuZCBub3QgbW9kaWZpZWRfaWRlbnRpZmll ci5zdGFydHN3aXRoKCd3ZWJraXRfZG9tX29iamVjdF8nKQogICAgICAgICAgICAgICAgIGFuZCBu b3QgbW9kaWZpZWRfaWRlbnRpZmllci5zdGFydHN3aXRoKCdOUE5fJykKZGlmZiAtLWdpdCBhL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5 IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRl c3QucHkKaW5kZXggN2RiYTgyYi4uN2RmY2U4ZiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKQEAg LTE1ODAsNiArMTU4MCwxMCBAQCBjbGFzcyBDcHBTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6 CiAgICAgICAgICAgICAgICAgICAgICAgICAgJ0RlY2xhcmF0aW9uIGhhcyBzcGFjZSBiZXR3ZWVu IHR5cGUgbmFtZSBhbmQgJiBpbiBpbnQgJmIgIFt3aGl0ZXNwYWNlL2RlY2xhcmF0aW9uXSBbM10n LAogICAgICAgICAgICAgICAgICAgICAgICAgICdmb28uY3BwJykKICAgICAgICAgc2VsZi5hc3Nl cnRfbGludCgncmV0dXJuICZiOycsICcnLCAnZm9vLmNwcCcpCisgICAgICAgICMgUXQgaGFzIHJ1 bGVzIHRvIGlnbm9yZSBfIGluICJkX3B0ciIgYW5kICJxX3B0ciIsIGJ1dCBvdGhlciBjaGVja3Mg c3RpbGwgYXBwbHkKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnUVdoYXRldmVyICpkX3B0cjsn LAorICAgICAgICAgICAgICAgICAgICAgICAgICdEZWNsYXJhdGlvbiBoYXMgc3BhY2UgYmV0d2Vl biB0eXBlIG5hbWUgYW5kICogaW4gUVdoYXRldmVyICpkX3B0ciAgW3doaXRlc3BhY2UvZGVjbGFy YXRpb25dIFszXScsCisgICAgICAgICAgICAgICAgICAgICAgICAgJ1dlYktpdC9xdC93aGF0ZXZl ci5jcHAnKQogCiAgICAgZGVmIHRlc3RfaW5kZW50KHNlbGYpOgogICAgICAgICBzZWxmLmFzc2Vy dF9saW50KCdzdGF0aWMgaW50IG5vaW5kZW50OycsICcnKQpAQCAtMzcxMiw5ICszNzE2LDExIEBA IGNsYXNzIFdlYktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgIyBUaGVy ZSBpcyBhbiBleGNlcHRpb24gZm9yIHNvbWUgdW5pdCB0ZXN0cyB0aGF0IGJlZ2luIHdpdGggInRz dF8iLgogICAgICAgICBzZWxmLmFzc2VydF9saW50KCd2b2lkIHRzdF9RV2ViRnJhbWU6OmFycmF5 T2JqZWN0RW51bWVyYWJsZShpbnQgdmFyMSwgaW50IHZhcjIpJywgJycpCiAKLSAgICAgICAgIyBU aGUgUXQgQVBJIHVzZXMgbmFtZXMgdGhhdCBiZWdpbiB3aXRoICJxdF8iLgorICAgICAgICAjIFRo ZSBRdCBBUEkgdXNlcyBuYW1lcyB0aGF0IGJlZ2luIHdpdGggInF0XyIsIHBsdXMgInFfcHRyIiBh bmQgImRfcHRyIgogICAgICAgICBzZWxmLmFzc2VydF9saW50KCd2b2lkIFFURnJhbWU6OnF0X2Ry dF9pc19hd2Vzb21lKGludCB2YXIxLCBpbnQgdmFyMiknLCAnJykKICAgICAgICAgc2VsZi5hc3Nl cnRfbGludCgndm9pZCBxdF9kcnRfaXNfYXdlc29tZShpbnQgdmFyMSwgaW50IHZhcjIpOycsICcn KQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCdRV2hhdGV2ZXIgKiBkX3B0cjsnLCAnJywgJ1dl YktpdC9xdC93aGF0ZXZlci5jcHAnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCdRV2hhdGV2 ZXIgKiBxX3B0cjsnLCAnJywgJ1dlYktpdC9xdC93aGF0ZXZlci5jcHAnKQogCiAgICAgICAgICMg Q2Fpcm8gZm9yd2FyZC1kZWNsYXJhdGlvbnMgc2hvdWxkIG5vdCBiZSBhIGZhaWx1cmUuCiAgICAg ICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ3R5cGVkZWYgc3RydWN0IF9jYWlybyBjYWlyb190OycsICcn KQotLSAKMS43LjIuMwoK 72033 2010-10-27 07:39:54 -0700 2010-11-11 23:21:33 -0800 patch #2 with review fixes 0001-Enable-check-webkit-style-on-Qt-files.patch text/plain 5498 ademar RnJvbSBhOTRmODgxZmM3OWZhMDY0MDM5Njg5Yjk4M2RmZGM2YTdkODE2MDA3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVtYXIgZGUgU291emEgUmVpcyBKciA8YWRlbWFyLnJlaXNA b3BlbmJvc3NhLm9yZz4KRGF0ZTogV2VkLCAyNyBPY3QgMjAxMCAxMTozNDo0NiAtMDMwMApTdWJq ZWN0OiBbUEFUQ0hdIEVuYWJsZSBjaGVjay13ZWJraXQtc3R5bGUgb24gUXQgZmlsZXMKCmh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODMyMgoKQWRkaW5nIGV4Y2VwdGlv biBmb3IgX3FfLi4uIHByaXZhdGUgc2xvdHMgYW5kCi4uLl9kYXRhKCkgbWV0aG9kcyBpbiB0ZXN0 cwotLS0KIFdlYktpdFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHwgICAxMyArKysrKysrKysKIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlci5weSAgICAgIHwgICAxNiArKysrLS0tLS0tLQogLi4uL1NjcmlwdHMvd2Via2l0cHkvc3R5 bGUvY2hlY2tlcl91bml0dGVzdC5weSAgICAgfCAgIDI3ICsrKysrKysrKysrKysrKy0tLS0KIDMg ZmlsZXMgY2hhbmdlZCwgNDAgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4 IGI4NTBmOWIuLjUyZjk2YmIgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysg Yi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMC0yNiAgQWRl bWFyIGRlIFNvdXphIFJlaXMgSnIgIDxhZGVtYXIucmVpc0BvcGVuYm9zc2Eub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuYWJsZSBjaGVjay13 ZWJraXQtc3R5bGUgb24gUXQgZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQ4MzIyCisKKyAgICAgICAgQWRkaW5nIGV4Y2VwdGlvbiBmb3IgX3Ff Li4uIHByaXZhdGUgc2xvdHMgYW5kCisgICAgICAgIC4uLl9kYXRhKCkgbWV0aG9kcyBpbiB0ZXN0 cworCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5OiBlbmFibGUg UXQgZGlycywgYWRkIGV4Y2VwdGlvbnMKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJfdW5pdHRlc3QucHk6IGltcHJvdmUgdW5pdHRlc3RzCisKIDIwMTAtMTAtMjUgIEFk ZW1hciBkZSBTb3V6YSBSZWlzIEpyLiAgPGFkZW1hci5yZWlzQG9wZW5ib3NzYS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkgYi9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKaW5kZXggZjhlZWZhNC4uYjVkYmI2YiAxMDA2NDQK LS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CisrKyBi L1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQpAQCAtMTI1LDEx ICsxMjUsMTMgQEAgX1BBVEhfUlVMRVNfU1BFQ0lGSUVSID0gWwogICAgICAgIldlYktpdC9lZmwv ZXdrLyIsCiAgICAgICAjIFRoZXJlIGlzIG5vIGNsZWFuIHdheSB0byBhdm9pZCAieXlfKiIgbmFt ZXMgdXNlZCBieSBmbGV4LgogICAgICAgIldlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAiLAotICAg ICAgIyBUaGVyZSBpcyBubyBjbGVhbiB3YXkgdG8gYXZvaWQgInh4eF9kYXRhIiBtZXRob2RzIGlu c2lkZQotICAgICAgIyBRdCdzIGF1dG90ZXN0cyBzaW5jZSB0aGV5IGFyZSBjYWxsZWQgYXV0b21h dGljYWxseSBieSB0aGUKLSAgICAgICMgUXRUZXN0IG1vZHVsZS4KKyAgICAgICMgUXQgY29kZSB1 c2VzICdfJyBpbiBzb21lIHBsYWNlcyAoc3VjaCBhcyBwcml2YXRlIHNsb3RzCisgICAgICAjIGFu ZCBvbiB0ZXN0IHh4eF9kYXRhIG1ldGhvcyBvbiB0ZXN0cykKKyAgICAgICJKYXZhU2NyaXB0Q29y ZS9xdC9hcGkvIiwKKyAgICAgICJXZWJLaXQvcXQvQXBpLyIsCiAgICAgICAiV2ViS2l0L3F0L3Rl c3RzLyIsCi0gICAgICAiSmF2YVNjcmlwdENvcmUvcXQvdGVzdHMiXSwKKyAgICAgICJXZWJLaXQv cXQvZGVjbGFyYXRpdmUvIiwKKyAgICAgICJXZWJLaXQvcXQvZXhhbXBsZXMvIl0sCiAgICAgIFsi LXJlYWRhYmlsaXR5L25hbWluZyJdKSwKICAgICAoWyMgVGhlIEdUSysgQVBJcyB1c2UgR1RLKyBu YW1pbmcgc3R5bGUsIHdoaWNoIGluY2x1ZGVzCiAgICAgICAjIGxvd2VyLWNhc2VkLCB1bmRlcnNj b3JlLXNlcGFyYXRlZCB2YWx1ZXMuCkBAIC0yMDMsMTUgKzIwNSw5IEBAIF9URVhUX0ZJTEVfRVhU RU5TSU9OUyA9IFsKICMgV2ViS2l0IG1haW50YWlucyBzb21lIGZpbGVzIGluIE1vemlsbGEgc3R5 bGUgb24gcHVycG9zZSB0byBlYXNlCiAjIGZ1dHVyZSBtZXJnZXMuCiBfU0tJUFBFRF9GSUxFU19X SVRIX1dBUk5JTkcgPSBbCi0gICAgIyBUaGUgUXQgQVBJIGFuZCB0ZXN0cyBkbyBub3QgZm9sbG93 IFdlYktpdCBzdHlsZS4KLSAgICAjIFRoZXkgZm9sbG93IFF0IHN0eWxlLiA6KQogICAgICJndGsy ZHJhd2luZy5jIiwgIyBXZWJDb3JlL3BsYXRmb3JtL2d0ay9ndGsyZHJhd2luZy5jCiAgICAgImd0 a2RyYXdpbmcuaCIsICMgV2ViQ29yZS9wbGF0Zm9ybS9ndGsvZ3RrZHJhd2luZy5oCi0gICAgIkph dmFTY3JpcHRDb3JlL3F0L2FwaS8iLAogICAgICJXZWJLaXQvZ3RrL3Rlc3RzLyIsCi0gICAgIldl YktpdC9xdC9BcGkvIiwKLSAgICAiV2ViS2l0L3F0L3Rlc3RzLyIsCi0gICAgIldlYktpdC9xdC9l eGFtcGxlcy8iLAogICAgICMgU291cCBBUEkgdGhhdCBpcyBzdGlsbCBiZWluZyBjb29rZWQsIHdp bGwgYmUgcmVtb3ZlZCBmcm9tIFdlYktpdAogICAgICMgaW4gYSBmZXcgbW9udGhzIHdoZW4gaXQg aXMgbWVyZ2VkIGludG8gc291cCBwcm9wZXIuIFRoZSBzdHlsZQogICAgICMgZm9sbG93cyB0aGUg bGlic291cCBzdHlsZSBjb21wbGV0ZWx5LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2VyX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2VyX3VuaXR0ZXN0LnB5CmluZGV4IDUyNTQyNzUuLjRmMThh MjEgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl cl91bml0dGVzdC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2No ZWNrZXJfdW5pdHRlc3QucHkKQEAgLTIyOCwxMSArMjI4LDI5IEBAIGNsYXNzIEdsb2JhbFZhcmlh Ymxlc1Rlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICAgICAgICAgICAgICAgICJyZWFk YWJpbGl0eS9uYW1pbmciKQogICAgICAgICBhc3NlcnROb0NoZWNrKCJXZWJDb3JlL2Nzcy9DU1NQ YXJzZXIuY3BwIiwKICAgICAgICAgICAgICAgICAgICAgICAicmVhZGFiaWxpdHkvbmFtaW5nIikK KworICAgICAgICAjIFRlc3QgaWYgUXQgZXhjZXB0aW9ucyBhcmUgaW5kZWVkIHdvcmtpbmcKKyAg ICAgICAgYXNzZXJ0Q2hlY2soIkphdmFTY3JpcHRDb3JlL3F0L2FwaS9xc2NyaXB0ZW5naW5lLmNw cCIsCisgICAgICAgICAgICAgICAgICAgICJyZWFkYWJpbGl0eS9icmFjZXMiKQorICAgICAgICBh c3NlcnRDaGVjaygiV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAiLAorICAgICAgICAgICAgICAg ICAgICAicmVhZGFiaWxpdHkvYnJhY2VzIikKKyAgICAgICAgYXNzZXJ0Q2hlY2soIldlYktpdC9x dC90ZXN0cy9xd2ViZWxlbWVudC90c3RfcXdlYmVsZW1lbnQuY3BwIiwKKyAgICAgICAgICAgICAg ICAgICAgInJlYWRhYmlsaXR5L2JyYWNlcyIpCisgICAgICAgIGFzc2VydENoZWNrKCJXZWJLaXQv cXQvZGVjbGFyYXRpdmUvcGxhdGZvcm1wbHVnaW4vV2ViUGx1Z2luLmNwcCIsCisgICAgICAgICAg ICAgICAgICAgICJyZWFkYWJpbGl0eS9icmFjZXMiKQorICAgICAgICBhc3NlcnRDaGVjaygiV2Vi S2l0L3F0L2V4YW1wbGVzL3BsYXRmb3JtcGx1Z2luL1dlYlBsdWdpbi5jcHAiLAorICAgICAgICAg ICAgICAgICAgICAicmVhZGFiaWxpdHkvYnJhY2VzIikKKyAgICAgICAgYXNzZXJ0Tm9DaGVjaygi SmF2YVNjcmlwdENvcmUvcXQvYXBpL3FzY3JpcHRlbmdpbmUuY3BwIiwKKyAgICAgICAgICAgICAg ICAgICAgICAicmVhZGFiaWxpdHkvbmFtaW5nIikKKyAgICAgICAgYXNzZXJ0Tm9DaGVjaygiV2Vi S2l0L3F0L0FwaS9xd2VicGFnZS5jcHAiLAorICAgICAgICAgICAgICAgICAgICAgICJyZWFkYWJp bGl0eS9uYW1pbmciKQogICAgICAgICBhc3NlcnROb0NoZWNrKCJXZWJLaXQvcXQvdGVzdHMvcXdl YmVsZW1lbnQvdHN0X3F3ZWJlbGVtZW50LmNwcCIsCiAgICAgICAgICAgICAgICAgICAgICAgInJl YWRhYmlsaXR5L25hbWluZyIpCi0gICAgICAgIGFzc2VydE5vQ2hlY2soCi0gICAgICAgICAgICAi SmF2YVNjcmlwdENvcmUvcXQvdGVzdHMvcXNjcmlwdGVuZ2luZS90c3RfcXNjcmlwdGVuZ2luZS5j cHAiLAotICAgICAgICAgICAgInJlYWRhYmlsaXR5L25hbWluZyIpCisgICAgICAgIGFzc2VydE5v Q2hlY2soIldlYktpdC9xdC9kZWNsYXJhdGl2ZS9wbGF0Zm9ybXBsdWdpbi9XZWJQbHVnaW4uY3Bw IiwKKyAgICAgICAgICAgICAgICAgICAgICAicmVhZGFiaWxpdHkvbmFtaW5nIikKKyAgICAgICAg YXNzZXJ0Tm9DaGVjaygiV2ViS2l0L3F0L2V4YW1wbGVzL3BsYXRmb3JtcGx1Z2luL1dlYlBsdWdp bi5jcHAiLAorICAgICAgICAgICAgICAgICAgICAgICJyZWFkYWJpbGl0eS9uYW1pbmciKQorCiAg ICAgICAgIGFzc2VydE5vQ2hlY2soIldlYkNvcmUvRm9yd2FyZGluZ0hlYWRlcnMvZGVidWdnZXIv RGVidWdnZXIuaCIsCiAgICAgICAgICAgICAgICAgICAgICAgImJ1aWxkL2hlYWRlcl9ndWFyZCIp CiAKQEAgLTI4MiwxMiArMzAwLDkgQEAgY2xhc3MgQ2hlY2tlckRpc3BhdGNoZXJTa2lwVGVzdCh1 bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgIHBhdGhzX3RvX3NraXAgPSBbCiAgICAgICAgICAg ICJndGsyZHJhd2luZy5jIiwKICAgICAgICAgICAgImd0a2RyYXdpbmcuaCIsCi0gICAgICAgICAg ICJKYXZhU2NyaXB0Q29yZS9xdC9hcGkvcXNjcmlwdGVuZ2luZV9wLmgiLAogICAgICAgICAgICAi V2ViQ29yZS9wbGF0Zm9ybS9ndGsvZ3RrMmRyYXdpbmcuYyIsCiAgICAgICAgICAgICJXZWJDb3Jl L3BsYXRmb3JtL2d0ay9ndGtkcmF3aW5nLmgiLAogICAgICAgICAgICAiV2ViS2l0L2d0ay90ZXN0 cy90ZXN0YXRrLmMiLAotICAgICAgICAgICAiV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5oIiwKLSAg ICAgICAgICAgIldlYktpdC9xdC90ZXN0cy9xd2Vic2VjdXJpdHlvcmlnaW4vdHN0X3F3ZWJzZWN1 cml0eW9yaWdpbi5jcHAiLAogICAgICAgICAgICAgXQogCiAgICAgICAgIGZvciBwYXRoIGluIHBh dGhzX3RvX3NraXA6Ci0tIAoxLjcuMi4zCgo=