48319 2010-10-26 06:40:45 -0700 [Qt] Some unit tests try to use the data:<content-type>,<content> URL syntax with setHtml 2010-10-26 13:03:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 jturcotte jturcotte ademar commit-queue oldest_to_newest 299404 0 jturcotte 2010-10-26 06:40:45 -0700 [Qt] Unit tests: setHtml("data:text/html,...") -> load(QUrl("data:text/html,...")) 299409 1 71871 jturcotte 2010-10-26 06:49:47 -0700 Created attachment 71871 Patch 299415 2 jturcotte 2010-10-26 06:58:58 -0700 This bug causes the tst_QWebElement::frame(), the tst_QGraphicsWebView::crashOnViewlessWebPages() and some tst_QWebPage unit tests to fail. 299417 3 71871 kling 2010-10-26 07:02:16 -0700 Comment on attachment 71871 Patch LGTM 299716 4 71871 commit-queue 2010-10-26 12:35:43 -0700 Comment on attachment 71871 Patch Clearing flags on attachment: 71871 Committed r70556: <http://trac.webkit.org/changeset/70556> 299717 5 commit-queue 2010-10-26 12:35:47 -0700 All reviewed patches have been landed. Closing bug. 299749 6 ademar 2010-10-26 13:03:13 -0700 Revision r70556 cherry-picked into qtwebkit-2.1 with commit f5d4208 <http://gitorious.org/webkit/qtwebkit/commit/f5d4208> 71871 2010-10-26 06:49:47 -0700 2010-10-26 12:35:42 -0700 Patch bug-48319-20101026154945.patch text/plain 7451 jturcotte ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IGVjNDFmZGY0ZmVmNjQxMzI4NTJlYmU0ODA4M2UzOTlhZTAyOTZmYmQuLjdiNTQzNjI0ODNl MTFkYjZlOWNjNDIwMWZjZTdlMjc0Yzk0NjljODggMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFu Z2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEwLTEw LTI2ICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBVbml0IHRl c3RzOiBzZXRIdG1sKCJkYXRhOnRleHQvaHRtbCwuLi4iKSAtPiBsb2FkKFFVcmwoImRhdGE6dGV4 dC9odG1sLC4uLiIpKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDgzMTkKKworICAgICAgICBUaGVzZSB0ZXN0cyB3ZXJlIGZhaWxpbmcgc2luY2UgdGhl IG5ldyBIVE1MIHBhcnNlci4KKyAgICAgICAgVGhpcyBwYXRjaCByZW1vdmVzIHRoZSBjb250ZW50 IHR5cGUgZnJvbSB0aGUgZXJyb3IgcGFnZSBhcyB3ZWxsLgorCisgICAgICAgICogdGVzdHMvcWdy YXBoaWNzd2Vidmlldy90c3RfcWdyYXBoaWNzd2Vidmlldy5jcHA6CisgICAgICAgICh0c3RfUUdy YXBoaWNzV2ViVmlldzo6Y3Jhc2hPblZpZXdsZXNzV2ViUGFnZXMpOgorICAgICAgICAqIHRlc3Rz L3F3ZWJlbGVtZW50L3RzdF9xd2ViZWxlbWVudC5jcHA6CisgICAgICAgICh0c3RfUVdlYkVsZW1l bnQ6OmZyYW1lKToKKyAgICAgICAgKiB0ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwOgor ICAgICAgICAodHN0X1FXZWJQYWdlOjpsb2FkRmluaXNoZWQpOgorICAgICAgICAoRXJyb3JQYWdl OjpleHRlbnNpb24pOgorICAgICAgICAodHN0X1FXZWJQYWdlOjplcnJvclBhZ2VFeHRlbnNpb24p OgorICAgICAgICAodHN0X1FXZWJQYWdlOjplcnJvclBhZ2VFeHRlbnNpb25JbklGcmFtZXMpOgor ICAgICAgICAodHN0X1FXZWJQYWdlOjplcnJvclBhZ2VFeHRlbnNpb25JbkZyYW1lc2V0KToKKwog MjAxMC0xMC0yNSAgTm8nYW0gUm9zZW50aGFsICA8bm9hbS5yb3NlbnRoYWxAbm9raWEuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0t Z2l0IGEvV2ViS2l0L3F0L3Rlc3RzL3FncmFwaGljc3dlYnZpZXcvdHN0X3FncmFwaGljc3dlYnZp ZXcuY3BwIGIvV2ViS2l0L3F0L3Rlc3RzL3FncmFwaGljc3dlYnZpZXcvdHN0X3FncmFwaGljc3dl YnZpZXcuY3BwCmluZGV4IDU2NzM0ODgwMzRjYWQzNDgyOWYyODAzZjlhMWQ1NzIwMThkMGFkODcu LjA5YTIxZTE2NjljZmVkYjkxNjg5ZGZhY2M4ZmRlOTRjNmU3MWY2Y2UgMTAwNjQ0Ci0tLSBhL1dl YktpdC9xdC90ZXN0cy9xZ3JhcGhpY3N3ZWJ2aWV3L3RzdF9xZ3JhcGhpY3N3ZWJ2aWV3LmNwcAor KysgYi9XZWJLaXQvcXQvdGVzdHMvcWdyYXBoaWNzd2Vidmlldy90c3RfcWdyYXBoaWNzd2Vidmll dy5jcHAKQEAgLTEyNCwxMSArMTI0LDExIEBAIHZvaWQgdHN0X1FHcmFwaGljc1dlYlZpZXc6OmNy YXNoT25WaWV3bGVzc1dlYlBhZ2VzKCkKICAgICAvLyBwYWdlLCBzbyB3ZSBmaXJzdCBjb25uZWN0 IHRoZSBzaWduYWwgYWZ0ZXJ3YXJkLgogICAgIGNvbm5lY3QocGFnZS0+bWFpbkZyYW1lKCksIFNJ R05BTChpbml0aWFsTGF5b3V0Q29tcGxldGVkKCkpLCBwYWdlLCBTTE9UKGFib3J0aW5nKCkpKTsK IAotICAgIHBhZ2UtPm1haW5GcmFtZSgpLT5zZXRIdG1sKFFTdHJpbmcoImRhdGE6dGV4dC9odG1s LCIKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIjxmcmFtZXNl dCBjb2xzPVwiMjUlLDc1JVwiPiIKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICI8ZnJhbWUgc3JjPVwiZGF0YTp0ZXh0L2h0bWwsZm9vIFwiPiIKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICI8ZnJhbWUgc3JjPVwi ZGF0YTp0ZXh0L2h0bWwsYmFyXCI+IgotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAiPC9mcmFtZXNldD4iKSk7CisgICAgcGFnZS0+bWFpbkZyYW1lKCktPmxvYWQo UVVybCgiZGF0YTp0ZXh0L2h0bWwsIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IjxmcmFtZXNldCBjb2xzPVwiMjUlLDc1JVwiPiIKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAiPGZyYW1lIHNyYz1cImRhdGE6dGV4dC9odG1sLGZvbyBcIj4iCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIjxmcmFtZSBzcmM9XCJkYXRhOnRleHQvaHRt bCxiYXJcIj4iCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiPC9mcmFtZXNldD4i KSk7CiAKICAgICBRVkVSSUZZKHdhaXRGb3JTaWduYWwocGFnZSwgU0lHTkFMKGxvYWRGaW5pc2hl ZChib29sKSkpKTsKICAgICBkZWxldGUgcGFnZTsKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC90ZXN0 cy9xd2ViZWxlbWVudC90c3RfcXdlYmVsZW1lbnQuY3BwIGIvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJl bGVtZW50L3RzdF9xd2ViZWxlbWVudC5jcHAKaW5kZXggMmYxMDk3YTU5YjM4Yzk4YjY0ZTg2NjA0 OWU4ZWYxZTJlYjNkNGM1ZC4uOWJkMjU1ZmEwMzIzNTcyMWY2MWU4NjQzZDU5OTVjOGM0YTU3OWEy ZSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJlbGVtZW50L3RzdF9xd2ViZWxlbWVu dC5jcHAKKysrIGIvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJlbGVtZW50L3RzdF9xd2ViZWxlbWVudC5j cHAKQEAgLTQzMCw5ICs0MzAsOSBAQCB2b2lkIHRzdF9RV2ViRWxlbWVudDo6ZnJhbWUoKQogICAg IFFXZWJFbGVtZW50IGRvYyA9IG1fbWFpbkZyYW1lLT5kb2N1bWVudEVsZW1lbnQoKTsKICAgICBR VkVSSUZZKGRvYy53ZWJGcmFtZSgpID09IG1fbWFpbkZyYW1lKTsKIAotICAgIG1fdmlldy0+c2V0 SHRtbChRU3RyaW5nKCJkYXRhOnRleHQvaHRtbCw8ZnJhbWVzZXQgY29scz1cIjI1JSw3NSVcIj48 ZnJhbWUgc3JjPVwiZGF0YTp0ZXh0L2h0bWwsIgotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICI8cD5mcmFtZTFcIj4iCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIjxmcmFtZSBzcmM9 XCJkYXRhOnRleHQvaHRtbCw8cD5mcmFtZTJcIj48L2ZyYW1lc2V0PiIpLCBRVXJsKCkpOworICAg IG1fbWFpbkZyYW1lLT5sb2FkKFFVcmwoImRhdGE6dGV4dC9odG1sLDxmcmFtZXNldCBjb2xzPVwi MjUlLDc1JVwiPjxmcmFtZSBzcmM9XCJkYXRhOnRleHQvaHRtbCwiCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAiPHA+ZnJhbWUxXCI+IgorICAgICAgICAgICAgICAgICAgICAgICAgICAgIjxm cmFtZSBzcmM9XCJkYXRhOnRleHQvaHRtbCw8cD5mcmFtZTJcIj48L2ZyYW1lc2V0PiIpKTsKIAog ICAgIHdhaXRGb3JTaWduYWwobV9wYWdlLCBTSUdOQUwobG9hZEZpbmlzaGVkKGJvb2wpKSk7CiAK ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwIGIv V2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKaW5kZXggM2Q5ZmNiMjJk YWE5OTBjMmE5NmRiNTA2YmVmZDQxODJiN2JiYzY0Zi4uZTZiNTkwOTY1NWNhNzIwZjIyZmMxOTNh YjgxMDg0MGUxNDMzZGFjOSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3Rz dF9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFn ZS5jcHAKQEAgLTI4NSw5ICsyODUsOSBAQCB2b2lkIHRzdF9RV2ViUGFnZTo6bG9hZEZpbmlzaGVk KCkKICAgICBRU2lnbmFsU3B5IHNweUxvYWRTdGFydGVkKG1fdmlldywgU0lHTkFMKGxvYWRTdGFy dGVkKCkpKTsKICAgICBRU2lnbmFsU3B5IHNweUxvYWRGaW5pc2hlZChtX3ZpZXcsIFNJR05BTChs b2FkRmluaXNoZWQoYm9vbCkpKTsKIAotICAgIG1fdmlldy0+c2V0SHRtbChRU3RyaW5nKCJkYXRh OnRleHQvaHRtbCw8ZnJhbWVzZXQgY29scz1cIjI1JSw3NSVcIj48ZnJhbWUgc3JjPVwiZGF0YTp0 ZXh0L2h0bWwsIgotICAgICAgICAgICAgICAgICAgICAgICAgICAgICI8aGVhZD48bWV0YSBodHRw LWVxdWl2PSdyZWZyZXNoJyBjb250ZW50PScxJz48L2hlYWQ+Zm9vIFwiPiIKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAiPGZyYW1lIHNyYz1cImRhdGE6dGV4dC9odG1sLGJhclwiPjwvZnJh bWVzZXQ+IiksIFFVcmwoKSk7CisgICAgbV92aWV3LT5wYWdlKCktPm1haW5GcmFtZSgpLT5sb2Fk KFFVcmwoImRhdGE6dGV4dC9odG1sLDxmcmFtZXNldCBjb2xzPVwiMjUlLDc1JVwiPjxmcmFtZSBz cmM9XCJkYXRhOnRleHQvaHRtbCwiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIjxoZWFkPjxtZXRhIGh0dHAtZXF1aXY9J3JlZnJlc2gnIGNvbnRlbnQ9JzEnPjwv aGVhZD5mb28gXCI+IgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICI8ZnJhbWUgc3JjPVwiZGF0YTp0ZXh0L2h0bWwsYmFyXCI+PC9mcmFtZXNldD4iKSk7CiAgICAg UVRSWV9DT01QQVJFKHNweUxvYWRGaW5pc2hlZC5jb3VudCgpLCAxKTsKIAogICAgIFFUUllfVkVS SUZZKHNweUxvYWRTdGFydGVkLmNvdW50KCkgPiAxKTsKQEAgLTI5NSw4ICsyOTUsOCBAQCB2b2lk IHRzdF9RV2ViUGFnZTo6bG9hZEZpbmlzaGVkKCkKIAogICAgIHNweUxvYWRGaW5pc2hlZC5jbGVh cigpOwogCi0gICAgbV92aWV3LT5zZXRIdG1sKFFTdHJpbmcoImRhdGE6dGV4dC9odG1sLDxmcmFt ZXNldCBjb2xzPVwiMjUlLDc1JVwiPjxmcmFtZSBzcmM9XCJkYXRhOnRleHQvaHRtbCwiCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgImZvbyBcIj48ZnJhbWUgc3JjPVwiZGF0YTp0ZXh0L2h0 bWwsYmFyXCI+PC9mcmFtZXNldD4iKSwgUVVybCgpKTsKKyAgICBtX3ZpZXctPnBhZ2UoKS0+bWFp bkZyYW1lKCktPmxvYWQoUVVybCgiZGF0YTp0ZXh0L2h0bWwsPGZyYW1lc2V0IGNvbHM9XCIyNSUs NzUlXCI+PGZyYW1lIHNyYz1cImRhdGE6dGV4dC9odG1sLCIKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAiZm9vIFwiPjxmcmFtZSBzcmM9XCJkYXRhOnRleHQvaHRt bCxiYXJcIj48L2ZyYW1lc2V0PiIpKTsKICAgICBRVFJZX0NPTVBBUkUoc3B5TG9hZEZpbmlzaGVk LmNvdW50KCksIDEpOwogICAgIFFDT01QQVJFKHNweUxvYWRGaW5pc2hlZC5jb3VudCgpLCAxKTsK IH0KQEAgLTE4ODIsNyArMTg4Miw4IEBAIHB1YmxpYzoKICAgICB7CiAgICAgICAgIEVycm9yUGFn ZUV4dGVuc2lvblJldHVybiogZXJyb3JQYWdlID0gc3RhdGljX2Nhc3Q8RXJyb3JQYWdlRXh0ZW5z aW9uUmV0dXJuKj4ob3V0cHV0KTsKIAotICAgICAgICBlcnJvclBhZ2UtPmNvbnRlbnQgPSAiZGF0 YTp0ZXh0L2h0bWwsZXJyb3IiOworICAgICAgICBlcnJvclBhZ2UtPmNvbnRlbnRUeXBlID0gInRl eHQvaHRtbCI7CisgICAgICAgIGVycm9yUGFnZS0+Y29udGVudCA9ICJlcnJvciI7CiAgICAgICAg IHJldHVybiB0cnVlOwogICAgIH0KIH07CkBAIC0xODk5LDcgKzE5MDAsNyBAQCB2b2lkIHRzdF9R V2ViUGFnZTo6ZXJyb3JQYWdlRXh0ZW5zaW9uKCkKIAogICAgIHBhZ2UtPm1haW5GcmFtZSgpLT5z ZXRVcmwoUVVybCgiaHR0cDovL25vbi5leGlzdGVudC91cmwiKSk7CiAgICAgUVRSWV9DT01QQVJF KHNweUxvYWRGaW5pc2hlZC5jb3VudCgpLCAyKTsKLSAgICBRQ09NUEFSRShwYWdlLT5tYWluRnJh bWUoKS0+dG9QbGFpblRleHQoKSwgUVN0cmluZygiZGF0YTp0ZXh0L2h0bWwsZXJyb3IiKSk7Cisg ICAgUUNPTVBBUkUocGFnZS0+bWFpbkZyYW1lKCktPnRvUGxhaW5UZXh0KCksIFFTdHJpbmcoImVy cm9yIikpOwogICAgIFFDT01QQVJFKHBhZ2UtPmhpc3RvcnkoKS0+Y291bnQoKSwgMik7CiAgICAg UUNPTVBBUkUocGFnZS0+aGlzdG9yeSgpLT5jdXJyZW50SXRlbSgpLnVybCgpLCBRVXJsKCJodHRw Oi8vbm9uLmV4aXN0ZW50L3VybCIpKTsKICAgICBRQ09NUEFSRShwYWdlLT5oaXN0b3J5KCktPmNh bkdvQmFjaygpLCB0cnVlKTsKQEAgLTE5MjYsMTQgKzE5MjcsMTUgQEAgdm9pZCB0c3RfUVdlYlBh Z2U6OmVycm9yUGFnZUV4dGVuc2lvbkluSUZyYW1lcygpCiAgICAgRXJyb3JQYWdlKiBwYWdlID0g bmV3IEVycm9yUGFnZTsKICAgICBtX3ZpZXctPnNldFBhZ2UocGFnZSk7CiAKLSAgICBtX3ZpZXct PnNldEh0bWwoUVN0cmluZygiZGF0YTp0ZXh0L2h0bWwsIgotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICI8aDE+aDE8L2gxPiIKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAiPGlmcmFt ZSBzcmM9J2RhdGE6dGV4dC9odG1sLDxwLz5wJz48L2lmcmFtZT4iCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgIjxpZnJhbWUgc3JjPSdub24tZXhpc3RlbnQuaHRtbCc+PC9pZnJhbWU+Iikp OworICAgIG1fdmlldy0+cGFnZSgpLT5tYWluRnJhbWUoKS0+bG9hZChRVXJsKAorICAgICAgICAi ZGF0YTp0ZXh0L2h0bWwsIgorICAgICAgICAiPGgxPmgxPC9oMT4iCisgICAgICAgICI8aWZyYW1l IHNyYz0nZGF0YTp0ZXh0L2h0bWwsPHAvPnAnPjwvaWZyYW1lPiIKKyAgICAgICAgIjxpZnJhbWUg c3JjPSdodHRwOi8vbm9uLmV4aXN0ZW50L3VybCc+PC9pZnJhbWU+IikpOwogICAgIFFTaWduYWxT cHkgc3B5TG9hZEZpbmlzaGVkKG1fdmlldywgU0lHTkFMKGxvYWRGaW5pc2hlZChib29sKSkpOwog ICAgIFFUUllfQ09NUEFSRShzcHlMb2FkRmluaXNoZWQuY291bnQoKSwgMSk7CiAKLSAgICBRQ09N UEFSRShwYWdlLT5tYWluRnJhbWUoKS0+Y2hpbGRGcmFtZXMoKVsxXS0+dG9QbGFpblRleHQoKSwg UVN0cmluZygiZGF0YTp0ZXh0L2h0bWwsZXJyb3IiKSk7CisgICAgUUNPTVBBUkUocGFnZS0+bWFp bkZyYW1lKCktPmNoaWxkRnJhbWVzKClbMV0tPnRvUGxhaW5UZXh0KCksIFFTdHJpbmcoImVycm9y IikpOwogCiAgICAgbV92aWV3LT5zZXRQYWdlKDApOwogfQpAQCAtMTk0Nyw3ICsxOTQ5LDcgQEAg dm9pZCB0c3RfUVdlYlBhZ2U6OmVycm9yUGFnZUV4dGVuc2lvbkluRnJhbWVzZXQoKQogCiAgICAg UVNpZ25hbFNweSBzcHlMb2FkRmluaXNoZWQobV92aWV3LCBTSUdOQUwobG9hZEZpbmlzaGVkKGJv b2wpKSk7CiAgICAgUVRSWV9DT01QQVJFKHNweUxvYWRGaW5pc2hlZC5jb3VudCgpLCAxKTsKLSAg ICBRQ09NUEFSRShwYWdlLT5tYWluRnJhbWUoKS0+Y2hpbGRGcmFtZXMoKVsxXS0+dG9QbGFpblRl eHQoKSwgUVN0cmluZygiZGF0YTp0ZXh0L2h0bWwsZXJyb3IiKSk7CisgICAgUUNPTVBBUkUocGFn ZS0+bWFpbkZyYW1lKCktPmNoaWxkRnJhbWVzKClbMV0tPnRvUGxhaW5UZXh0KCksIFFTdHJpbmco ImVycm9yIikpOwogCiAgICAgbV92aWV3LT5zZXRQYWdlKDApOwogfQo=