48286 2010-10-25 19:49:14 -0700 Fix Cache::dumpStats formatting 2010-10-26 12:14:11 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned abarth commit-queue ddkilzer eric ggaren joepeck webkit.review.bot oldest_to_newest 299252 0 joepeck 2010-10-25 19:49:14 -0700 Cache::dumpStats has columns that are 11 characters wide but PurgeableSize is 13 characters long. Messes up later columns. 299254 1 71837 joepeck 2010-10-25 19:54:15 -0700 Created attachment 71837 [PATCH] Make Columns 13 Characters Wide Now, none of the titles are too wide. Sample output: (gdb) p WebCore::cache()->dumpStats() Count Size LiveSize DecodedSize PurgeableSize PurgedSize ------------- ------------- ------------- ------------- ------------- ------------- ------------- Images 38 3965777 3948921 3053452 0 0 CSS 3 66663 66663 0 0 0 XSL 0 0 0 0 0 0 JavaScript 4 406906 406906 0 0 0 Fonts 0 0 0 0 0 0 ------------- ------------- ------------- ------------- ------------- ------------- ------------- Note, there could also be a bunch of improvements to add XBL to this list. However, I don't know anyone that actually uses XBL, so I didn't take the time to add it to the list. Let me know if that is a desired improvement. I don't think this output is actually used anywhere in tests, but I'm running tests overnight anyways to see. 299257 2 joepeck 2010-10-25 19:58:04 -0700 Nevermind what I said about XBL. I was looking at an outdated file, XBL was recently removed! =) 299262 3 71837 ddkilzer 2010-10-25 21:05:58 -0700 Comment on attachment 71837 [PATCH] Make Columns 13 Characters Wide r=me 299634 4 71837 commit-queue 2010-10-26 11:30:36 -0700 Comment on attachment 71837 [PATCH] Make Columns 13 Characters Wide Clearing flags on attachment: 71837 Committed r70545: <http://trac.webkit.org/changeset/70545> 299635 5 commit-queue 2010-10-26 11:30:42 -0700 All reviewed patches have been landed. Closing bug. 299682 6 webkit.review.bot 2010-10-26 12:05:27 -0700 http://trac.webkit.org/changeset/70545 might have broken Qt Linux Release The following tests are not passing: fast/blockflow/floats-in-block-layout.html fast/blockflow/self-collapsing-block.html fast/multicol/nested-columns.html 299694 7 joepeck 2010-10-26 12:14:11 -0700 (In reply to comment #6) > http://trac.webkit.org/changeset/70545 might have broken Qt Linux Release > The following tests are not passing: > fast/blockflow/floats-in-block-layout.html > fast/blockflow/self-collapsing-block.html > fast/multicol/nested-columns.html Doesn't appear to be related to this change. There were a few other patches that landed at the same time. 71837 2010-10-25 19:54:15 -0700 2010-10-26 11:30:36 -0700 [PATCH] Make Columns 13 Characters Wide formatting.patch text/plain 4054 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjY3YWRiNi4uYWY5MzA2YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMC0yNSAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeCBDYWNoZTo6ZHVtcFN0YXRzIGZvcm1hdHRpbmcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4Mjg2CisKKyAgICAg ICAgVGhpcyB1cGRhdGVzIHRoZSBjb2x1bW4gd2lkdGggaW4gdGhlIGR1bXBTdGF0cyBvdXRwdXQg dG8gYmUgd2lkZSBlbm91Z2gKKyAgICAgICAgZm9yIGFsbCB0aGUgdGl0bGVzLiBQcmV2aW91c2x5 IG9uZSBvZiB0aGUgdGl0bGVzIHdhcyB0b28gd2lkZSBhbmQgY3JlcHQKKyAgICAgICAgaW50byBs YXRlciBjb2x1bW4gc3BhY2UuCisKKyAgICAgICAgKiBsb2FkZXIvQ2FjaGUuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Q2FjaGU6OmR1bXBTdGF0cyk6IG1ha2UgY29sdW1ucyAxMyBjaGFyYWN0ZXJz IHdpZGUuCisKIDIwMTAtMTAtMjEgIFNhdGlzaCBTYW1wYXRoICA8c2F0aXNoQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBKZXJlbXkgT3Jsb3cuCmRpZmYgLS1naXQgYS9XZWJD b3JlL2xvYWRlci9DYWNoZS5jcHAgYi9XZWJDb3JlL2xvYWRlci9DYWNoZS5jcHAKaW5kZXggNmVm NjVjMC4uN2RjOGEzMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvQ2FjaGUuY3BwCisrKyBi L1dlYkNvcmUvbG9hZGVyL0NhY2hlLmNwcApAQCAtNzU0LDE2ICs3NTQsMTYgQEAgdm9pZCBDYWNo ZTo6c2V0RGlzYWJsZWQoYm9vbCBkaXNhYmxlZCkKIHZvaWQgQ2FjaGU6OmR1bXBTdGF0cygpCiB7 CiAgICAgU3RhdGlzdGljcyBzID0gZ2V0U3RhdGlzdGljcygpOwotICAgIHByaW50ZigiJS0xMXMg JS0xMXMgJS0xMXMgJS0xMXMgJS0xMXMgJS0xMXMgJS0xMXNcbiIsICIiLCAiQ291bnQiLCAiU2l6 ZSIsICJMaXZlU2l6ZSIsICJEZWNvZGVkU2l6ZSIsICJQdXJnZWFibGVTaXplIiwgIlB1cmdlZFNp emUiKTsKLSAgICBwcmludGYoIiUtMTFzICUtMTFzICUtMTFzICUtMTFzICUtMTFzICUtMTFzICUt MTFzXG4iLCAiLS0tLS0tLS0tLS0iLCAiLS0tLS0tLS0tLS0iLCAiLS0tLS0tLS0tLS0iLCAiLS0t LS0tLS0tLS0iLCAiLS0tLS0tLS0tLS0iLCAiLS0tLS0tLS0tLS0iLCAiLS0tLS0tLS0tLS0iKTsK LSAgICBwcmludGYoIiUtMTFzICUxMWQgJTExZCAlMTFkICUxMWQgJTExZCAlMTFkXG4iLCAiSW1h Z2VzIiwgcy5pbWFnZXMuY291bnQsIHMuaW1hZ2VzLnNpemUsIHMuaW1hZ2VzLmxpdmVTaXplLCBz LmltYWdlcy5kZWNvZGVkU2l6ZSwgcy5pbWFnZXMucHVyZ2VhYmxlU2l6ZSwgcy5pbWFnZXMucHVy Z2VkU2l6ZSk7Ci0gICAgcHJpbnRmKCIlLTExcyAlMTFkICUxMWQgJTExZCAlMTFkICUxMWQgJTEx ZFxuIiwgIkNTUyIsIHMuY3NzU3R5bGVTaGVldHMuY291bnQsIHMuY3NzU3R5bGVTaGVldHMuc2l6 ZSwgcy5jc3NTdHlsZVNoZWV0cy5saXZlU2l6ZSwgcy5jc3NTdHlsZVNoZWV0cy5kZWNvZGVkU2l6 ZSwgcy5jc3NTdHlsZVNoZWV0cy5wdXJnZWFibGVTaXplLCBzLmNzc1N0eWxlU2hlZXRzLnB1cmdl ZFNpemUpOworICAgIHByaW50ZigiJS0xM3MgJS0xM3MgJS0xM3MgJS0xM3MgJS0xM3MgJS0xM3Mg JS0xM3NcbiIsICIiLCAiQ291bnQiLCAiU2l6ZSIsICJMaXZlU2l6ZSIsICJEZWNvZGVkU2l6ZSIs ICJQdXJnZWFibGVTaXplIiwgIlB1cmdlZFNpemUiKTsKKyAgICBwcmludGYoIiUtMTNzICUtMTNz ICUtMTNzICUtMTNzICUtMTNzICUtMTNzICUtMTNzXG4iLCAiLS0tLS0tLS0tLS0tLSIsICItLS0t LS0tLS0tLS0tIiwgIi0tLS0tLS0tLS0tLS0iLCAiLS0tLS0tLS0tLS0tLSIsICItLS0tLS0tLS0t LS0tIiwgIi0tLS0tLS0tLS0tLS0iLCAiLS0tLS0tLS0tLS0tLSIpOworICAgIHByaW50ZigiJS0x M3MgJTEzZCAlMTNkICUxM2QgJTEzZCAlMTNkICUxM2RcbiIsICJJbWFnZXMiLCBzLmltYWdlcy5j b3VudCwgcy5pbWFnZXMuc2l6ZSwgcy5pbWFnZXMubGl2ZVNpemUsIHMuaW1hZ2VzLmRlY29kZWRT aXplLCBzLmltYWdlcy5wdXJnZWFibGVTaXplLCBzLmltYWdlcy5wdXJnZWRTaXplKTsKKyAgICBw cmludGYoIiUtMTNzICUxM2QgJTEzZCAlMTNkICUxM2QgJTEzZCAlMTNkXG4iLCAiQ1NTIiwgcy5j c3NTdHlsZVNoZWV0cy5jb3VudCwgcy5jc3NTdHlsZVNoZWV0cy5zaXplLCBzLmNzc1N0eWxlU2hl ZXRzLmxpdmVTaXplLCBzLmNzc1N0eWxlU2hlZXRzLmRlY29kZWRTaXplLCBzLmNzc1N0eWxlU2hl ZXRzLnB1cmdlYWJsZVNpemUsIHMuY3NzU3R5bGVTaGVldHMucHVyZ2VkU2l6ZSk7CiAjaWYgRU5B QkxFKFhTTFQpCi0gICAgcHJpbnRmKCIlLTExcyAlMTFkICUxMWQgJTExZCAlMTFkICUxMWQgJTEx ZFxuIiwgIlhTTCIsIHMueHNsU3R5bGVTaGVldHMuY291bnQsIHMueHNsU3R5bGVTaGVldHMuc2l6 ZSwgcy54c2xTdHlsZVNoZWV0cy5saXZlU2l6ZSwgcy54c2xTdHlsZVNoZWV0cy5kZWNvZGVkU2l6 ZSwgcy54c2xTdHlsZVNoZWV0cy5wdXJnZWFibGVTaXplLCBzLnhzbFN0eWxlU2hlZXRzLnB1cmdl ZFNpemUpOworICAgIHByaW50ZigiJS0xM3MgJTEzZCAlMTNkICUxM2QgJTEzZCAlMTNkICUxM2Rc biIsICJYU0wiLCBzLnhzbFN0eWxlU2hlZXRzLmNvdW50LCBzLnhzbFN0eWxlU2hlZXRzLnNpemUs IHMueHNsU3R5bGVTaGVldHMubGl2ZVNpemUsIHMueHNsU3R5bGVTaGVldHMuZGVjb2RlZFNpemUs IHMueHNsU3R5bGVTaGVldHMucHVyZ2VhYmxlU2l6ZSwgcy54c2xTdHlsZVNoZWV0cy5wdXJnZWRT aXplKTsKICNlbmRpZgotICAgIHByaW50ZigiJS0xMXMgJTExZCAlMTFkICUxMWQgJTExZCAlMTFk ICUxMWRcbiIsICJKYXZhU2NyaXB0Iiwgcy5zY3JpcHRzLmNvdW50LCBzLnNjcmlwdHMuc2l6ZSwg cy5zY3JpcHRzLmxpdmVTaXplLCBzLnNjcmlwdHMuZGVjb2RlZFNpemUsIHMuc2NyaXB0cy5wdXJn ZWFibGVTaXplLCBzLnNjcmlwdHMucHVyZ2VkU2l6ZSk7Ci0gICAgcHJpbnRmKCIlLTExcyAlMTFk ICUxMWQgJTExZCAlMTFkICUxMWQgJTExZFxuIiwgIkZvbnRzIiwgcy5mb250cy5jb3VudCwgcy5m b250cy5zaXplLCBzLmZvbnRzLmxpdmVTaXplLCBzLmZvbnRzLmRlY29kZWRTaXplLCBzLmZvbnRz LnB1cmdlYWJsZVNpemUsIHMuZm9udHMucHVyZ2VkU2l6ZSk7Ci0gICAgcHJpbnRmKCIlLTExcyAl LTExcyAlLTExcyAlLTExcyAlLTExcyAlLTExcyAlLTExc1xuXG4iLCAiLS0tLS0tLS0tLS0iLCAi LS0tLS0tLS0tLS0iLCAiLS0tLS0tLS0tLS0iLCAiLS0tLS0tLS0tLS0iLCAiLS0tLS0tLS0tLS0i LCAiLS0tLS0tLS0tLS0iLCAiLS0tLS0tLS0tLS0iKTsKKyAgICBwcmludGYoIiUtMTNzICUxM2Qg JTEzZCAlMTNkICUxM2QgJTEzZCAlMTNkXG4iLCAiSmF2YVNjcmlwdCIsIHMuc2NyaXB0cy5jb3Vu dCwgcy5zY3JpcHRzLnNpemUsIHMuc2NyaXB0cy5saXZlU2l6ZSwgcy5zY3JpcHRzLmRlY29kZWRT aXplLCBzLnNjcmlwdHMucHVyZ2VhYmxlU2l6ZSwgcy5zY3JpcHRzLnB1cmdlZFNpemUpOworICAg IHByaW50ZigiJS0xM3MgJTEzZCAlMTNkICUxM2QgJTEzZCAlMTNkICUxM2RcbiIsICJGb250cyIs IHMuZm9udHMuY291bnQsIHMuZm9udHMuc2l6ZSwgcy5mb250cy5saXZlU2l6ZSwgcy5mb250cy5k ZWNvZGVkU2l6ZSwgcy5mb250cy5wdXJnZWFibGVTaXplLCBzLmZvbnRzLnB1cmdlZFNpemUpOwor ICAgIHByaW50ZigiJS0xM3MgJS0xM3MgJS0xM3MgJS0xM3MgJS0xM3MgJS0xM3MgJS0xM3Ncblxu IiwgIi0tLS0tLS0tLS0tLS0iLCAiLS0tLS0tLS0tLS0tLSIsICItLS0tLS0tLS0tLS0tIiwgIi0t LS0tLS0tLS0tLS0iLCAiLS0tLS0tLS0tLS0tLSIsICItLS0tLS0tLS0tLS0tIiwgIi0tLS0tLS0t LS0tLS0iKTsKIH0KIAogdm9pZCBDYWNoZTo6ZHVtcExSVUxpc3RzKGJvb2wgaW5jbHVkZUxpdmUp IGNvbnN0Cg==