48284 2010-10-25 18:34:18 -0700 Valgrind failure in GraphicsContext3DInternal::reshape 2010-10-26 10:28:38 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr kbr dglazkov enne jamesr zmo oldest_to_newest 299226 0 kbr 2010-10-25 18:34:18 -0700 There is a Valgrind failure reported in GraphicsContext3DInternal::reshape caused by uninitialized members m_cachedWidth and m_cachedHeight in WebGraphicsContext3DDefaultImpl. The stack trace: 14:19:56 memcheck_analyze.py [ERROR] FAIL! There were 1 errors: 14:19:56 memcheck_analyze.py [ERROR] Command: /b/slave/webkit-rel-linux-valgrind-layout/build/src/sconsbuild/Release/test_shell --pixel-tests=/b/slave/webkit-rel-linux-valgrind-layout/build/src/webkit/Release/layout-test-results/png_result1.png --layout-tests UninitCondition Conditional jump or move depends on uninitialised value(s) WebCore::GraphicsContext3DInternal::reshape(int, int) (third_party/WebKit/WebKit/chromium/src/GraphicsContext3DChromium.cpp:229) WebCore::GraphicsContext3D::reshape(int, int) (third_party/WebKit/WebKit/chromium/src/GraphicsContext3DChromium.cpp:841) WebCore::WebGLRenderingContext::WebGLRenderingContext(WebCore::HTMLCanvasElement*, WTF::PassRefPtr<WebCore::GraphicsContext3D>) (third_party/WebKit/WebCore/html/canvas/WebGLRenderingContext.cpp:139) WebCore::WebGLRenderingContext::create(WebCore::HTMLCanvasElement*, WebCore::WebGLContextAttributes*) (third_party/WebKit/WebCore/html/canvas/WebGLRenderingContext.cpp:96) WebCore::HTMLCanvasElement::getContext(WTF::String const&, WebCore::CanvasContextAttributes*) (third_party/WebKit/WebCore/html/HTMLCanvasElement.cpp:173) WebCore::V8HTMLCanvasElement::getContextCallback(v8::Arguments const&) (third_party/WebKit/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:82) v8::internal::Object* v8::internal::HandleApiCallHelper<false>(v8::internal::(anonymous namespace)::BuiltinArguments<(v8::internal::BuiltinExtraArguments)1>) (v8/src/builtins.cc:983) 0x5C6422D () 0x5C7C271 () 0x5C6609E () 0x5C7B4C9 () 0x5C75058 () 0x5C65421 () v8::internal::Invoke(bool, v8::internal::Handle<v8::internal::JSFunction>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Object***, bool*) (v8/src/execution.cc:94) 0x4E8E83B () 299227 1 71828 kbr 2010-10-25 18:35:39 -0700 Created attachment 71828 Patch 299382 2 71828 kling 2010-10-26 04:13:22 -0700 Comment on attachment 71828 Patch LGTM. 299561 3 kbr 2010-10-26 10:28:38 -0700 Committed r70534: <http://trac.webkit.org/changeset/70534> 71828 2010-10-25 18:35:39 -0700 2010-10-26 04:13:22 -0700 Patch initialization.patch text/plain 1244 kbr SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNzA1MDkpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMTAtMjUgIEtlbm5l dGggUnVzc2VsbCAgPGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFZhbGdyaW5kIGZhaWx1cmUgaW4gR3JhcGhpY3NDb250ZXh0 M0RJbnRlcm5hbDo6cmVzaGFwZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDgyODQKKworICAgICAgICAqIHNyYy9XZWJHcmFwaGljc0NvbnRleHQzRERl ZmF1bHRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViR3JhcGhpY3NDb250ZXh0M0REZWZh dWx0SW1wbDo6V2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0SW1wbCk6CisKIDIwMTAtMTAtMjUg IFNhdGlzaCBTYW1wYXRoICA8c2F0aXNoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmll d2VkLCBmaXggZm9yIGEgYnVpbGQgYnJlYWsgY2F1c2VkIGJ5IG15IGVhcmxpZXIgcGF0Y2guCklu ZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkdyYXBoaWNzQ29udGV4dDNERGVmYXVsdEltcGwu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViR3JhcGhpY3NDb250ZXh0 M0REZWZhdWx0SW1wbC5jcHAJKHJldmlzaW9uIDcwNTA3KQorKysgV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NzMsNiArNzMsOCBAQCBXZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBsOjpXZWJHcmFwCiAg ICAgLCBtX3RleHR1cmUoMCkKICAgICAsIG1fZmJvKDApCiAgICAgLCBtX2RlcHRoU3RlbmNpbEJ1 ZmZlcigwKQorICAgICwgbV9jYWNoZWRXaWR0aCgwKQorICAgICwgbV9jYWNoZWRIZWlnaHQoMCkK ICAgICAsIG1fbXVsdGlzYW1wbGVGQk8oMCkKICAgICAsIG1fbXVsdGlzYW1wbGVEZXB0aFN0ZW5j aWxCdWZmZXIoMCkKICAgICAsIG1fbXVsdGlzYW1wbGVDb2xvckJ1ZmZlcigwKQo=