48273 2010-10-25 15:42:35 -0700 Update the fake Carbon window when the window frame changes 2010-10-25 16:01:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 299139 0 andersca 2010-10-25 15:42:35 -0700 Update the fake Carbon window when the window frame changes 299145 1 71807 andersca 2010-10-25 15:46:08 -0700 Created attachment 71807 Patch 299149 2 71807 mitz 2010-10-25 15:52:52 -0700 Comment on attachment 71807 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71807&action=review > WebKit2/UIProcess/API/mac/WKView.mm:415 > + NSScreen *screen = [window screen]; // nil if the window is off-screen > + if (screen) > + return screen; You can move the definition of 'screen' into the if statement. 299153 3 andersca 2010-10-25 16:01:03 -0700 Committed r70499: <http://trac.webkit.org/changeset/70499> 71807 2010-10-25 15:46:08 -0700 2010-10-25 15:52:52 -0700 Patch bug-48273-20101025154607.patch text/plain 4540 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ZTNjMTIxYzI3YWM5MDI3ODQxMDU0ZTMxNDBiNjRkYzI4N2E0NTk5ZC4uNDgxMzg5OGZmZDkxOTIx ODE0MDE5NWU1MGEwZDdmYzYyNjRlM2M0MSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyOCBAQAogMjAxMC0xMC0yNSAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSB0aGUgZmFrZSBDYXJib24gd2luZG93 IHdoZW4gdGhlIHdpbmRvdyBmcmFtZSBjaGFuZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODI3MworCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9t YWMvV0tWaWV3Lm1tOgorICAgICAgICAoc2NyZWVuRm9yV2luZG93KToKKyAgICAgICAgKC1bV0tW aWV3IF91cGRhdGVXaW5kb3dGcmFtZV0pOgorICAgICAgICBQYXNzIHRoZSB3aW5kb3cgZnJhbWUg aW4gQ2FyYm9uIGNvb3JkaW5hdGVzLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL05l dHNjYXBlL21hYy9OZXRzY2FwZVBsdWdpbk1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6TmV0c2Nh cGVQbHVnaW46OndpbmRvd0ZyYW1lQ2hhbmdlZCk6CisgICAgICAgIFVwZGF0ZSB0aGUgd2luZG93 IGJvdW5kcy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcDoK KyAgICAgICAgKFdlYktpdDo6UGx1Z2luVmlldzo6c2V0V2luZG93RnJhbWUpOgorICAgICAgICBD YWxsIHRoZSBwbHVnLWluLgorCisgICAgICAgIChXZWJLaXQ6OlBsdWdpblZpZXc6OnBsYXRmb3Jt TGF5ZXIpOgorICAgICAgICBGaXggYSBjcmFzaCB3aGVuIFdlYkNvcmUgYXNrZWQgZm9yIHRoZSBs YXllciBiZWZvcmUgaXQgd2FzIGluaXRpYWxpemVkLgorCisyMDEwLTEwLTI1ICBBbmRlcnMgQ2Fy bHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4g QWRsZXIuCiAKICAgICAgICAgUmVwbGFjZSBtYXRjaENvdW50RGlkQ2hhbmdlIHdpdGggZGlkRmlu ZFN0cmluZy9kaWRGYWlsVG9GaW5kU3RyaW5nCmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvbWFjL1dLVmlldy5tbSBiL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1t CmluZGV4IGMyMDM1NTQzMmQ2NTJiMmVjNGRkNjdjYTAzNzUwMjg5YjdiMjAyYmYuLmQ2ZmU1MGZj OWExMTI4OTlhOTk1YTFiYWNkMjg2MGIyNzBmYWYyNjYgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCisrKyBiL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMv V0tWaWV3Lm1tCkBAIC00MDgsMTEgKzQwOCwzMCBAQCAtICh2b2lkKV91cGRhdGVWaXNpYmlsaXR5 CiAgICAgICAgIGFyZWEtPnNldFBhZ2VJc1Zpc2libGUoaXNWaWV3VmlzaWJsZShzZWxmKSk7CiB9 CiAKK3N0YXRpYyBOU1NjcmVlbiAqc2NyZWVuRm9yV2luZG93KE5TV2luZG93ICp3aW5kb3cpCit7 CisgICAgTlNTY3JlZW4gKnNjcmVlbiA9IFt3aW5kb3cgc2NyZWVuXTsgLy8gbmlsIGlmIHRoZSB3 aW5kb3cgaXMgb2ZmLXNjcmVlbgorICAgIGlmIChzY3JlZW4pCisgICAgICAgIHJldHVybiBzY3Jl ZW47CisgICAgCisgICAgTlNBcnJheSAqc2NyZWVucyA9IFtOU1NjcmVlbiBzY3JlZW5zXTsKKyAg ICBpZiAoW3NjcmVlbnMgY291bnRdID4gMCkKKyAgICAgICAgcmV0dXJuIFtzY3JlZW5zIG9iamVj dEF0SW5kZXg6MF07IC8vIHNjcmVlbiBjb250YWluaW5nIHRoZSBtZW51YmFyCisgICAgCisgICAg cmV0dXJuIG5pbDsKK30KKwogLSAodm9pZClfdXBkYXRlV2luZG93RnJhbWUKIHsKLSAgICBBU1NF UlQoW3NlbGYgd2luZG93XSk7CisgICAgTlNXaW5kb3cgKndpbmRvdyA9IFtzZWxmIHdpbmRvd107 CisgICAgQVNTRVJUKHdpbmRvdyk7CisKKyAgICAvLyBXZSB3YW50IHRoZSB3aW5kb3cgZnJhbWUg aW4gQ2FyYm9uIGNvb3JkaW5hdGVzLCBzbyBmbGlwIHRoZSBZIGNvb3JkaW5hdGUuCisgICAgTlNS ZWN0IHdpbmRvd0ZyYW1lID0gW3dpbmRvdyBmcmFtZV07CisgICAgTlNTY3JlZW4gKnNjcmVlbiA9 IDo6c2NyZWVuRm9yV2luZG93KHdpbmRvdyk7CisgICAgd2luZG93RnJhbWUub3JpZ2luLnkgPSBO U01heFkoW3NjcmVlbiBmcmFtZV0pIC0gd2luZG93RnJhbWUub3JpZ2luLnk7CiAKLSAgICBfZGF0 YS0+X3BhZ2UtPnVwZGF0ZVdpbmRvd0ZyYW1lKGVuY2xvc2luZ0ludFJlY3QoW1tzZWxmIHdpbmRv d10gZnJhbWVdKSk7CisgICAgX2RhdGEtPl9wYWdlLT51cGRhdGVXaW5kb3dGcmFtZShlbmNsb3Np bmdJbnRSZWN0KHdpbmRvd0ZyYW1lKSk7CiB9CiAKIC0gKHZvaWQpdmlld1dpbGxNb3ZlVG9XaW5k b3c6KE5TV2luZG93ICopd2luZG93CmRpZmYgLS1naXQgYS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1 Z2lucy9OZXRzY2FwZS9tYWMvTmV0c2NhcGVQbHVnaW5NYWMubW0gYi9XZWJLaXQyL1dlYlByb2Nl c3MvUGx1Z2lucy9OZXRzY2FwZS9tYWMvTmV0c2NhcGVQbHVnaW5NYWMubW0KaW5kZXggZmI5YzFk ZmExODY3YzUzMDEzMDI1MDY2ZjlmMjUwMjdlNGYxYjA3My4uODUzMmI3YzBlMGQ4YTc4NjVkMGQw ZmIwOTcxOWYyMTMwY2Y1MDBhNyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdp bnMvTmV0c2NhcGUvbWFjL05ldHNjYXBlUGx1Z2luTWFjLm1tCisrKyBiL1dlYktpdDIvV2ViUHJv Y2Vzcy9QbHVnaW5zL05ldHNjYXBlL21hYy9OZXRzY2FwZVBsdWdpbk1hYy5tbQpAQCAtNjAyLDkg KzYwMiwyNyBAQCB2b2lkIE5ldHNjYXBlUGx1Z2luOjp3aW5kb3dGb2N1c0NoYW5nZWQoYm9vbCBo YXNGb2N1cykKICAgICB9CiB9CiAKLXZvaWQgTmV0c2NhcGVQbHVnaW46OndpbmRvd0ZyYW1lQ2hh bmdlZChjb25zdCBJbnRSZWN0JikKK3ZvaWQgTmV0c2NhcGVQbHVnaW46OndpbmRvd0ZyYW1lQ2hh bmdlZChjb25zdCBJbnRSZWN0JiB3aW5kb3dGcmFtZSkKIHsKLSAgICAvLyBGSVhNRTogSW1wbGVt ZW50LgorICAgIHN3aXRjaCAobV9ldmVudE1vZGVsKSB7CisgICAgICAgIGNhc2UgTlBFdmVudE1v ZGVsQ29jb2E6CisgICAgICAgICAgICAvLyBOb3RoaW5nIHRvIGRvLgorICAgICAgICAgICAgYnJl YWs7CisKKyAgICAgICAgY2FzZSBOUEV2ZW50TW9kZWxDYXJib246IHsKKyAgICAgICAgICAgIFJl Y3QgYm91bmRzOworICAgICAgICAgICAgYm91bmRzLnRvcCA9IHdpbmRvd0ZyYW1lLnkoKSArIHdp bmRvd0ZyYW1lLmhlaWdodCgpOworICAgICAgICAgICAgYm91bmRzLmxlZnQgPSB3aW5kb3dGcmFt ZS54KCk7CisgICAgICAgICAgICBib3VuZHMucmlnaHQgPSB3aW5kb3dGcmFtZS5yaWdodCgpOwor ICAgICAgICAgICAgYm91bmRzLmJvdHRvbSA9IHdpbmRvd0ZyYW1lLnkoKTsKKyAgICAgICAgICAg IAorICAgICAgICAgICAgOjpTZXRXaW5kb3dCb3VuZHMod2luZG93UmVmKCksIGtXaW5kb3dTdHJ1 Y3R1cmVSZ24sICZib3VuZHMpOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KKworICAg ICAgICBkZWZhdWx0OgorICAgICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgfQog fQogICAgIAogdm9pZCBOZXRzY2FwZVBsdWdpbjo6d2luZG93VmlzaWJpbGl0eUNoYW5nZWQoYm9v bCkKZGlmZiAtLWdpdCBhL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3Bw IGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHAKaW5kZXggZTU5YTJj MjE5YmRlM2MxNGQwY2YyMzYzMDZiMjUxZmYyODI1ZjZhYy4uZjJjYzlhMjliY2Y4NTM4ZjhjNmJl YzMxNDg2NTMzMjYyNjhjYjI0NiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdp bnMvUGx1Z2luVmlldy5jcHAKKysrIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2lu Vmlldy5jcHAKQEAgLTMzOSw4ICszMzksOCBAQCB2b2lkIFBsdWdpblZpZXc6OnNldFdpbmRvd0Zy YW1lKGNvbnN0IEludFJlY3QmIHdpbmRvd0ZyYW1lKQogewogICAgIGlmICghbV9wbHVnaW4pCiAg ICAgICAgIHJldHVybjsKLSAgICAgICAgCi0gICAgLy8gRklYTUU6IEltcGxlbWVudC4KKworICAg IG1fcGx1Z2luLT53aW5kb3dGcmFtZUNoYW5nZWQod2luZG93RnJhbWUpOwogfQogCiAjZW5kaWYK QEAgLTM5OCw2ICszOTgsMTAgQEAgdm9pZCBQbHVnaW5WaWV3Ojppbml0aWFsaXplUGx1Z2luKCkK ICNpZiBQTEFURk9STShNQUMpCiBQbGF0Zm9ybUxheWVyKiBQbHVnaW5WaWV3OjpwbGF0Zm9ybUxh eWVyKCkgY29uc3QKIHsKKyAgICAvLyBUaGUgcGx1Zy1pbiBjYW4gYmUgbnVsbCBoZXJlIGlmIGl0 IGZhaWxlZCB0byBpbml0aWFsaXplIG9yIGhhc24ndCB5ZXQgYmVlbiBpbml0aWFsaXplZC4KKyAg ICBpZiAoIW1fcGx1Z2luKQorICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgCiAgICAgcmV0dXJu IG1fcGx1Z2luLT5wbHVnaW5MYXllcigpOwogfQogI2VuZGlmCg==