48258 2010-10-25 12:35:04 -0700 check-webkit-style fails on operator+=, operator-=, ... methods 2010-10-26 19:01:25 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 48322 1 ademar ademar commit-queue oldest_to_newest 299034 0 ademar 2010-10-25 12:35:04 -0700 check-webkit-style complains on operator+= and -= methods: "[...] Missing spaces around += [whitespace/operators] [3]" Patch is on the way. 299045 1 71784 ademar 2010-10-25 12:49:42 -0700 Created attachment 71784 patch 299904 2 71784 dumi 2010-10-26 17:15:14 -0700 Comment on attachment 71784 patch looks good. r=me. 299936 3 71784 commit-queue 2010-10-26 19:01:20 -0700 Comment on attachment 71784 patch Clearing flags on attachment: 71784 Committed r70600: <http://trac.webkit.org/changeset/70600> 299937 4 commit-queue 2010-10-26 19:01:25 -0700 All reviewed patches have been landed. Closing bug. 71784 2010-10-25 12:49:42 -0700 2010-10-26 19:01:20 -0700 patch 0001-check-webkit-style-Improve-check-for-operator-method.patch text/plain 3739 ademar RnJvbSBhN2ZhYjY4NGIxZjg3YjZmZmMwOWMwOWQxZTEzY2ZkYjE1ZDg3YjYyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVtYXIgZGUgU291emEgUmVpcyBKciA8YWRlbWFyLnJlaXNA b3BlbmJvc3NhLm9yZz4KRGF0ZTogTW9uLCAyNSBPY3QgMjAxMCAxNjozNzowOCAtMDMwMApTdWJq ZWN0OiBbUEFUQ0hdIGNoZWNrLXdlYmtpdC1zdHlsZTogSW1wcm92ZSBjaGVjayBmb3Igb3BlcmF0 b3IgbWV0aG9kcwoKICAgY2hlY2std2Via2l0LXN0eWxlIGZhaWxzIG9uIG9wZXJhdG9yKz0sIG9w ZXJhdG9yLT0sIC4uLiBtZXRob2RzCiAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00ODI1OAotLS0KIFdlYktpdFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgICAxMCArKysrKysrKysrCiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weSB8ICAgIDIgKy0KIC4uLi93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHBfdW5pdHRlc3QucHkgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiAzIGZp bGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDAz NDJmYTMuLmNmOWVkYjYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9X ZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMC0yNSAgQWRlbWFy IGRlIFNvdXphIFJlaXMgSnIuICA8YWRlbWFyLnJlaXNAb3BlbmJvc3NhLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjaGVjay13ZWJraXQtc3R5 bGUgZmFpbHMgb24gb3BlcmF0b3IrPSwgb3BlcmF0b3ItPSwgLi4uIG1ldGhvZHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4MjU4CisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weTogQWRkZWQgZXhjZXB0aW9u cworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0 LnB5OiBBZGRlZCB1bml0LXRlc3RzCisKIDIwMTAtMTAtMjUgIEpvaG5ueSBEaW5nICA8am5kQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgpkaWZmIC0tZ2l0 IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9X ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCA3 YzFjYjNlLi5jZDllNmFlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMTI5Myw3ICsxMjkzLDcgQEAgZGVmIGNoZWNrX3Nw YWNpbmcoZmlsZV9leHRlbnNpb24sIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZXJyb3IpOgog ICAgIGxpbmUgPSBjbGVhbl9saW5lcy5lbGlkZWRbbGluZV9udW1iZXJdICAjIGdldCByaWQgb2Yg Y29tbWVudHMgYW5kIHN0cmluZ3MKIAogICAgICMgRG9uJ3QgdHJ5IHRvIGRvIHNwYWNpbmcgY2hl Y2tzIGZvciBvcGVyYXRvciBtZXRob2RzCi0gICAgbGluZSA9IHN1YihyJ29wZXJhdG9yKD09fCE9 fDx8PDx8PD18Pj18Pj58PilcKCcsICdvcGVyYXRvclwoJywgbGluZSkKKyAgICBsaW5lID0gc3Vi KHInb3BlcmF0b3IoPT18IT18PHw8PHw8PXw+PXw+Pnw+fFwrPXwtPXxcKj18Lz18JT18Jj18XHw9 fF49fDw8PXw+Pj0pXCgnLCAnb3BlcmF0b3JcKCcsIGxpbmUpCiAgICAgIyBEb24ndCB0cnkgdG8g ZG8gc3BhY2luZyBjaGVja3MgZm9yICNpbmNsdWRlIG9yICNpbXBvcnQgc3RhdGVtZW50cyBhdAog ICAgICMgbWluaW11bSBiZWNhdXNlIGl0IG1lc3NlcyB1cCBjaGVja3MgZm9yIHNwYWNpbmcgYXJv dW5kIC8KICAgICBpZiBtYXRjaChyJ1xzKiNccyooPzppbmNsdWRlfGltcG9ydCknLCBsaW5lKToK ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggMDcxY2U1MC4uNmQ1YzI0YiAxMDA2NDQKLS0tIGEv V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3Qu cHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBf dW5pdHRlc3QucHkKQEAgLTEzMTMsNiArMTMxMywxOSBAQCBjbGFzcyBDcHBTdHlsZVRlc3QoQ3Bw U3R5bGVUZXN0QmFzZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgnI2lu Y2x1ZGUgImNvbmZpZy5oIlxuI2ltcG9ydCA8Zm9vL2Jhci5oPlxuJywKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICcnKQogCisgICAgZGVmIHRlc3Rfb3BlcmF0b3JfbWV0aG9k cyhzZWxmKToKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnU3RyaW5nIG9wZXJhdG9yKyhjb25z dCBTdHJpbmcmLCBjb25zdCBTdHJpbmcmKTsnLCAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGlu dCgnYm9vbCBvcGVyYXRvcj09KGNvbnN0IFN0cmluZyYsIGNvbnN0IFN0cmluZyYpOycsICcnKQor ICAgICAgICBzZWxmLmFzc2VydF9saW50KCdTdHJpbmcmIG9wZXJhdG9yLT0oY29uc3QgU3RyaW5n JiwgY29uc3QgU3RyaW5nJik7JywgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ1N0cmlu ZyYgb3BlcmF0b3IrPShjb25zdCBTdHJpbmcmLCBjb25zdCBTdHJpbmcmKTsnLCAnJykKKyAgICAg ICAgc2VsZi5hc3NlcnRfbGludCgnU3RyaW5nJiBvcGVyYXRvcio9KGNvbnN0IFN0cmluZyYsIGNv bnN0IFN0cmluZyYpOycsICcnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCdTdHJpbmcmIG9w ZXJhdG9yJT0oY29uc3QgU3RyaW5nJiwgY29uc3QgU3RyaW5nJik7JywgJycpCisgICAgICAgIHNl bGYuYXNzZXJ0X2xpbnQoJ1N0cmluZyYgb3BlcmF0b3ImPShjb25zdCBTdHJpbmcmLCBjb25zdCBT dHJpbmcmKTsnLCAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnU3RyaW5nJiBvcGVyYXRv cjw8PShjb25zdCBTdHJpbmcmLCBjb25zdCBTdHJpbmcmKTsnLCAnJykKKyAgICAgICAgc2VsZi5h c3NlcnRfbGludCgnU3RyaW5nJiBvcGVyYXRvcj4+PShjb25zdCBTdHJpbmcmLCBjb25zdCBTdHJp bmcmKTsnLCAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnU3RyaW5nJiBvcGVyYXRvcnw9 KGNvbnN0IFN0cmluZyYsIGNvbnN0IFN0cmluZyYpOycsICcnKQorICAgICAgICBzZWxmLmFzc2Vy dF9saW50KCdTdHJpbmcmIG9wZXJhdG9yXj0oY29uc3QgU3RyaW5nJiwgY29uc3QgU3RyaW5nJik7 JywgJycpCisKICAgICBkZWYgdGVzdF9zcGFjaW5nX2JlZm9yZV9sYXN0X3NlbWljb2xvbihzZWxm KToKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnY2FsbF9mdW5jdGlvbigpIDsnLAogICAgICAg ICAgICAgICAgICAgICAgICAgICdFeHRyYSBzcGFjZSBiZWZvcmUgbGFzdCBzZW1pY29sb24uIElm IHRoaXMgc2hvdWxkIGJlIGFuICcKLS0gCjEuNy4yLjMKCg==