48253 2010-10-25 11:23:33 -0700 Control + Mousewheel shouldn't be handled in WebKit2 2010-10-25 13:12:13 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 bweinstein bweinstein aroben sam oldest_to_newest 298982 0 bweinstein 2010-10-25 11:23:33 -0700 WebKit2's WebView shouldn't handle Control + Mousewheel. 298984 1 71773 bweinstein 2010-10-25 11:26:02 -0700 Created attachment 71773 [PATCH] Fix 299027 2 71773 aroben 2010-10-25 12:27:41 -0700 Comment on attachment 71773 [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=71773&action=review > WebKit2/UIProcess/win/WebView.cpp:319 > + // We do not want WebKit to handle Control + Wheel, this should be handled by the App. I'd say "handled by the client application to zoom the page" instead of "handled by the App". 299042 3 bweinstein 2010-10-25 12:48:23 -0700 (In reply to comment #2) > (From update of attachment 71773 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=71773&action=review > > > WebKit2/UIProcess/win/WebView.cpp:319 > > + // We do not want WebKit to handle Control + Wheel, this should be handled by the App. > > I'd say "handled by the client application to zoom the page" instead of "handled by the App". Fixed. Thanks! 299066 4 bweinstein 2010-10-25 13:12:13 -0700 Landed in r70479. 71773 2010-10-25 11:26:02 -0700 2010-10-25 12:27:41 -0700 [PATCH] Fix dont_handle_wheeel.patch text/plain 1974 bweinstein SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDQ2NSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTAtMjUgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5A YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIENvbnRyb2wgKyBNb3VzZXdoZWVsIHNob3VsZG4ndCBiZSBoYW5kbGVkIGluIFdlYktpdDIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4MjUzCisg ICAgICAgIAorICAgICAgICBEb24ndCBoYW5kbGUgYSB3aGVlbCBldmVudCBpZiBDb250cm9sIGlz IHByZXNzZWQsIHBhc3MgdGhlIG1lc3NhZ2UgYmFjayB0byBEZWZXaW5kb3dQcm9jLgorCisgICAg ICAgICogVUlQcm9jZXNzL3dpbi9XZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmll dzo6b25XaGVlbEV2ZW50KToKKwogMjAxMC0xMC0yNSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJz Y2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4 OiBXZWJLaXQyL1VJUHJvY2Vzcy93aW4vV2ViVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 Mi9VSVByb2Nlc3Mvd2luL1dlYlZpZXcuY3BwCShyZXZpc2lvbiA3MDQ2MCkKKysrIFdlYktpdDIv VUlQcm9jZXNzL3dpbi9XZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzE0LDIzICszMTQs MTMgQEAgTFJFU1VMVCBXZWJWaWV3Ojpvbk1vdXNlRXZlbnQoSFdORCBoV25kLAogCiBMUkVTVUxU IFdlYlZpZXc6Om9uV2hlZWxFdmVudChIV05EIGhXbmQsIFVJTlQgbWVzc2FnZSwgV1BBUkFNIHdQ YXJhbSwgTFBBUkFNIGxQYXJhbSwgYm9vbCYgaGFuZGxlZCkKIHsKLSAgICAvLyBDdHJsK01vdXNl IHdoZWVsIGRvZXNuJ3QgZXZlciBnbyBpbnRvIFdlYkNvcmUuICBJdCBpcyB1c2VkIHRvCi0gICAg Ly8gem9vbSBpbnN0ZWFkIChNYWMgem9vbXMgdGhlIHdob2xlIERlc2t0b3AsIGJ1dCBXaW5kb3dz IGJyb3dzZXJzIHRyaWdnZXIgdGhlaXIKLSAgICAvLyBvd24gbG9jYWwgem9vbSBtb2RlcyBmb3Ig Q3RybCt3aGVlbCkuCi0gICAgLyoKLSAgICBpZiAod1BhcmFtICYgTUtfQ09OVFJPTCkgewotICAg ICAgICBzaG9ydCBkZWx0YSA9IHN0YXRpY19jYXN0PHNob3J0PihISVdPUkQod1BhcmFtKSk7Ci0g ICAgICAgIGlmIChkZWx0YSA8IDApCi0gICAgICAgICAgICBtX3BhZ2UtPm1ha2VUZXh0U21hbGxl cigwKTsKLSAgICAgICAgZWxzZQotICAgICAgICAgICAgbV9wYWdlLT5tYWtlVGV4dExhcmdlcigw KTsKLQotICAgICAgICBoYW5kbGVkID0gdHJ1ZTsKKyAgICBXZWJXaGVlbEV2ZW50IHdoZWVsRXZl bnQgPSBXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYldoZWVsRXZlbnQoaFduZCwgbWVzc2FnZSwg d1BhcmFtLCBsUGFyYW0pOworICAgIGlmICh3aGVlbEV2ZW50LmNvbnRyb2xLZXkoKSkgeworICAg ICAgICAvLyBXZSBkbyBub3Qgd2FudCBXZWJLaXQgdG8gaGFuZGxlIENvbnRyb2wgKyBXaGVlbCwg dGhpcyBzaG91bGQgYmUgaGFuZGxlZCBieSB0aGUgQXBwLgorICAgICAgICBoYW5kbGVkID0gZmFs c2U7CiAgICAgICAgIHJldHVybiAwOwogICAgIH0KLSAgICAqLwogCi0gICAgV2ViV2hlZWxFdmVu dCB3aGVlbEV2ZW50ID0gV2ViRXZlbnRGYWN0b3J5OjpjcmVhdGVXZWJXaGVlbEV2ZW50KGhXbmQs IG1lc3NhZ2UsIHdQYXJhbSwgbFBhcmFtKTsKICAgICBtX3BhZ2UtPmhhbmRsZVdoZWVsRXZlbnQo d2hlZWxFdmVudCk7CiAKICAgICBoYW5kbGVkID0gdHJ1ZTsK