48244 2010-10-25 08:50:16 -0700 webkit-patch rollout produces incorrect patch when using svn move 2010-10-26 12:05:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 abecsi webkit-unassigned abarth abecsi cjerdonek commit-queue eric ossy webkit.review.bot oldest_to_newest 298873 0 abecsi 2010-10-25 08:50:16 -0700 During the rolling out of r70450 sheriffbot produced a patch which landed in r70453. This patch broke the build by not renaming the MappedMemoryPool.h file back to it's original name MappedMemory.h. The problem might be cased by webkit-patch rollout incorrectly handling the svn move command. 298875 1 ossy 2010-10-25 08:53:06 -0700 (In reply to comment #0) > During the rolling out of r70450 sheriffbot produced a patch which landed in r70453. > This patch broke the build by not renaming the MappedMemoryPool.h file back to it's original name MappedMemory.h. > The problem might be cased by webkit-patch rollout incorrectly handling the svn move command. MappedMemory.h was moved and modified before landing. 298972 2 eric 2010-10-25 11:04:12 -0700 Is this a recent regression? Adam recently changed how files were passed around in scm.py 299125 3 ossy 2010-10-25 15:14:50 -0700 (In reply to comment #2) > Is this a recent regression? Adam recently changed how files were passed around in scm.py Yes, it is. :( Just check r70450 and r70453. 299266 4 abarth 2010-10-25 21:21:19 -0700 Maybe we need to clear out the cached list of changed_files at some point in the rollout process? 299273 5 71840 abarth 2010-10-25 21:46:05 -0700 Created attachment 71840 Patch 299275 6 71840 eric 2010-10-25 21:51:08 -0700 Comment on attachment 71840 Patch LGTM. 299645 7 71840 commit-queue 2010-10-26 11:36:54 -0700 Comment on attachment 71840 Patch Clearing flags on attachment: 71840 Committed r70547: <http://trac.webkit.org/changeset/70547> 299646 8 commit-queue 2010-10-26 11:37:00 -0700 All reviewed patches have been landed. Closing bug. 299685 9 webkit.review.bot 2010-10-26 12:05:47 -0700 http://trac.webkit.org/changeset/70547 might have broken Qt Linux Release The following tests are not passing: fast/blockflow/floats-in-block-layout.html fast/blockflow/self-collapsing-block.html fast/multicol/nested-columns.html 71840 2010-10-25 21:46:05 -0700 2010-10-26 11:36:54 -0700 Patch bug-48244-20101025214604.patch text/plain 1262 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA4MzNmNWE3YzlkZmFhNzFjYTY4NTAzYmJlMmQ2NzllNzg1ZjAyZTIwLi5hMTEzYThj ZDRhNDg0ZDQ5ZThlNTg1MzExMTNmZDc4MWZhZDI1NmIxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMTAtMjUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICB3ZWJraXQtcGF0Y2ggcm9sbG91 dCBwcm9kdWNlcyBpbmNvcnJlY3QgcGF0Y2ggd2hlbiB1c2luZyBzdm4gbW92ZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDgyNDQKKworICAgICAgICBX ZSBuZWVkIHRvIGZsdXNoIG91ciBjYWNoZXMgd2hlbiB3ZSBtb2RpZnkgdGhlIHdvcmtpbmcgY29w eS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9yZXZlcnRyZXZpc2lv bi5weToKKwogMjAxMC0xMC0yNSAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9yZXZlcnRyZXZpc2lvbi5weSBiL1dlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9yZXZlcnRyZXZpc2lvbi5weQppbmRleCA4MWI2 YmNiYmE1YmZlNmIwNzJlYTEzMmY3YjkzZDliOGE1OWNiYmVmLi5iYmI3OTRjYWM4MDUwOTlhNWMx YWRmODhiNDA1MmVmNWExNGZmMWM1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dl YmtpdHB5L3Rvb2wvc3RlcHMvcmV2ZXJ0cmV2aXNpb24ucHkKKysrIGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3JldmVydHJldmlzaW9uLnB5CkBAIC0zMiwzICszMiw0 IEBAIGZyb20gd2Via2l0cHkudG9vbC5zdGVwcy5hYnN0cmFjdHN0ZXAgaW1wb3J0IEFic3RyYWN0 U3RlcAogY2xhc3MgUmV2ZXJ0UmV2aXNpb24oQWJzdHJhY3RTdGVwKToKICAgICBkZWYgcnVuKHNl bGYsIHN0YXRlKToKICAgICAgICAgc2VsZi5fdG9vbC5jaGVja291dCgpLmFwcGx5X3JldmVyc2Vf ZGlmZihzdGF0ZVsicmV2aXNpb24iXSkKKyAgICAgICAgc2VsZi5kaWRfbW9kaWZ5X2NoZWNrb3V0 KHN0YXRlKQo=