4824 2005-09-03 09:37:40 -0700 CSS "border-bottom-style: dotted" attribute sometimes draws extra pixel 2024-04-12 04:18:08 -0700 1 1 1 Unclassified WebKit Layout and Rendering 412 Mac OS X 10.4 REOPENED https://bugs.webkit.org/show_bug.cgi?id=268448 InRadar P2 Normal --- 1 sullivan webkit-unassigned ahmad.saleem792 ap ian mitz simon.fraser webkit-bug-importer zalan oldest_to_newest 18536 0 sullivan 2005-09-03 09:37:40 -0700 This bug is also in Radar as <rdar://4045083> The CSS border-bottom-style:dotted attribute sometimes draws an extra pixel in the bottom border when the link length is a certain length. See screenshot. For "Fire" and "Colloquy" the bottome borders look fine; but for "LimeWire" and "Fractality" you can see an extra pixel at the right side of the border; almost like an ink smudge. What's probably happening is that it's always drawing a last pixel at the end of the bounds... and this sometimes happens to line up with the dotted pattern, sometimes not. 33122 1 mitz 2006-02-17 05:34:36 -0800 (In reply to comment #0) > What's probably happening is that it's always drawing a last pixel at the end of the bounds... and this > sometimes happens to line up with the dotted pattern, sometimes not. This is intended (QWKPainter.mm:295): // Do a rect fill of our endpoints. This ensures we always have the // appearance of being a border. We then draw the actual dotted/dashed line. ideally it should be done only if two borders meet at the given endpoint. 1953480 2 ahmad.saleem792 2023-05-06 23:56:29 -0700 (In reply to mitz from comment #1) > (In reply to comment #0) > > What's probably happening is that it's always drawing a last pixel at the end of the bounds... and this > > sometimes happens to line up with the dotted pattern, sometimes not. > > This is intended (QWKPainter.mm:295): > // Do a rect fill of our endpoints. This ensures we always have the > // appearance of being a border. We then draw the actual > dotted/dashed line. > > ideally it should be done only if two borders meet at the given endpoint. I tried to search for this comment in WebKit source using Searchfox.org (easier to use when trying to search comment) but I couldn't find this comment. I am not sure on the radar bug, whether we have any testcase etc. Can we close this now? Adding @ap - to help on Radar bit. 1953518 3 zalan 2023-05-07 09:52:31 -0700 I am not seeing any test case on this. Not sure what the right category for "needs more information" in bugzilla but I am somewhat convinced we already addressed this so -> config changed. 1953523 4 466261 ap 2023-05-07 10:22:04 -0700 Created attachment 466261 test case 1953528 5 ap 2023-05-07 10:26:30 -0700 Doesn't seem fixed. All browser engines are different here, but at least on this test case, Firefox seems nicest. 1953544 6 zalan 2023-05-07 12:58:24 -0700 (In reply to Alexey Proskuryakov from comment #4) > Created attachment 466261 [details] > test case 👍 2028042 7 ahmad.saleem792 2024-04-12 04:18:08 -0700 @Alan & Alexey - I think bug 268448 might have progressed it slightly. Since Safari 17.5 is different from Minibrowser. https://commits.webkit.org/276585@main 466261 2023-05-07 10:22:04 -0700 2023-05-07 10:22:04 -0700 test case test.html text/html 312 ap PHN0eWxlPgpkaXYgewpib3JkZXItYm90dG9tLXN0eWxlOmRvdHRlZDsKfQo8L3N0eWxlPgo8ZGl2 IHN0eWxlPSJ3aWR0aDoxMDBweDsiPjwvZGl2Pjxicj4KPGRpdiBzdHlsZT0id2lkdGg6MTAxcHg7 Ij48L2Rpdj48YnI+CjxkaXYgc3R5bGU9IndpZHRoOjEwMnB4OyI+PC9kaXY+PGJyPgo8ZGl2IHN0 eWxlPSJ3aWR0aDoxMDNweDsiPjwvZGl2Pjxicj4KPGRpdiBzdHlsZT0id2lkdGg6MTA0cHg7Ij48 L2Rpdj48YnI+CjxkaXYgc3R5bGU9IndpZHRoOjEwNXB4OyI+PC9kaXY+PGJyPgo8ZGl2IHN0eWxl PSJ3aWR0aDoxMDZweDsiPjwvZGl2Pjxicj4K