48236 2010-10-25 07:10:03 -0700 Add support for loading each test several times in chromium Python test runner 2010-10-28 11:08:38 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 sgjesse webkit-unassigned abarth commit-queue dglazkov dpranke levin webkit.review.bot oldest_to_newest 298831 0 sgjesse 2010-10-25 07:10:03 -0700 The Python test runner needs to support the DumpRenderTree flags --multiple-loads and --js-flags. 298832 1 71745 sgjesse 2010-10-25 07:12:55 -0700 Created attachment 71745 Proposed patch. 298834 2 webkit.review.bot 2010-10-25 07:17:26 -0700 Attachment 71745 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:390: trailing whitespace [pep8/W291] [5] WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:396: indentation is not a multiple of four [pep8/E111] [5] WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:398: indentation is not a multiple of four [pep8/E111] [5] Total errors found: 3 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 298840 3 71746 sgjesse 2010-10-25 07:37:42 -0700 Created attachment 71746 Fixed style issues 298843 4 dglazkov 2010-10-25 07:47:05 -0700 Dirk/David/Adam, could you take a look? 299006 5 dpranke 2010-10-25 11:51:24 -0700 What are these flags used for (or what are they going to be used for)? AFAIK, old-run-webkit-tests has a --repeat-each flag, but that's implemented by looping in the script, not in DRT, and doesn't have a --js-flags script. Does upstream DRT support these flags, or just Chromium DRT? How does --multiple-loads actually interact with the framework? Do we only dump output for the first load, or the last load, or something? As far as the actual coding of the patch goes ... 1) Is it actually possible to pass an option in that preserves the quotation marks, or will you need to actually enclose the option in quotes every time (i.e., can both branches of that test execute)? 2) I'm not wild about using --multiple-loads=0 to indicate "use the default value". It seems like --multiple-loads=0 should turn off the feature, and I'm not sure what the savings would be over just typing --multiple-loads=5 ? 299327 6 sgjesse 2010-10-26 00:54:15 -0700 (In reply to comment #5) > What are these flags used for (or what are they going to be used for)? AFAIK, old-run-webkit-tests has a --repeat-each flag, but that's implemented by looping in the script, not in DRT, and doesn't have a --js-flags script. > The main purpose is the enhance testing as we have seen bugs related to V8 which could only be revealed by loading the tests several times. While testing this new option the bug http://code.google.com/p/chromium/issues/detail?id=60135 was discovered. > Does upstream DRT support these flags, or just Chromium DRT? > No this is a chromium DRT only option for now. > How does --multiple-loads actually interact with the framework? Do we only dump output for the first load, or the last load, or something? > The --multiple-loads and --js-files are passed unmodified to DRT. Currently DRT will just dump the output for the last load. See https://bugs.webkit.org/show_bug.cgi?id=48233. > As far as the actual coding of the patch goes ... > > 1) Is it actually possible to pass an option in that preserves the quotation marks, or will you need to actually enclose the option in quotes every time (i.e., can both branches of that test execute)? > Well, only if you really want to e.g. --js-flags="\"--xxx --yyy\"", so I will remove that check. > 2) I'm not wild about using --multiple-loads=0 to indicate "use the default value". It seems like --multiple-loads=0 should turn off the feature, and I'm not sure what the savings would be over just typing --multiple-loads=5 ? Good point. I was thinking of having different defaults for release and debug (e.g. 5 and 2), but I could not get optparse of type "int" to handle just --multiple-loads (without equals some number). I have discarded the idea of a default for now. 299331 7 71848 sgjesse 2010-10-26 01:02:56 -0700 Created attachment 71848 Addressed comments #5 299702 8 71848 dpranke 2010-10-26 12:21:38 -0700 Comment on attachment 71848 Addressed comments #5 Change now looks good to me. Unfortunately, I'm not a review :( 300165 9 71848 pfeldman 2010-10-27 06:11:17 -0700 Comment on attachment 71848 Addressed comments #5 View in context: https://bugs.webkit.org/attachment.cgi?id=71848&action=review > WebKitTools/ChangeLog:6 > + Should point to the bug. 300703 10 71848 eric 2010-10-27 16:45:28 -0700 Comment on attachment 71848 Addressed comments #5 View in context: https://bugs.webkit.org/attachment.cgi?id=71848&action=review I'm willing to rs=me this. As Pavel said, your ChangeLog should point to the bug. If you're using webkit-patch upload it will create a properly formated changelog for you. You'll need to post a new patch if you want to use the commit-queue. > WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:394 > + > + Why the extra newline? 300928 11 72155 sgjesse 2010-10-28 00:51:57 -0700 Created attachment 72155 Addressed comments #9 and #10 301172 12 72155 commit-queue 2010-10-28 11:08:30 -0700 Comment on attachment 72155 Addressed comments #9 and #10 Clearing flags on attachment: 72155 Committed r70789: <http://trac.webkit.org/changeset/70789> 301173 13 commit-queue 2010-10-28 11:08:38 -0700 All reviewed patches have been landed. Closing bug. 71745 2010-10-25 07:12:55 -0700 2010-10-25 07:37:42 -0700 Proposed patch. runner.patch text/plain 2745 sgjesse SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwNDUwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTAtMjUgIFPDuHJlbiBHamVzc2UgIDxz Z2plc3NlQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGRlZCBzdXBwb3J0IGZvciB0aGUgRHVtcFJlbmRlclRyZWUgZmxhZ3Mg LS1tdWx0aXBsZS1sb2FkcyBhbmQgLS1qcy1mbGFncyB0byB0aGUgUHl0aG9uIHRlc3QgcnVubmVy LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1 bS5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0 X3Rlc3RzLnB5OgorCiAyMDEwLTEwLTI1ICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAaW5mLnUt c3plZ2VkLmh1PgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9qYW4gVmFmYWkuCkluZGV4OiBXZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3J1bl93ZWJraXRfdGVzdHMucHkJKHJldmlzaW9uIDcwNDQ3KQorKysgV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQkod29ya2luZyBj b3B5KQpAQCAtMTUwMCw2ICsxNTAwLDEwIEBAIGRlZiBwYXJzZV9hcmdzKGFyZ3M9Tm9uZSk6CiAg ICAgICAgICAgICBkZWZhdWx0PUZhbHNlLCBoZWxwPSJjcmVhdGUgYSBkaWFsb2cgb24gRHVtcFJl bmRlclRyZWUgc3RhcnR1cCIpLAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1ncC1m YXVsdC1lcnJvci1ib3giLCBhY3Rpb249InN0b3JlX3RydWUiLAogICAgICAgICAgICAgZGVmYXVs dD1GYWxzZSwgaGVscD0iZW5hYmxlIFdpbmRvd3MgR1AgZmF1bHQgZXJyb3IgYm94IiksCisgICAg ICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLW11bHRpcGxlLWxvYWRzIiwKKyAgICAgICAgICAg IHR5cGU9ImludCIsIGhlbHA9InR1cm4gb24gbXVsdGlwbGUgbG9hZHMgb2YgZWFjaCB0ZXN0Iiks CisgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLWpzLWZsYWdzIiwKKyAgICAgICAgICAg IHR5cGU9InN0cmluZyIsIGhlbHA9IkphdmFTY3JpcHQgZmxhZ3MgdG8gcGFzcyB0byB0ZXN0cyIp LAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1ub2NoZWNrLXN5cy1kZXBzIiwgYWN0 aW9uPSJzdG9yZV90cnVlIiwKICAgICAgICAgICAgIGRlZmF1bHQ9RmFsc2UsCiAgICAgICAgICAg ICBoZWxwPSJEb24ndCBjaGVjayB0aGUgc3lzdGVtIGRlcGVuZGVuY2llcyAodGhlbWVzKSIpLApJ bmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJv bWl1bS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CShyZXZpc2lvbiA3MDQ0NykKKysrIFdlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkJKHdvcmtpbmcg Y29weSkKQEAgLTM4NSw2ICszODUsMTkgQEAgY2xhc3MgQ2hyb21pdW1Ecml2ZXIoYmFzZS5Ecml2 ZXIpOgogICAgICAgICBpZiBzZWxmLl9wb3J0LmdldF9vcHRpb24oJ2dwX2ZhdWx0X2Vycm9yX2Jv eCcpOgogICAgICAgICAgICAgZHJpdmVyX2FyZ3MuYXBwZW5kKCctLWdwLWZhdWx0LWVycm9yLWJv eCcpCiAKKyAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy5qc19mbGFncyBpcyBub3QgTm9uZToKKyAg ICAgICAgICAgIGpzX2ZsYWdzID0gc2VsZi5fb3B0aW9ucy5qc19mbGFncworICAgICAgICAgICAg aWYgbm90IChqc19mbGFncy5zdGFydHN3aXRoKCciJykgYW5kIGpzX2ZsYWdzLmVuZHN3aXRoKCci JykpOiAKKyAgICAgICAgICAgICAgICBqc19mbGFncyA9ICciJyArIGpzX2ZsYWdzICsgJyInCisg ICAgICAgICAgICBkcml2ZXJfYXJncy5hcHBlbmQoJy0tanMtZmxhZ3M9JyArIGpzX2ZsYWdzKQor CisgICAgICAgIGlmIHNlbGYuX29wdGlvbnMubXVsdGlwbGVfbG9hZHMgaXMgbm90IE5vbmU6Cisg ICAgICAgICAgICBpZiBzZWxmLl9vcHRpb25zLm11bHRpcGxlX2xvYWRzID09IDA6CisgICAgICAg ICAgICAgIGRyaXZlcl9hcmdzLmFwcGVuZCgnLS1tdWx0aXBsZS1sb2Fkcz01JykKKyAgICAgICAg ICAgIGVsc2U6CisgICAgICAgICAgICAgIGRyaXZlcl9hcmdzLmFwcGVuZCgnLS1tdWx0aXBsZS1s b2Fkcz0nICsgc3RyKHNlbGYuX29wdGlvbnMubXVsdGlwbGVfbG9hZHMpKQorCisKICAgICAgICAg aWYgc2VsZi5fcG9ydC5nZXRfb3B0aW9uKCdhY2NlbGVyYXRlZF9jb21wb3NpdGluZycpOgogICAg ICAgICAgICAgZHJpdmVyX2FyZ3MuYXBwZW5kKCctLWVuYWJsZS1hY2NlbGVyYXRlZC1jb21wb3Np dGluZycpCiAK 71746 2010-10-25 07:37:42 -0700 2010-10-26 01:02:56 -0700 Fixed style issues runner.patch text/plain 2748 sgjesse SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwNDUwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTAtMjUgIFPDuHJlbiBHamVzc2UgIDxz Z2plc3NlQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGRlZCBzdXBwb3J0IGZvciB0aGUgRHVtcFJlbmRlclRyZWUgZmxhZ3Mg LS1tdWx0aXBsZS1sb2FkcyBhbmQgLS1qcy1mbGFncyB0byB0aGUgUHl0aG9uIHRlc3QgcnVubmVy LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1 bS5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0 X3Rlc3RzLnB5OgorCiAyMDEwLTEwLTI1ICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAaW5mLnUt c3plZ2VkLmh1PgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9qYW4gVmFmYWkuCkluZGV4OiBXZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3J1bl93ZWJraXRfdGVzdHMucHkJKHJldmlzaW9uIDcwNDQ3KQorKysgV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQkod29ya2luZyBj b3B5KQpAQCAtMTUwMCw2ICsxNTAwLDEwIEBAIGRlZiBwYXJzZV9hcmdzKGFyZ3M9Tm9uZSk6CiAg ICAgICAgICAgICBkZWZhdWx0PUZhbHNlLCBoZWxwPSJjcmVhdGUgYSBkaWFsb2cgb24gRHVtcFJl bmRlclRyZWUgc3RhcnR1cCIpLAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1ncC1m YXVsdC1lcnJvci1ib3giLCBhY3Rpb249InN0b3JlX3RydWUiLAogICAgICAgICAgICAgZGVmYXVs dD1GYWxzZSwgaGVscD0iZW5hYmxlIFdpbmRvd3MgR1AgZmF1bHQgZXJyb3IgYm94IiksCisgICAg ICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLW11bHRpcGxlLWxvYWRzIiwKKyAgICAgICAgICAg IHR5cGU9ImludCIsIGhlbHA9InR1cm4gb24gbXVsdGlwbGUgbG9hZHMgb2YgZWFjaCB0ZXN0Iiks CisgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLWpzLWZsYWdzIiwKKyAgICAgICAgICAg IHR5cGU9InN0cmluZyIsIGhlbHA9IkphdmFTY3JpcHQgZmxhZ3MgdG8gcGFzcyB0byB0ZXN0cyIp LAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1ub2NoZWNrLXN5cy1kZXBzIiwgYWN0 aW9uPSJzdG9yZV90cnVlIiwKICAgICAgICAgICAgIGRlZmF1bHQ9RmFsc2UsCiAgICAgICAgICAg ICBoZWxwPSJEb24ndCBjaGVjayB0aGUgc3lzdGVtIGRlcGVuZGVuY2llcyAodGhlbWVzKSIpLApJ bmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJv bWl1bS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CShyZXZpc2lvbiA3MDQ0NykKKysrIFdlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkJKHdvcmtpbmcg Y29weSkKQEAgLTM4NSw2ICszODUsMTkgQEAgY2xhc3MgQ2hyb21pdW1Ecml2ZXIoYmFzZS5Ecml2 ZXIpOgogICAgICAgICBpZiBzZWxmLl9wb3J0LmdldF9vcHRpb24oJ2dwX2ZhdWx0X2Vycm9yX2Jv eCcpOgogICAgICAgICAgICAgZHJpdmVyX2FyZ3MuYXBwZW5kKCctLWdwLWZhdWx0LWVycm9yLWJv eCcpCiAKKyAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy5qc19mbGFncyBpcyBub3QgTm9uZToKKyAg ICAgICAgICAgIGpzX2ZsYWdzID0gc2VsZi5fb3B0aW9ucy5qc19mbGFncworICAgICAgICAgICAg aWYgbm90IChqc19mbGFncy5zdGFydHN3aXRoKCciJykgYW5kIGpzX2ZsYWdzLmVuZHN3aXRoKCci JykpOgorICAgICAgICAgICAgICAgIGpzX2ZsYWdzID0gJyInICsganNfZmxhZ3MgKyAnIicKKyAg ICAgICAgICAgIGRyaXZlcl9hcmdzLmFwcGVuZCgnLS1qcy1mbGFncz0nICsganNfZmxhZ3MpCisK KyAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy5tdWx0aXBsZV9sb2FkcyBpcyBub3QgTm9uZToKKyAg ICAgICAgICAgIGlmIHNlbGYuX29wdGlvbnMubXVsdGlwbGVfbG9hZHMgPT0gMDoKKyAgICAgICAg ICAgICAgICBkcml2ZXJfYXJncy5hcHBlbmQoJy0tbXVsdGlwbGUtbG9hZHM9NScpCisgICAgICAg ICAgICBlbHNlOgorICAgICAgICAgICAgICAgIGRyaXZlcl9hcmdzLmFwcGVuZCgnLS1tdWx0aXBs ZS1sb2Fkcz0nICsgc3RyKHNlbGYuX29wdGlvbnMubXVsdGlwbGVfbG9hZHMpKQorCisKICAgICAg ICAgaWYgc2VsZi5fcG9ydC5nZXRfb3B0aW9uKCdhY2NlbGVyYXRlZF9jb21wb3NpdGluZycpOgog ICAgICAgICAgICAgZHJpdmVyX2FyZ3MuYXBwZW5kKCctLWVuYWJsZS1hY2NlbGVyYXRlZC1jb21w b3NpdGluZycpCiAK 71848 2010-10-26 01:02:56 -0700 2010-10-28 00:51:57 -0700 Addressed comments #5 runner.patch text/plain 2503 sgjesse SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwNDUwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTAtMjUgIFPDuHJlbiBHamVzc2UgIDxz Z2plc3NlQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGRlZCBzdXBwb3J0IGZvciB0aGUgRHVtcFJlbmRlclRyZWUgZmxhZ3Mg LS1tdWx0aXBsZS1sb2FkcyBhbmQgLS1qcy1mbGFncyB0byB0aGUgUHl0aG9uIHRlc3QgcnVubmVy LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1 bS5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0 X3Rlc3RzLnB5OgorCiAyMDEwLTEwLTI1ICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAaW5mLnUt c3plZ2VkLmh1PgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9qYW4gVmFmYWkuCkluZGV4OiBXZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3J1bl93ZWJraXRfdGVzdHMucHkJKHJldmlzaW9uIDcwNDQ3KQorKysgV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQkod29ya2luZyBj b3B5KQpAQCAtMTUwMCw2ICsxNTAwLDEwIEBAIGRlZiBwYXJzZV9hcmdzKGFyZ3M9Tm9uZSk6CiAg ICAgICAgICAgICBkZWZhdWx0PUZhbHNlLCBoZWxwPSJjcmVhdGUgYSBkaWFsb2cgb24gRHVtcFJl bmRlclRyZWUgc3RhcnR1cCIpLAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1ncC1m YXVsdC1lcnJvci1ib3giLCBhY3Rpb249InN0b3JlX3RydWUiLAogICAgICAgICAgICAgZGVmYXVs dD1GYWxzZSwgaGVscD0iZW5hYmxlIFdpbmRvd3MgR1AgZmF1bHQgZXJyb3IgYm94IiksCisgICAg ICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLW11bHRpcGxlLWxvYWRzIiwKKyAgICAgICAgICAg IHR5cGU9ImludCIsIGhlbHA9InR1cm4gb24gbXVsdGlwbGUgbG9hZHMgb2YgZWFjaCB0ZXN0Iiks CisgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLWpzLWZsYWdzIiwKKyAgICAgICAgICAg IHR5cGU9InN0cmluZyIsIGhlbHA9IkphdmFTY3JpcHQgZmxhZ3MgdG8gcGFzcyB0byB0ZXN0cyIp LAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1ub2NoZWNrLXN5cy1kZXBzIiwgYWN0 aW9uPSJzdG9yZV90cnVlIiwKICAgICAgICAgICAgIGRlZmF1bHQ9RmFsc2UsCiAgICAgICAgICAg ICBoZWxwPSJEb24ndCBjaGVjayB0aGUgc3lzdGVtIGRlcGVuZGVuY2llcyAodGhlbWVzKSIpLApJ bmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJv bWl1bS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CShyZXZpc2lvbiA3MDQ0NykKKysrIFdlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkJKHdvcmtpbmcg Y29weSkKQEAgLTM4NSw2ICszODUsMTMgQEAgY2xhc3MgQ2hyb21pdW1Ecml2ZXIoYmFzZS5Ecml2 ZXIpOgogICAgICAgICBpZiBzZWxmLl9wb3J0LmdldF9vcHRpb24oJ2dwX2ZhdWx0X2Vycm9yX2Jv eCcpOgogICAgICAgICAgICAgZHJpdmVyX2FyZ3MuYXBwZW5kKCctLWdwLWZhdWx0LWVycm9yLWJv eCcpCiAKKyAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy5qc19mbGFncyBpcyBub3QgTm9uZToKKyAg ICAgICAgICAgIGRyaXZlcl9hcmdzLmFwcGVuZCgnLS1qcy1mbGFncz0iJyArIHNlbGYuX29wdGlv bnMuanNfZmxhZ3MgKyAnIicpCisKKyAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy5tdWx0aXBsZV9s b2FkcyBpcyBub3QgTm9uZSBhbmQgc2VsZi5fb3B0aW9ucy5tdWx0aXBsZV9sb2FkcyA+IDA6Cisg ICAgICAgICAgICBkcml2ZXJfYXJncy5hcHBlbmQoJy0tbXVsdGlwbGUtbG9hZHM9JyArIHN0cihz ZWxmLl9vcHRpb25zLm11bHRpcGxlX2xvYWRzKSkKKworCiAgICAgICAgIGlmIHNlbGYuX3BvcnQu Z2V0X29wdGlvbignYWNjZWxlcmF0ZWRfY29tcG9zaXRpbmcnKToKICAgICAgICAgICAgIGRyaXZl cl9hcmdzLmFwcGVuZCgnLS1lbmFibGUtYWNjZWxlcmF0ZWQtY29tcG9zaXRpbmcnKQogCg== 72155 2010-10-28 00:51:57 -0700 2010-10-28 11:08:30 -0700 Addressed comments #9 and #10 runner.patch text/plain 2545 sgjesse SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwNzUyKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMTAtMjUgIFPDuHJlbiBHamVzc2UgIDxz Z2plc3NlQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGRlZCBzdXBwb3J0IGZvciB0aGUgRHVtcFJlbmRlclRyZWUgZmxhZ3Mg LS1tdWx0aXBsZS1sb2FkcyBhbmQgLS1qcy1mbGFncyB0byB0aGUgUHl0aG9uIHRlc3QgcnVubmVy LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDgyMzYK KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0u cHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90 ZXN0cy5weToKKwogMjAxMC0xMC0yNyAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IFdlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90 ZXN0cy5weQkocmV2aXNpb24gNzA3NTIpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xNTA4 LDYgKzE1MDgsMTAgQEAgZGVmIHBhcnNlX2FyZ3MoYXJncz1Ob25lKToKICAgICAgICAgICAgIGRl ZmF1bHQ9RmFsc2UsIGhlbHA9ImNyZWF0ZSBhIGRpYWxvZyBvbiBEdW1wUmVuZGVyVHJlZSBzdGFy dHVwIiksCiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLWdwLWZhdWx0LWVycm9yLWJv eCIsIGFjdGlvbj0ic3RvcmVfdHJ1ZSIsCiAgICAgICAgICAgICBkZWZhdWx0PUZhbHNlLCBoZWxw PSJlbmFibGUgV2luZG93cyBHUCBmYXVsdCBlcnJvciBib3giKSwKKyAgICAgICAgb3B0cGFyc2Uu bWFrZV9vcHRpb24oIi0tbXVsdGlwbGUtbG9hZHMiLAorICAgICAgICAgICAgdHlwZT0iaW50Iiwg aGVscD0idHVybiBvbiBtdWx0aXBsZSBsb2FkcyBvZiBlYWNoIHRlc3QiKSwKKyAgICAgICAgb3B0 cGFyc2UubWFrZV9vcHRpb24oIi0tanMtZmxhZ3MiLAorICAgICAgICAgICAgdHlwZT0ic3RyaW5n IiwgaGVscD0iSmF2YVNjcmlwdCBmbGFncyB0byBwYXNzIHRvIHRlc3RzIiksCiAgICAgICAgIG9w dHBhcnNlLm1ha2Vfb3B0aW9uKCItLW5vY2hlY2stc3lzLWRlcHMiLCBhY3Rpb249InN0b3JlX3Ry dWUiLAogICAgICAgICAgICAgZGVmYXVsdD1GYWxzZSwKICAgICAgICAgICAgIGhlbHA9IkRvbid0 IGNoZWNrIHRoZSBzeXN0ZW0gZGVwZW5kZW5jaWVzICh0aGVtZXMpIiksCkluZGV4OiBXZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv Y2hyb21pdW0ucHkJKHJldmlzaW9uIDcwNzUyKQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weQkod29ya2luZyBjb3B5KQpAQCAtMzg1 LDYgKzM4NSwxMiBAQCBjbGFzcyBDaHJvbWl1bURyaXZlcihiYXNlLkRyaXZlcik6CiAgICAgICAg IGlmIHNlbGYuX3BvcnQuZ2V0X29wdGlvbignZ3BfZmF1bHRfZXJyb3JfYm94Jyk6CiAgICAgICAg ICAgICBkcml2ZXJfYXJncy5hcHBlbmQoJy0tZ3AtZmF1bHQtZXJyb3ItYm94JykKIAorICAgICAg ICBpZiBzZWxmLl9vcHRpb25zLmpzX2ZsYWdzIGlzIG5vdCBOb25lOgorICAgICAgICAgICAgZHJp dmVyX2FyZ3MuYXBwZW5kKCctLWpzLWZsYWdzPSInICsgc2VsZi5fb3B0aW9ucy5qc19mbGFncyAr ICciJykKKworICAgICAgICBpZiBzZWxmLl9vcHRpb25zLm11bHRpcGxlX2xvYWRzIGlzIG5vdCBO b25lIGFuZCBzZWxmLl9vcHRpb25zLm11bHRpcGxlX2xvYWRzID4gMDoKKyAgICAgICAgICAgIGRy aXZlcl9hcmdzLmFwcGVuZCgnLS1tdWx0aXBsZS1sb2Fkcz0nICsgc3RyKHNlbGYuX29wdGlvbnMu bXVsdGlwbGVfbG9hZHMpKQorCiAgICAgICAgIGlmIHNlbGYuX3BvcnQuZ2V0X29wdGlvbignYWNj ZWxlcmF0ZWRfY29tcG9zaXRpbmcnKToKICAgICAgICAgICAgIGRyaXZlcl9hcmdzLmFwcGVuZCgn LS1lbmFibGUtYWNjZWxlcmF0ZWQtY29tcG9zaXRpbmcnKQogCg==