48220 2010-10-24 23:56:30 -0700 constraint validation: stepMismatch (rounding error) 2010-10-26 22:42:51 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 48221 0 dmikurube webkit-unassigned commit-queue tkent oldest_to_newest 298738 0 dmikurube 2010-10-24 23:56:30 -0700 Steps to reproduce: 1. use following input <input type="number" step="0.005" min="4" value="5.005" /> 2. check the validity-property (valid and stepMismatch Expected: validity.valid should be true. Actually happens: validity.valid is false and validity.stepMismatch is true. 298749 1 71719 dmikurube 2010-10-25 00:42:12 -0700 Created attachment 71719 Patch 298759 2 71719 tkent 2010-10-25 01:51:16 -0700 Comment on attachment 71719 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71719&action=review You need to add a test case to LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js > WebCore/html/NumberInputType.cpp:120 > + // Accepts errors in the equvalent precision to IEEE 754 single-precision numbers and additional 7-bits. This comment doesn't match to the code? 299380 3 71863 dmikurube 2010-10-26 04:10:39 -0700 Created attachment 71863 Patch 299381 4 dmikurube 2010-10-26 04:12:02 -0700 (In reply to comment #2) Thank you for the comments. Added tests and modified the comment. 299416 5 71863 tkent 2010-10-26 07:01:29 -0700 Comment on attachment 71863 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71863&action=review > WebCore/html/NumberInputType.cpp:119 > // is greater than step*2^DBL_MANT_DIG, the following fmod() makes no sense. Needs to update the comment. fmod() won't be used. > WebCore/html/NumberInputType.cpp:122 > + double remainder = fabs(doubleValue - step * round(doubleValue / step)); Would you explain why we need to use fabs() instead of fmod() in a code comment or ChangeLog please? > WebCore/html/NumberInputType.cpp:123 > + // Accepts errors in the equvalent precision to IEEE 754 single-precision This comment is confusing. "Accepts erros in lower fractional part which IEEE 754 single-precision can't represent." ? 299971 6 71979 dmikurube 2010-10-26 21:35:22 -0700 Created attachment 71979 Patch 299983 7 71863 dmikurube 2010-10-26 21:46:27 -0700 Comment on attachment 71863 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71863&action=review >> WebCore/html/NumberInputType.cpp:122 >> + double remainder = fabs(doubleValue - step * round(doubleValue / step)); > > Would you explain why we need to use fabs() instead of fmod() in a code comment or ChangeLog please? Ok, added a detailed description in ChangeLog. >> WebCore/html/NumberInputType.cpp:123 >> + // Accepts errors in the equvalent precision to IEEE 754 single-precision > > This comment is confusing. "Accepts erros in lower fractional part which IEEE 754 single-precision can't represent." ? Thank you. Replaced with your expression. 299999 8 71979 tkent 2010-10-26 22:25:16 -0700 Comment on attachment 71979 Patch Looks good. Thanks! 300008 9 71979 commit-queue 2010-10-26 22:42:46 -0700 Comment on attachment 71979 Patch Clearing flags on attachment: 71979 Committed r70615: <http://trac.webkit.org/changeset/70615> 300009 10 commit-queue 2010-10-26 22:42:51 -0700 All reviewed patches have been landed. Closing bug. 71719 2010-10-25 00:42:12 -0700 2010-10-26 04:10:34 -0700 Patch bug-48220-20101025164210.patch text/plain 2187 dmikurube ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWM0NzUwYTdmMmQ1OGY3ZjFiNmYyMzI2OWI1NDNiMTllNGZmZTY3NC4uMDU1YWEzMjBjOWZiZDE4 Y2EwOGE5MDlmYjZlZWFjZmM0OWVmYTdhOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMC0yNSAgRGFp IE1pa3VydWJlICA8ZG1pa3VydWJlQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZWQgcm91bmRpbmcgZXJyb3Igb24gc3RlcE1p c21hdGNoCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ4MjIwCisKKyAgICAgICAgKiBodG1sL051bWJlcklucHV0VHlwZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpOdW1iZXJJbnB1dFR5cGU6OnN0ZXBNaXNtYXRjaCk6CisKIDIwMTAtMTAtMjAgIEtp bnVrbyBZYXN1ZGEgIDxraW51a29AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEppYW4gTGkuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvTnVtYmVySW5wdXRUeXBlLmNwcCBi L1dlYkNvcmUvaHRtbC9OdW1iZXJJbnB1dFR5cGUuY3BwCmluZGV4IGE0ZTExOGMwMmYzMmMwOWQz NzFjNWNkOGZmOTI1MjYyNWEzYmRkN2QuLmIyN2RlMWI1NTQ4MWIwNTVjYWIyMDc1MDFlNTQwZmUz NzkxYTllYTAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9OdW1iZXJJbnB1dFR5cGUuY3BwCisr KyBiL1dlYkNvcmUvaHRtbC9OdW1iZXJJbnB1dFR5cGUuY3BwCkBAIC00MywxMSArNDMsOCBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiB1c2luZyBuYW1lc3BhY2UgSFRNTE5hbWVzOwogdXNpbmcgbmFt ZXNwYWNlIHN0ZDsKIAotLy8gRklYTUU6IE51bWJlciB2YWx1ZXMgc2hvdWxkIGJlIGluIHRoZSBy YW5nZSBvZiBJRUVFIDc1NCBzaW5nbGUtcHJlY2lzaW9uCi0vLyBmbG9hdGluZyBwb2ludCBudW1i ZXIuCi0vLyBodHRwOi8vd3d3LndoYXR3Zy5vcmcvc3BlY3Mvd2ViLWFwcHMvY3VycmVudC13b3Jr L211bHRpcGFnZS9jb21tb24tbWljcm9zeW50YXhlcy5odG1sI3JlYWwtbnVtYmVycwotc3RhdGlj IGNvbnN0IGRvdWJsZSBudW1iZXJEZWZhdWx0TWluaW11bSA9IC1EQkxfTUFYOwotc3RhdGljIGNv bnN0IGRvdWJsZSBudW1iZXJEZWZhdWx0TWF4aW11bSA9IERCTF9NQVg7CitzdGF0aWMgY29uc3Qg ZG91YmxlIG51bWJlckRlZmF1bHRNaW5pbXVtID0gLUZMVF9NQVg7CitzdGF0aWMgY29uc3QgZG91 YmxlIG51bWJlckRlZmF1bHRNYXhpbXVtID0gRkxUX01BWDsKIAogc3RhdGljIGNvbnN0IGRvdWJs ZSBudW1iZXJEZWZhdWx0U3RlcCA9IDEuMDsKIHN0YXRpYyBjb25zdCBkb3VibGUgbnVtYmVyU3Rl cFNjYWxlRmFjdG9yID0gMS4wOwpAQCAtMTE5LDkgKzExNiw5IEBAIGJvb2wgTnVtYmVySW5wdXRU eXBlOjpzdGVwTWlzbWF0Y2goY29uc3QgU3RyaW5nJiB2YWx1ZSwgZG91YmxlIHN0ZXApIGNvbnN0 CiAgICAgLy8gaXMgZ3JlYXRlciB0aGFuIHN0ZXAqMl5EQkxfTUFOVF9ESUcsIHRoZSBmb2xsb3dp bmcgZm1vZCgpIG1ha2VzIG5vIHNlbnNlLgogICAgIGlmIChkb3VibGVWYWx1ZSAvIHBvdygyLjAs IERCTF9NQU5UX0RJRykgPiBzdGVwKQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgZG91Ymxl IHJlbWFpbmRlciA9IGZtb2QoZG91YmxlVmFsdWUsIHN0ZXApOwotICAgIC8vIEFjY2VwdHMgZXJy b3JzIGluIGxvd2VyIDctYml0LgotICAgIGRvdWJsZSBhY2NlcHRhYmxlRXJyb3IgPSBzdGVwIC8g cG93KDIuMCwgREJMX01BTlRfRElHIC0gNyk7CisgICAgZG91YmxlIHJlbWFpbmRlciA9IGZhYnMo ZG91YmxlVmFsdWUgLSBzdGVwICogcm91bmQoZG91YmxlVmFsdWUgLyBzdGVwKSk7CisgICAgLy8g QWNjZXB0cyBlcnJvcnMgaW4gdGhlIGVxdXZhbGVudCBwcmVjaXNpb24gdG8gSUVFRSA3NTQgc2lu Z2xlLXByZWNpc2lvbiBudW1iZXJzIGFuZCBhZGRpdGlvbmFsIDctYml0cy4KKyAgICBkb3VibGUg YWNjZXB0YWJsZUVycm9yID0gc3RlcCAvIHBvdygyLjAsIEZMVF9NQU5UX0RJRyk7CiAgICAgcmV0 dXJuIGFjY2VwdGFibGVFcnJvciA8IHJlbWFpbmRlciAmJiByZW1haW5kZXIgPCAoc3RlcCAtIGFj Y2VwdGFibGVFcnJvcik7CiB9CiAK 71863 2010-10-26 04:10:39 -0700 2010-10-26 21:46:27 -0700 Patch bug-48220-20101026201037.patch text/plain 3718 dmikurube ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkMzEyMTBjODNmNDUwYjhhZWZlNDJjMDUxNGQ5ODUwYjFkYmI5NGQ2Li40MzZiMjhk MTQ4YWU3NjdhNjY2MjVjYmUxMzljYTVmMmRiMjcyMmUwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTAtMjYgIERhaSBNaWt1cnViZSAgPGRtaWt1cnViZUBnb29nbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNvbnN0cmFpbnQgdmFs aWRhdGlvbjogc3RlcE1pc21hdGNoIChyb3VuZGluZyBlcnJvcikKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4MjIwCisKKyAgICAgICAgKiBmYXN0L2Zv cm1zL1ZhbGlkaXR5U3RhdGUtc3RlcE1pc21hdGNoLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBm YXN0L2Zvcm1zL3NjcmlwdC10ZXN0cy9WYWxpZGl0eVN0YXRlLXN0ZXBNaXNtYXRjaC5qczoKKwog MjAxMC0xMC0yMiAgTU9SSVRBIEhhamltZSA8bW9ycml0YUBnb29nbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL1ZhbGlkaXR5U3RhdGUtc3RlcE1pc21hdGNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2Zhc3QvZm9ybXMvVmFsaWRpdHlTdGF0ZS1zdGVwTWlzbWF0Y2gtZXhwZWN0ZWQudHh0CmluZGV4 IDdiNzYwNzVjNTRiYWVlMDY0ZjQyNTg4Yzg3Njc4OWIyNzk4ZDZiOWQuLmY5MzhjNmRhYTI4MTU1 ZTQwMjE3ZDA1NjI1MGI1NjFmMTQwMDhiYjQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qv Zm9ybXMvVmFsaWRpdHlTdGF0ZS1zdGVwTWlzbWF0Y2gtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvZm9ybXMvVmFsaWRpdHlTdGF0ZS1zdGVwTWlzbWF0Y2gtZXhwZWN0ZWQudHh0 CkBAIC0xNDIsNiArMTQyLDggQEAgUEFTUyBzdGVwTWlzbWF0Y2hGb3IoIjAuOSIsICIwLjEiLCAi IikgaXMgZmFsc2UKIFBBU1Mgc3RlcE1pc21hdGNoRm9yKCIwLjkiLCAiMC4xMDAwMDAxIiwgIiIp IGlzIHRydWUKIFBBU1Mgc3RlcE1pc21hdGNoRm9yKCIwLjkiLCAiMC4xMDAwMDAwMDAwMDAwMDAx IiwgIiIpIGlzIGZhbHNlCiBQQVNTIHN0ZXBNaXNtYXRjaEZvcigiMS4wIiwgIjAuMzMzMzMzMzMz MzMzMzMzMyIsICIiKSBpcyBmYWxzZQorUm91bmRpbmcKK1BBU1Mgc3RlcE1pc21hdGNoRm9yKCI1 LjAwNSIsICIwLjAwNSIsICI0IikgaXMgZmFsc2UKIAogUmFuZ2UgdHlwZQogRW1wdHkgdmFsdWVz CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NjcmlwdC10ZXN0cy9WYWxpZGl0 eVN0YXRlLXN0ZXBNaXNtYXRjaC5qcyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2NyaXB0LXRl c3RzL1ZhbGlkaXR5U3RhdGUtc3RlcE1pc21hdGNoLmpzCmluZGV4IDYxZmFlYzkyYjc0OGQ5ODRk ZWVjZGRjZDZkNjk1YzgwMzk3ZjM0M2IuLjg5MDU5OWMyMThjMmE5M2NjNDUyYjdjN2VlOWEzZGVj YWM1MWY4YzEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2NyaXB0LXRlc3Rz L1ZhbGlkaXR5U3RhdGUtc3RlcE1pc21hdGNoLmpzCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9y bXMvc2NyaXB0LXRlc3RzL1ZhbGlkaXR5U3RhdGUtc3RlcE1pc21hdGNoLmpzCkBAIC0xNTksNiAr MTU5LDggQEAgc2hvdWxkQmUoJ3N0ZXBNaXNtYXRjaEZvcigiMC45IiwgIjAuMSIsICIiKScsICdm YWxzZScpOwogc2hvdWxkQmUoJ3N0ZXBNaXNtYXRjaEZvcigiMC45IiwgIjAuMTAwMDAwMSIsICIi KScsICd0cnVlJyk7CiBzaG91bGRCZSgnc3RlcE1pc21hdGNoRm9yKCIwLjkiLCAiMC4xMDAwMDAw MDAwMDAwMDAxIiwgIiIpJywgJ2ZhbHNlJyk7CiBzaG91bGRCZSgnc3RlcE1pc21hdGNoRm9yKCIx LjAiLCAiMC4zMzMzMzMzMzMzMzMzMzMzIiwgIiIpJywgJ2ZhbHNlJyk7CitkZWJ1ZygnUm91bmRp bmcnKTsKK3Nob3VsZEJlKCdzdGVwTWlzbWF0Y2hGb3IoIjUuMDA1IiwgIjAuMDA1IiwgIjQiKScs ICdmYWxzZScpOwogCiBkZWJ1ZygnJyk7CiBkZWJ1ZygnUmFuZ2UgdHlwZScpOwpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4ZTRiZmU4MGE3 MjZlYzFkNzcyZjIyMDU2N2YzYThkOTliOGQ1MmI1Li43NjdhZDJmNjQ0YWI5MThkZmNlZjM2MGZj M2U3ZTU0MjM1ZTQ0ZTA0IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTEwLTI2ICBEYWkgTWlrdXJ1YmUg IDxkbWlrdXJ1YmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBjb25zdHJhaW50IHZhbGlkYXRpb246IHN0ZXBNaXNtYXRjaCAocm91 bmRpbmcgZXJyb3IpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00ODIyMAorCisgICAgICAgICogaHRtbC9OdW1iZXJJbnB1dFR5cGUuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6TnVtYmVySW5wdXRUeXBlOjpzdGVwTWlzbWF0Y2gpOgorCiAyMDEwLTEwLTI0 ICBNT1JJVEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IFRvbnkgQ2hhbmcuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvTnVtYmVySW5wdXRUeXBl LmNwcCBiL1dlYkNvcmUvaHRtbC9OdW1iZXJJbnB1dFR5cGUuY3BwCmluZGV4IGE0ZTExOGMwMmYz MmMwOWQzNzFjNWNkOGZmOTI1MjYyNWEzYmRkN2QuLmM3N2QyZWY3MTQwMWIxODFjZGQzNTZmNzlj MmRhY2NlZDQzMzVmYTIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9OdW1iZXJJbnB1dFR5cGUu Y3BwCisrKyBiL1dlYkNvcmUvaHRtbC9OdW1iZXJJbnB1dFR5cGUuY3BwCkBAIC0xMTksOSArMTE5 LDkgQEAgYm9vbCBOdW1iZXJJbnB1dFR5cGU6OnN0ZXBNaXNtYXRjaChjb25zdCBTdHJpbmcmIHZh bHVlLCBkb3VibGUgc3RlcCkgY29uc3QKICAgICAvLyBpcyBncmVhdGVyIHRoYW4gc3RlcCoyXkRC TF9NQU5UX0RJRywgdGhlIGZvbGxvd2luZyBmbW9kKCkgbWFrZXMgbm8gc2Vuc2UuCiAgICAgaWYg KGRvdWJsZVZhbHVlIC8gcG93KDIuMCwgREJMX01BTlRfRElHKSA+IHN0ZXApCiAgICAgICAgIHJl dHVybiBmYWxzZTsKLSAgICBkb3VibGUgcmVtYWluZGVyID0gZm1vZChkb3VibGVWYWx1ZSwgc3Rl cCk7Ci0gICAgLy8gQWNjZXB0cyBlcnJvcnMgaW4gbG93ZXIgNy1iaXQuCi0gICAgZG91YmxlIGFj Y2VwdGFibGVFcnJvciA9IHN0ZXAgLyBwb3coMi4wLCBEQkxfTUFOVF9ESUcgLSA3KTsKKyAgICBk b3VibGUgcmVtYWluZGVyID0gZmFicyhkb3VibGVWYWx1ZSAtIHN0ZXAgKiByb3VuZChkb3VibGVW YWx1ZSAvIHN0ZXApKTsKKyAgICAvLyBBY2NlcHRzIGVycm9ycyBpbiB0aGUgZXF1dmFsZW50IHBy ZWNpc2lvbiB0byBJRUVFIDc1NCBzaW5nbGUtcHJlY2lzaW9uCisgICAgZG91YmxlIGFjY2VwdGFi bGVFcnJvciA9IHN0ZXAgLyBwb3coMi4wLCBGTFRfTUFOVF9ESUcpOwogICAgIHJldHVybiBhY2Nl cHRhYmxlRXJyb3IgPCByZW1haW5kZXIgJiYgcmVtYWluZGVyIDwgKHN0ZXAgLSBhY2NlcHRhYmxl RXJyb3IpOwogfQogCg== 71979 2010-10-26 21:35:22 -0700 2010-10-26 22:42:46 -0700 Patch bug-48220-20101027133520.patch text/plain 5108 dmikurube ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4YzQwNDE2NDdkNzE5YjYyYjk5NmQxOWMyOTk4YmYwNzVhZDk2MGExLi4zNzdlZTA0 Yjk3NTE5YTAxZWNkZmEwZDY3ZDk3YmM5M2ZhNzZiZGVlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTAtMjYgIERhaSBNaWt1cnViZSAgPGRtaWt1cnViZUBnb29nbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNvbnN0cmFpbnQgdmFs aWRhdGlvbjogc3RlcE1pc21hdGNoIChyb3VuZGluZyBlcnJvcikKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4MjIwCisKKyAgICAgICAgKiBmYXN0L2Zv cm1zL1ZhbGlkaXR5U3RhdGUtc3RlcE1pc21hdGNoLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBm YXN0L2Zvcm1zL3NjcmlwdC10ZXN0cy9WYWxpZGl0eVN0YXRlLXN0ZXBNaXNtYXRjaC5qczoKKwog MjAxMC0xMC0yNiAgTU9SSVRBIEhhamltZSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBUb255IENoYW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy9WYWxpZGl0eVN0YXRlLXN0ZXBNaXNtYXRjaC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL1ZhbGlkaXR5U3RhdGUtc3RlcE1pc21hdGNoLWV4cGVjdGVkLnR4dAppbmRl eCBmMDcyNjQwNTM4ODE2MzQ4ZjQ1OTA3ODUyYWIyODkzODAyZDdhYzczLi5hYTEyOWE2ZGYyYjE3 MTU2MDMyNmQ3OTJkMjdiMjk0YWJmM2E5YzRmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0 L2Zvcm1zL1ZhbGlkaXR5U3RhdGUtc3RlcE1pc21hdGNoLWV4cGVjdGVkLnR4dAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL1ZhbGlkaXR5U3RhdGUtc3RlcE1pc21hdGNoLWV4cGVjdGVkLnR4 dApAQCAtMTQyLDYgKzE0Miw4IEBAIFBBU1Mgc3RlcE1pc21hdGNoRm9yKCIwLjkiLCAiMC4xIiwg IiIpIGlzIGZhbHNlCiBQQVNTIHN0ZXBNaXNtYXRjaEZvcigiMC45IiwgIjAuMTAwMDAwMSIsICIi KSBpcyB0cnVlCiBQQVNTIHN0ZXBNaXNtYXRjaEZvcigiMC45IiwgIjAuMTAwMDAwMDAwMDAwMDAw MSIsICIiKSBpcyBmYWxzZQogUEFTUyBzdGVwTWlzbWF0Y2hGb3IoIjEuMCIsICIwLjMzMzMzMzMz MzMzMzMzMzMiLCAiIikgaXMgZmFsc2UKK1JvdW5kaW5nCitQQVNTIHN0ZXBNaXNtYXRjaEZvcigi NS4wMDUiLCAiMC4wMDUiLCAiNCIpIGlzIGZhbHNlCiAKIFJhbmdlIHR5cGUKIEVtcHR5IHZhbHVl cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zY3JpcHQtdGVzdHMvVmFsaWRp dHlTdGF0ZS1zdGVwTWlzbWF0Y2guanMgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NjcmlwdC10 ZXN0cy9WYWxpZGl0eVN0YXRlLXN0ZXBNaXNtYXRjaC5qcwppbmRleCA2MzIyZTk2MWQ5YWM4NjBm OWQwOWM5YmIwMTg1Zjk4NWNhNWM3NTZmLi43ZmM1ZWY1NWI2ZTQxZGMyNGNiMDRlMTFiNjljYzE5 ZDJmODEwMmMyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NjcmlwdC10ZXN0 cy9WYWxpZGl0eVN0YXRlLXN0ZXBNaXNtYXRjaC5qcworKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL3NjcmlwdC10ZXN0cy9WYWxpZGl0eVN0YXRlLXN0ZXBNaXNtYXRjaC5qcwpAQCAtMTU5LDYg KzE1OSw4IEBAIHNob3VsZEJlKCdzdGVwTWlzbWF0Y2hGb3IoIjAuOSIsICIwLjEiLCAiIiknLCAn ZmFsc2UnKTsKIHNob3VsZEJlKCdzdGVwTWlzbWF0Y2hGb3IoIjAuOSIsICIwLjEwMDAwMDEiLCAi IiknLCAndHJ1ZScpOwogc2hvdWxkQmUoJ3N0ZXBNaXNtYXRjaEZvcigiMC45IiwgIjAuMTAwMDAw MDAwMDAwMDAwMSIsICIiKScsICdmYWxzZScpOwogc2hvdWxkQmUoJ3N0ZXBNaXNtYXRjaEZvcigi MS4wIiwgIjAuMzMzMzMzMzMzMzMzMzMzMyIsICIiKScsICdmYWxzZScpOworZGVidWcoJ1JvdW5k aW5nJyk7CitzaG91bGRCZSgnc3RlcE1pc21hdGNoRm9yKCI1LjAwNSIsICIwLjAwNSIsICI0Iikn LCAnZmFsc2UnKTsKIAogZGVidWcoJycpOwogZGVidWcoJ1JhbmdlIHR5cGUnKTsKZGlmZiAtLWdp dCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjI2ZjA5MmQy ZGU0ODMxZTE4MGJjOGVhZDcyZjE1OGJmNzQ5NzNiYy4uOTMyNjRjY2E4ODJlNjdjY2NiNWI3NWU1 NjVhZTBkZjUxYzJhMTJjOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMyBAQAorMjAxMC0xMC0yNiAgRGFpIE1pa3VydWJl ICA8ZG1pa3VydWJlQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgY29uc3RyYWludCB2YWxpZGF0aW9uOiBzdGVwTWlzbWF0Y2ggKHJv dW5kaW5nIGVycm9yKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDgyMjAKKworICAgICAgICAxLiBDaGFuZ2VkIHRoZSBjb21wdXRhdGlvbiB0byBhY2hp ZXZlIGRpZmZlcmVuY2UgZnJvbSBhIGludGVncmFsCisgICAgICAgIG11bHRpcGxlIG9mIHRoZSBh bGxvd2VkIHZhbHVlIHN0ZXAuCisKKyAgICAgICAgVGhlIHByZXZpb3VzIGZtb2QoZG91YmxlVmFs dWUsIHN0ZXApIHNvbWV0aW1lcyByZXR1cm5lZCB1bmFjY2VwdGFibGUKKyAgICAgICAgcmVtYWlu ZGVyLiBGb3IgZXhhbXBsZSwKKyAgICAgICAgICAgIGRvdWJsZSBkb3VibGVWYWx1ZSA9IDEuMDA1 OyAvLyBBY3R1YWxseSwgbmVhciB0byAxLjAwNQorICAgICAgICAgICAgZG91YmxlIHN0ZXAgPSAw LjAwNTsgLy8gQWN0dWFsbHksIG5lYXIgdG8gMC4wMDUKKyAgICAgICAgICAgIGZtb2QoZG91Ymxl VmFsdWUsIHN0ZXApID09PiAobmVhciB0bykgMC4wMDUKKyAgICAgICAgSXQncyBhIGNhc2UgdGhh dCBkb3VibGVWYWx1ZSBpcyBhIGxpdHRsZSBzbWFsbGVyIHRoYW4gMS4wMDUgYW5kIHN0ZXAgaXMK KyAgICAgICAgYSBsaXR0bGUgbGFyZ2VyIHRoYW4gMC4wMDUuCisKKyAgICAgICAgMi4gQ2hhbmdl ZCB0aGUgZXJyb3IgdGhyZXNob2xkLgorCisgICAgICAgIE51bWJlciB2YWx1ZXMgaW4gSFRNTDUg YXJlIGV4cHJlc3NlZCBpbiBJRUVFIDc1NCBzaW5nbGUtcHJlY2lzaW9uLgorICAgICAgICBUb28g cHJlY2lzZSBjb21wYXJpc29uIHNvbWV0aW1lcyBsZWFkcyB1bmludGVuZGVkIGVycm9ycy4KKwor ICAgICAgICBGb3IgZXhhbXBsZSwgSSBmb3VuZCBhIGNhc2UgOgorICAgICAgICAgICAgICAgICAg cmVtYWluZGVyID0gMC4wMDAwMDAwMDAwMDAwMDAyMjIwNDQ2MAorICAgICAgICAgICAgYWNjZXB0 YWJsZUVycm9yID0gMC4wMDAwMDAwMDAwMDAwMDAwNzEwNTQyNworCisgICAgICAgICogaHRtbC9O dW1iZXJJbnB1dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TnVtYmVySW5wdXRUeXBlOjpz dGVwTWlzbWF0Y2gpOgorCiAyMDEwLTEwLTI2ICBDaHJpcyBSb2dlcnMgIDxjcm9nZXJzQGdvb2ds ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSdXNzZWxsLgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9odG1sL051bWJlcklucHV0VHlwZS5jcHAgYi9XZWJDb3JlL2h0bWwvTnVtYmVy SW5wdXRUeXBlLmNwcAppbmRleCBiNjBlMmVlYWYwZTNlMzhjNDIzMzZhMGM3ZjFmMTU1NjlhNTBj ZWY5Li4yOGY1MTBjMWJmNDViYzNmMzk1YTczNjQ0YTU3MGRiOTk4NTg3ZTU0IDEwMDY0NAotLS0g YS9XZWJDb3JlL2h0bWwvTnVtYmVySW5wdXRUeXBlLmNwcAorKysgYi9XZWJDb3JlL2h0bWwvTnVt YmVySW5wdXRUeXBlLmNwcApAQCAtMTIxLDEyICsxMjEsMTcgQEAgYm9vbCBOdW1iZXJJbnB1dFR5 cGU6OnN0ZXBNaXNtYXRjaChjb25zdCBTdHJpbmcmIHZhbHVlLCBkb3VibGUgc3RlcCkgY29uc3QK ICAgICBpZiAoaXNpbmYoZG91YmxlVmFsdWUpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAg Ly8gZG91YmxlJ3MgZnJhY3Rpb25hbCBwYXJ0IHNpemUgaXMgREJMX01BTl9ESUctYml0LiBJZiB0 aGUgY3VycmVudCB2YWx1ZQotICAgIC8vIGlzIGdyZWF0ZXIgdGhhbiBzdGVwKjJeREJMX01BTlRf RElHLCB0aGUgZm9sbG93aW5nIGZtb2QoKSBtYWtlcyBubyBzZW5zZS4KKyAgICAvLyBpcyBncmVh dGVyIHRoYW4gc3RlcCoyXkRCTF9NQU5UX0RJRywgdGhlIGZvbGxvd2luZyBjb21wdXRhdGlvbiBm b3IKKyAgICAvLyByZW1haW5kZXIgbWFrZXMgbm8gc2Vuc2UuCiAgICAgaWYgKGRvdWJsZVZhbHVl IC8gcG93KDIuMCwgREJMX01BTlRfRElHKSA+IHN0ZXApCiAgICAgICAgIHJldHVybiBmYWxzZTsK LSAgICBkb3VibGUgcmVtYWluZGVyID0gZm1vZChkb3VibGVWYWx1ZSwgc3RlcCk7Ci0gICAgLy8g QWNjZXB0cyBlcnJvcnMgaW4gbG93ZXIgNy1iaXQuCi0gICAgZG91YmxlIGFjY2VwdGFibGVFcnJv ciA9IHN0ZXAgLyBwb3coMi4wLCBEQkxfTUFOVF9ESUcgLSA3KTsKKyAgICAvLyBUaGUgY29tcHV0 YXRpb24gZm9sbG93cyBIVE1MNSA0LjEwLjcuMi4xMCBgVGhlIHN0ZXAgYXR0cmlidXRlJyA6Cisg ICAgLy8gLi4uIHRoYXQgbnVtYmVyIHN1YnRyYWN0ZWQgZnJvbSB0aGUgc3RlcCBiYXNlIGlzIG5v dCBhbiBpbnRlZ3JhbCBtdWx0aXBsZQorICAgIC8vIG9mIHRoZSBhbGxvd2VkIHZhbHVlIHN0ZXAs IHRoZSBlbGVtZW50IGlzIHN1ZmZlcmluZyBmcm9tIGEgc3RlcCBtaXNtYXRjaC4KKyAgICBkb3Vi bGUgcmVtYWluZGVyID0gZmFicyhkb3VibGVWYWx1ZSAtIHN0ZXAgKiByb3VuZChkb3VibGVWYWx1 ZSAvIHN0ZXApKTsKKyAgICAvLyBBY2NlcHRzIGVycm9zIGluIGxvd2VyIGZyYWN0aW9uYWwgcGFy dCB3aGljaCBJRUVFIDc1NCBzaW5nbGUtcHJlY2lzaW9uCisgICAgLy8gY2FuJ3QgcmVwcmVzZW50 LgorICAgIGRvdWJsZSBhY2NlcHRhYmxlRXJyb3IgPSBzdGVwIC8gcG93KDIuMCwgRkxUX01BTlRf RElHKTsKICAgICByZXR1cm4gYWNjZXB0YWJsZUVycm9yIDwgcmVtYWluZGVyICYmIHJlbWFpbmRl ciA8IChzdGVwIC0gYWNjZXB0YWJsZUVycm9yKTsKIH0KIAo=