48211 2010-10-24 13:41:57 -0700 [Qt] ImageBuffer::platformTransformColorSpace is unnecessarily slow 2010-10-24 17:58:58 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Performance, Qt, QtTriaged P2 Normal --- 1 kling webkit-qt-unassigned abarth eric webkit.review.bot oldest_to_newest 298652 0 kling 2010-10-24 13:41:57 -0700 This function iterates over a QImage getting and setting every pixel with pixel() and setPixel(). This is ridiculously slow since it does bounds checking and detach() for every pixel. We should grab the bits() and do direct access. 298656 1 71697 kling 2010-10-24 13:55:08 -0700 Created attachment 71697 Proposed patch 298657 2 71697 kenneth 2010-10-24 13:59:12 -0700 Comment on attachment 71697 Proposed patch Looks fine. Where did you run into this issue? 298658 3 kling 2010-10-24 14:01:59 -0700 (In reply to comment #2) > (From update of attachment 71697 [details]) > Looks fine. Where did you run into this issue? The SVG folks were discussing http://svg-wow.org/filterEffects/chiseled.svg so I gave it a spin in QtTestBrowser. I should have included that in the bug description, sorry. Thanks for reviewing! <3 298659 4 71697 kling 2010-10-24 14:08:27 -0700 Comment on attachment 71697 Proposed patch Clearing flags on attachment: 71697 Committed r70424: <http://trac.webkit.org/changeset/70424> 298660 5 kling 2010-10-24 14:08:36 -0700 All reviewed patches have been landed. Closing bug. 298682 6 webkit.review.bot 2010-10-24 17:58:58 -0700 http://trac.webkit.org/changeset/70424 might have broken Leopard Intel Debug (Tests) The following tests are not passing: editing/spelling/context-menu-suggestions.html editing/spelling/spellcheck-attribute.html editing/spelling/spelling-backspace-between-lines.html editing/spelling/spelling-contenteditable.html editing/spelling/spelling-textarea.html platform/mac/accessibility/attributed-string-includes-misspelled-with-selection.html platform/mac/accessibility/misspelled-attributed-string.html 71697 2010-10-24 13:55:08 -0700 2010-10-24 14:08:27 -0700 Proposed patch bug-48211.diff text/plain 2111 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTFkZGE4ZS4uODc2ZTJlYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMC0yNCAgQW5kcmVhcyBLbGlu ZyAgPGtsaW5nQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW1F0XSBJbWFnZUJ1ZmZlcjo6cGxhdGZvcm1UcmFuc2Zvcm1Db2xvclNw YWNlIGlzIHVubmVjZXNzYXJpbHkgc2xvdworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDgyMTEKKworICAgICAgICBHcmFiIHRoZSBRSW1hZ2U6OmJpdHMo KSBhbmQgZG8gZGlyZWN0IGFjY2VzcyBpbnN0ZWFkIG9mIGdvaW5nIHRocm91Z2gKKyAgICAgICAg UUltYWdlOjpwaXhlbCgpIGFuZCBRSW1hZ2U6OnNldFBpeGVsKCkuCisKKyAgICAgICAgVGhpcyBp cyBhIHBlcmZvcm1hbmNlIG9wdGltaXphdGlvbiwgc28gbm8gbmV3IHRlc3RzLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VCdWZmZXJRdC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpJbWFnZUJ1ZmZlcjo6cGxhdGZvcm1UcmFuc2Zvcm1Db2xvclNwYWNlKToKKwogMjAxMC0x MC0yNCAgRGlyayBTY2h1bHplICA8a3JpdEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IE5pa29sYXMgWmltbWVybWFubi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvcXQvSW1hZ2VCdWZmZXJRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0 L0ltYWdlQnVmZmVyUXQuY3BwCmluZGV4IDBjZGM4OTQuLmRlMjMyOTcgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VCdWZmZXJRdC5jcHAKKysrIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFnZUJ1ZmZlclF0LmNwcApAQCAtMTU3LDE0ICsxNTcs MTcgQEAgdm9pZCBJbWFnZUJ1ZmZlcjo6cGxhdGZvcm1UcmFuc2Zvcm1Db2xvclNwYWNlKGNvbnN0 IFZlY3RvcjxpbnQ+JiBsb29rVXBUYWJsZSkKICAgICBRSW1hZ2UgaW1hZ2UgPSBtX2RhdGEubV9w aXhtYXAudG9JbWFnZSgpLmNvbnZlcnRUb0Zvcm1hdChRSW1hZ2U6OkZvcm1hdF9BUkdCMzIpOwog ICAgIEFTU0VSVCghaW1hZ2UuaXNOdWxsKCkpOwogCisgICAgdWNoYXIqIGJpdHMgPSBpbWFnZS5i aXRzKCk7CisgICAgY29uc3QgaW50IGJ5dGVzUGVyTGluZSA9IGltYWdlLmJ5dGVzUGVyTGluZSgp OworCiAgICAgZm9yIChpbnQgeSA9IDA7IHkgPCBtX3NpemUuaGVpZ2h0KCk7ICsreSkgewotICAg ICAgICBmb3IgKGludCB4ID0gMDsgeCA8IG1fc2l6ZS53aWR0aCgpOyB4KyspIHsKLSAgICAgICAg ICAgIFFSZ2IgdmFsdWUgPSBpbWFnZS5waXhlbCh4LCB5KTsKLSAgICAgICAgICAgIHZhbHVlID0g cVJnYmEobG9va1VwVGFibGVbcVJlZCh2YWx1ZSldLAotICAgICAgICAgICAgICAgICAgICAgICAg ICBsb29rVXBUYWJsZVtxR3JlZW4odmFsdWUpXSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAg bG9va1VwVGFibGVbcUJsdWUodmFsdWUpXSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgcUFs cGhhKHZhbHVlKSk7Ci0gICAgICAgICAgICBpbWFnZS5zZXRQaXhlbCh4LCB5LCB2YWx1ZSk7Cisg ICAgICAgIHF1aW50MzIqIHNjYW5MaW5lID0gcmVpbnRlcnByZXRfY2FzdF9wdHI8cXVpbnQzMio+ KGJpdHMgKyB5ICogYnl0ZXNQZXJMaW5lKTsKKyAgICAgICAgZm9yIChpbnQgeCA9IDA7IHggPCBt X3NpemUud2lkdGgoKTsgKyt4KSB7CisgICAgICAgICAgICBRUmdiJiBwaXhlbCA9IHNjYW5MaW5l W3hdOworICAgICAgICAgICAgcGl4ZWwgPSBxUmdiYShsb29rVXBUYWJsZVtxUmVkKHBpeGVsKV0s CisgICAgICAgICAgICAgICAgICAgICAgICAgIGxvb2tVcFRhYmxlW3FHcmVlbihwaXhlbCldLAor ICAgICAgICAgICAgICAgICAgICAgICAgICBsb29rVXBUYWJsZVtxQmx1ZShwaXhlbCldLAorICAg ICAgICAgICAgICAgICAgICAgICAgICBxQWxwaGEocGl4ZWwpKTsKICAgICAgICAgfQogICAgIH0K IAo=