48208 2010-10-24 09:09:41 -0700 Inline WTF::bitCount 2010-10-24 11:53:46 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 32828 1 paroga paroga commit-queue ddkilzer webkit.review.bot oldest_to_newest 298600 0 paroga 2010-10-24 09:09:41 -0700 see patch 298601 1 71689 paroga 2010-10-24 09:11:19 -0700 Created attachment 71689 Patch 298604 2 webkit.review.bot 2010-10-24 09:15:10 -0700 Attachment 71689 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/wtf/StdLibExtras.h:94: bitwise_cast is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 298605 3 71689 ddkilzer 2010-10-24 09:37:25 -0700 Comment on attachment 71689 Patch Thanks! r=me 298629 4 71689 commit-queue 2010-10-24 11:53:41 -0700 Comment on attachment 71689 Patch Clearing flags on attachment: 71689 Committed r70419: <http://trac.webkit.org/changeset/70419> 298630 5 commit-queue 2010-10-24 11:53:46 -0700 All reviewed patches have been landed. Closing bug. 71689 2010-10-24 09:11:19 -0700 2010-10-24 11:53:41 -0700 Patch bug-48208.patch text/plain 2225 paroga ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAyMmNkODU0Li40OGQ5YzAwIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTAtMTAtMjMgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5saW5lIFdU Rjo6Yml0d2lzZV9jYXN0IGFuZCBmaXggc3R5bGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4MjA4CisKKyAgICAgICAgKiB3dGYvU3RkTGliRXh0cmFz Lmg6CisgICAgICAgIChXVEY6OmJpdHdpc2VfY2FzdCk6CisgICAgICAgIChXVEY6OmJpdENvdW50 KToKKwogMjAxMC0xMC0yMyAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI3MDM2OS4KZGlmZiAtLWdpdCBh L0phdmFTY3JpcHRDb3JlL3d0Zi9TdGRMaWJFeHRyYXMuaCBiL0phdmFTY3JpcHRDb3JlL3d0Zi9T dGRMaWJFeHRyYXMuaAppbmRleCBkNTk0YzE3Li5lZDc3MGZkIDEwMDY0NAotLS0gYS9KYXZhU2Ny aXB0Q29yZS93dGYvU3RkTGliRXh0cmFzLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL1N0ZExp YkV4dHJhcy5oCkBAIC04NywyOSArODcsMjkgQEAgVHlwZVB0ciByZWludGVycHJldF9jYXN0X3B0 cihjb25zdCB2b2lkKiBwdHIpCiAKIG5hbWVzcGFjZSBXVEYgewogCi0gICAgLyoKLSAgICAgKiBD KysncyBpZGVhIG9mIGEgcmVpbnRlcnByZXRfY2FzdCBsYWNrcyBzdWZmaWNpZW50IGNvam9uZXMu Ci0gICAgICovCi0gICAgdGVtcGxhdGU8dHlwZW5hbWUgVE8sIHR5cGVuYW1lIEZST00+Ci0gICAg VE8gYml0d2lzZV9jYXN0KEZST00gZnJvbSkKLSAgICB7Ci0gICAgICAgIENPTVBJTEVfQVNTRVJU KHNpemVvZihUTykgPT0gc2l6ZW9mKEZST00pLCBXVEZfYml0d2lzZV9jYXN0X3NpemVvZl9jYXN0 ZWRfdHlwZXNfaXNfZXF1YWwpOwotICAgICAgICB1bmlvbiB7Ci0gICAgICAgICAgICBGUk9NIGZy b207Ci0gICAgICAgICAgICBUTyB0bzsKLSAgICAgICAgfSB1OwotICAgICAgICB1LmZyb20gPSBm cm9tOwotICAgICAgICByZXR1cm4gdS50bzsKLSAgICB9CisvKgorICogQysrJ3MgaWRlYSBvZiBh IHJlaW50ZXJwcmV0X2Nhc3QgbGFja3Mgc3VmZmljaWVudCBjb2pvbmVzLgorICovCit0ZW1wbGF0 ZTx0eXBlbmFtZSBUTywgdHlwZW5hbWUgRlJPTT4KK2lubGluZSBUTyBiaXR3aXNlX2Nhc3QoRlJP TSBmcm9tKQoreworICAgIENPTVBJTEVfQVNTRVJUKHNpemVvZihUTykgPT0gc2l6ZW9mKEZST00p LCBXVEZfYml0d2lzZV9jYXN0X3NpemVvZl9jYXN0ZWRfdHlwZXNfaXNfZXF1YWwpOworICAgIHVu aW9uIHsKKyAgICAgICAgRlJPTSBmcm9tOworICAgICAgICBUTyB0bzsKKyAgICB9IHU7CisgICAg dS5mcm9tID0gZnJvbTsKKyAgICByZXR1cm4gdS50bzsKK30KIAotICAgIC8vIFJldHVybnMgYSBj b3VudCBvZiB0aGUgbnVtYmVyIG9mIGJpdHMgc2V0IGluICdiaXRzJy4KLSAgICBpbmxpbmUgc2l6 ZV90IGJpdENvdW50KHVuc2lnbmVkIGJpdHMpCi0gICAgewotICAgICAgICBiaXRzID0gYml0cyAt ICgoYml0cyA+PiAxKSAmIDB4NTU1NTU1NTUpOwotICAgICAgICBiaXRzID0gKGJpdHMgJiAweDMz MzMzMzMzKSArICgoYml0cyA+PiAyKSAmIDB4MzMzMzMzMzMpOwotICAgICAgICByZXR1cm4gKCgo Yml0cyArIChiaXRzID4+IDQpKSAmIDB4RjBGMEYwRikgKiAweDEwMTAxMDEpID4+IDI0OwotICAg IH0KKy8vIFJldHVybnMgYSBjb3VudCBvZiB0aGUgbnVtYmVyIG9mIGJpdHMgc2V0IGluICdiaXRz Jy4KK2lubGluZSBzaXplX3QgYml0Q291bnQodW5zaWduZWQgYml0cykKK3sKKyAgICBiaXRzID0g Yml0cyAtICgoYml0cyA+PiAxKSAmIDB4NTU1NTU1NTUpOworICAgIGJpdHMgPSAoYml0cyAmIDB4 MzMzMzMzMzMpICsgKChiaXRzID4+IDIpICYgMHgzMzMzMzMzMyk7CisgICAgcmV0dXJuICgoKGJp dHMgKyAoYml0cyA+PiA0KSkgJiAweEYwRjBGMEYpICogMHgxMDEwMTAxKSA+PiAyNDsKK30KIAog fSAvLyBuYW1lc3BhY2UgV1RGCiAKLSNlbmRpZgorI2VuZGlmIC8vIFdURl9TdGRMaWJFeHRyYXNf aAo=