48197 2010-10-23 17:47:24 -0700 Remove unused method HTMLFrameElementBase::setNameAndOpenURLCallback() 2010-10-23 19:19:51 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates dbates commit-queue dglazkov eric oldest_to_newest 298497 0 dbates 2010-10-23 17:47:24 -0700 We should remove the method HTMLFrameElementBase::setNameAndOpenURLCallback() since it is unused. For completeness, this method was added in changeset 24396 <http://trac.webkit.org/changeset/24396> and had one call site in HTMLFrameElementBase::attach(). This call site was removed in changeset 67182 <http://trac.webkit.org/changeset/67182>. 298500 1 71662 dbates 2010-10-23 18:02:20 -0700 Created attachment 71662 Patch No functionality was changed. So, no new tests. 298506 2 commit-queue 2010-10-23 19:19:06 -0700 The commit-queue encountered the following flaky tests while processing attachment 71662: http/tests/appcache/credential-url.html Please file bugs against the tests. The author(s) of the test(s) are jchaffraix@webkit.org. The commit-queue is continuing to process your patch. 298507 3 71662 commit-queue 2010-10-23 19:19:46 -0700 Comment on attachment 71662 Patch Clearing flags on attachment: 71662 Committed r70407: <http://trac.webkit.org/changeset/70407> 298508 4 commit-queue 2010-10-23 19:19:51 -0700 All reviewed patches have been landed. Closing bug. 71662 2010-10-23 18:02:20 -0700 2010-10-23 19:19:46 -0700 Patch Bug48197.patch text/plain 2155 dbates SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDQwNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjQgQEAKKzIwMTAtMTAtMjMgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92 ZSB1bnVzZWQgbWV0aG9kIEhUTUxGcmFtZUVsZW1lbnRCYXNlOjpzZXROYW1lQW5kT3BlblVSTENh bGxiYWNrKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ4MTk3CisKKyAgICAgICAgV2l0aCB0aGUgbGFuZGluZyBvZiB0aGUgcGF0Y2ggZm9yIGJ1ZyAj NDUzNjUgaW4KKyAgICAgICAgY2hhbmdlc2V0IDY3MTgyIDxodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC82NzE4Mj4sIAorICAgICAgICBIVE1MRnJhbWVFbGVtZW50QmFzZTo6c2V0TmFt ZUFuZE9wZW5VUkxDYWxsYmFjaygpIGlzIG5vdCBuZWVkZWQuCisgICAgICAgIFRoZXJlZm9yZSwg d2UgcmVtb3ZlIGl0LgorCisgICAgICAgIEJlZm9yZSBjaGFuZ2VzZXQgNjcxODIsIEhUTUxGcmFt ZUVsZW1lbnRCYXNlOjphdHRhY2goKSBzZXQgdXAgYSBwb3N0LWF0dGFjaAorICAgICAgICBjYWxs YmFjayB0byBIVE1MRnJhbWVFbGVtZW50QmFzZTo6c2V0TmFtZUFuZE9wZW5VUkxDYWxsYmFjaygp LiBDaGFuZ2VzZXQgNjcxODIKKyAgICAgICAgcmVtb3ZlZCB0aGlzIGNhbGxiYWNrLgorCisgICAg ICAgIE5vIGZ1bmN0aW9uYWxpdHkgd2FzIGNoYW5nZWQuIFNvLCBubyBuZXcgdGVzdHMuCisKKyAg ICAgICAgKiBodG1sL0hUTUxGcmFtZUVsZW1lbnRCYXNlLmNwcDogUmVtb3ZlIEhUTUxGcmFtZUVs ZW1lbnRCYXNlOjpzZXROYW1lQW5kT3BlblVSTENhbGxiYWNrKCkuCisgICAgICAgICogaHRtbC9I VE1MRnJhbWVFbGVtZW50QmFzZS5oOiBEaXR0by4KKwogMjAxMC0xMC0yMyAgWGFuIExvcGV6ICA8 eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5k ZXg6IFdlYkNvcmUvaHRtbC9IVE1MRnJhbWVFbGVtZW50QmFzZS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9odG1sL0hUTUxGcmFtZUVsZW1lbnRCYXNlLmNwcAkocmV2aXNpb24gNzAzODApCisr KyBXZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxlbWVudEJhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xNjYsMTEgKzE2Niw2IEBAIHZvaWQgSFRNTEZyYW1lRWxlbWVudEJhc2U6OnNldE5hbWVBbmRP cGUKICAgICBvcGVuVVJMKCk7CiB9CiAKLXZvaWQgSFRNTEZyYW1lRWxlbWVudEJhc2U6OnNldE5h bWVBbmRPcGVuVVJMQ2FsbGJhY2soTm9kZSogbikKLXsKLSAgICBzdGF0aWNfY2FzdDxIVE1MRnJh bWVFbGVtZW50QmFzZSo+KG4pLT5zZXROYW1lQW5kT3BlblVSTCgpOwotfQotCiB2b2lkIEhUTUxG cmFtZUVsZW1lbnRCYXNlOjp1cGRhdGVPblJlcGFyZW50aW5nKCkKIHsKICAgICBBU1NFUlQobV9y ZW1haW5zQWxpdmVPblJlbW92YWxGcm9tVHJlZSk7CkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTEZy YW1lRWxlbWVudEJhc2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxl bWVudEJhc2UuaAkocmV2aXNpb24gNzAzODApCisrKyBXZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxl bWVudEJhc2UuaAkod29ya2luZyBjb3B5KQpAQCAtNzAsOCArNzAsNiBAQCBwcml2YXRlOgogICAg IHZvaWQgc2V0TmFtZUFuZE9wZW5VUkwoKTsKICAgICB2b2lkIG9wZW5VUkwoYm9vbCBsb2NrSGlz dG9yeSA9IHRydWUsIGJvb2wgbG9ja0JhY2tGb3J3YXJkTGlzdCA9IHRydWUpOwogCi0gICAgc3Rh dGljIHZvaWQgc2V0TmFtZUFuZE9wZW5VUkxDYWxsYmFjayhOb2RlKik7Ci0KICAgICBBdG9taWNT dHJpbmcgbV9VUkw7CiAgICAgQXRvbWljU3RyaW5nIG1fZnJhbWVOYW1lOwogCg==