48196 2010-10-23 16:17:03 -0700 Fix Perl uninitialized warnings in VCSUtils::svnStatus() and VCSUtils::removeEOL(). 2010-10-24 09:54:24 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates dbates ddkilzer mrobinson oldest_to_newest 298478 0 dbates 2010-10-23 16:17:03 -0700 VCSUtils::svnStatus() concatenate the output of svn status with new line character. svn status may return no ouput (say for a file that has not been added, deleted, or modified). Currently, VCSUtils::svnStatus() assumes svn status always returns output. Instead, we should check that svn status returns some output before trying to concatenate it with the new line character. Also, VCSUtils::removeEOL() should return if its argument is uninitialized. 298485 1 dbates 2010-10-23 16:26:44 -0700 For completeness, I came across this issues when performing the following within the WebKit directory: 1. Download the patch for bug 6751 <https://bug-6751-attachments.webkit.org/attachment.cgi?id=71377> to ~/Desktop as Bug6751_2.patch 2. WebKitTools/Scripts/svn-apply ~/Desktop/Bug6751_2.patch. Then the output of svn-apply will contain: ... patching file LayoutTests/fast/frames/resources/frame-element-name-left.html patching file LayoutTests/fast/frames/resources/frame-element-name-right.html Use of uninitialized value $line in substitution (s///) at /Users/dbates/Desktop/WebKit/WebKitTools/Scripts/VCSUtils.pm line 417. Use of uninitialized value in concatenation (.) or string at /Users/dbates/Desktop/WebKit/WebKitTools/Scripts/VCSUtils.pm line 447. Notice the uninitialized value warnings. 298486 2 71660 dbates 2010-10-23 16:26:59 -0700 Created attachment 71660 Patch 298516 3 71660 ddkilzer 2010-10-23 21:41:23 -0700 Comment on attachment 71660 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71660&action=review Is it possible to write a test for this? Maybe verify that removeEOL(undef) returns ""? > WebKitTools/Scripts/VCSUtils.pm:416 > + return unless $line; Why not do this? return "" unless $line; > WebKitTools/Scripts/VCSUtils.pm:447 > + $svnStatus = (removeEOL(<SVN>) || "") . "\n"; Then you don't have to do anything special here. 298520 4 dbates 2010-10-23 21:46:24 -0700 (In reply to comment #3) > (From update of attachment 71660 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=71660&action=review > > Is it possible to write a test for this? Maybe verify that removeEOL(undef) returns ""? Yes, we can write a test for this. We would need to export the function removeEOL. > > > WebKitTools/Scripts/VCSUtils.pm:416 > > + return unless $line; > > Why not do this? > > return "" unless $line; Will change. 298522 5 71668 dbates 2010-10-23 21:57:47 -0700 Created attachment 71668 Patch with unit test Updated patch based on David Kilzer's comments. Added unit test. 298525 6 71669 dbates 2010-10-23 22:02:28 -0700 Created attachment 71669 Patch with unit test Fix copyright in unit test file removeEOL.pl. 298563 7 71669 ddkilzer 2010-10-24 06:17:57 -0700 Comment on attachment 71669 Patch with unit test Thanks Dan! r=me 298608 8 71669 dbates 2010-10-24 09:54:18 -0700 Comment on attachment 71669 Patch with unit test Clearing flags on attachment: 71669 Committed r70415: <http://trac.webkit.org/changeset/70415> 298609 9 dbates 2010-10-24 09:54:24 -0700 All reviewed patches have been landed. Closing bug. 71660 2010-10-23 16:26:59 -0700 2010-10-23 21:57:47 -0700 Patch Bug48196.patch text/plain 1778 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwNDAxKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMTAtMjMgIERhbmllbCBCYXRlcyAgPGRi YXRlc0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZpeCBQZXJsIHVuaW5pdGlhbGl6ZWQgd2FybmluZ3MgaW4gVkNTVXRpbHM6OnN2blN0 YXR1cygpIGFuZAorICAgICAgICBWQ1NVdGlsczo6cmVtb3ZlRU9MKCkuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODE5NgorCisgICAgICAgIFZDU1V0 aWxzOjpzdm5TdGF0dXMoKSBjb25jYXRlbmF0ZXMgdGhlIG91dHB1dCBvZiBzdm4gc3RhdHVzIHdp dGgKKyAgICAgICAgYSBuZXcgbGluZSBjaGFyYWN0ZXIgYW5kIHN2biBzdGF0dXMgbWF5IHJldHVy biBubyBvdXRwdXQgKHNheSBmb3IKKyAgICAgICAgYSBmaWxlIHRoYXQgaGFzIG5vdCBiZWVuIGFk ZGVkLCBkZWxldGVkLCBvciBtb2RpZmllZCkuIFdlIHNob3VsZAorICAgICAgICBvbmx5IGNvbmNh dGVuYXRlIHRoZSBvdXRwdXQgb2Ygc3ZuIHN0YXR1cyBpZiB0aGVyZSBpcyBzb21lLgorCisgICAg ICAgIEFsc28sIFZDU1V0aWxzOjpyZW1vdmVFT0woKSBzaG91bGQgZW5zdXJlIHRoYXQgaXRzIGFy Z3VtZW50CisgICAgICAgIGlzIGluaXRpYWxpemVkIGJlZm9yZSBwZXJmb3JtaW5nIGEgc3RyaW5n IHN1YnN0aXR1dGlvbi4KKworICAgICAgICAqIFNjcmlwdHMvVkNTVXRpbHMucG06CisKIDIwMTAt MTAtMjMgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI3MDM2Ny4KSW5kZXg6IFdlYktpdFRvb2xzL1Nj cmlwdHMvVkNTVXRpbHMucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy9WQ1NV dGlscy5wbQkocmV2aXNpb24gNzAzODApCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL1ZDU1V0aWxz LnBtCSh3b3JraW5nIGNvcHkpCkBAIC00MTMsNiArNDEzLDcgQEAgc3ViIGNhbm9uaWNhbGl6ZVBh dGgoJCkKIHN1YiByZW1vdmVFT0woJCkKIHsKICAgICBteSAoJGxpbmUpID0gQF87CisgICAgcmV0 dXJuIHVubGVzcyAkbGluZTsKIAogICAgICRsaW5lID1+IHMvW1xyXG5dKyQvL2c7CiAgICAgcmV0 dXJuICRsaW5lOwpAQCAtNDQxLDEwICs0NDIsOSBAQCBzdWIgc3ZuU3RhdHVzKCQpCiAgICAgICAg ICMgUmVhZCB0aGUgcmVzdCBvZiB0aGUgc3ZuIGNvbW1hbmQgb3V0cHV0IHRvIGF2b2lkIGEgYnJv a2VuIHBpcGUgd2FybmluZy4KICAgICAgICAgbG9jYWwgJC8gPSB1bmRlZjsKICAgICAgICAgPFNW Tj47Ci0gICAgfQotICAgIGVsc2UgeworICAgIH0gZWxzZSB7CiAgICAgICAgICMgRmlsZXMgd2ls bCBoYXZlIG9ubHkgb25lIHN0YXR1cyByZXR1cm5lZC4KLSAgICAgICAgJHN2blN0YXR1cyA9IHJl bW92ZUVPTCg8U1ZOPikgLiAiXG4iOworICAgICAgICAkc3ZuU3RhdHVzID0gKHJlbW92ZUVPTCg8 U1ZOPikgfHwgIiIpIC4gIlxuIjsKICAgICB9CiAgICAgY2xvc2UgU1ZOOwogICAgIHJldHVybiAk c3ZuU3RhdHVzOwo= 71668 2010-10-23 21:57:47 -0700 2010-10-23 22:02:28 -0700 Patch with unit test Bug48196_1.patch text/plain 4642 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwNDA5KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTAtMTAtMjMgIERhbmllbCBCYXRlcyAgPGRi YXRlc0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZpeCBQZXJsIHVuaW5pdGlhbGl6ZWQgd2FybmluZ3MgaW4gVkNTVXRpbHM6OnN2blN0 YXR1cygpCisgICAgICAgIGFuZCBWQ1NVdGlsczo6cmVtb3ZlRU9MKCkuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODE5NgorCisgICAgICAgIFZDU1V0 aWxzOjpzdm5TdGF0dXMoKSBjb25jYXRlbmF0ZXMgdGhlIG91dHB1dCBvZiBzdm4gc3RhdHVzIHdp dGgKKyAgICAgICAgYSBuZXcgbGluZSBjaGFyYWN0ZXIgYW5kIHN2biBzdGF0dXMgbWF5IHJldHVy biBubyBvdXRwdXQgKHNheSBmb3IKKyAgICAgICAgYSBmaWxlIHRoYXQgaGFzIG5vdCBiZWVuIGFk ZGVkLCBkZWxldGVkLCBvciBtb2RpZmllZCkuIFdlIHNob3VsZAorICAgICAgICBvbmx5IGNvbmNh dGVuYXRlIHRoZSBvdXRwdXQgb2Ygc3ZuIHN0YXR1cyBpZiB0aGVyZSBpcyBzb21lLgorCisgICAg ICAgIEFsc28sIFZDU1V0aWxzOjpyZW1vdmVFT0woKSBzaG91bGQgZW5zdXJlIHRoYXQgaXRzIGFy Z3VtZW50CisgICAgICAgIGlzIGluaXRpYWxpemVkIGJlZm9yZSBwZXJmb3JtaW5nIGEgc3RyaW5n IHN1YnN0aXR1dGlvbi4KKworICAgICAgICAqIFNjcmlwdHMvVkNTVXRpbHMucG06CisgICAgICAg ICAgLSBNb2RpZmllZCByZW1vdmVFT0woKSB0byByZXR1cm4gIiIgaWYgaXRzIGFyZ3VtZW50IGlz IHVuZGVmaW5lZC4KKyAgICAgICAgICAtIEV4cG9ydGVkIHJlbW92ZUVPTCgpIHNvIHRoYXQgaXQg Y2FuIGJlIHRlc3RlZC4gCisgICAgICAgICogU2NyaXB0cy93ZWJraXRwZXJsL1ZDU1V0aWxzX3Vu aXR0ZXN0L3JlbW92ZUVPTC5wbDogQWRkZWQuCisKIDIwMTAtMTAtMjMgIEVyaWMgU2VpZGVsICA8 ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4 OiBXZWJLaXRUb29scy9TY3JpcHRzL1ZDU1V0aWxzLnBtCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRv b2xzL1NjcmlwdHMvVkNTVXRpbHMucG0JKHJldmlzaW9uIDcwNDA2KQorKysgV2ViS2l0VG9vbHMv U2NyaXB0cy9WQ1NVdGlscy5wbQkod29ya2luZyBjb3B5KQpAQCAtNjgsNiArNjgsNyBAQCBCRUdJ TiB7CiAgICAgICAgICZwYXJzZVBhdGNoCiAgICAgICAgICZwYXRoUmVsYXRpdmVUb1NWTlJlcG9z aXRvcnlSb290Rm9yUGF0aAogICAgICAgICAmcHJlcGFyZVBhcnNlZFBhdGNoCisgICAgICAgICZy ZW1vdmVFT0wKICAgICAgICAgJnJ1blBhdGNoQ29tbWFuZAogICAgICAgICAmc2NtTW92ZU9yUmVu YW1lRmlsZQogICAgICAgICAmc2NtVG9nZ2xlRXhlY3V0YWJsZUJpdApAQCAtNDEzLDYgKzQxNCw3 IEBAIHN1YiBjYW5vbmljYWxpemVQYXRoKCQpCiBzdWIgcmVtb3ZlRU9MKCQpCiB7CiAgICAgbXkg KCRsaW5lKSA9IEBfOworICAgIHJldHVybiAiIiB1bmxlc3MgJGxpbmU7CiAKICAgICAkbGluZSA9 fiBzL1tcclxuXSskLy9nOwogICAgIHJldHVybiAkbGluZTsKSW5kZXg6IFdlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cGVybC9WQ1NVdGlsc191bml0dGVzdC9yZW1vdmVFT0wucGwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL1ZDU1V0aWxzX3VuaXR0ZXN0L3Jl bW92ZUVPTC5wbAkocmV2aXNpb24gMCkKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cGVy bC9WQ1NVdGlsc191bml0dGVzdC9yZW1vdmVFT0wucGwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEs NTYgQEAKKyMhL3Vzci9iaW4vcGVybAorIworIyBDb3B5cmlnaHQgKEMpIDIwMTAgUmVzZWFyY2gg SW4gTW90aW9uIExpbWl0ZWQgMjAxMC4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMKKyMgUmVkaXN0 cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRo b3V0CisjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xs b3dpbmcgY29uZGl0aW9ucyBhcmUKKyMgbWV0OgorIyAKKyMgICAgICogUmVkaXN0cmlidXRpb25z IG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgbm90aWNl LCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgor IyAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhl IGFib3ZlCisjIGNvcHlyaWdodCBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0 aGUgZm9sbG93aW5nIGRpc2NsYWltZXIKKyMgaW4gdGhlIGRvY3VtZW50YXRpb24gYW5kL29yIG90 aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZQorIyBkaXN0cmlidXRpb24uCisjICAgICAq IE5laXRoZXIgdGhlIG5hbWUgb2YgUmVzZWFyY2ggSW4gTW90aW9uIExpbWl0ZWQgbm9yIHRoZSBu YW1lcyBvZgorIyBpdHMgY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJv bW90ZSBwcm9kdWN0cyBkZXJpdmVkCisjIGZyb20gdGhpcyBzb2Z0d2FyZSB3aXRob3V0IHNwZWNp ZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4KKyMgCisjIFRISVMgU09GVFdBUkUgSVMgUFJP VklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVJTIEFORCBDT05UUklCVVRPUlMKKyMgIkFTIElT IiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBO T1QKKyMgTElNSVRFRCBUTywgVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJ VFkgQU5EIEZJVE5FU1MgRk9SCisjIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRSBESVNDTEFJTUVE LiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUCisjIE9XTkVSIE9SIENPTlRSSUJVVE9S UyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLAorIyBTUEVD SUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQg Tk9UCisjIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VS VklDRVM7IExPU1MgT0YgVVNFLAorIyBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRF UlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkKKyMgVEhFT1JZIE9GIExJQUJJTElU WSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorIyAoSU5D TFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9G IFRIRSBVU0UKKyMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NT SUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKworIyBVbml0IHRlc3RzIG9mIFZDU1V0aWxzOjpyZW1v dmVFT0woKS4KKwordXNlIFRlc3Q6OlNpbXBsZSB0ZXN0cyA9PiA1OwordXNlIFZDU1V0aWxzOwor CitteSAkdGl0bGU7CisKKyMgTmV3IHRlc3QKKyR0aXRsZSA9ICJyZW1vdmVFT0w6IFVuZGVmaW5l ZCBhcmd1bWVudC4iOworb2socmVtb3ZlRU9MKHVuZGVmKSBlcSAiIik7CisKKyMgTmV3IHRlc3QK KyR0aXRsZSA9ICJyZW1vdmVFT0w6IExpbmUgd2l0aCBXaW5kb3dzIGxpbmUgZW5kaW5nLiI7Citv ayhyZW1vdmVFT0woIlRoaXMgbGluZSBlbmRzIHdpdGggYSBXaW5kb3dzIGxpbmUgZW5kaW5nLlxy XG4iKSBlcSAiVGhpcyBsaW5lIGVuZHMgd2l0aCBhIFdpbmRvd3MgbGluZSBlbmRpbmcuIik7CisK KyMgTmV3IHRlc3QKKyR0aXRsZSA9ICJyZW1vdmVFT0w6IExpbmUgd2l0aCBVbml4IGxpbmUgZW5k aW5nLiI7CitvayhyZW1vdmVFT0woIlRoaXMgbGluZSBlbmRzIHdpdGggYSBVbml4IGxpbmUgZW5k aW5nLlxuIikgZXEgIlRoaXMgbGluZSBlbmRzIHdpdGggYSBVbml4IGxpbmUgZW5kaW5nLiIpOwor CisjIE5ldyB0ZXN0CiskdGl0bGUgPSAicmVtb3ZlRU9MOiBMaW5lIHdpdGggTWFjIGxpbmUgZW5k aW5nLiI7CitvayhyZW1vdmVFT0woIlRoaXMgbGluZSBlbmRzIHdpdGggYSBNYWMgbGluZSBlbmRp bmcuXHIiKSBlcSAiVGhpcyBsaW5lIGVuZHMgd2l0aCBhIE1hYyBsaW5lIGVuZGluZy4iKTsKKwor IyBOZXcgdGVzdAorJHRpdGxlID0gInJlbW92ZUVPTDogTGluZSB3aXRoIGEgbWl4IG9mIGxpbmUg ZW5kaW5ncy4iOworb2socmVtb3ZlRU9MKCJUaGlzIGxpbmUgY29udGFpbnMgYSBtaXggb2YgbGlu ZSBlbmRpbmdzLlxyXG5cclxuXHJcclxuXG5cblxuIikgZXEgIlRoaXMgbGluZSBjb250YWlucyBh IG1peCBvZiBsaW5lIGVuZGluZ3MuIik7Cg== 71669 2010-10-23 22:02:28 -0700 2010-10-24 09:54:17 -0700 Patch with unit test Bug48196_1.patch text/plain 4637 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwNDA5KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTAtMTAtMjMgIERhbmllbCBCYXRlcyAgPGRi YXRlc0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZpeCBQZXJsIHVuaW5pdGlhbGl6ZWQgd2FybmluZ3MgaW4gVkNTVXRpbHM6OnN2blN0 YXR1cygpCisgICAgICAgIGFuZCBWQ1NVdGlsczo6cmVtb3ZlRU9MKCkuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODE5NgorCisgICAgICAgIFZDU1V0 aWxzOjpzdm5TdGF0dXMoKSBjb25jYXRlbmF0ZXMgdGhlIG91dHB1dCBvZiBzdm4gc3RhdHVzIHdp dGgKKyAgICAgICAgYSBuZXcgbGluZSBjaGFyYWN0ZXIgYW5kIHN2biBzdGF0dXMgbWF5IHJldHVy biBubyBvdXRwdXQgKHNheSBmb3IKKyAgICAgICAgYSBmaWxlIHRoYXQgaGFzIG5vdCBiZWVuIGFk ZGVkLCBkZWxldGVkLCBvciBtb2RpZmllZCkuIFdlIHNob3VsZAorICAgICAgICBvbmx5IGNvbmNh dGVuYXRlIHRoZSBvdXRwdXQgb2Ygc3ZuIHN0YXR1cyBpZiB0aGVyZSBpcyBzb21lLgorCisgICAg ICAgIEFsc28sIFZDU1V0aWxzOjpyZW1vdmVFT0woKSBzaG91bGQgZW5zdXJlIHRoYXQgaXRzIGFy Z3VtZW50CisgICAgICAgIGlzIGluaXRpYWxpemVkIGJlZm9yZSBwZXJmb3JtaW5nIGEgc3RyaW5n IHN1YnN0aXR1dGlvbi4KKworICAgICAgICAqIFNjcmlwdHMvVkNTVXRpbHMucG06CisgICAgICAg ICAgLSBNb2RpZmllZCByZW1vdmVFT0woKSB0byByZXR1cm4gIiIgaWYgaXRzIGFyZ3VtZW50IGlz IHVuZGVmaW5lZC4KKyAgICAgICAgICAtIEV4cG9ydGVkIHJlbW92ZUVPTCgpIHNvIHRoYXQgaXQg Y2FuIGJlIHRlc3RlZC4gCisgICAgICAgICogU2NyaXB0cy93ZWJraXRwZXJsL1ZDU1V0aWxzX3Vu aXR0ZXN0L3JlbW92ZUVPTC5wbDogQWRkZWQuCisKIDIwMTAtMTAtMjMgIEVyaWMgU2VpZGVsICA8 ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4 OiBXZWJLaXRUb29scy9TY3JpcHRzL1ZDU1V0aWxzLnBtCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRv b2xzL1NjcmlwdHMvVkNTVXRpbHMucG0JKHJldmlzaW9uIDcwNDA2KQorKysgV2ViS2l0VG9vbHMv U2NyaXB0cy9WQ1NVdGlscy5wbQkod29ya2luZyBjb3B5KQpAQCAtNjgsNiArNjgsNyBAQCBCRUdJ TiB7CiAgICAgICAgICZwYXJzZVBhdGNoCiAgICAgICAgICZwYXRoUmVsYXRpdmVUb1NWTlJlcG9z aXRvcnlSb290Rm9yUGF0aAogICAgICAgICAmcHJlcGFyZVBhcnNlZFBhdGNoCisgICAgICAgICZy ZW1vdmVFT0wKICAgICAgICAgJnJ1blBhdGNoQ29tbWFuZAogICAgICAgICAmc2NtTW92ZU9yUmVu YW1lRmlsZQogICAgICAgICAmc2NtVG9nZ2xlRXhlY3V0YWJsZUJpdApAQCAtNDEzLDYgKzQxNCw3 IEBAIHN1YiBjYW5vbmljYWxpemVQYXRoKCQpCiBzdWIgcmVtb3ZlRU9MKCQpCiB7CiAgICAgbXkg KCRsaW5lKSA9IEBfOworICAgIHJldHVybiAiIiB1bmxlc3MgJGxpbmU7CiAKICAgICAkbGluZSA9 fiBzL1tcclxuXSskLy9nOwogICAgIHJldHVybiAkbGluZTsKSW5kZXg6IFdlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cGVybC9WQ1NVdGlsc191bml0dGVzdC9yZW1vdmVFT0wucGwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL1ZDU1V0aWxzX3VuaXR0ZXN0L3Jl bW92ZUVPTC5wbAkocmV2aXNpb24gMCkKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cGVy bC9WQ1NVdGlsc191bml0dGVzdC9yZW1vdmVFT0wucGwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEs NTYgQEAKKyMhL3Vzci9iaW4vcGVybAorIworIyBDb3B5cmlnaHQgKEMpIFJlc2VhcmNoIEluIE1v dGlvbiBMaW1pdGVkIDIwMTAuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjCisjIFJlZGlzdHJpYnV0 aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAor IyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5n IGNvbmRpdGlvbnMgYXJlCisjIG1ldDoKKyMgCisjICAgICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBz b3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisjIG5vdGljZSwgdGhp cyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyMgICAg ICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92 ZQorIyBjb3B5cmlnaHQgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZv bGxvd2luZyBkaXNjbGFpbWVyCisjIGluIHRoZSBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBt YXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUKKyMgZGlzdHJpYnV0aW9uLgorIyAgICAgKiBOZWl0 aGVyIHRoZSBuYW1lIG9mIFJlc2VhcmNoIEluIE1vdGlvbiBMaW1pdGVkIG5vciB0aGUgbmFtZXMg b2YKKyMgaXRzIGNvbnRyaWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBlbmRvcnNlIG9yIHByb21vdGUg cHJvZHVjdHMgZGVyaXZlZAorIyBmcm9tIHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBw cmlvciB3cml0dGVuIHBlcm1pc3Npb24uCisjIAorIyBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVE IEJZIFRIRSBDT1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCisjICJBUyBJUyIgQU5E IEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UCisj IExJTUlURUQgVE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFO RCBGSVRORVNTIEZPUgorIyBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4g Tk8gRVZFTlQgU0hBTEwgVEhFIENPUFlSSUdIVAorIyBPV05FUiBPUiBDT05UUklCVVRPUlMgQkUg TElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwKKyMgU1BFQ0lBTCwg RVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAor IyBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VT OyBMT1NTIE9GIFVTRSwKKyMgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBU SU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZCisjIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdI RVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyMgKElOQ0xVRElO RyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUg VVNFCisjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJ VFkgT0YgU1VDSCBEQU1BR0UuCisKKyMgVW5pdCB0ZXN0cyBvZiBWQ1NVdGlsczo6cmVtb3ZlRU9M KCkuCisKK3VzZSBUZXN0OjpTaW1wbGUgdGVzdHMgPT4gNTsKK3VzZSBWQ1NVdGlsczsKKworbXkg JHRpdGxlOworCisjIE5ldyB0ZXN0CiskdGl0bGUgPSAicmVtb3ZlRU9MOiBVbmRlZmluZWQgYXJn dW1lbnQuIjsKK29rKHJlbW92ZUVPTCh1bmRlZikgZXEgIiIpOworCisjIE5ldyB0ZXN0CiskdGl0 bGUgPSAicmVtb3ZlRU9MOiBMaW5lIHdpdGggV2luZG93cyBsaW5lIGVuZGluZy4iOworb2socmVt b3ZlRU9MKCJUaGlzIGxpbmUgZW5kcyB3aXRoIGEgV2luZG93cyBsaW5lIGVuZGluZy5cclxuIikg ZXEgIlRoaXMgbGluZSBlbmRzIHdpdGggYSBXaW5kb3dzIGxpbmUgZW5kaW5nLiIpOworCisjIE5l dyB0ZXN0CiskdGl0bGUgPSAicmVtb3ZlRU9MOiBMaW5lIHdpdGggVW5peCBsaW5lIGVuZGluZy4i Oworb2socmVtb3ZlRU9MKCJUaGlzIGxpbmUgZW5kcyB3aXRoIGEgVW5peCBsaW5lIGVuZGluZy5c biIpIGVxICJUaGlzIGxpbmUgZW5kcyB3aXRoIGEgVW5peCBsaW5lIGVuZGluZy4iKTsKKworIyBO ZXcgdGVzdAorJHRpdGxlID0gInJlbW92ZUVPTDogTGluZSB3aXRoIE1hYyBsaW5lIGVuZGluZy4i Oworb2socmVtb3ZlRU9MKCJUaGlzIGxpbmUgZW5kcyB3aXRoIGEgTWFjIGxpbmUgZW5kaW5nLlxy IikgZXEgIlRoaXMgbGluZSBlbmRzIHdpdGggYSBNYWMgbGluZSBlbmRpbmcuIik7CisKKyMgTmV3 IHRlc3QKKyR0aXRsZSA9ICJyZW1vdmVFT0w6IExpbmUgd2l0aCBhIG1peCBvZiBsaW5lIGVuZGlu Z3MuIjsKK29rKHJlbW92ZUVPTCgiVGhpcyBsaW5lIGNvbnRhaW5zIGEgbWl4IG9mIGxpbmUgZW5k aW5ncy5cclxuXHJcblxyXHJcblxuXG5cbiIpIGVxICJUaGlzIGxpbmUgY29udGFpbnMgYSBtaXgg b2YgbGluZSBlbmRpbmdzLiIpOwo=