48190 2010-10-23 10:22:15 -0700 [WINCE] Port COMPtr.h to WinCE 2010-10-23 13:02:26 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 paroga paroga commit-queue oldest_to_newest 298423 0 paroga 2010-10-23 10:22:15 -0700 see patch 298424 1 71646 paroga 2010-10-23 10:36:38 -0700 Created attachment 71646 Patch 298431 2 71646 ddkilzer 2010-10-23 10:57:29 -0700 Comment on attachment 71646 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71646&action=review r- to fix header sort order since this is a cq? patch. > WebCore/platform/win/COMPtr.h:35 > +#include <wtf/Assertions.h> > +#include <wtf/HashTraits.h> > #include <unknwn.h> Nit: <unkwn.h> is alphabetically before <wtf/...h>. Please realphabetize. > WebCore/platform/win/COMPtr.h:-36 > -#include <WTF/Assertions.h> > -#include <WTF/HashTraits.h> Nice catch re: WTF! 298433 3 71648 paroga 2010-10-23 11:05:14 -0700 Created attachment 71648 Patch (In reply to comment #2) > (From update of attachment 71646 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=71646&action=review > > r- to fix header sort order since this is a cq? patch. Why don't you set it to r+ and add a comment about whats needed to be ok? > > WebCore/platform/win/COMPtr.h:35 > > +#include <wtf/Assertions.h> > > +#include <wtf/HashTraits.h> > > #include <unknwn.h> > > Nit: <unkwn.h> is alphabetically before <wtf/...h>. Please realphabetize. Don't we usually add WebKit headers befor external headers? > > WebCore/platform/win/COMPtr.h:-36 > > -#include <WTF/Assertions.h> > > -#include <WTF/HashTraits.h> > > Nice catch re: WTF! It's windows, so not a real problem until we cross compile form e.g. linux. ;-) 298434 4 paroga 2010-10-23 11:08:01 -0700 (In reply to comment #3) > > Nit: <unkwn.h> is alphabetically before <wtf/...h>. Please realphabetize. > Don't we usually add WebKit headers befor external headers? See http://webkit.org/coding/coding-style.html at #include Statements point 4: "Includes of system headers must come after includes of other headers." 298443 5 71648 ddkilzer 2010-10-23 11:42:41 -0700 Comment on attachment 71648 Patch Thanks! r=me 298448 6 commit-queue 2010-10-23 12:38:22 -0700 The commit-queue encountered the following flaky tests while processing attachment 71648: http/tests/xmlhttprequest/remember-bad-password.html java/lc3/JSObject/ToObject-001.html Please file bugs against the tests. The author(s) of the test(s) are ap@webkit.org, ap@webkit.org, and ap@webkit.org. The commit-queue is continuing to process your patch. 298452 7 commit-queue 2010-10-23 13:00:24 -0700 The commit-queue encountered the following flaky tests while processing attachment 71648: http/tests/appcache/remove-cache.html Please file bugs against the tests. The author(s) of the test(s) are ap@webkit.org and ap@webkit.org. The commit-queue is continuing to process your patch. 298453 8 71648 commit-queue 2010-10-23 13:02:22 -0700 Comment on attachment 71648 Patch Clearing flags on attachment: 71648 Committed r70398: <http://trac.webkit.org/changeset/70398> 298454 9 commit-queue 2010-10-23 13:02:26 -0700 All reviewed patches have been landed. Closing bug. 71646 2010-10-23 10:36:38 -0700 2010-10-23 11:05:14 -0700 Patch bug-48190.patch text/plain 1002 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWViNDk4My4uZThkZGI3ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMC0yMyAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbV0lOQ0VdIFBvcnQgQ09NUHRyLmggdG8gV2luQ0UKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4MTkwCisKKyAgICAg ICAgRG9uJ3QgaW5jbHVkZSBndWlkZGVmLmggb24gV2luQ0UuIEl0J3Mgbm90IHJlcXVpcmVkIGFu ZCBvbmx5IGNyZWF0ZXMgYnVpbGQgcHJvYmxlbXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4v Q09NUHRyLmg6CisKIDIwMTAtMTAtMjIgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtp dC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZv cm0vd2luL0NPTVB0ci5oIGIvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ09NUHRyLmgKaW5kZXggNmI4 NDI1Ni4uMDg5YzI5NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ09NUHRyLmgK KysrIGIvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ09NUHRyLmgKQEAgLTMwLDEwICszMCwxMyBAQAog I2RlZmluZSBOT01JTk1BWAogI2VuZGlmCiAKLSNpbmNsdWRlIDxndWlkZGVmLmg+CisjaW5jbHVk ZSA8d3RmL0Fzc2VydGlvbnMuaD4KKyNpbmNsdWRlIDx3dGYvSGFzaFRyYWl0cy5oPgogI2luY2x1 ZGUgPHVua253bi5oPgotI2luY2x1ZGUgPFdURi9Bc3NlcnRpb25zLmg+Ci0jaW5jbHVkZSA8V1RG L0hhc2hUcmFpdHMuaD4KKworI2lmICFPUyhXSU5DRSkKKyNpbmNsdWRlIDxndWlkZGVmLmg+Cisj ZW5kaWYKIAogdHlwZWRlZiBsb25nIEhSRVNVTFQ7CiAK 71648 2010-10-23 11:05:14 -0700 2010-10-23 13:02:22 -0700 Patch bug-48190.patch text/plain 1002 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWViNDk4My4uZThkZGI3ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMC0yMyAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbV0lOQ0VdIFBvcnQgQ09NUHRyLmggdG8gV2luQ0UKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4MTkwCisKKyAgICAg ICAgRG9uJ3QgaW5jbHVkZSBndWlkZGVmLmggb24gV2luQ0UuIEl0J3Mgbm90IHJlcXVpcmVkIGFu ZCBvbmx5IGNyZWF0ZXMgYnVpbGQgcHJvYmxlbXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4v Q09NUHRyLmg6CisKIDIwMTAtMTAtMjIgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtp dC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZv cm0vd2luL0NPTVB0ci5oIGIvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ09NUHRyLmgKaW5kZXggNmI4 NDI1Ni4uOTViNTNhZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ09NUHRyLmgK KysrIGIvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ09NUHRyLmgKQEAgLTMwLDEwICszMCwxMyBAQAog I2RlZmluZSBOT01JTk1BWAogI2VuZGlmCiAKLSNpbmNsdWRlIDxndWlkZGVmLmg+CiAjaW5jbHVk ZSA8dW5rbnduLmg+Ci0jaW5jbHVkZSA8V1RGL0Fzc2VydGlvbnMuaD4KLSNpbmNsdWRlIDxXVEYv SGFzaFRyYWl0cy5oPgorI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CisjaW5jbHVkZSA8d3Rm L0hhc2hUcmFpdHMuaD4KKworI2lmICFPUyhXSU5DRSkKKyNpbmNsdWRlIDxndWlkZGVmLmg+Cisj ZW5kaWYKIAogdHlwZWRlZiBsb25nIEhSRVNVTFQ7CiAK