48187 2010-10-23 08:36:43 -0700 webkit-patch upload fails when the patch removes a file 2010-10-25 15:36:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 48272 1 ddkilzer webkit-unassigned abarth commit-queue eric ojan oldest_to_newest 298403 0 ddkilzer 2010-10-23 08:36:43 -0700 When webkit-patch upload attempts to process a patch that removes a file (for Bug 48186), it fails: $ ./WebKitTools/Scripts/webkit-patch upload -m "Patch v1" --open-bug --suggest-reviewers -g HEAD 48186 Running check-webkit-style Total errors found: 0 in 4 files 3 files to edit Was that diff correct? [Y/n]: y Fetching: https://bugs.webkit.org/show_bug.cgi?id=48186&ctype=xml Failed to run "[u'git', u'log', u'--pretty=format:%H', u'-5', u'/Volumes/Data/WebKit.git/WebKit/mac/WebView/WebHTMLRepresentationInternal.h']" exit_code: 128 fatal: ambiguous argument '/Volumes/Data/WebKit.git/WebKit/mac/WebView/WebHTMLRepresentationInternal.h': unknown revision or path not in the working tree. Use '--' to separate paths from revisions Failed to run "[u'git', u'log', u'--pretty=format:%H', u'-5', u'/Volumes/Data/WebKit.git/WebKit/mac/WebView/WebHTMLRepresentationInternal.h']" exit_code: 128 298411 1 abarth 2010-10-23 09:35:40 -0700 Thanks for the report. We need to add -- before the file names. 298716 2 71713 abarth 2010-10-24 20:51:25 -0700 Created attachment 71713 Patch 298720 3 71713 ddkilzer 2010-10-24 21:10:01 -0700 Comment on attachment 71713 Patch Thanks! r=me 298729 4 71713 commit-queue 2010-10-24 22:30:39 -0700 Comment on attachment 71713 Patch Clearing flags on attachment: 71713 Committed r70437: <http://trac.webkit.org/changeset/70437> 298730 5 commit-queue 2010-10-24 22:30:45 -0700 All reviewed patches have been landed. Closing bug. 71713 2010-10-24 20:51:25 -0700 2010-10-24 22:30:38 -0700 Patch bug-48187-20101024205124.patch text/plain 1423 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwNDMzKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTAtMjQgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICB3ZWJraXQtcGF0Y2ggdXBsb2FkIGZhaWxzIHdoZW4gdGhlIHBhdGNoIHJlbW92ZXMg YSBmaWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 ODE4NworCisgICAgICAgIFdlIG5lZWQgdG8gdXNlICItLSIgdG8gc2VwYXJhdGUgZmlsZSBuYW1l cyBmcm9tIHRoZSByZXN0IG9mIHRoZQorICAgICAgICBjb21tYW5kLgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtLnB5OgorCiAyMDEwLTEwLTI0ICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByNzA0MTMuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9jaGVja291dC9zY20ucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtLnB5CShyZXZpc2lvbiA3MDQwOSkKKysr IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS5weQkod29y a2luZyBjb3B5KQpAQCAtNjY3LDcgKzY2Nyw3IEBAIGNsYXNzIEdpdChTQ00pOgogICAgICAgICBy ZXR1cm4gc2VsZi5fY2hhbmdlc19maWxlc19mb3JfY29tbWl0KGNvbW1pdF9pZCkKIAogICAgIGRl ZiByZXZpc2lvbnNfY2hhbmdpbmdfZmlsZShzZWxmLCBwYXRoLCBsaW1pdD01KToKLSAgICAgICAg Y29tbWl0X2lkcyA9IHNlbGYucnVuKFsiZ2l0IiwgImxvZyIsICItLXByZXR0eT1mb3JtYXQ6JUgi LCAiLSVzIiAlIGxpbWl0LCBwYXRoXSkuc3BsaXRsaW5lcygpCisgICAgICAgIGNvbW1pdF9pZHMg PSBzZWxmLnJ1bihbImdpdCIsICJsb2ciLCAiLS1wcmV0dHk9Zm9ybWF0OiVIIiwgIi0lcyIgJSBs aW1pdCwgIi0tIiwgcGF0aF0pLnNwbGl0bGluZXMoKQogICAgICAgICByZXR1cm4gZmlsdGVyKGxh bWJkYSByZXZpc2lvbjogcmV2aXNpb24sIG1hcChzZWxmLnN2bl9yZXZpc2lvbl9mcm9tX2dpdF9j b21taXQsIGNvbW1pdF9pZHMpKQogCiAgICAgZGVmIGNvbmZsaWN0ZWRfZmlsZXMoc2VsZik6Cg==