48183 2010-10-23 05:59:44 -0700 Add Gradient::hasAlpha 2010-10-23 08:09:00 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 48180 1 paroga paroga commit-queue oldest_to_newest 298376 0 paroga 2010-10-23 05:59:44 -0700 see patch 298377 1 71637 paroga 2010-10-23 06:03:23 -0700 Created attachment 71637 Patch 298383 2 71637 ddkilzer 2010-10-23 07:00:37 -0700 Comment on attachment 71637 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71637&action=review r- due to the for() loop style issue > WebCore/platform/graphics/Gradient.cpp:203 > + for (size_t i = 0; i < m_stops.size(); i++) > + if (m_stops[i].alpha < 1) > + return true; The for loop must have curly braces around it because it's body is more than two lines. 298384 3 71640 paroga 2010-10-23 07:11:32 -0700 Created attachment 71640 Patch 298386 4 71640 ddkilzer 2010-10-23 07:16:29 -0700 Comment on attachment 71640 Patch r=me Thanks! 298394 5 71640 commit-queue 2010-10-23 08:08:56 -0700 Comment on attachment 71640 Patch Clearing flags on attachment: 71640 Committed r70389: <http://trac.webkit.org/changeset/70389> 298396 6 commit-queue 2010-10-23 08:09:00 -0700 All reviewed patches have been landed. Closing bug. 71637 2010-10-23 06:03:23 -0700 2010-10-23 07:11:32 -0700 Patch bug-48183.patch text/plain 1842 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWViNDk4My4uNTU2NzFhNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMC0yMyAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgR3JhZGllbnQ6Omhhc0FscGhhCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODE4MworCisgICAgICAgIFdpbkNF IGNhbiBkbyBzb21lIHBlcmZvcm1hbmNlIGltcHJvdmVtZW50cyBpZiB0aGUgZ3JhZGllbnQgaXMg b3BhcXVlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhZGllbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6R3JhZGllbnQ6Omhhc0FscGhhKToKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9HcmFkaWVudC5oOgorCiAyMDEwLTEwLTIyICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBh cm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuCmRpZmYgLS1naXQgYS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvR3JhZGllbnQuY3BwCmluZGV4IDhiYzliM2YuLjJjNTIxMmMgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhZGllbnQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvR3JhZGllbnQuY3BwCkBAIC0xOTYsNiArMTk2LDE1IEBAIGludCBHcmFkaWVu dDo6ZmluZFN0b3AoZmxvYXQgdmFsdWUpIGNvbnN0CiAgICAgcmV0dXJuIG1fbGFzdFN0b3A7CiB9 CiAKK2Jvb2wgR3JhZGllbnQ6Omhhc0FscGhhKCkgY29uc3QKK3sKKyAgICBmb3IgKHNpemVfdCBp ID0gMDsgaSA8IG1fc3RvcHMuc2l6ZSgpOyBpKyspCisgICAgICAgIGlmIChtX3N0b3BzW2ldLmFs cGhhIDwgMSkKKyAgICAgICAgICAgIHJldHVybiB0cnVlOworCisgICAgcmV0dXJuIGZhbHNlOwor fQorCiB2b2lkIEdyYWRpZW50OjpzZXRTcHJlYWRNZXRob2QoR3JhZGllbnRTcHJlYWRNZXRob2Qg c3ByZWFkTWV0aG9kKQogewogICAgIC8vIEZJWE1FOiBTaG91bGQgaXQgYmVjb21lIG5lY2Vzc2Fy eSwgYWxsb3cgY2FsbHMgdG8gdGhpcyBtZXRob2QgYWZ0ZXIgbV9ncmFkaWVudCBoYXMgYmVlbiBz ZXQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50LmggYi9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50LmgKaW5kZXggNmZhZDgxMC4uMTM2NTQw NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVudC5oCisrKyBi L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhZGllbnQuaApAQCAtODcsNiArODcsNyBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZvaWQgYWRkQ29sb3JTdG9wKGZsb2F0LCBjb25z dCBDb2xvciYpOwogCiAgICAgICAgIHZvaWQgZ2V0Q29sb3IoZmxvYXQgdmFsdWUsIGZsb2F0KiBy LCBmbG9hdCogZywgZmxvYXQqIGIsIGZsb2F0KiBhKSBjb25zdDsKKyAgICAgICAgYm9vbCBoYXNB bHBoYSgpIGNvbnN0OwogCiAgICAgICAgIGJvb2wgaXNSYWRpYWwoKSBjb25zdCB7IHJldHVybiBt X3JhZGlhbDsgfQogICAgICAgICBib29sIGlzWmVyb1NpemUoKSBjb25zdCB7IHJldHVybiBtX3Aw LngoKSA9PSBtX3AxLngoKSAmJiBtX3AwLnkoKSA9PSBtX3AxLnkoKSAmJiAoIW1fcmFkaWFsIHx8 IG1fcjAgPT0gbV9yMSk7IH0K 71640 2010-10-23 07:11:32 -0700 2010-10-23 08:08:56 -0700 Patch bug-48183.patch text/plain 1851 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWViNDk4My4uNTU2NzFhNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMC0yMyAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgR3JhZGllbnQ6Omhhc0FscGhhCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODE4MworCisgICAgICAgIFdpbkNF IGNhbiBkbyBzb21lIHBlcmZvcm1hbmNlIGltcHJvdmVtZW50cyBpZiB0aGUgZ3JhZGllbnQgaXMg b3BhcXVlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhZGllbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6R3JhZGllbnQ6Omhhc0FscGhhKToKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9HcmFkaWVudC5oOgorCiAyMDEwLTEwLTIyICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBh cm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuCmRpZmYgLS1naXQgYS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvR3JhZGllbnQuY3BwCmluZGV4IDhiYzliM2YuLjJjNTIxMmMgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhZGllbnQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvR3JhZGllbnQuY3BwCkBAIC0xOTYsNiArMTk2LDE2IEBAIGludCBHcmFkaWVu dDo6ZmluZFN0b3AoZmxvYXQgdmFsdWUpIGNvbnN0CiAgICAgcmV0dXJuIG1fbGFzdFN0b3A7CiB9 CiAKK2Jvb2wgR3JhZGllbnQ6Omhhc0FscGhhKCkgY29uc3QKK3sKKyAgICBmb3IgKHNpemVfdCBp ID0gMDsgaSA8IG1fc3RvcHMuc2l6ZSgpOyBpKyspIHsKKyAgICAgICAgaWYgKG1fc3RvcHNbaV0u YWxwaGEgPCAxKQorICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfQorCisgICAgcmV0dXJu IGZhbHNlOworfQorCiB2b2lkIEdyYWRpZW50OjpzZXRTcHJlYWRNZXRob2QoR3JhZGllbnRTcHJl YWRNZXRob2Qgc3ByZWFkTWV0aG9kKQogewogICAgIC8vIEZJWE1FOiBTaG91bGQgaXQgYmVjb21l IG5lY2Vzc2FyeSwgYWxsb3cgY2FsbHMgdG8gdGhpcyBtZXRob2QgYWZ0ZXIgbV9ncmFkaWVudCBo YXMgYmVlbiBzZXQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYWRp ZW50LmggYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50LmgKaW5kZXggNmZhZDgx MC4uMTM2NTQwNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVu dC5oCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhZGllbnQuaApAQCAtODcsNiAr ODcsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZvaWQgYWRkQ29sb3JTdG9wKGZs b2F0LCBjb25zdCBDb2xvciYpOwogCiAgICAgICAgIHZvaWQgZ2V0Q29sb3IoZmxvYXQgdmFsdWUs IGZsb2F0KiByLCBmbG9hdCogZywgZmxvYXQqIGIsIGZsb2F0KiBhKSBjb25zdDsKKyAgICAgICAg Ym9vbCBoYXNBbHBoYSgpIGNvbnN0OwogCiAgICAgICAgIGJvb2wgaXNSYWRpYWwoKSBjb25zdCB7 IHJldHVybiBtX3JhZGlhbDsgfQogICAgICAgICBib29sIGlzWmVyb1NpemUoKSBjb25zdCB7IHJl dHVybiBtX3AwLngoKSA9PSBtX3AxLngoKSAmJiBtX3AwLnkoKSA9PSBtX3AxLnkoKSAmJiAoIW1f cmFkaWFsIHx8IG1fcjAgPT0gbV9yMSk7IH0K