48180 2010-10-23 04:38:49 -0700 [WINCE] Rename SharedBitmap::createInstance to SharedBitmap::create 2010-10-23 12:01:35 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 48183 1 paroga paroga aroben commit-queue ddkilzer oldest_to_newest 298368 0 paroga 2010-10-23 04:38:49 -0700 see patch 298369 1 71634 paroga 2010-10-23 04:45:11 -0700 Created attachment 71634 Patch New new create function are: PassRefPtr<SharedBitmap> SharedBitmap::create(const IntSize& size, BitmapInfo::BitCount bitCount, bool initPixels) PassRefPtr<SharedBitmap> SharedBitmap::create(const Vector<unsigned>& data, const IntSize& size, bool hasAlpha) 298390 2 ddkilzer 2010-10-23 07:25:46 -0700 Where are the SharedBitmap::create() methods defined? I don't see SharedBitmap.h in the tree. (Has it not been upstreamed yet?) 298406 3 paroga 2010-10-23 09:24:43 -0700 (In reply to comment #2) > Where are the SharedBitmap::create() methods defined? I don't see SharedBitmap.h in the tree. (Has it not been upstreamed yet?) It's not upstreamed yet and I want to upream it with the correct name of the create-function: see bug 28272 for SharedBitmap 298426 4 71634 ddkilzer 2010-10-23 10:41:53 -0700 Comment on attachment 71634 Patch Thanks! r=me 298427 5 71634 commit-queue 2010-10-23 10:43:26 -0700 Comment on attachment 71634 Patch Rejecting patch 71634 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 71634]" exit_code: 2 Last 500 characters of output: 3 (offset -8 lines). Hunk #3 succeeded at 1777 (offset -17 lines). patching file WebCore/platform/graphics/wince/ImageBufferWinCE.cpp Hunk #1 succeeded at 64 (offset -1 lines). patching file WebCore/platform/graphics/wince/ImageWinCE.cpp Hunk #1 FAILED at 43. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/platform/graphics/wince/ImageWinCE.cpp.rej Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'David Kilzer', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/4708040 298444 6 71634 paroga 2010-10-23 12:01:20 -0700 Comment on attachment 71634 Patch Clearing flags on attachment: 71634 Manually committed r70397: <http://trac.webkit.org/changeset/70397> 298445 7 paroga 2010-10-23 12:01:35 -0700 All reviewed patches have been landed. Closing bug. 71634 2010-10-23 04:45:11 -0700 2010-10-23 12:01:20 -0700 Patch bug-48180.patch text/plain 4476 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWViNDk4My4uMTFmOGE4NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0xMC0yMyAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbV0lOQ0VdIFJlbmFtZSBTaGFyZWRCaXRtYXA6OmNyZWF0ZUlu c3RhbmNlIHRvIFNoYXJlZEJpdG1hcDo6Y3JlYXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODE4MAorCisgICAgICAgIEFsc28gdXNlIGJldHRlciBh cmd1bWVudHMgZm9yIHRoZSBjcmVhdGUgZnVuY3Rpb24uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy93aW5jZS9HcmFwaGljc0NvbnRleHRXaW5DRS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpHcmFwaGljc0NvbnRleHRQbGF0Zm9ybVByaXZhdGU6OmdldFRyYW5zcGFyZW50TGF5ZXJCaXRt YXApOgorICAgICAgICAoV2ViQ29yZTo6VHJhbnNwYXJlbnRMYXllckRDOjpUcmFuc3BhcmVudExh eWVyREMpOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpkcmF3RnJhbWVDb250 cm9sKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW5jZS9JbWFnZUJ1ZmZlcldpbkNF LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlQnVmZmVyRGF0YTo6SW1hZ2VCdWZmZXJEYXRh KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW5jZS9JbWFnZVdpbkNFLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJHQkEzMkJ1ZmZlcjo6YXNOZXdOYXRpdmVJbWFnZSk6CisKIDIwMTAt MTAtMjIgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAg VW5yZXZpZXdlZC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luY2Uv R3JhcGhpY3NDb250ZXh0V2luQ0UuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW5j ZS9HcmFwaGljc0NvbnRleHRXaW5DRS5jcHAKaW5kZXggMTJiN2I5Zi4uNDE0YTNiNCAxMDA2NDQK LS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW5jZS9HcmFwaGljc0NvbnRleHRXaW5D RS5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW5jZS9HcmFwaGljc0NvbnRl eHRXaW5DRS5jcHAKQEAgLTI4NCw3ICsyODQsNyBAQCBwdWJsaWM6CiAgICAgICAgICAgICAgICAg ICAgIHJldHVybiAwOwogICAgICAgICAgICAgfQogCi0gICAgICAgICAgICBSZWZQdHI8U2hhcmVk Qml0bWFwPiBibXAgPSBTaGFyZWRCaXRtYXA6OmNyZWF0ZUluc3RhbmNlKGFscGhhUGFpbnQgPT0g QWxwaGFQYWludE5vbmUsIG9yaWdSZWN0LndpZHRoKCksIG9yaWdSZWN0LmhlaWdodCgpLCBmYWxz ZSk7CisgICAgICAgICAgICBSZWZQdHI8U2hhcmVkQml0bWFwPiBibXAgPSBTaGFyZWRCaXRtYXA6 OmNyZWF0ZShvcmlnUmVjdC5zaXplKCksIGFscGhhUGFpbnQgPT0gQWxwaGFQYWludE5vbmUgPyBC aXRtYXBJbmZvOjpCaXRDb3VudDE2IDogQml0bWFwSW5mbzo6Qml0Q291bnQzMiwgZmFsc2UpOwog ICAgICAgICAgICAgU2V0UmVjdCgmYm1wUmVjdCwgMCwgMCwgb3JpZ1JlY3Qud2lkdGgoKSwgb3Jp Z1JlY3QuaGVpZ2h0KCkpOwogICAgICAgICAgICAgaWYgKGJtcCkgewogICAgICAgICAgICAgICAg IHN3aXRjaCAoYWxwaGFQYWludCkgewpAQCAtNTMxLDcgKzUzMSw3IEBAIFRyYW5zcGFyZW50TGF5 ZXJEQzo6VHJhbnNwYXJlbnRMYXllckRDKEdyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZSog ZGF0YSwgSW50CiAgICAgICAgICAgICBvcmlnUmVjdC5pbmZsYXRlWChzdGFibGVSb3VuZCgod2lk dGggLSBvcmlnUmVjdC53aWR0aCgpKSAqIDAuNSkpOwogICAgICAgICAgICAgb3JpZ1JlY3QuaW5m bGF0ZVkoc3RhYmxlUm91bmQoKGhlaWdodCAtIG9yaWdSZWN0LmhlaWdodCgpKSAqIDAuNSkpOwog Ci0gICAgICAgICAgICBtX2JpdG1hcCA9IFNoYXJlZEJpdG1hcDo6Y3JlYXRlSW5zdGFuY2UobV9y b3RhdGVkQml0bWFwLT5pczE2Yml0KCksIG1fb3JpZ1JlY3Qud2lkdGgoKSwgbV9vcmlnUmVjdC5o ZWlnaHQoKSwgdHJ1ZSk7CisgICAgICAgICAgICBtX2JpdG1hcCA9IFNoYXJlZEJpdG1hcDo6Y3Jl YXRlKG1fb3JpZ1JlY3Quc2l6ZSgpLCBtX3JvdGF0ZWRCaXRtYXAtPmlzMTZiaXQoKSA/IEJpdG1h cEluZm86OkJpdENvdW50MTYgOiBCaXRtYXBJbmZvOjpCaXRDb3VudDMyLCB0cnVlKTsKICAgICAg ICAgICAgIGlmIChtX2JpdG1hcCkKICAgICAgICAgICAgICAgICByb3RhdGVCaXRtYXAobV9iaXRt YXAuZ2V0KCksIG1fcm90YXRlZEJpdG1hcC5nZXQoKSwgLW1fcm90YXRpb24pOwogICAgICAgICAg ICAgZWxzZQpAQCAtMTc5NCw3ICsxNzk0LDcgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OmRyYXdG cmFtZUNvbnRyb2woY29uc3QgSW50UmVjdCYgcmVjdCwgdW5zaWduZWQgdHlwZSwgdW5zaWcKICAg ICBSRUNUIHJlY3RXaW4gPSB0clJlY3Q7CiAKICAgICBpZiAoKHJlY3RXaW4ucmlnaHQgLSByZWN0 V2luLmxlZnQpIDwgYm94V2lkdGhCZXN0KSB7Ci0gICAgICAgIFJlZlB0cjxTaGFyZWRCaXRtYXA+ IGJtcCA9IFNoYXJlZEJpdG1hcDo6Y3JlYXRlSW5zdGFuY2UodHJ1ZSwgYm94V2lkdGhCZXN0LCBi b3hIZWlnaHRCZXN0LCB0cnVlKTsKKyAgICAgICAgUmVmUHRyPFNoYXJlZEJpdG1hcD4gYm1wID0g U2hhcmVkQml0bWFwOjpjcmVhdGUoSW50U2l6ZShib3hXaWR0aEJlc3QsIGJveEhlaWdodEJlc3Qp LCBCaXRtYXBJbmZvOjpCaXRDb3VudDE2LCB0cnVlKTsKICAgICAgICAgU2hhcmVkQml0bWFwOjpE Q0hvbGRlciBtZW1EQyhibXAuZ2V0KCkpOwogICAgICAgICBpZiAobWVtREMuZ2V0KCkpIHsKICAg ICAgICAgICAgIFJFQ1QgdGVtcFJlY3QgPSB7MCwgMCwgYm94V2lkdGhCZXN0LCBib3hIZWlnaHRC ZXN0fTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luY2UvSW1hZ2VC dWZmZXJXaW5DRS5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbmNlL0ltYWdlQnVm ZmVyV2luQ0UuY3BwCmluZGV4IGY0NDQwZjEuLmQ2NjE1Y2QgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvd2luY2UvSW1hZ2VCdWZmZXJXaW5DRS5jcHAKKysrIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy93aW5jZS9JbWFnZUJ1ZmZlcldpbkNFLmNwcApAQCAtNjUsNyAr NjUsNyBAQCB2b2lkIEJ1ZmZlcmVkSW1hZ2U6OmRyYXdQYXR0ZXJuKEdyYXBoaWNzQ29udGV4dCog Y3R4dCwgY29uc3QgRmxvYXRSZWN0JiB0aWxlUmVjdAogfQogCiBJbWFnZUJ1ZmZlckRhdGE6Oklt YWdlQnVmZmVyRGF0YShjb25zdCBJbnRTaXplJiBzaXplKQotOiBtX2JpdG1hcChTaGFyZWRCaXRt YXA6OmNyZWF0ZUluc3RhbmNlKGZhbHNlLCBzaXplLndpZHRoKCksIHNpemUuaGVpZ2h0KCksIGZh bHNlKSkKKyAgICA6IG1fYml0bWFwKFNoYXJlZEJpdG1hcDo6Y3JlYXRlKHNpemUsIEJpdG1hcElu Zm86OkJpdENvdW50MzIsIGZhbHNlKSkKIHsKICAgICAvLyBodHRwOi8vd3d3LnczLm9yZy9UUi8y MDA5L1dELWh0bWw1LTIwMDkwMjEyL3RoZS1jYW52YXMtZWxlbWVudC5odG1sI2NhbnZhc3BpeGVs YXJyYXkKICAgICAvLyAiV2hlbiB0aGUgY2FudmFzIGlzIGluaXRpYWxpemVkIGl0IG11c3QgYmUg c2V0IHRvIGZ1bGx5IHRyYW5zcGFyZW50IGJsYWNrLiIKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvd2luY2UvSW1hZ2VXaW5DRS5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3dpbmNlL0ltYWdlV2luQ0UuY3BwCmluZGV4IDU1ZjFlYzcuLmVjNzQwM2UgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luY2UvSW1hZ2VXaW5DRS5jcHAKKysr IGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW5jZS9JbWFnZVdpbkNFLmNwcApAQCAtNDMs MTIgKzQzLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBOYXRpdmVJbWFnZVB0ciBSR0JBMzJC dWZmZXI6OmFzTmV3TmF0aXZlSW1hZ2UoKSBjb25zdAogewotICAgIE5hdGl2ZUltYWdlUHRyIGlt YWdlID0gU2hhcmVkQml0bWFwOjpjcmVhdGVJbnN0YW5jZShmYWxzZSwgd2lkdGgoKSwgaGVpZ2h0 KCksIGZhbHNlKTsKLQotICAgIG1lbWNweShpbWFnZS0+Ynl0ZXMoKSwgbV9ieXRlcy5kYXRhKCks IG1fYnl0ZXMuc2l6ZSgpICogc2l6ZW9mKFBpeGVsRGF0YSkpOwotICAgIGltYWdlLT5zZXRIYXNB bHBoYSh0cnVlKTsKLQotICAgIHJldHVybiBpbWFnZTsKKyAgICByZXR1cm4gU2hhcmVkQml0bWFw OjpjcmVhdGUobV9ieXRlcywgbV9zaXplLCBoYXNBbHBoYSgpKTsKIH0KIAogYm9vbCBGcmFtZURh dGE6OmNsZWFyKGJvb2wgY2xlYXJNZXRhRGF0YSkK