48177 2010-10-23 01:38:12 -0700 Expose sendChangeEvent parameter in WebInputElement::setValue() API 2010-11-02 13:30:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 isherman isherman commit-queue darin dglazkov fishd isherman levin rniwa tkent webkit.review.bot oldest_to_newest 298351 0 isherman 2010-10-23 01:38:12 -0700 The Chromium API is missing the second parameter for WebInputElement::setValue(), which is a boolean value controlling whether or not to send an onChange() JS event. We want to be able to send the onChange() event for form autofill; but this is not possible with the current API. 298352 1 71630 isherman 2010-10-23 01:52:35 -0700 Created attachment 71630 Patch 298353 2 isherman 2010-10-23 01:56:12 -0700 My thinking is to have both versions of setValue() temporarily. Once Chromium code is updated (which I will do once this patch lands), I'll post a new WebKit patch to remove the single-parameter version of setValue(). 298354 3 webkit.review.bot 2010-10-23 01:56:22 -0700 Attachment 71630 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/chromium/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 298356 4 71631 isherman 2010-10-23 01:59:10 -0700 Created attachment 71631 Patch 301530 5 71631 tkent 2010-10-28 18:52:17 -0700 Comment on attachment 71631 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71631&action=review > WebKit/chromium/public/WebInputElement.h:69 > + WEBKIT_API void setValue(const WebString&); // TODO(isherman): Remove once chromium code is updated. We use some default arguments in WebKit API. WebKit/chromium/public/WebCursorInfo.h: explicit WebCursorInfo(Type type = TypePointer) WebKit/chromium/public/WebFrame.h: bool replace = false) = 0; WebKit/chromium/public/WebFrame.h: bool replace = false) = 0; WebKit/chromium/public/WebFrame.h: virtual int printBegin(const WebSize& pageSize, int printerDPI = 72, WebKit/chromium/public/WebFrame.h: bool* useBrowserOverlays = 0) = 0; WebKit/chromium/public/WebInputEvent.h: WebKeyboardEvent(unsigned sizeParam = sizeof(WebKeyboardEvent)) WebKit/chromium/public/WebInputEvent.h: WebMouseEvent(unsigned sizeParam = sizeof(WebMouseEvent)) WebKit/chromium/public/WebInputEvent.h: WebMouseWheelEvent(unsigned sizeParam = sizeof(WebMouseWheelEvent)) WebKit/chromium/public/WebInputEvent.h: WebTouchEvent(unsigned sizeParam = sizeof(WebTouchEvent)) WebKit/chromium/public/WebVector.h: explicit WebVector(size_t size = 0) It might be ok to use default argument though Chromium style doesn't allow it. I'm not 100% sure. 301592 6 isherman 2010-10-28 23:03:48 -0700 (In reply to comment #5) > (From update of attachment 71631 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=71631&action=review > > > WebKit/chromium/public/WebInputElement.h:69 > > + WEBKIT_API void setValue(const WebString&); // TODO(isherman): Remove once chromium code is updated. > > We use some default arguments in WebKit API. > It might be ok to use default argument though Chromium style doesn't allow it. I'm not 100% sure. I'm not really opposed to using a default argument here -- I was just trying to stay consistent with Chromium style =) What say ye, wise guardians of the Chromium WebKit API? 302862 7 71631 fishd 2010-11-01 13:09:28 -0700 Comment on attachment 71631 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71631&action=review > WebKit/chromium/public/WebInputElement.h:70 > + WEBKIT_API void setValue(const WebString&, bool); yes, please use a default argument. also, please give this "bool" parameter a name. 302882 8 72547 isherman 2010-11-01 13:27:06 -0700 Created attachment 72547 Addresses Darin's review comments Done and done =) 302921 9 72547 tkent 2010-11-01 14:14:22 -0700 Comment on attachment 72547 Addresses Darin's review comments View in context: https://bugs.webkit.org/attachment.cgi?id=72547&action=review > WebKit/chromium/ChangeLog:5 > + Expose |sendChangeEvent| parameter in WebInputElement::setValue() API, nit: we don't enclose a parameter name with || in WebKit style. 302958 10 72567 isherman 2010-11-01 14:50:33 -0700 Created attachment 72567 Patch 303601 11 commit-queue 2010-11-02 13:11:50 -0700 The commit-queue encountered the following flaky tests while processing attachment 72567: http/tests/appcache/fail-on-update-2.html animations/suspend-resume-animation.html Please file bugs against the tests. These tests were authored by ap@webkit.org and cmarrin@apple.com. The commit-queue is continuing to process your patch. 303610 12 72567 commit-queue 2010-11-02 13:30:48 -0700 Comment on attachment 72567 Patch Clearing flags on attachment: 72567 Committed r71158: <http://trac.webkit.org/changeset/71158> 303611 13 commit-queue 2010-11-02 13:30:55 -0700 All reviewed patches have been landed. Closing bug. 71630 2010-10-23 01:52:35 -0700 2010-10-23 01:59:07 -0700 Patch bug-48177-20101023015234.patch text/plain 2266 isherman ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGYwZmNkNTY3OGFjOWYyMjM4OTBiNDg5OGVmNjhlMzczYzljNDBiMjcu Ljk4ZDBkNDJmNWUxZWRmNDdiYzQ0ZDk3NjI2ZjNkNDFkNTIxYjgwNGMgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEwLTEwLTIzICBJbHlhIFNoZXJtYW4gIDxpc2hlcm1hbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRXhwb3NlIHxzZW5kQ2hhbmdlRXZlbnR8IHBhcmFtZXRlciBpbiBXZWJJbnB1dEVsZW1lbnQ6 OnNldFZhbHVlKCkgQVBJLAorCXByaW1hcmlseSBzbyB0aGF0IGNocm9taXVtIGZvcm0gYXV0b2Zp bGwgY2FuIGZpcmUgdGhlIG9uQ2hhbmdlIGV2ZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDgxNzcKKworICAgICAgICAqIHB1YmxpYy9XZWJJbnB1 dEVsZW1lbnQuaDoKKyAgICAgICAgKiBzcmMvV2ViSW5wdXRFbGVtZW50LmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViSW5wdXRFbGVtZW50OjpzZXRWYWx1ZSk6CisKIDIwMTAtMTAtMjIgIEpheSBD aXZlbGxpICA8amNpdmVsbGlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh dmlkIExldmluLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEVs ZW1lbnQuaCBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFbGVtZW50LmgKaW5kZXgg OGZlYTRmYTkzZTI4ZWJmMDJmMTA5YWZkZjExNDdiZTA3OTA1NTU4Ni4uMTUzMDlhZTUyYWE1YTI5 NDVjZjFjODg0MWFjMWRmM2RjZTY1MjdlYSAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJJbnB1dEVsZW1lbnQuaAorKysgYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklu cHV0RWxlbWVudC5oCkBAIC02Niw3ICs2Niw4IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogICAgICAg ICBXRUJLSVRfQVBJIGJvb2wgaXNBY3RpdmF0ZWRTdWJtaXQoKSBjb25zdDsKICAgICAgICAgV0VC S0lUX0FQSSB2b2lkIHNldEFjdGl2YXRlZFN1Ym1pdChib29sKTsKICAgICAgICAgV0VCS0lUX0FQ SSBpbnQgc2l6ZSgpIGNvbnN0OwotICAgICAgICBXRUJLSVRfQVBJIHZvaWQgc2V0VmFsdWUoY29u c3QgV2ViU3RyaW5nJik7CisgICAgICAgIFdFQktJVF9BUEkgdm9pZCBzZXRWYWx1ZShjb25zdCBX ZWJTdHJpbmcmKTsgLy8gVE9ETyhpc2hlcm1hbik6IFJlbW92ZSBvbmNlIGNocm9taXVtIGNvZGUg aXMgdXBkYXRlZC4KKyAgICAgICAgV0VCS0lUX0FQSSB2b2lkIHNldFZhbHVlKGNvbnN0IFdlYlN0 cmluZyYsIGJvb2wpOwogICAgICAgICBXRUJLSVRfQVBJIFdlYlN0cmluZyB2YWx1ZSgpIGNvbnN0 OwogICAgICAgICBXRUJLSVRfQVBJIHZvaWQgc2V0U3VnZ2VzdGVkVmFsdWUoY29uc3QgV2ViU3Ry aW5nJik7CiAgICAgICAgIFdFQktJVF9BUEkgV2ViU3RyaW5nIHN1Z2dlc3RlZFZhbHVlKCkgY29u c3Q7CmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RWxlbWVudC5jcHAg Yi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RWxlbWVudC5jcHAKaW5kZXggNzc3OWRiYzNj YTRjYzc5OTQ2MzQwOTkwZGUyOWVkM2JhMTU0ZGVlZS4uYjc0NmFlYmM0MWRkODUyOWNkY2M1NmMz YTAxM2Y4MGQ3ZjVkODM0YyAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1 dEVsZW1lbnQuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFbGVtZW50LmNw cApAQCAtMTAwLDYgKzEwMCwxMSBAQCB2b2lkIFdlYklucHV0RWxlbWVudDo6c2V0VmFsdWUoY29u c3QgV2ViU3RyaW5nJiB2YWx1ZSkKICAgICB1bndyYXA8SFRNTElucHV0RWxlbWVudD4oKS0+c2V0 VmFsdWUodmFsdWUpOwogfQogCit2b2lkIFdlYklucHV0RWxlbWVudDo6c2V0VmFsdWUoY29uc3Qg V2ViU3RyaW5nJiB2YWx1ZSwgYm9vbCBzZW5kQ2hhbmdlRXZlbnQpCit7CisgICAgdW53cmFwPEhU TUxJbnB1dEVsZW1lbnQ+KCktPnNldFZhbHVlKHZhbHVlLCBzZW5kQ2hhbmdlRXZlbnQpOworfQor CiBXZWJTdHJpbmcgV2ViSW5wdXRFbGVtZW50Ojp2YWx1ZSgpIGNvbnN0CiB7CiAgICAgcmV0dXJu IGNvbnN0VW53cmFwPEhUTUxJbnB1dEVsZW1lbnQ+KCktPnZhbHVlKCk7Cg== 71631 2010-10-23 01:59:10 -0700 2010-11-01 13:27:02 -0700 Patch bug-48177-20101023015909.patch text/plain 2273 isherman ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGYwZmNkNTY3OGFjOWYyMjM4OTBiNDg5OGVmNjhlMzczYzljNDBiMjcu LjcyZjFmODk1NmI5NDAzYTI1NzgyZjllNDdlZmM4NDI5Mjc3NjU1NGIgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEwLTEwLTIzICBJbHlhIFNoZXJtYW4gIDxpc2hlcm1hbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRXhwb3NlIHxzZW5kQ2hhbmdlRXZlbnR8IHBhcmFtZXRlciBpbiBXZWJJbnB1dEVsZW1lbnQ6 OnNldFZhbHVlKCkgQVBJLAorICAgICAgICBwcmltYXJpbHkgc28gdGhhdCBjaHJvbWl1bSBmb3Jt IGF1dG9maWxsIGNhbiBmaXJlIHRoZSBvbkNoYW5nZSBldmVudC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4MTc3CisKKyAgICAgICAgKiBwdWJsaWMv V2ViSW5wdXRFbGVtZW50Lmg6CisgICAgICAgICogc3JjL1dlYklucHV0RWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYklucHV0RWxlbWVudDo6c2V0VmFsdWUpOgorCiAyMDEwLTEwLTIy ICBKYXkgQ2l2ZWxsaSAgPGpjaXZlbGxpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYXZpZCBMZXZpbi4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi SW5wdXRFbGVtZW50LmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklucHV0RWxlbWVudC5o CmluZGV4IDhmZWE0ZmE5M2UyOGViZjAyZjEwOWFmZGYxMTQ3YmUwNzkwNTU1ODYuLjE1MzA5YWU1 MmFhNWEyOTQ1Y2YxYzg4NDFhYzFkZjNkY2U2NTI3ZWEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViSW5wdXRFbGVtZW50LmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJJbnB1dEVsZW1lbnQuaApAQCAtNjYsNyArNjYsOCBAQCBuYW1lc3BhY2UgV2ViS2l0IHsK ICAgICAgICAgV0VCS0lUX0FQSSBib29sIGlzQWN0aXZhdGVkU3VibWl0KCkgY29uc3Q7CiAgICAg ICAgIFdFQktJVF9BUEkgdm9pZCBzZXRBY3RpdmF0ZWRTdWJtaXQoYm9vbCk7CiAgICAgICAgIFdF QktJVF9BUEkgaW50IHNpemUoKSBjb25zdDsKLSAgICAgICAgV0VCS0lUX0FQSSB2b2lkIHNldFZh bHVlKGNvbnN0IFdlYlN0cmluZyYpOworICAgICAgICBXRUJLSVRfQVBJIHZvaWQgc2V0VmFsdWUo Y29uc3QgV2ViU3RyaW5nJik7IC8vIFRPRE8oaXNoZXJtYW4pOiBSZW1vdmUgb25jZSBjaHJvbWl1 bSBjb2RlIGlzIHVwZGF0ZWQuCisgICAgICAgIFdFQktJVF9BUEkgdm9pZCBzZXRWYWx1ZShjb25z dCBXZWJTdHJpbmcmLCBib29sKTsKICAgICAgICAgV0VCS0lUX0FQSSBXZWJTdHJpbmcgdmFsdWUo KSBjb25zdDsKICAgICAgICAgV0VCS0lUX0FQSSB2b2lkIHNldFN1Z2dlc3RlZFZhbHVlKGNvbnN0 IFdlYlN0cmluZyYpOwogICAgICAgICBXRUJLSVRfQVBJIFdlYlN0cmluZyBzdWdnZXN0ZWRWYWx1 ZSgpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEVsZW1l bnQuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEVsZW1lbnQuY3BwCmluZGV4IDc3 NzlkYmMzY2E0Y2M3OTk0NjM0MDk5MGRlMjllZDNiYTE1NGRlZWUuLmI3NDZhZWJjNDFkZDg1Mjlj ZGNjNTZjM2EwMTNmODBkN2Y1ZDgzNGMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViSW5wdXRFbGVtZW50LmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RWxl bWVudC5jcHAKQEAgLTEwMCw2ICsxMDAsMTEgQEAgdm9pZCBXZWJJbnB1dEVsZW1lbnQ6OnNldFZh bHVlKGNvbnN0IFdlYlN0cmluZyYgdmFsdWUpCiAgICAgdW53cmFwPEhUTUxJbnB1dEVsZW1lbnQ+ KCktPnNldFZhbHVlKHZhbHVlKTsKIH0KIAordm9pZCBXZWJJbnB1dEVsZW1lbnQ6OnNldFZhbHVl KGNvbnN0IFdlYlN0cmluZyYgdmFsdWUsIGJvb2wgc2VuZENoYW5nZUV2ZW50KQoreworICAgIHVu d3JhcDxIVE1MSW5wdXRFbGVtZW50PigpLT5zZXRWYWx1ZSh2YWx1ZSwgc2VuZENoYW5nZUV2ZW50 KTsKK30KKwogV2ViU3RyaW5nIFdlYklucHV0RWxlbWVudDo6dmFsdWUoKSBjb25zdAogewogICAg IHJldHVybiBjb25zdFVud3JhcDxIVE1MSW5wdXRFbGVtZW50PigpLT52YWx1ZSgpOwo= 72547 2010-11-01 13:27:06 -0700 2010-11-01 14:50:29 -0700 Addresses Darin's review comments bug-48177-20101101132705.patch text/plain 2216 isherman ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGZmNTA5YTlmYjYxZWJiZmE4Y2M0OWFlY2IxZGU2ZDRmMDJkNTg5ZDku LjQ4NTUyZjdlYWZiMTUxMWVhYWEzOTBlZmEzNDM2YTI3ZjVmOGI4OTMgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEwLTEwLTIzICBJbHlhIFNoZXJtYW4gIDxpc2hlcm1hbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRXhwb3NlIHxzZW5kQ2hhbmdlRXZlbnR8IHBhcmFtZXRlciBpbiBXZWJJbnB1dEVsZW1lbnQ6 OnNldFZhbHVlKCkgQVBJLAorICAgICAgICBwcmltYXJpbHkgc28gdGhhdCBjaHJvbWl1bSBmb3Jt IGF1dG9maWxsIGNhbiBmaXJlIHRoZSBvbkNoYW5nZSBldmVudC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4MTc3CisKKyAgICAgICAgKiBwdWJsaWMv V2ViSW5wdXRFbGVtZW50Lmg6CisgICAgICAgICogc3JjL1dlYklucHV0RWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYklucHV0RWxlbWVudDo6c2V0VmFsdWUpOgorCiAyMDEwLTExLTAx ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBbmRlcnMgQ2FybHNzb24uCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YklucHV0RWxlbWVudC5oIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQu aAppbmRleCA4ZmVhNGZhOTNlMjhlYmYwMmYxMDlhZmRmMTE0N2JlMDc5MDU1NTg2Li5kMGRmMDc5 MTQwNjQxNTlhMGU5NTY5MDliYzQ3MzIxN2Y5NWEwNDgwIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYklucHV0RWxlbWVudC5oCisrKyBiL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViSW5wdXRFbGVtZW50LmgKQEAgLTY2LDcgKzY2LDcgQEAgbmFtZXNwYWNlIFdlYktpdCB7 CiAgICAgICAgIFdFQktJVF9BUEkgYm9vbCBpc0FjdGl2YXRlZFN1Ym1pdCgpIGNvbnN0OwogICAg ICAgICBXRUJLSVRfQVBJIHZvaWQgc2V0QWN0aXZhdGVkU3VibWl0KGJvb2wpOwogICAgICAgICBX RUJLSVRfQVBJIGludCBzaXplKCkgY29uc3Q7Ci0gICAgICAgIFdFQktJVF9BUEkgdm9pZCBzZXRW YWx1ZShjb25zdCBXZWJTdHJpbmcmKTsKKyAgICAgICAgV0VCS0lUX0FQSSB2b2lkIHNldFZhbHVl KGNvbnN0IFdlYlN0cmluZyYsIGJvb2wgc2VuZENoYW5nZUV2ZW50ID0gZmFsc2UpOwogICAgICAg ICBXRUJLSVRfQVBJIFdlYlN0cmluZyB2YWx1ZSgpIGNvbnN0OwogICAgICAgICBXRUJLSVRfQVBJ IHZvaWQgc2V0U3VnZ2VzdGVkVmFsdWUoY29uc3QgV2ViU3RyaW5nJik7CiAgICAgICAgIFdFQktJ VF9BUEkgV2ViU3RyaW5nIHN1Z2dlc3RlZFZhbHVlKCkgY29uc3Q7CmRpZmYgLS1naXQgYS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYklucHV0RWxlbWVudC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYklucHV0RWxlbWVudC5jcHAKaW5kZXggNzc3OWRiYzNjYTRjYzc5OTQ2MzQwOTkwZGUyOWVk M2JhMTU0ZGVlZS4uOWQ1MGVkMTg0NjljMjg3ZmUxNDQwN2IzY2Q4ODEwMzU4YmI3MDMyNyAxMDA2 NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEVsZW1lbnQuY3BwCisrKyBiL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFbGVtZW50LmNwcApAQCAtOTUsOSArOTUsOSBAQCBp bnQgV2ViSW5wdXRFbGVtZW50OjpzaXplKCkgY29uc3QKICAgICByZXR1cm4gY29uc3RVbndyYXA8 SFRNTElucHV0RWxlbWVudD4oKS0+c2l6ZSgpOwogfQogCi12b2lkIFdlYklucHV0RWxlbWVudDo6 c2V0VmFsdWUoY29uc3QgV2ViU3RyaW5nJiB2YWx1ZSkKK3ZvaWQgV2ViSW5wdXRFbGVtZW50Ojpz ZXRWYWx1ZShjb25zdCBXZWJTdHJpbmcmIHZhbHVlLCBib29sIHNlbmRDaGFuZ2VFdmVudCkKIHsK LSAgICB1bndyYXA8SFRNTElucHV0RWxlbWVudD4oKS0+c2V0VmFsdWUodmFsdWUpOworICAgIHVu d3JhcDxIVE1MSW5wdXRFbGVtZW50PigpLT5zZXRWYWx1ZSh2YWx1ZSwgc2VuZENoYW5nZUV2ZW50 KTsKIH0KIAogV2ViU3RyaW5nIFdlYklucHV0RWxlbWVudDo6dmFsdWUoKSBjb25zdAo= 72567 2010-11-01 14:50:33 -0700 2010-11-02 13:30:48 -0700 Patch bug-48177-20101101145032.patch text/plain 2218 isherman ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGZmNTA5YTlmYjYxZWJiZmE4Y2M0OWFlY2IxZGU2ZDRmMDJkNTg5ZDku LmEzNDIzNmM4ZWU3ZDI0NDhlZmIyNWZiNDViZjkxZDgwMzdhZGMzYmQgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEwLTEwLTIzICBJbHlhIFNoZXJtYW4gIDxpc2hlcm1hbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRXhwb3NlIHRoZSBzZW5kQ2hhbmdlRXZlbnQgcGFyYW1ldGVyIGluIFdlYklucHV0RWxlbWVu dDo6c2V0VmFsdWUoKSBBUEksCisgICAgICAgIHByaW1hcmlseSBzbyB0aGF0IGNocm9taXVtIGZv cm0gYXV0b2ZpbGwgY2FuIGZpcmUgdGhlIG9uQ2hhbmdlIGV2ZW50LgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDgxNzcKKworICAgICAgICAqIHB1Ymxp Yy9XZWJJbnB1dEVsZW1lbnQuaDoKKyAgICAgICAgKiBzcmMvV2ViSW5wdXRFbGVtZW50LmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViSW5wdXRFbGVtZW50OjpzZXRWYWx1ZSk6CisKIDIwMTAtMTEt MDEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEFuZGVycyBDYXJsc3Nvbi4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViSW5wdXRFbGVtZW50LmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklucHV0RWxlbWVu dC5oCmluZGV4IDhmZWE0ZmE5M2UyOGViZjAyZjEwOWFmZGYxMTQ3YmUwNzkwNTU1ODYuLmQwZGYw NzkxNDA2NDE1OWEwZTk1NjkwOWJjNDczMjE3Zjk1YTA0ODAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFbGVtZW50LmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJJbnB1dEVsZW1lbnQuaApAQCAtNjYsNyArNjYsNyBAQCBuYW1lc3BhY2UgV2ViS2l0 IHsKICAgICAgICAgV0VCS0lUX0FQSSBib29sIGlzQWN0aXZhdGVkU3VibWl0KCkgY29uc3Q7CiAg ICAgICAgIFdFQktJVF9BUEkgdm9pZCBzZXRBY3RpdmF0ZWRTdWJtaXQoYm9vbCk7CiAgICAgICAg IFdFQktJVF9BUEkgaW50IHNpemUoKSBjb25zdDsKLSAgICAgICAgV0VCS0lUX0FQSSB2b2lkIHNl dFZhbHVlKGNvbnN0IFdlYlN0cmluZyYpOworICAgICAgICBXRUJLSVRfQVBJIHZvaWQgc2V0VmFs dWUoY29uc3QgV2ViU3RyaW5nJiwgYm9vbCBzZW5kQ2hhbmdlRXZlbnQgPSBmYWxzZSk7CiAgICAg ICAgIFdFQktJVF9BUEkgV2ViU3RyaW5nIHZhbHVlKCkgY29uc3Q7CiAgICAgICAgIFdFQktJVF9B UEkgdm9pZCBzZXRTdWdnZXN0ZWRWYWx1ZShjb25zdCBXZWJTdHJpbmcmKTsKICAgICAgICAgV0VC S0lUX0FQSSBXZWJTdHJpbmcgc3VnZ2VzdGVkVmFsdWUoKSBjb25zdDsKZGlmZiAtLWdpdCBhL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFbGVtZW50LmNwcCBiL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViSW5wdXRFbGVtZW50LmNwcAppbmRleCA3Nzc5ZGJjM2NhNGNjNzk5NDYzNDA5OTBkZTI5 ZWQzYmExNTRkZWVlLi45ZDUwZWQxODQ2OWMyODdmZTE0NDA3YjNjZDg4MTAzNThiYjcwMzI3IDEw MDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RWxlbWVudC5jcHAKKysrIGIv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEVsZW1lbnQuY3BwCkBAIC05NSw5ICs5NSw5IEBA IGludCBXZWJJbnB1dEVsZW1lbnQ6OnNpemUoKSBjb25zdAogICAgIHJldHVybiBjb25zdFVud3Jh cDxIVE1MSW5wdXRFbGVtZW50PigpLT5zaXplKCk7CiB9CiAKLXZvaWQgV2ViSW5wdXRFbGVtZW50 OjpzZXRWYWx1ZShjb25zdCBXZWJTdHJpbmcmIHZhbHVlKQordm9pZCBXZWJJbnB1dEVsZW1lbnQ6 OnNldFZhbHVlKGNvbnN0IFdlYlN0cmluZyYgdmFsdWUsIGJvb2wgc2VuZENoYW5nZUV2ZW50KQog ewotICAgIHVud3JhcDxIVE1MSW5wdXRFbGVtZW50PigpLT5zZXRWYWx1ZSh2YWx1ZSk7CisgICAg dW53cmFwPEhUTUxJbnB1dEVsZW1lbnQ+KCktPnNldFZhbHVlKHZhbHVlLCBzZW5kQ2hhbmdlRXZl bnQpOwogfQogCiBXZWJTdHJpbmcgV2ViSW5wdXRFbGVtZW50Ojp2YWx1ZSgpIGNvbnN0Cg==