48171 2010-10-22 23:03:27 -0700 EWS never releases patches which fail to apply 2010-10-22 23:48:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 35460 1 eric eric abarth commit-queue eric ossy oldest_to_newest 298314 0 eric 2010-10-22 23:03:27 -0700 EWS never releases patches which fail to apply 298315 1 71622 eric 2010-10-22 23:07:14 -0700 Created attachment 71622 Patch 298316 2 eric 2010-10-22 23:08:40 -0700 This explains 10 of the 11 patches that the Qt-EWS is stuck chewing on (and countless others from other queues). The /release-patch design is fragile. We need to come up with a cleaner pattern through which to release patches. 298320 3 71622 abarth 2010-10-22 23:32:52 -0700 Comment on attachment 71622 Patch i wish there was a more central place to put these calls to release_work_item. 298321 4 eric 2010-10-22 23:42:52 -0700 There probably are. We need to finish patching holes in the dam and then sit back and make a sane design out of all this. :) 298322 5 eric 2010-10-22 23:43:24 -0700 We also need to split release_work_item into two methods: remove_work_item and unlock_work_item (or similar names). 298324 6 71622 commit-queue 2010-10-22 23:47:56 -0700 Comment on attachment 71622 Patch Clearing flags on attachment: 71622 Committed r70382: <http://trac.webkit.org/changeset/70382> 298325 7 commit-queue 2010-10-22 23:48:01 -0700 All reviewed patches have been landed. Closing bug. 71622 2010-10-22 23:07:14 -0700 2010-10-22 23:47:56 -0700 Patch bug-48171-20101022230712.patch text/plain 3116 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0ODA2ZjEzNGM0MmQ5ZWJkNDUzMmRiNGJhZDVkMzY0NmFiOGY1YjViLi4yNGIzMDBl OWMyNjZmYzdhMjRlMmY2ZjRiODlmODMyYzZkNTUzZWI2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAK IDIwMTAtMTAtMjIgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVXUyBuZXZlciByZWxlYXNlcyBw YXRjaGVzIHdoaWNoIGZhaWwgdG8gYXBwbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ4MTcxCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rv b2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtX3VuaXR0ZXN0LnB5OgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHk6CisKKzIwMTAtMTAtMjIgIEVy aWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCiAgICAgICAgIFVucmV2aWV3ZWQuCiAKICAg ICAgICAgTWFrZSB0aGUgRVdTIHF1ZXVlcyByZXN0YXJ0IHRoZW1zZWx2ZXMgbW9yZSBvZnRlbi4K ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9l YXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3QucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtX3VuaXR0ZXN0LnB5CmluZGV4IDQ0 OGMzMTQzMDhlYzdlNGUyYTU2OGM1YTRmMTQ0N2Q0MWE2NzhhMDYuLmFlNDQ3NDg5OWY4ZDdkZGI3 NDAxYzQxYjM2ZmZiNzM4NTM5NDdmNTUgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3QucHkKKysr IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2Fybmlu Z3N5c3RlbV91bml0dGVzdC5weQpAQCAtMjksMTEgKzI5LDI3IEBACiBpbXBvcnQgb3MKIAogZnJv bSB3ZWJraXRweS50aGlyZHBhcnR5Lm1vY2sgaW1wb3J0IE1vY2sKK2Zyb20gd2Via2l0cHkuY29t bW9uLnN5c3RlbS5vdXRwdXRjYXB0dXJlIGltcG9ydCBPdXRwdXRDYXB0dXJlCitmcm9tIHdlYmtp dHB5LnRvb2wuYm90LnF1ZXVlZW5naW5lIGltcG9ydCBRdWV1ZUVuZ2luZQogZnJvbSB3ZWJraXRw eS50b29sLmNvbW1hbmRzLmVhcmx5d2FybmluZ3N5c3RlbSBpbXBvcnQgKgogZnJvbSB3ZWJraXRw eS50b29sLmNvbW1hbmRzLnF1ZXVlc3Rlc3QgaW1wb3J0IFF1ZXVlc1Rlc3QKIGZyb20gd2Via2l0 cHkudG9vbC5tb2NrdG9vbCBpbXBvcnQgTW9ja1Rvb2wKIAogCitjbGFzcyBBYnN0cmFjdEVhcmx5 V2FybmluZ1N5c3RlbVRlc3QoUXVldWVzVGVzdCk6CisgICAgZGVmIHRlc3Rfc3VicHJvY2Vzc19o YW5kbGVkX2Vycm9yKHNlbGYpOgorICAgICAgICBxdWV1ZSA9IEFic3RyYWN0UmV2aWV3UXVldWUo KQorICAgICAgICBxdWV1ZS5iaW5kX3RvX3Rvb2woTW9ja1Rvb2woKSkKKworICAgICAgICBkZWYg bW9ja19yZXZpZXdfcGF0Y2gocGF0Y2gpOgorICAgICAgICAgICAgcmFpc2UgU2NyaXB0RXJyb3Io J01PQ0sgc2NyaXB0IGVycm9yJywgZXhpdF9jb2RlPVF1ZXVlRW5naW5lLmhhbmRsZWRfZXJyb3Jf Y29kZSkKKworICAgICAgICBxdWV1ZS5yZXZpZXdfcGF0Y2ggPSBtb2NrX3Jldmlld19wYXRjaAor ICAgICAgICBtb2NrX3BhdGNoID0gcXVldWUuX3Rvb2wuYnVncy5mZXRjaF9hdHRhY2htZW50KDE5 NykKKyAgICAgICAgZXhwZWN0ZWRfc3RkZXJyID0gIk1PQ0s6IHJlbGVhc2Vfd29ya19pdGVtOiBO b25lIDE5N1xuIgorICAgICAgICBPdXRwdXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1dHMoc2VsZiwg cXVldWUucHJvY2Vzc193b3JrX2l0ZW0sIFttb2NrX3BhdGNoXSwgZXhwZWN0ZWRfc3RkZXJyPWV4 cGVjdGVkX3N0ZGVyciwgZXhwZWN0ZWRfZXhjZXB0aW9uPVNjcmlwdEVycm9yKQorCisKIGNsYXNz IEVhcmx5V2FybmluZ1N5dGVtVGVzdChRdWV1ZXNUZXN0KToKICAgICBkZWYgdGVzdF9mYWlsZWRf YnVpbGRzKHNlbGYpOgogICAgICAgICBld3MgPSBDaHJvbWl1bUxpbnV4RVdTKCkKZGlmZiAtLWdp dCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHkg Yi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5Cmlu ZGV4IDM0NmMwMzY3YjhlNWQ0NDAzOTI0MjAyYmU1NmY4MGRmOTc4NGQ0MzQuLmQ2ZWZlYjQ2NGMy ZTIwYWM4MTg4N2MwM2YyOTgxZTAyMzk5YWI4NzkgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHkKKysrIGIvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weQpAQCAtNDEyLDYgKzQxMiwx MCBAQCBjbGFzcyBBYnN0cmFjdFJldmlld1F1ZXVlKEFic3RyYWN0UGF0Y2hRdWV1ZSwgU3RlcFNl cXVlbmNlRXJyb3JIYW5kbGVyKToKICAgICAgICAgZXhjZXB0IFNjcmlwdEVycm9yLCBlOgogICAg ICAgICAgICAgaWYgZS5leGl0X2NvZGUgIT0gUXVldWVFbmdpbmUuaGFuZGxlZF9lcnJvcl9jb2Rl OgogICAgICAgICAgICAgICAgIHNlbGYuX2RpZF9mYWlsKHBhdGNoKQorICAgICAgICAgICAgZWxz ZToKKyAgICAgICAgICAgICAgICAjIFRoZSBzdWJwcm9jZXNzIGhhbmRsZWQgdGhlIGVycm9yLCBi dXQgd29uJ3QgaGF2ZSByZWxlYXNlZCB0aGUgcGF0Y2gsIHNvIHdlIGRvLgorICAgICAgICAgICAg ICAgICMgRklYTUU6IFdlIG5lZWQgdG8gc2ltcGxpZnkgdGhlIHJ1bGVzIGJ5IHdoaWNoIF9yZWxl YXNlX3dvcmtfaXRlbSBpcyBjYWxsZWQuCisgICAgICAgICAgICAgICAgc2VsZi5fcmVsZWFzZV93 b3JrX2l0ZW0ocGF0Y2gpCiAgICAgICAgICAgICByYWlzZSBlCiAKICAgICBkZWYgaGFuZGxlX3Vu ZXhwZWN0ZWRfZXJyb3Ioc2VsZiwgcGF0Y2gsIG1lc3NhZ2UpOgo=