48168 2010-10-22 18:12:19 -0700 WebP decoding hits ASSERT 2010-10-23 17:19:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth abarth commit-queue pascal.massimino pkasting oldest_to_newest 298290 0 abarth 2010-10-22 18:12:19 -0700 WebP decoding hits ASSERT 298292 1 71616 abarth 2010-10-22 18:19:46 -0700 Created attachment 71616 Patch 298365 2 71616 kling 2010-10-23 03:38:00 -0700 Comment on attachment 71616 Patch LGTM. 298410 3 71616 abarth 2010-10-23 09:34:13 -0700 Comment on attachment 71616 Patch Thanks. 298415 4 71616 commit-queue 2010-10-23 09:48:14 -0700 Comment on attachment 71616 Patch Clearing flags on attachment: 71616 Committed r70392: <http://trac.webkit.org/changeset/70392> 298416 5 commit-queue 2010-10-23 09:48:19 -0700 All reviewed patches have been landed. Closing bug. 298442 6 pascal.massimino 2010-10-23 11:35:10 -0700 (In reply to comment #5) > All reviewed patches have been landed. Closing bug. thanks for fixing that Adam! i'm a little worried that rgb.resize() is zero'ing the memory we are going to be filling. Is it? If so, this is unneeded operation... But we can revisit that later. 298495 7 abarth 2010-10-23 17:19:56 -0700 > i'm a little worried that rgb.resize() is zero'ing the memory we are going to be > filling. Is it? If so, this is unneeded operation... But we can revisit that later. We should look at the code an see. There area a bunch of templates to unwind. If it does, we can add a resizeUninitialized() function to vector. 71616 2010-10-22 18:19:46 -0700 2010-10-23 09:48:14 -0700 Patch bug-48168-20101022181945.patch text/plain 1617 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDM3NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTAtMjIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJQ IGRlY29kaW5nIGhpdHMgQVNTRVJUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00ODE2OAorCisgICAgICAgIENhbGxpbmcgcmVzZXJ2ZUNhcGFjaXR5IG9u bHkgYWxsb2NhdGVzIHRoZSBtZW1vcnkuICBJdCBkb2Vzbid0IGFjdHVhbGx5CisgICAgICAgIHNl dCB0aGUgbGVuZ3RoLiAgV2hlbiB5b3UgdHJ5IHRvIGFjY2VzcyB0aGUgemVyb3RoIGVsZW1lbnQs IHlvdSBoaXQgYW4KKyAgICAgICAgQVNTRVJULgorCisgICAgICAgIENvdmVyZWQgYnkgZmFzdC9p bWFnZXMvd2VicC1pbWFnZS1kZWNvZGluZy5odG1sIGluIGRlYnVnLgorCisgICAgICAgICogcGxh dGZvcm0vaW1hZ2UtZGVjb2RlcnMvd2VicC9XRUJQSW1hZ2VEZWNvZGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OldFQlBJbWFnZURlY29kZXI6OmRlY29kZSk6CisKIDIwMTAtMTAtMjEgIEFkYW0g QmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNl aWRlbCwgUGV0ZXIgS2FzdGluZywgYW5kIERhcmluIEZpc2hlci4KSW5kZXg6IFdlYkNvcmUvcGxh dGZvcm0vaW1hZ2UtZGVjb2RlcnMvd2VicC9XRUJQSW1hZ2VEZWNvZGVyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3dlYnAvV0VCUEltYWdlRGVjb2Rl ci5jcHAJKHJldmlzaW9uIDcwMzcwKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVy cy93ZWJwL1dFQlBJbWFnZURlY29kZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDMsOCArMTAz LDggQEAgYm9vbCBXRUJQSW1hZ2VEZWNvZGVyOjpkZWNvZGUoYm9vbCBvbmx5UwogICAgIH0KICAg ICBjb25zdCBpbnQgc3RyaWRlID0gd2lkdGggKiBieXRlc1BlclBpeGVsOwogICAgIFZlY3Rvcjx1 aW50OF90PiByZ2I7Ci0gICAgcmdiLnJlc2VydmVDYXBhY2l0eShoZWlnaHQgKiBzdHJpZGUpOwot ICAgIGlmICghV2ViUERlY29kZUJHUkludG8oZGF0YUJ5dGVzLCBkYXRhU2l6ZSwgJnJnYlswXSwg aGVpZ2h0ICogc3RyaWRlLCBzdHJpZGUpKQorICAgIHJnYi5yZXNpemUoaGVpZ2h0ICogc3RyaWRl KTsKKyAgICBpZiAoIVdlYlBEZWNvZGVCR1JJbnRvKGRhdGFCeXRlcywgZGF0YVNpemUsIHJnYi5k YXRhKCksIHJnYi5zaXplKCksIHN0cmlkZSkpCiAgICAgICAgIHJldHVybiBzZXRGYWlsZWQoKTsK ICAgICAvLyBGSVhNRTogcmVtb3ZlIHRoaXMgZGF0YSBjb3B5LgogICAgIGZvciAoaW50IHkgPSAw OyB5IDwgaGVpZ2h0OyArK3kpIHsK