48155 2010-10-22 14:42:19 -0700 Fix assert when a NetscapePluginModule loses its last NetscapePlugin. 2010-10-22 15:16:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 298186 0 andersca 2010-10-22 14:42:19 -0700 Fix assert when a NetscapePluginModule loses its last NetscapePlugin. 298188 1 71596 andersca 2010-10-22 14:44:33 -0700 Created attachment 71596 Patch 298190 2 71596 aroben 2010-10-22 14:47:52 -0700 Comment on attachment 71596 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71596&action=review > WebKit2/ChangeLog:16 > + Set m_sInitialized to false. Typo: m_sInitialized. Can you make a test? It would be nice to say what assertion was failing and when. Then we'll have a hope of reproducing this in the future if we need to. 298194 3 andersca 2010-10-22 14:50:29 -0700 (In reply to comment #2) > (From update of attachment 71596 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=71596&action=review > > > WebKit2/ChangeLog:16 > > + Set m_sInitialized to false. > > Typo: m_sInitialized. > > Can you make a test? This is already tested in LayoutTests/plugins. > It would be nice to say what assertion was failing and when. Then we'll have a hope of reproducing this in the future if we need to. Sure! 298215 4 andersca 2010-10-22 15:16:41 -0700 Committed r70347: <http://trac.webkit.org/changeset/70347> 71596 2010-10-22 14:44:33 -0700 2010-10-22 14:47:52 -0700 Patch bug-48155-20101022144432.patch text/plain 3762 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg N2UzMTI1NWEzOWM5MjhlZDVmMWIwMmM2OWU4OGQyM2I0MTkyOWE3ZC4uM2EzNTE3YmYxMzJjYjk5 MGU0YTFhM2NkMjA5NDFiZmVlNTlmMGNhOSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwzMiBAQAogMjAxMC0xMC0yMiAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhc3NlcnQgd2hlbiBhIE5ldHNjYXBlUGx1 Z2luTW9kdWxlIGxvc2VzIGl0cyBsYXN0IE5ldHNjYXBlUGx1Z2luLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDgxNTUKKworICAgICAgICAqIFdlYlBy b2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbk1vZHVsZS5jcHA6CisgICAgICAg IChXZWJLaXQ6Ok5ldHNjYXBlUGx1Z2luTW9kdWxlOjpwbHVnaW5DcmVhdGVkKToKKyAgICAgICAg SWYgd2UgZGlkbid0IGhhdmUgYW55IGxpdmUgcGx1Zy1pbnMsIGxvYWQgdGhlIHBsdWctaW4gbW9k dWxlLgorCisgICAgICAgIChXZWJLaXQ6Ok5ldHNjYXBlUGx1Z2luTW9kdWxlOjpwbHVnaW5EZXN0 cm95ZWQpOgorICAgICAgICBJZiB0aGlzIHdhcyB0aGUgbGFzdCBwbHVnLWluLCB1bmxvYWQgdGhl IHBsdWctaW4gbW9kdWxlLgorCisgICAgICAgIChXZWJLaXQ6Ok5ldHNjYXBlUGx1Z2luTW9kdWxl OjpzaHV0ZG93bik6CisgICAgICAgIFNldCBtX3NJbml0aWFsaXplZCB0byBmYWxzZS4KKworICAg ICAgICAoV2ViS2l0OjpOZXRzY2FwZVBsdWdpbk1vZHVsZTo6bG9hZCk6CisgICAgICAgIERvbid0 IGRvIGFueXRoaW5nIGlmIHRoZSBwbHVnLWluIG1vZHVsZSBoYXMgYWxyZWFkeSBiZWVuIGluaXRp YWxpemVkLgorCisgICAgICAgIChXZWJLaXQ6Ok5ldHNjYXBlUGx1Z2luTW9kdWxlOjp1bmxvYWQp OgorICAgICAgICBBc3NlcnQgdGhhdCB3ZSdyZSBub3QgaW5pdGlhbGl6ZWQuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvbWFjL05ldHNjYXBlUGx1Z2luTWFjLm1tOgor ICAgICAgICAoV2ViS2l0OjpOZXRzY2FwZVBsdWdpbjo6cGxhdGZvcm1Qb3N0SW5pdGlhbGl6ZSk6 CisgICAgICAgIEFzc2VydCB0aGF0IHdlIHN1Y2Nlc3NmdWxseSBjcmVhdGVkIHRoZSB3aW5kb3cu CisKKzIwMTAtMTAtMjIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwog ICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgogCiAgICAgICAgIFJlbmFtZSBwcm9jZXNz RGlkRXhpdCB0byBwcm9jZXNzRGlkQ3Jhc2gKZGlmZiAtLWdpdCBhL1dlYktpdDIvV2ViUHJvY2Vz cy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luTW9kdWxlLmNwcCBiL1dlYktpdDIvV2Vi UHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luTW9kdWxlLmNwcAppbmRleCBi N2Q0YThlY2NlOWM5NjlmOTZiMzU5OTAyMDkxZTM4Y2UyNGJkNGYyLi42YzE0YzRkOTM4N2YxOGU0 ZTI4ZTljZGY1ZDdmZDdjNWMxNmQ0NDA5IDEwMDY0NAotLS0gYS9XZWJLaXQyL1dlYlByb2Nlc3Mv UGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbk1vZHVsZS5jcHAKKysrIGIvV2ViS2l0Mi9X ZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW5Nb2R1bGUuY3BwCkBAIC01 Myw2ICs1MywxMSBAQCBOZXRzY2FwZVBsdWdpbk1vZHVsZTo6fk5ldHNjYXBlUGx1Z2luTW9kdWxl KCkKIAogdm9pZCBOZXRzY2FwZVBsdWdpbk1vZHVsZTo6cGx1Z2luQ3JlYXRlZCgpCiB7CisgICAg aWYgKCFtX3BsdWdpbkNvdW50KSB7CisgICAgICAgIC8vIExvYWQgdGhlIHBsdWctaW4gbW9kdWxl IGlmIG5lY2Vzc2FyeS4KKyAgICAgICAgbG9hZCgpOworICAgIH0KKyAgICAgICAgCiAgICAgbV9w bHVnaW5Db3VudCsrOwogfQogCkBAIC02MSw4ICs2NiwxMCBAQCB2b2lkIE5ldHNjYXBlUGx1Z2lu TW9kdWxlOjpwbHVnaW5EZXN0cm95ZWQoKQogICAgIEFTU0VSVChtX3BsdWdpbkNvdW50ID4gMCk7 CiAgICAgbV9wbHVnaW5Db3VudC0tOwogICAgIAotICAgIGlmICghbV9wbHVnaW5Db3VudCkKKyAg ICBpZiAoIW1fcGx1Z2luQ291bnQpIHsKICAgICAgICAgc2h1dGRvd24oKTsKKyAgICAgICAgdW5s b2FkKCk7CisgICAgfQogfQogCiB2b2lkIE5ldHNjYXBlUGx1Z2luTW9kdWxlOjpzaHV0ZG93bigp CkBAIC03MSw2ICs3OCw4IEBAIHZvaWQgTmV0c2NhcGVQbHVnaW5Nb2R1bGU6OnNodXRkb3duKCkK IAogICAgIG1fc2h1dGRvd25Qcm9jUHRyKCk7CiAKKyAgICBtX2lzSW5pdGlhbGl6ZWQgPSBmYWxz ZTsKKwogICAgIHNpemVfdCBwbHVnaW5Nb2R1bGVJbmRleCA9IGluaXRpYWxpemVkTmV0c2NhcGVQ bHVnaW5Nb2R1bGVzKCkuZmluZCh0aGlzKTsKICAgICBBU1NFUlQocGx1Z2luTW9kdWxlSW5kZXgg IT0gbm90Rm91bmQpOwogICAgIApAQCAtOTgsNiArMTA3LDExIEBAIFBhc3NSZWZQdHI8TmV0c2Nh cGVQbHVnaW5Nb2R1bGU+IE5ldHNjYXBlUGx1Z2luTW9kdWxlOjpnZXRPckNyZWF0ZShjb25zdCBT dHJpbmcmCiAKIGJvb2wgTmV0c2NhcGVQbHVnaW5Nb2R1bGU6OmxvYWQoKQogeworICAgIGlmICht X2lzSW5pdGlhbGl6ZWQpIHsKKyAgICAgICAgQVNTRVJUKGluaXRpYWxpemVkTmV0c2NhcGVQbHVn aW5Nb2R1bGVzKCkuZmluZCh0aGlzKSAhPSBub3RGb3VuZCk7CisgICAgICAgIHJldHVybiB0cnVl OworICAgIH0KKwogICAgIGlmICghdHJ5TG9hZCgpKSB7CiAgICAgICAgIHVubG9hZCgpOwogICAg ICAgICByZXR1cm4gZmFsc2U7CkBAIC0xNDgsNiArMTYyLDggQEAgYm9vbCBOZXRzY2FwZVBsdWdp bk1vZHVsZTo6dHJ5TG9hZCgpCiAKIHZvaWQgTmV0c2NhcGVQbHVnaW5Nb2R1bGU6OnVubG9hZCgp CiB7CisgICAgQVNTRVJUKCFtX2lzSW5pdGlhbGl6ZWQpOworCiAgICAgbV9tb2R1bGUgPSAwOwog fQogCmRpZmYgLS1naXQgYS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9tYWMv TmV0c2NhcGVQbHVnaW5NYWMubW0gYi9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2Fw ZS9tYWMvTmV0c2NhcGVQbHVnaW5NYWMubW0KaW5kZXggMDhlNDY0M2Q4YzJhMjcxZjE4ZTIyNzY0 MzQ4ZDAzMGNjNTU2NGNlMS4uZmI5YzFkZmExODY3YzUzMDEzMDI1MDY2ZjlmMjUwMjdlNGYxYjA3 MyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvbWFjL05l dHNjYXBlUGx1Z2luTWFjLm1tCisrKyBiL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNj YXBlL21hYy9OZXRzY2FwZVBsdWdpbk1hYy5tbQpAQCAtMTMyLDYgKzEzMiw3IEBAIGJvb2wgTmV0 c2NhcGVQbHVnaW46OnBsYXRmb3JtUG9zdEluaXRpYWxpemUoKQogICAgICAgICAvLyBJbml0aWFs aXplIHRoZSBmYWtlIENhcmJvbiB3aW5kb3cuCiAgICAgICAgIFJlY3QgYm91bmRzID0geyAwLCAw LCAwLCAwIH07CiAgICAgICAgIENyZWF0ZU5ld1dpbmRvdyhrRG9jdW1lbnRXaW5kb3dDbGFzcywg MCwgJmJvdW5kcywgcmVpbnRlcnByZXRfY2FzdDxXaW5kb3dSZWYqPigmbV9ucENHQ29udGV4dC53 aW5kb3cpKTsKKyAgICAgICAgQVNTRVJUKG1fbnBDR0NvbnRleHQud2luZG93KTsKICAgICAgICAg CiAgICAgICAgIC8vIEZJWE1FOiBEaXNhYmxlIHRoZSBiYWNraW5nIHN0b3JlLgogICAgICAgICAK