48148 2010-10-22 12:44:08 -0700 ASSERT while viewing Google C++ style guide 2010-10-22 14:00:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth abarth commit-queue eric jamesr tonyg webkit.review.bot oldest_to_newest 298114 0 abarth 2010-10-22 12:44:08 -0700 ASSERT while viewing Google C++ style guide 298116 1 71586 abarth 2010-10-22 12:48:31 -0700 Created attachment 71586 Patch 298117 2 71586 eric 2010-10-22 12:51:20 -0700 Comment on attachment 71586 Patch OK. I assume finishParsing() does nothing else we'd need here? 298121 3 tonyg 2010-10-22 12:57:50 -0700 Nice. Thanks for the fix. 298123 4 tonyg 2010-10-22 13:00:42 -0700 *** Bug 47305 has been marked as a duplicate of this bug. *** 298128 5 abarth 2010-10-22 13:06:28 -0700 close() calls finishParsing() for us. That how it ... finishes parsing. :) 298129 6 71586 commit-queue 2010-10-22 13:06:32 -0700 Comment on attachment 71586 Patch Clearing flags on attachment: 71586 Committed r70327: <http://trac.webkit.org/changeset/70327> 298130 7 commit-queue 2010-10-22 13:06:37 -0700 All reviewed patches have been landed. Closing bug. 298161 8 webkit.review.bot 2010-10-22 14:00:21 -0700 http://trac.webkit.org/changeset/70327 might have broken GTK Linux 64-bit Debug The following tests are not passing: mathml/presentation/fenced-mi.xhtml mathml/presentation/subsup.xhtml 71586 2010-10-22 12:48:31 -0700 2010-10-22 13:06:32 -0700 Patch bug-48148-20101022124830.patch text/plain 3495 abarth ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiN2IyMDhiMWNjNTZjM2U3Zjk0MDY2Y2NlOWJmOGFkMmRiMjQzMzA3Li42OGRkM2Uy Y2VhMjUwMzM3NzhhNjA0YjUzZmRiYmM5YmRjODg5ZmM4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMTAtMjIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBU1NFUlQgd2hpbGUgdmlld2lu ZyBHb29nbGUgQysrIHN0eWxlIGd1aWRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00ODE0OAorCisgICAgICAgIE1ha2Ugc3VyZSB3ZSBkb24ndCBoaXQg YW4gQVNTRVJUIHdoZW4gYW4gWFNMVCBvdXRwdXRzIEhUTUwuCisKKyAgICAgICAgKiBmYXN0L3hz bC9yZXNvdXJjZXMvdG8taHRtbC54c2w6IEFkZGVkLgorICAgICAgICAqIGZhc3QveHNsL3RyYW5z Zm9ybS10by1odG1sLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC94c2wvdHJh bnNmb3JtLXRvLWh0bWwueG1sOiBBZGRlZC4KKwogMjAxMC0xMC0yMiAgQ29zbWluIFRydXRhICA8 Y3RydXRhQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOaWtvbGFzIFppbW1l cm1hbm4uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3hzbC9yZXNvdXJjZXMvdG8taHRt bC54c2wgYi9MYXlvdXRUZXN0cy9mYXN0L3hzbC9yZXNvdXJjZXMvdG8taHRtbC54c2wKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uZGNjZmRiOWJlMmE3OTUwZTNmZmJjYWFlYTcxNTg2MTAzZTllOTUzZgotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QveHNsL3Jlc291cmNlcy90by1odG1sLnhzbApAQCAt MCwwICsxLDEwIEBACis8eHNsOnN0eWxlc2hlZXQgdmVyc2lvbj0iMS4wIiB4bWxuczp4c2w9Imh0 dHA6Ly93d3cudzMub3JnLzE5OTkvWFNML1RyYW5zZm9ybSI+CisgIDx4c2w6b3V0cHV0IG1ldGhv ZD0iaHRtbCIvPgorICA8eHNsOnRlbXBsYXRlIG1hdGNoPSJ0ZXN0Ij4KKyAgICA8c2NyaXB0Pgor ICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgPC9zY3JpcHQ+CisgICAgUEFTUworICA8 L3hzbDp0ZW1wbGF0ZT4KKzwveHNsOnN0eWxlc2hlZXQ+IApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC94c2wvdHJhbnNmb3JtLXRvLWh0bWwtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv ZmFzdC94c2wvdHJhbnNmb3JtLXRvLWh0bWwtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjdlZjIy ZTlhNDMxYWQwMjcyNzEzYjcxZmRjODc5NDAxNmM4ZWYxMmYKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L3hzbC90cmFuc2Zvcm0tdG8taHRtbC1leHBlY3RlZC50eHQKQEAgLTAs MCArMSBAQAorUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC94c2wvdHJhbnNmb3Jt LXRvLWh0bWwueG1sIGIvTGF5b3V0VGVzdHMvZmFzdC94c2wvdHJhbnNmb3JtLXRvLWh0bWwueG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLmYwOTY0ZjA4MmI1NmM4MWNjZjc0ZjY3NzQyMTYyZTM5MmQxNTJmYzMKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3hzbC90cmFuc2Zvcm0tdG8taHRtbC54 bWwKQEAgLTAsMCArMSwzIEBACis8P3htbCB2ZXJzaW9uPSIxLjAiPz4gCis8P3htbC1zdHlsZXNo ZWV0IHR5cGU9InRleHQveHNsIiBocmVmPSJyZXNvdXJjZXMvdG8taHRtbC54c2wiPz4gCis8dGVz dD5GQUlMPC90ZXN0PgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjOGRhMjA3MGZjNTE0M2QwZjQ2M2Y3YjY0NTAxZjY2OTE0NWE4YjY1Li42 OWUyNjYzZGIwYWUzODQzYjNkOGFhOWM3ZTQ4YjFkZmY1MzQ3NzJjIDEwMDY0NAotLS0gYS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAy MDEwLTEwLTIyICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQVNTRVJUIHdoaWxlIHZpZXdpbmcg R29vZ2xlIEMrKyBzdHlsZSBndWlkZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDgxNDgKKworICAgICAgICBUaGlzIGNvZGUgdXNlZCB0byBzdG9wIHRo ZSBwYXJzZXIgdHdpY2UuICBJbnN0ZWFkIG9mIHJlYWNoaW5nIGluIGFuCisgICAgICAgIHRyeWlu ZyB0byBzdG9wIHRoZSBwYXJzZXIgbWFudWFsbHksIHdlIG5vdyBqdXN0IGxldCBjbG9zZSgpIGRv IHRoZSB3b3JrCisgICAgICAgIGZvciB1cy4KKworICAgICAgICBUZXN0OiBmYXN0L3hzbC90cmFu c2Zvcm0tdG8taHRtbC54bWwKKworICAgICAgICAqIHhtbC9YU0xUUHJvY2Vzc29yLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlhTTFRQcm9jZXNzb3I6OmNyZWF0ZURvY3VtZW50RnJvbVNvdXJjZSk6 CisKKzIwMTAtMTAtMjIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwogICAgICAg ICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNzAyOTAuCiAgICAgICAgIGh0dHA6Ly90cmFjLndl YmtpdC5vcmcvY2hhbmdlc2V0LzcwMjkwCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00ODExMQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS94bWwvWFNMVFByb2Nl c3Nvci5jcHAgYi9XZWJDb3JlL3htbC9YU0xUUHJvY2Vzc29yLmNwcAppbmRleCBiZGFlMGNkZDE0 MDc1N2ZmMzhjYTA0ZTdlYWQ2NmIwODA4Nzc0MTViLi41ZmQwMDljZDJlYjIxOGMyYzFmNDIxMWE1 ZTg4ODVlMzZlNjc0OGMyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3htbC9YU0xUUHJvY2Vzc29yLmNw cAorKysgYi9XZWJDb3JlL3htbC9YU0xUUHJvY2Vzc29yLmNwcApAQCAtOTAsNyArOTAsNiBAQCBQ YXNzUmVmUHRyPERvY3VtZW50PiBYU0xUUHJvY2Vzc29yOjpjcmVhdGVEb2N1bWVudEZyb21Tb3Vy Y2UoY29uc3QgU3RyaW5nJiBzb3VyYwogICAgIHJlc3VsdC0+c2V0RGVjb2RlcihkZWNvZGVyLnJl bGVhc2UoKSk7CiAKICAgICByZXN1bHQtPndyaXRlKGRvY3VtZW50U291cmNlKTsKLSAgICByZXN1 bHQtPmZpbmlzaFBhcnNpbmcoKTsKICAgICByZXN1bHQtPmNsb3NlKCk7CiAKICAgICByZXR1cm4g cmVzdWx0LnJlbGVhc2UoKTsK