48141 2010-10-22 10:53:20 -0700 [Qt][QtTestBrowser] Toggle use of QGraphicsView messes up the menu 2010-11-09 09:58:38 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 0 max.hong.shen webkit-unassigned ademar commit-queue suresh.voruganti tonikitoo oldest_to_newest 298072 0 max.hong.shen 2010-10-22 10:53:20 -0700 Steps to reproduce 1. launch QtTestBrowser 2. check the 'edit' menu on the menu bar, you can see several menu items, like 'undo','redo','cut' ... 3. on the menu bar, check 'Develop'->'QGraphicsView'->'Toggle use of QGraphicsView' 4. check the 'edit' menu again Result, menu items are missing Excepted, No menu items missing 298075 1 71577 max.hong.shen 2010-10-22 10:59:49 -0700 Created attachment 71577 first try Need to create/reconnect menu items with the new qwebpage. 298559 2 71577 kling 2010-10-24 05:16:41 -0700 Comment on attachment 71577 first try Nice, r=me! 298612 3 71577 commit-queue 2010-10-24 09:59:49 -0700 Comment on attachment 71577 first try Clearing flags on attachment: 71577 Committed r70417: <http://trac.webkit.org/changeset/70417> 298613 4 commit-queue 2010-10-24 09:59:54 -0700 All reviewed patches have been landed. Closing bug. 303455 5 suresh.voruganti 2010-11-02 10:25:54 -0700 Please cherry pick the fix to Qtwebkit 2.1 branch 306841 6 ademar 2010-11-09 09:58:29 -0800 Revision r70417 cherry-picked into qtwebkit-2.1 with commit ee16ad6 <http://gitorious.org/webkit/qtwebkit/commit/ee16ad6> 71577 2010-10-22 10:59:49 -0700 2010-10-24 09:59:49 -0700 first try 48141.patch text/plain 3426 max.hong.shen SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwMzE3KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTAtMjIgIFlpIFNoZW4gIDx5aS40LnNo ZW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF1bUXRUZXN0QnJvd3Nlcl0gVG9nZ2xlIHVzZSBvZiBRR3JhcGhpY3NWaWV3IG1l c3NlcyB1cCB0aGUgbWVudQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDgxNDEKKworICAgICAgICAqIFF0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cu Y3BwOgorICAgICAgICAoTGF1bmNoZXJXaW5kb3c6OmluaXQpOgorICAgICAgICAoTGF1bmNoZXJX aW5kb3c6OmluaXRpYWxpemVWaWV3KToKKyAgICAgICAgKExhdW5jaGVyV2luZG93Ojp0b2dnbGVX ZWJWaWV3KToKKwogMjAxMC0xMC0yMiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBn bWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjcwMzAxLgpJbmRl eDogV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAJKHJldmlz aW9uIDcwMzE2KQorKysgV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTcwLDI4ICs3MCwxNCBAQCB2b2lkIExhdW5jaGVyV2luZG93 Ojppbml0KCkKICAgICByZXNpemUoODAwLCA2MDApOwogI2VuZGlmCiAKLSAgICBpbml0aWFsaXpl VmlldygpOwotCi0gICAgY29ubmVjdChwYWdlKCksIFNJR05BTChsb2FkU3RhcnRlZCgpKSwgdGhp cywgU0xPVChsb2FkU3RhcnRlZCgpKSk7Ci0gICAgY29ubmVjdChwYWdlKCksIFNJR05BTChsb2Fk RmluaXNoZWQoYm9vbCkpLCB0aGlzLCBTTE9UKGxvYWRGaW5pc2hlZCgpKSk7Ci0gICAgY29ubmVj dChwYWdlKCksIFNJR05BTChsaW5rSG92ZXJlZChjb25zdCBRU3RyaW5nJiwgY29uc3QgUVN0cmlu ZyYsIGNvbnN0IFFTdHJpbmcmKSksCi0gICAgICAgICAgICB0aGlzLCBTTE9UKHNob3dMaW5rSG92 ZXIoY29uc3QgUVN0cmluZyYsIGNvbnN0IFFTdHJpbmcmKSkpOwotICAgIGNvbm5lY3QodGhpcywg U0lHTkFMKGVudGVyZWRGdWxsU2NyZWVuTW9kZShib29sKSksIHRoaXMsIFNMT1QodG9nZ2xlRnVs bFNjcmVlbk1vZGUoYm9vbCkpKTsKLQotICAgIGFwcGx5UHJlZnMoKTsKLQogICAgIG1faW5zcGVj dG9yID0gbmV3IFdlYkluc3BlY3RvcihzcGxpdHRlcik7CiAjaWZuZGVmIFFUX05PX1BST1BFUlRJ RVMKICAgICBpZiAoIW1fd2luZG93T3B0aW9ucy5pbnNwZWN0b3JVcmwuaXNFbXB0eSgpKQogICAg ICAgICBtX2luc3BlY3Rvci0+c2V0UHJvcGVydHkoIl9xX2luc3BlY3RvclVybCIsIG1fd2luZG93 T3B0aW9ucy5pbnNwZWN0b3JVcmwpOwogI2VuZGlmCi0gICAgbV9pbnNwZWN0b3ItPnNldFBhZ2Uo cGFnZSgpKTsKICAgICBtX2luc3BlY3Rvci0+aGlkZSgpOwogICAgIGNvbm5lY3QodGhpcywgU0lH TkFMKGRlc3Ryb3llZCgpKSwgbV9pbnNwZWN0b3IsIFNMT1QoZGVsZXRlTGF0ZXIoKSkpOwogCi0g ICAgaWYgKG1fd2luZG93T3B0aW9ucy5yZW1vdGVJbnNwZWN0b3JQb3J0KQotICAgICAgICBwYWdl KCktPnNldFByb3BlcnR5KCJfcV93ZWJJbnNwZWN0b3JTZXJ2ZXJQb3J0IiwgbV93aW5kb3dPcHRp b25zLnJlbW90ZUluc3BlY3RvclBvcnQpOwotCiAgICAgLy8gdGhlIHpvb20gdmFsdWVzIGFyZSBj aG9zZW4gdG8gYmUgbGlrZSBpbiBNb3ppbGxhIEZpcmVmb3ggMwogICAgIGlmICghbV96b29tTGV2 ZWxzLmNvdW50KCkpIHsKICAgICAgICAgbV96b29tTGV2ZWxzIDw8IDMwIDw8IDUwIDw8IDY3IDw8 IDgwIDw8IDkwOwpAQCAtMTAwLDYgKzg2LDggQEAgdm9pZCBMYXVuY2hlcldpbmRvdzo6aW5pdCgp CiAgICAgfQogCiAgICAgZ3JhYlpvb21LZXlzKHRydWUpOworCisgICAgaW5pdGlhbGl6ZVZpZXco KTsKIH0KIAogdm9pZCBMYXVuY2hlcldpbmRvdzo6aW5pdGlhbGl6ZVZpZXcoKQpAQCAtMTMyLDEw ICsxMjAsMjQgQEAgdm9pZCBMYXVuY2hlcldpbmRvdzo6aW5pdGlhbGl6ZVZpZXcoKQogICAgICAg ICBtX3ZpZXcgPSB2aWV3OwogICAgIH0KIAorICAgIG1fdG91Y2hNb2NraW5nID0gZmFsc2U7CisK KyAgICBjb25uZWN0KHBhZ2UoKSwgU0lHTkFMKGxvYWRTdGFydGVkKCkpLCB0aGlzLCBTTE9UKGxv YWRTdGFydGVkKCkpKTsKKyAgICBjb25uZWN0KHBhZ2UoKSwgU0lHTkFMKGxvYWRGaW5pc2hlZChi b29sKSksIHRoaXMsIFNMT1QobG9hZEZpbmlzaGVkKCkpKTsKKyAgICBjb25uZWN0KHBhZ2UoKSwg U0lHTkFMKGxpbmtIb3ZlcmVkKGNvbnN0IFFTdHJpbmcmLCBjb25zdCBRU3RyaW5nJiwgY29uc3Qg UVN0cmluZyYpKSwKKyAgICAgICAgICAgIHRoaXMsIFNMT1Qoc2hvd0xpbmtIb3Zlcihjb25zdCBR U3RyaW5nJiwgY29uc3QgUVN0cmluZyYpKSk7CisgICAgY29ubmVjdCh0aGlzLCBTSUdOQUwoZW50 ZXJlZEZ1bGxTY3JlZW5Nb2RlKGJvb2wpKSwgdGhpcywgU0xPVCh0b2dnbGVGdWxsU2NyZWVuTW9k ZShib29sKSkpOworCisgICAgYXBwbHlQcmVmcygpOworCisgICAgbV9pbnNwZWN0b3ItPnNldFBh Z2UocGFnZSgpKTsKKyAgICBtX2luc3BlY3Rvci0+aGlkZSgpOworCisgICAgaWYgKG1fd2luZG93 T3B0aW9ucy5yZW1vdGVJbnNwZWN0b3JQb3J0KQorICAgICAgICBwYWdlKCktPnNldFByb3BlcnR5 KCJfcV93ZWJJbnNwZWN0b3JTZXJ2ZXJQb3J0IiwgbV93aW5kb3dPcHRpb25zLnJlbW90ZUluc3Bl Y3RvclBvcnQpOworCiAgICAgaWYgKHVybC5pc1ZhbGlkKCkpCiAgICAgICAgIHBhZ2UoKS0+bWFp bkZyYW1lKCktPmxvYWQodXJsKTsKLQotICAgIG1fdG91Y2hNb2NraW5nID0gZmFsc2U7CiB9CiAK IHZvaWQgTGF1bmNoZXJXaW5kb3c6OmFwcGx5UHJlZnMoKQpAQCAtNjcyLDYgKzY3NCw4IEBAIHZv aWQgTGF1bmNoZXJXaW5kb3c6OnRvZ2dsZVdlYlZpZXcoYm9vbCAKIHsKICAgICBtX3dpbmRvd09w dGlvbnMudXNlR3JhcGhpY3NWaWV3ID0gZ3JhcGhpY3NCYXNlZDsKICAgICBpbml0aWFsaXplVmll dygpOworICAgIG1lbnVCYXIoKS0+Y2xlYXIoKTsKKyAgICBjcmVhdGVDaHJvbWUoKTsKIH0KIAog dm9pZCBMYXVuY2hlcldpbmRvdzo6dG9nZ2xlQWNjZWxlcmF0ZWRDb21wb3NpdGluZyhib29sIHRv Z2dsZSkK