48120 2010-10-22 03:36:02 -0700 SVGColor::cssText() shouldn't return #RRGGBBAA colors 2011-02-25 00:49:16 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED DUPLICATE 55119 P2 Normal --- 54539 1 kling webkit-unassigned krit mdelaney7 zimmermann oldest_to_newest 297890 0 kling 2010-10-22 03:36:02 -0700 For SVG_COLORTYPE_RGBCOLOR, SVGColor::cssText() currently returns Color::name() which uses #RRGGBBAA notation for colors with alpha < 255. These color values are not valid CSS and can't be set. We should return spec compliant serialized colors (i.e using rgba() notation for colors with alpha.) 297891 1 71545 kling 2010-10-22 03:43:21 -0700 Created attachment 71545 Proposed patch 297893 2 71545 darin 2010-10-22 03:48:21 -0700 Comment on attachment 71545 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=71545&action=review Fix looks good, but tests do not. > LayoutTests/ChangeLog:9 > + Color::serialized() is already exercised in depth by fast/canvas tests. Sure, it’s good that function has good test coverage, but this patch doesn’t include a test case for the bug you are fixing! These test results only show that we are switching from uppercase hex to lowercase hex. 297894 3 krit 2010-10-22 03:49:47 -0700 Ok, the problem is, that SVG doesn't support RGBA. But we added RGBA support recently with rgba(..,..,..,..). This is a violation of the specification, but a useful one. Therefor SVG_COLORTYPE_RGBCOLOR is also a unlucky name now, since it implicates that there are just three channels (what the spec explicitly wants). We should look what the other Browsers are doing and should definitely write to the www-svg mailing list. Didn't take a look at the SVG 1.1se specification, but I doubt that someone specified it yet. This is also a topic the svg-css task force should look at. Can you investigate more please? 357760 4 zimmermann 2011-02-25 00:49:16 -0800 For now, we shouldn't exose these colors through CSS, as long as it's not specified how. I'll also ask on the SVG WG, now that I'm a member :-) Bug 55119 rewrites SVGColor/SVGPaint to be spec compilant, and depends on this bug to be fixed, as well. *** This bug has been marked as a duplicate of bug 55119 *** 71545 2010-10-22 03:43:21 -0700 2010-10-22 03:48:20 -0700 Proposed patch bug-48120.diff text/plain 11759 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjZDQzZGJkLi43Y2Y4MTNlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMTAt MjEgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNWR0NvbG9yOjpjc3NUZXh0KCkgc2hvdWxk bid0IHJldHVybiAjUlJHR0JCQUEgY29sb3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00ODEyMAorCisgICAgICAgIFR3ZWFrIHRoZSBuZWNlc3Nhcnkg dGVzdHMgdG8gYWNjb3VudCBmb3IgdGhlIGNoYW5nZS4KKyAgICAgICAgQ29sb3I6OnNlcmlhbGl6 ZWQoKSBpcyBhbHJlYWR5IGV4ZXJjaXNlZCBpbiBkZXB0aCBieSBmYXN0L2NhbnZhcyB0ZXN0cy4K KworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtLW1hYy9zdmcvY3NzL2dldENvbXB1dGVkU3R5 bGUtYmFzaWMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtLXdpbi9z dmcvY3NzL2dldENvbXB1dGVkU3R5bGUtYmFzaWMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHBs YXRmb3JtL2d0ay9zdmcvY3NzL2dldENvbXB1dGVkU3R5bGUtYmFzaWMtZXhwZWN0ZWQudHh0Ogor ICAgICAgICAqIHN2Zy9jc3MvZ2V0Q29tcHV0ZWRTdHlsZS1iYXNpYy1leHBlY3RlZC50eHQ6Cisg ICAgICAgICogc3ZnL2N1c3RvbS9nZXRQcmVzZW50YXRpb25BdHRyaWJ1dGUtbW9kaWZ5LnN2ZzoK KyAgICAgICAgKiBzdmcvY3VzdG9tL3JnYmNvbG9yLXN5bnRheC5zdmc6CisKIDIwMTAtMTAtMjIg IE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgS2VudCBUYW11cmEuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1 bS1tYWMvc3ZnL2Nzcy9nZXRDb21wdXRlZFN0eWxlLWJhc2ljLWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLW1hYy9zdmcvY3NzL2dldENvbXB1dGVkU3R5bGUtYmFz aWMtZXhwZWN0ZWQudHh0CmluZGV4IGVmZjI0ZjIuLjQwNjUzYmIgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLW1hYy9zdmcvY3NzL2dldENvbXB1dGVkU3R5bGUtYmFz aWMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLW1hYy9z dmcvY3NzL2dldENvbXB1dGVkU3R5bGUtYmFzaWMtZXhwZWN0ZWQudHh0CkBAIC0zNjgsNyArMzY4 LDcgQEAgcmVjdDogc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZShjb2xvci1pbnRlcnBvbGF0aW9uLWZp bHRlcnMpIDogbGluZWFycmdiCiByZWN0OiBzdHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKGNvbG9y LWludGVycG9sYXRpb24tZmlsdGVycykgOiBbb2JqZWN0IENTU1ByaW1pdGl2ZVZhbHVlXQogcmVj dDogc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZShjb2xvci1yZW5kZXJpbmcpIDogYXV0bwogcmVjdDog c3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZShjb2xvci1yZW5kZXJpbmcpIDogW29iamVjdCBDU1NQ cmltaXRpdmVWYWx1ZV0KLXJlY3Q6IHN0eWxlLmdldFByb3BlcnR5VmFsdWUoZmlsbCkgOiAjMDAw MEZGCityZWN0OiBzdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKGZpbGwpIDogIzAwMDBmZgogcmVjdDog c3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZShmaWxsKSA6IFtvYmplY3QgU1ZHUGFpbnRdCiByZWN0 OiBzdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKGZpbGwtb3BhY2l0eSkgOiAxCiByZWN0OiBzdHlsZS5n ZXRQcm9wZXJ0eUNTU1ZhbHVlKGZpbGwtb3BhY2l0eSkgOiBbb2JqZWN0IENTU1ByaW1pdGl2ZVZh bHVlXQpAQCAtMzg0LDcgKzM4NCw3IEBAIHJlY3Q6IHN0eWxlLmdldFByb3BlcnR5VmFsdWUobWFy a2VyLXN0YXJ0KSA6IG5vbmUKIHJlY3Q6IHN0eWxlLmdldFByb3BlcnR5Q1NTVmFsdWUobWFya2Vy LXN0YXJ0KSA6IFtvYmplY3QgQ1NTUHJpbWl0aXZlVmFsdWVdCiByZWN0OiBzdHlsZS5nZXRQcm9w ZXJ0eVZhbHVlKHNoYXBlLXJlbmRlcmluZykgOiBhdXRvCiByZWN0OiBzdHlsZS5nZXRQcm9wZXJ0 eUNTU1ZhbHVlKHNoYXBlLXJlbmRlcmluZykgOiBbb2JqZWN0IENTU1ByaW1pdGl2ZVZhbHVlXQot cmVjdDogc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZShzdHJva2UpIDogI0ZGQTUwMAorcmVjdDogc3R5 bGUuZ2V0UHJvcGVydHlWYWx1ZShzdHJva2UpIDogI2ZmYTUwMAogcmVjdDogc3R5bGUuZ2V0UHJv cGVydHlDU1NWYWx1ZShzdHJva2UpIDogW29iamVjdCBTVkdQYWludF0KIHJlY3Q6IHN0eWxlLmdl dFByb3BlcnR5VmFsdWUoc3Ryb2tlLWRhc2hhcnJheSkgOiBub25lCiByZWN0OiBzdHlsZS5nZXRQ cm9wZXJ0eUNTU1ZhbHVlKHN0cm9rZS1kYXNoYXJyYXkpIDogW29iamVjdCBDU1NQcmltaXRpdmVW YWx1ZV0KQEAgLTgwNiw3ICs4MDYsNyBAQCBnOiBzdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKG1hcmtl ci1zdGFydCkgOiBub25lCiBnOiBzdHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKG1hcmtlci1zdGFy dCkgOiBbb2JqZWN0IENTU1ByaW1pdGl2ZVZhbHVlXQogZzogc3R5bGUuZ2V0UHJvcGVydHlWYWx1 ZShzaGFwZS1yZW5kZXJpbmcpIDogYXV0bwogZzogc3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZShz aGFwZS1yZW5kZXJpbmcpIDogW29iamVjdCBDU1NQcmltaXRpdmVWYWx1ZV0KLWc6IHN0eWxlLmdl dFByb3BlcnR5VmFsdWUoc3Ryb2tlKSA6ICNGRkE1MDAKK2c6IHN0eWxlLmdldFByb3BlcnR5VmFs dWUoc3Ryb2tlKSA6ICNmZmE1MDAKIGc6IHN0eWxlLmdldFByb3BlcnR5Q1NTVmFsdWUoc3Ryb2tl KSA6IFtvYmplY3QgU1ZHUGFpbnRdCiBnOiBzdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKHN0cm9rZS1k YXNoYXJyYXkpIDogbm9uZQogZzogc3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZShzdHJva2UtZGFz aGFycmF5KSA6IFtvYmplY3QgQ1NTUHJpbWl0aXZlVmFsdWVdCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS13aW4vc3ZnL2Nzcy9nZXRDb21wdXRlZFN0eWxlLWJhc2lj LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLXdpbi9zdmcvY3Nz L2dldENvbXB1dGVkU3R5bGUtYmFzaWMtZXhwZWN0ZWQudHh0CmluZGV4IGQ1NThkY2IuLmQyOGMz OGMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLXdpbi9zdmcvY3Nz L2dldENvbXB1dGVkU3R5bGUtYmFzaWMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL2Nocm9taXVtLXdpbi9zdmcvY3NzL2dldENvbXB1dGVkU3R5bGUtYmFzaWMtZXhwZWN0 ZWQudHh0CkBAIC0zNjgsNyArMzY4LDcgQEAgcmVjdDogc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZShj b2xvci1pbnRlcnBvbGF0aW9uLWZpbHRlcnMpIDogbGluZWFycmdiCiByZWN0OiBzdHlsZS5nZXRQ cm9wZXJ0eUNTU1ZhbHVlKGNvbG9yLWludGVycG9sYXRpb24tZmlsdGVycykgOiBbb2JqZWN0IENT U1ByaW1pdGl2ZVZhbHVlXQogcmVjdDogc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZShjb2xvci1yZW5k ZXJpbmcpIDogYXV0bwogcmVjdDogc3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZShjb2xvci1yZW5k ZXJpbmcpIDogW29iamVjdCBDU1NQcmltaXRpdmVWYWx1ZV0KLXJlY3Q6IHN0eWxlLmdldFByb3Bl cnR5VmFsdWUoZmlsbCkgOiAjMDAwMEZGCityZWN0OiBzdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKGZp bGwpIDogIzAwMDBmZgogcmVjdDogc3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZShmaWxsKSA6IFtv YmplY3QgU1ZHUGFpbnRdCiByZWN0OiBzdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKGZpbGwtb3BhY2l0 eSkgOiAxCiByZWN0OiBzdHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKGZpbGwtb3BhY2l0eSkgOiBb b2JqZWN0IENTU1ByaW1pdGl2ZVZhbHVlXQpAQCAtMzg0LDcgKzM4NCw3IEBAIHJlY3Q6IHN0eWxl LmdldFByb3BlcnR5VmFsdWUobWFya2VyLXN0YXJ0KSA6IG5vbmUKIHJlY3Q6IHN0eWxlLmdldFBy b3BlcnR5Q1NTVmFsdWUobWFya2VyLXN0YXJ0KSA6IFtvYmplY3QgQ1NTUHJpbWl0aXZlVmFsdWVd CiByZWN0OiBzdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKHNoYXBlLXJlbmRlcmluZykgOiBhdXRvCiBy ZWN0OiBzdHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKHNoYXBlLXJlbmRlcmluZykgOiBbb2JqZWN0 IENTU1ByaW1pdGl2ZVZhbHVlXQotcmVjdDogc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZShzdHJva2Up IDogI0ZGQTUwMAorcmVjdDogc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZShzdHJva2UpIDogI2ZmYTUw MAogcmVjdDogc3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZShzdHJva2UpIDogW29iamVjdCBTVkdQ YWludF0KIHJlY3Q6IHN0eWxlLmdldFByb3BlcnR5VmFsdWUoc3Ryb2tlLWRhc2hhcnJheSkgOiBu b25lCiByZWN0OiBzdHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKHN0cm9rZS1kYXNoYXJyYXkpIDog W29iamVjdCBDU1NQcmltaXRpdmVWYWx1ZV0KQEAgLTgwNiw3ICs4MDYsNyBAQCBnOiBzdHlsZS5n ZXRQcm9wZXJ0eVZhbHVlKG1hcmtlci1zdGFydCkgOiBub25lCiBnOiBzdHlsZS5nZXRQcm9wZXJ0 eUNTU1ZhbHVlKG1hcmtlci1zdGFydCkgOiBbb2JqZWN0IENTU1ByaW1pdGl2ZVZhbHVlXQogZzog c3R5bGUuZ2V0UHJvcGVydHlWYWx1ZShzaGFwZS1yZW5kZXJpbmcpIDogYXV0bwogZzogc3R5bGUu Z2V0UHJvcGVydHlDU1NWYWx1ZShzaGFwZS1yZW5kZXJpbmcpIDogW29iamVjdCBDU1NQcmltaXRp dmVWYWx1ZV0KLWc6IHN0eWxlLmdldFByb3BlcnR5VmFsdWUoc3Ryb2tlKSA6ICNGRkE1MDAKK2c6 IHN0eWxlLmdldFByb3BlcnR5VmFsdWUoc3Ryb2tlKSA6ICNmZmE1MDAKIGc6IHN0eWxlLmdldFBy b3BlcnR5Q1NTVmFsdWUoc3Ryb2tlKSA6IFtvYmplY3QgU1ZHUGFpbnRdCiBnOiBzdHlsZS5nZXRQ cm9wZXJ0eVZhbHVlKHN0cm9rZS1kYXNoYXJyYXkpIDogbm9uZQogZzogc3R5bGUuZ2V0UHJvcGVy dHlDU1NWYWx1ZShzdHJva2UtZGFzaGFycmF5KSA6IFtvYmplY3QgQ1NTUHJpbWl0aXZlVmFsdWVd CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvc3ZnL2Nzcy9nZXRDb21wdXRl ZFN0eWxlLWJhc2ljLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9zdmcv Y3NzL2dldENvbXB1dGVkU3R5bGUtYmFzaWMtZXhwZWN0ZWQudHh0CmluZGV4IGQ4Yzc1MDQuLjYy OTJmNGQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9zdmcvY3NzL2dldENv bXB1dGVkU3R5bGUtYmFzaWMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L2d0ay9zdmcvY3NzL2dldENvbXB1dGVkU3R5bGUtYmFzaWMtZXhwZWN0ZWQudHh0CkBAIC0zNjgs NyArMzY4LDcgQEAgcmVjdDogc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZShjb2xvci1pbnRlcnBvbGF0 aW9uLWZpbHRlcnMpIDogbGluZWFycmdiCiByZWN0OiBzdHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVl KGNvbG9yLWludGVycG9sYXRpb24tZmlsdGVycykgOiBbb2JqZWN0IENTU1ByaW1pdGl2ZVZhbHVl XQogcmVjdDogc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZShjb2xvci1yZW5kZXJpbmcpIDogYXV0bwog cmVjdDogc3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZShjb2xvci1yZW5kZXJpbmcpIDogW29iamVj dCBDU1NQcmltaXRpdmVWYWx1ZV0KLXJlY3Q6IHN0eWxlLmdldFByb3BlcnR5VmFsdWUoZmlsbCkg OiAjMDAwMEZGCityZWN0OiBzdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKGZpbGwpIDogIzAwMDBmZgog cmVjdDogc3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZShmaWxsKSA6IFtvYmplY3QgU1ZHUGFpbnRd CiByZWN0OiBzdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKGZpbGwtb3BhY2l0eSkgOiAxCiByZWN0OiBz dHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKGZpbGwtb3BhY2l0eSkgOiBbb2JqZWN0IENTU1ByaW1p dGl2ZVZhbHVlXQpAQCAtMzg0LDcgKzM4NCw3IEBAIHJlY3Q6IHN0eWxlLmdldFByb3BlcnR5VmFs dWUobWFya2VyLXN0YXJ0KSA6IG5vbmUKIHJlY3Q6IHN0eWxlLmdldFByb3BlcnR5Q1NTVmFsdWUo bWFya2VyLXN0YXJ0KSA6IFtvYmplY3QgQ1NTUHJpbWl0aXZlVmFsdWVdCiByZWN0OiBzdHlsZS5n ZXRQcm9wZXJ0eVZhbHVlKHNoYXBlLXJlbmRlcmluZykgOiBhdXRvCiByZWN0OiBzdHlsZS5nZXRQ cm9wZXJ0eUNTU1ZhbHVlKHNoYXBlLXJlbmRlcmluZykgOiBbb2JqZWN0IENTU1ByaW1pdGl2ZVZh bHVlXQotcmVjdDogc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZShzdHJva2UpIDogI0ZGQTUwMAorcmVj dDogc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZShzdHJva2UpIDogI2ZmYTUwMAogcmVjdDogc3R5bGUu Z2V0UHJvcGVydHlDU1NWYWx1ZShzdHJva2UpIDogW29iamVjdCBTVkdQYWludF0KIHJlY3Q6IHN0 eWxlLmdldFByb3BlcnR5VmFsdWUoc3Ryb2tlLWRhc2hhcnJheSkgOiBub25lCiByZWN0OiBzdHls ZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKHN0cm9rZS1kYXNoYXJyYXkpIDogW29iamVjdCBDU1NQcmlt aXRpdmVWYWx1ZV0KQEAgLTgwNiw3ICs4MDYsNyBAQCBnOiBzdHlsZS5nZXRQcm9wZXJ0eVZhbHVl KG1hcmtlci1zdGFydCkgOiBub25lCiBnOiBzdHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKG1hcmtl ci1zdGFydCkgOiBbb2JqZWN0IENTU1ByaW1pdGl2ZVZhbHVlXQogZzogc3R5bGUuZ2V0UHJvcGVy dHlWYWx1ZShzaGFwZS1yZW5kZXJpbmcpIDogYXV0bwogZzogc3R5bGUuZ2V0UHJvcGVydHlDU1NW YWx1ZShzaGFwZS1yZW5kZXJpbmcpIDogW29iamVjdCBDU1NQcmltaXRpdmVWYWx1ZV0KLWc6IHN0 eWxlLmdldFByb3BlcnR5VmFsdWUoc3Ryb2tlKSA6ICNGRkE1MDAKK2c6IHN0eWxlLmdldFByb3Bl cnR5VmFsdWUoc3Ryb2tlKSA6ICNmZmE1MDAKIGc6IHN0eWxlLmdldFByb3BlcnR5Q1NTVmFsdWUo c3Ryb2tlKSA6IFtvYmplY3QgU1ZHUGFpbnRdCiBnOiBzdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKHN0 cm9rZS1kYXNoYXJyYXkpIDogbm9uZQogZzogc3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZShzdHJv a2UtZGFzaGFycmF5KSA6IFtvYmplY3QgQ1NTUHJpbWl0aXZlVmFsdWVdCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9zdmcvY3NzL2dldENvbXB1dGVkU3R5bGUtYmFzaWMtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvc3ZnL2Nzcy9nZXRDb21wdXRlZFN0eWxlLWJhc2ljLWV4cGVjdGVkLnR4dApp bmRleCBkOGM3NTA0Li42MjkyZjRkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdmcvY3NzL2dl dENvbXB1dGVkU3R5bGUtYmFzaWMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL3N2Zy9j c3MvZ2V0Q29tcHV0ZWRTdHlsZS1iYXNpYy1leHBlY3RlZC50eHQKQEAgLTM2OCw3ICszNjgsNyBA QCByZWN0OiBzdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKGNvbG9yLWludGVycG9sYXRpb24tZmlsdGVy cykgOiBsaW5lYXJyZ2IKIHJlY3Q6IHN0eWxlLmdldFByb3BlcnR5Q1NTVmFsdWUoY29sb3ItaW50 ZXJwb2xhdGlvbi1maWx0ZXJzKSA6IFtvYmplY3QgQ1NTUHJpbWl0aXZlVmFsdWVdCiByZWN0OiBz dHlsZS5nZXRQcm9wZXJ0eVZhbHVlKGNvbG9yLXJlbmRlcmluZykgOiBhdXRvCiByZWN0OiBzdHls ZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKGNvbG9yLXJlbmRlcmluZykgOiBbb2JqZWN0IENTU1ByaW1p dGl2ZVZhbHVlXQotcmVjdDogc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZShmaWxsKSA6ICMwMDAwRkYK K3JlY3Q6IHN0eWxlLmdldFByb3BlcnR5VmFsdWUoZmlsbCkgOiAjMDAwMGZmCiByZWN0OiBzdHls ZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKGZpbGwpIDogW29iamVjdCBTVkdQYWludF0KIHJlY3Q6IHN0 eWxlLmdldFByb3BlcnR5VmFsdWUoZmlsbC1vcGFjaXR5KSA6IDEKIHJlY3Q6IHN0eWxlLmdldFBy b3BlcnR5Q1NTVmFsdWUoZmlsbC1vcGFjaXR5KSA6IFtvYmplY3QgQ1NTUHJpbWl0aXZlVmFsdWVd CkBAIC0zODQsNyArMzg0LDcgQEAgcmVjdDogc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZShtYXJrZXIt c3RhcnQpIDogbm9uZQogcmVjdDogc3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZShtYXJrZXItc3Rh cnQpIDogW29iamVjdCBDU1NQcmltaXRpdmVWYWx1ZV0KIHJlY3Q6IHN0eWxlLmdldFByb3BlcnR5 VmFsdWUoc2hhcGUtcmVuZGVyaW5nKSA6IGF1dG8KIHJlY3Q6IHN0eWxlLmdldFByb3BlcnR5Q1NT VmFsdWUoc2hhcGUtcmVuZGVyaW5nKSA6IFtvYmplY3QgQ1NTUHJpbWl0aXZlVmFsdWVdCi1yZWN0 OiBzdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKHN0cm9rZSkgOiAjRkZBNTAwCityZWN0OiBzdHlsZS5n ZXRQcm9wZXJ0eVZhbHVlKHN0cm9rZSkgOiAjZmZhNTAwCiByZWN0OiBzdHlsZS5nZXRQcm9wZXJ0 eUNTU1ZhbHVlKHN0cm9rZSkgOiBbb2JqZWN0IFNWR1BhaW50XQogcmVjdDogc3R5bGUuZ2V0UHJv cGVydHlWYWx1ZShzdHJva2UtZGFzaGFycmF5KSA6IG5vbmUKIHJlY3Q6IHN0eWxlLmdldFByb3Bl cnR5Q1NTVmFsdWUoc3Ryb2tlLWRhc2hhcnJheSkgOiBbb2JqZWN0IENTU1ByaW1pdGl2ZVZhbHVl XQpAQCAtODA2LDcgKzgwNiw3IEBAIGc6IHN0eWxlLmdldFByb3BlcnR5VmFsdWUobWFya2VyLXN0 YXJ0KSA6IG5vbmUKIGc6IHN0eWxlLmdldFByb3BlcnR5Q1NTVmFsdWUobWFya2VyLXN0YXJ0KSA6 IFtvYmplY3QgQ1NTUHJpbWl0aXZlVmFsdWVdCiBnOiBzdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKHNo YXBlLXJlbmRlcmluZykgOiBhdXRvCiBnOiBzdHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKHNoYXBl LXJlbmRlcmluZykgOiBbb2JqZWN0IENTU1ByaW1pdGl2ZVZhbHVlXQotZzogc3R5bGUuZ2V0UHJv cGVydHlWYWx1ZShzdHJva2UpIDogI0ZGQTUwMAorZzogc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZShz dHJva2UpIDogI2ZmYTUwMAogZzogc3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZShzdHJva2UpIDog W29iamVjdCBTVkdQYWludF0KIGc6IHN0eWxlLmdldFByb3BlcnR5VmFsdWUoc3Ryb2tlLWRhc2hh cnJheSkgOiBub25lCiBnOiBzdHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKHN0cm9rZS1kYXNoYXJy YXkpIDogW29iamVjdCBDU1NQcmltaXRpdmVWYWx1ZV0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3N2Zy9jdXN0b20vZ2V0UHJlc2VudGF0aW9uQXR0cmlidXRlLW1vZGlmeS5zdmcgYi9MYXlvdXRU ZXN0cy9zdmcvY3VzdG9tL2dldFByZXNlbnRhdGlvbkF0dHJpYnV0ZS1tb2RpZnkuc3ZnCmluZGV4 IDE3MDM4NmEuLmJiMjIyMWMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vZ2V0 UHJlc2VudGF0aW9uQXR0cmlidXRlLW1vZGlmeS5zdmcKKysrIGIvTGF5b3V0VGVzdHMvc3ZnL2N1 c3RvbS9nZXRQcmVzZW50YXRpb25BdHRyaWJ1dGUtbW9kaWZ5LnN2ZwpAQCAtMjIsNyArMjIsNyBA QAogICAgICAgICBmaWxsLnNldFJHQkNvbG9yKCJncmVlbiIpOwogICAgICAgICByZWN0ID0gZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoImZpcnN0cmVjdCIpOwogICAgICAgICBmaWxsID0gcmVjdC5n ZXRQcmVzZW50YXRpb25BdHRyaWJ1dGUoImZpbGwiKTsKLSAgICAgICAgaWYgKGZpbGwuY3NzVGV4 dCAhPSAnI0ZGMDAwMCcpIHsKKyAgICAgICAgaWYgKGZpbGwuY3NzVGV4dCAhPSAnI2ZmMDAwMCcp IHsKICAgICAgICAgICAgIGxvZygiQ2hhbmdpbmcgZmlsbCBQQSBzaG91bGQgbm90IGNoYW5nZSBm aXJzdHJlY3QgZmlsbCBQQSIpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3JnYmNvbG9yLXN5bnRheC5zdmcgYi9MYXlv dXRUZXN0cy9zdmcvY3VzdG9tL3JnYmNvbG9yLXN5bnRheC5zdmcKaW5kZXggYjQ3NTZkYi4uNDVk ZWE2ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9yZ2Jjb2xvci1zeW50YXgu c3ZnCisrKyBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vcmdiY29sb3Itc3ludGF4LnN2ZwpAQCAt NDQsOSArNDQsOSBAQAogICAgIGlmICghZXhwZWN0c0V4Y2VwdGlvbihjb2wsICIjZmZmZmYiKSkg cmV0dXJuOwogICAgIGlmICghZXhwZWN0c0V4Y2VwdGlvbihjb2wsICIjZmZmZmZmZiIpKSByZXR1 cm47CiAgICAgaWYgKCFleHBlY3RzRXhjZXB0aW9uKGNvbCwgImdyZWVuLCIpKSByZXR1cm47Ci0g ICAgaWYgKCFleHBlY3RzVmFsaWQoY29sLCAicmdiKDAsIDEwLCAyMCkiLCAiIzAwMEExNCIpKSBy ZXR1cm47Ci0gICAgaWYgKCFleHBlY3RzVmFsaWQoY29sLCAiI0ZGRiIsICIjRkZGRkZGIikpIHJl dHVybjsKLSAgICBpZiAoIWV4cGVjdHNWYWxpZChjb2wsICIjRkZGRkZGIiwgIiNGRkZGRkYiKSkg cmV0dXJuOworICAgIGlmICghZXhwZWN0c1ZhbGlkKGNvbCwgInJnYigwLCAxMCwgMjApIiwgIiMw MDBhMTQiKSkgcmV0dXJuOworICAgIGlmICghZXhwZWN0c1ZhbGlkKGNvbCwgIiNGRkYiLCAiI2Zm ZmZmZiIpKSByZXR1cm47CisgICAgaWYgKCFleHBlY3RzVmFsaWQoY29sLCAiI0ZGRkZGRiIsICIj ZmZmZmZmIikpIHJldHVybjsKICAgICBpZiAoIWV4cGVjdHNWYWxpZChjb2wsICIgZ3JlZW4iLCAi IzAwODAwMCIpKSByZXR1cm47CiAgICAgaWYgKCFleHBlY3RzVmFsaWQoY29sLCAiZ3JlZW4gIiwg IiMwMDgwMDAiKSkgcmV0dXJuOwogICAgIGlmICghZXhwZWN0c1ZhbGlkKGNvbCwgImdyZWVuIiwg IiMwMDgwMDAiKSkgcmV0dXJuOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJD b3JlL0NoYW5nZUxvZwppbmRleCA5MGQxOTAzLi5hY2UwZmNhIDEwMDY0NAotLS0gYS9XZWJDb3Jl L0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEw LTEwLTIxICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTVkdDb2xvcjo6Y3NzVGV4dCgpIHNo b3VsZG4ndCByZXR1cm4gI1JSR0dCQkFBIGNvbG9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDgxMjAKKworICAgICAgICAqIHN2Zy9TVkdDb2xvci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdDb2xvcjo6Y3NzVGV4dCk6IFJldHVybiBDb2xvcjo6 c2VyaWFsaXplZCgpCisgICAgICAgIGluc3RlYWQgb2YgQ29sb3I6Om5hbWUoKS4KKwogMjAxMC0x MC0yMiAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9z dmcvU1ZHQ29sb3IuY3BwIGIvV2ViQ29yZS9zdmcvU1ZHQ29sb3IuY3BwCmluZGV4IDc1OTAwYWQu LmM0MGYxOWQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvc3ZnL1NWR0NvbG9yLmNwcAorKysgYi9XZWJD b3JlL3N2Zy9TVkdDb2xvci5jcHAKQEAgLTg4LDcgKzg4LDcgQEAgdm9pZCBTVkdDb2xvcjo6c2V0 Q29sb3IodW5zaWduZWQgc2hvcnQgY29sb3JUeXBlLCBjb25zdCBTdHJpbmcmIC8qIHJnYkNvbG9y ICovICwKIFN0cmluZyBTVkdDb2xvcjo6Y3NzVGV4dCgpIGNvbnN0CiB7CiAgICAgaWYgKG1fY29s b3JUeXBlID09IFNWR19DT0xPUlRZUEVfUkdCQ09MT1IpCi0gICAgICAgIHJldHVybiBtX2NvbG9y Lm5hbWUoKTsKKyAgICAgICAgcmV0dXJuIG1fY29sb3Iuc2VyaWFsaXplZCgpOwogCiAgICAgcmV0 dXJuIFN0cmluZygpOwogfQo=