48117 2010-10-22 00:41:13 -0700 History item and document.location change. 2010-10-25 06:33:32 -0700 1 1 1 Unclassified WebKit History 528+ (Nightly build) All All RESOLVED FIXED P4 Normal --- 1 jedrzej.nowacki webkit-unassigned commit-queue jedrzej.nowacki mihaip msrinirao tonikitoo oldest_to_newest 297857 0 jedrzej.nowacki 2010-10-22 00:41:13 -0700 Behavior of back / forward history changed between QtWebkit 2.0 and the trunk. <html> <head> <script> document.location = "another url"; </script> </head> <body></body> </html> I believe that page above should not create a history item in the B/F history, which is the current behavior. From user point of view there is no difference between document.location and http redirection. Related mail thread (with real use case): https://lists.webkit.org/pipermail/webkit-qt/2010-October/000902.html 297859 1 71532 jedrzej.nowacki 2010-10-22 00:44:21 -0700 Created attachment 71532 test I would like to add this test 298021 2 71532 tonikitoo 2010-10-22 09:55:44 -0700 Comment on attachment 71532 test Tests! 298031 3 commit-queue 2010-10-22 10:14:51 -0700 The commit-queue encountered the following flaky tests while processing attachment 71532: java/lc3/JSObject/ToObject-001.html Please file bugs against the tests. The author(s) of the test(s) are ap@webkit.org and ap@webkit.org. The commit-queue is continuing to process your patch. 298036 4 71532 commit-queue 2010-10-22 10:15:39 -0700 Comment on attachment 71532 test Clearing flags on attachment: 71532 Committed r70315: <http://trac.webkit.org/changeset/70315> 298037 5 commit-queue 2010-10-22 10:15:45 -0700 All reviewed patches have been landed. Closing bug. 298195 6 mihaip 2010-10-22 14:52:30 -0700 FWIW, this behavior already had tests (e.g. http/tests/history/redirect-js-location-before-load.html), which were updated when the change was made: http://trac.webkit.org/changeset/65340. 298745 7 jedrzej.nowacki 2010-10-25 00:27:57 -0700 (In reply to comment #6) > FWIW, this behavior already had tests (e.g. http/tests/history/redirect-js-location-before-load.html), which were updated when the change was made: http://trac.webkit.org/changeset/65340. True, I've missed that one. Do you think it is worth to revert my test? If yes I can do it. 298816 8 mihaip 2010-10-25 06:33:32 -0700 (In reply to comment #7) > (In reply to comment #6) > > FWIW, this behavior already had tests (e.g. http/tests/history/redirect-js-location-before-load.html), which were updated when the change was made: http://trac.webkit.org/changeset/65340. > > True, I've missed that one. Do you think it is worth to revert my test? If yes I can do it. No, I think it's fine to leave as is. However, if you're going to be making other history-related changes, you may want to add tests to that directory instead. 71532 2010-10-22 00:44:21 -0700 2010-10-22 10:15:39 -0700 test test.diff text/plain 2340 jedrzej.nowacki ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0ZDkwYTlmLi44YTM0MjI1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMTAt MjIgIEplZHJ6ZWogTm93YWNraSAgPGplZHJ6ZWoubm93YWNraUBub2tpYS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG5ldyBMYXlvdXRU ZXN0IGNoZWNraW5nIHdlYiBoaXN0b3J5IG9uIGRvY3VtZW50LmxvY2F0aW9uIGNoYW5nZS4KKwor ICAgICAgICBUaGUgbmV3IHRlc3QgZW5mb3JjZSB0aGUgY3VycmVudCBiZWhhdmlvcjsgSWYgcmVk aXJlY3Rpb24gaXMgY2F1c2VkIGJ5CisgICAgICAgIGRvY3VtZW50LmxvY2F0aW9uIGNoYW5nZSwg aW1tZWRpYXRlbHkgYWZ0ZXIgYSBwYWdlIGxvYWQgYW5kIHdpdGhvdXQgdXNpbmcKKyAgICAgICAg c2V0VGltZW91dCwgYSB3ZWIgaGlzdG9yeSBpdGVtIHNob3VsZG4ndCBiZSBjcmVhdGVkLgorCisg ICAgICAgIEhpc3RvcnkgaXRlbSBhbmQgZG9jdW1lbnQubG9jYXRpb24gY2hhbmdlLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDgxMTcKKworICAgICAg ICAqIGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9kb2N1bWVudC1sb2NhdGlvbi1zY3JpcHQtZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL25hdmlnYXRpb24vZG9jdW1lbnQt bG9jYXRpb24tc2NyaXB0Lmh0bWw6IEFkZGVkLgorCiAyMDEwLTEwLTIwICBTaGluaWNoaXJvIEhh bWFqaSAgPGhhbWFqaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBU YW11cmEuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vZG9j dW1lbnQtbG9jYXRpb24tc2NyaXB0LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvbmF2aWdhdGlvbi9kb2N1bWVudC1sb2NhdGlvbi1zY3JpcHQtZXhwZWN0ZWQudHh0Cm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjQyNzhiN2UKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vZG9jdW1lbnQtbG9jYXRpb24tc2Ny aXB0LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDUgQEAKK1RoaXMgdGVzdHMgdGhhdCBhc3NpZ25p bmcgdG8gZG9jdW1lbnQubG9jYXRpb24gZnJvbSBhIHNjcmlwdCB0YWcgZG9lc24ndCBhZGQgYSBi YWNrL2ZvcndhcmQgaXRlbS4KKworPT09PT09PT09PT09PT0gQmFjayBGb3J3YXJkIExpc3QgPT09 PT09PT09PT09PT0KK2N1cnItPiAgaHR0cDovLzEyNy4wLjAuMTo4MDAwL25hdmlnYXRpb24vZG9j dW1lbnQtbG9jYXRpb24tc2NyaXB0Lmh0bWw/MSAgKipuYXYgdGFyZ2V0KioKKz09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vZG9jdW1lbnQtbG9jYXRpb24tc2NyaXB0Lmh0bWwg Yi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vZG9jdW1lbnQtbG9jYXRpb24tc2Ny aXB0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uM2RjZDE3YQotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9kb2N1bWVu dC1sb2NhdGlvbi1zY3JpcHQuaHRtbApAQCAtMCwwICsxLDIxIEBACis8aHRtbD4KKzxoZWFkPgor PHNjcmlwdD4KKyAgICB2YXIgbiA9IGRvY3VtZW50LmxvY2F0aW9uLnNlYXJjaC5zdWJzdHJpbmco MSk7CisgICAgaWYgKCFuKSB7CisgICAgICAvLyBwYWdlIGp1c3Qgb3BlbmVkCisgICAgICBsYXlv dXRUZXN0Q29udHJvbGxlci5kdW1wQmFja0ZvcndhcmRMaXN0KCk7CisgICAgICBsYXlvdXRUZXN0 Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0 VW50aWxEb25lKCk7CisKKyAgICAgIGRvY3VtZW50LmxvY2F0aW9uID0gIj8xIgorICAgIH0gZWxz ZSB7CisgICAgICAvLyBsb2FkZWQgdGhlID8xIG5hdmlnYXRpb24KKyAgICAgIGxheW91dFRlc3RD b250cm9sbGVyLm5vdGlmeURvbmUoKTsKKyAgfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4K K1RoaXMgdGVzdHMgdGhhdCBhc3NpZ25pbmcgdG8gZG9jdW1lbnQubG9jYXRpb24gZnJvbSBhIHNj cmlwdCB0YWcgZG9lc24ndCBhZGQgYSBiYWNrL2ZvcndhcmQgaXRlbS4KKzwvYm9keT4KKzwvaHRt bD4K