48079 2010-10-21 10:54:43 -0700 [Qt] InspectorClientQt crashes when deleting a qwebpage which has an inspector 2010-11-03 09:57:04 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 max.hong.shen webkit-unassigned ademar commit-queue suresh.voruganti oldest_to_newest 297507 0 max.hong.shen 2010-10-21 10:54:43 -0700 Steps to reproduce this issue 1. Launch QtTestBrowser and load a website like 'webkit.org' 2. on the menu bar, choose 'Developer'->'Show Web Inspector' 3. on the menu bar, choose 'Developer'->'QGraphicsView'->'Toggle use of QGraphicsView' Result, the QtTestBrowser crashes Following is the calltrace, #0 0x01e02d01 in WebCore::InspectorClientQt::sendMessageToFrontend (this=0x8242b50, message="{\"type\":\"event\",\"event\":\"disconnectFromBackend\",\"data\":{}}") at ../../../WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:258 #1 0x01500051 in WebCore::InspectorFrontend::disconnectFromBackend (this=0x844c370) at generated/InspectorFrontend.cpp:142 #2 0x019d5062 in WebCore::InspectorController::inspectedPageDestroyed (this=0x8264068) at ../../../WebCore/inspector/InspectorController.cpp:184 #3 0x01b3e8e8 in ~Page (this=0x8242ef8, __in_chrg=<value optimized out>) at ../../../WebCore/page/Page.cpp:215 #4 0x01e23934 in ~QWebPagePrivate (this=0x8229c98, __in_chrg=<value optimized out>) at ../../../WebKit/qt/Api/qwebpage.cpp:333 #5 0x01e28304 in ~QWebPage (this=0x820b558, __in_chrg=<value optimized out>) at ../../../WebKit/qt/Api/qwebpage.cpp:1771 #6 0x0807a11c in ~WebPage (this=0x820b558, __in_chrg=<value optimized out>) at ../../../../WebKitTools/QtTestBrowser/webpage.h:39 #7 0x08072c6e in MainWindow::setPage (this=0xb7500a70, page=0x8427c58) at ../../../../WebKitTools/QtTestBrowser/mainwindow.cpp:106 #8 0x08066f5e in LauncherWindow::initializeView (this=0xb7500a70) at ../../../../Web ... 297510 1 71460 max.hong.shen 2010-10-21 10:59:42 -0700 Created attachment 71460 first try 297950 2 max.hong.shen 2010-10-22 06:29:16 -0700 The problem is that m_inspectedWebPage->d->inspector is NULL in following snippet bool InspectorClientQt::sendMessageToFrontend(const String& message) { if (m_inspectedWebPage->d->inspector->d->remoteFrontend) { // crash 297952 3 max.hong.shen 2010-10-22 06:30:23 -0700 (In reply to comment #2) > The problem is that m_inspectedWebPage->d->inspector is NULL in following snippet > > bool InspectorClientQt::sendMessageToFrontend(const String& message) > { > if (m_inspectedWebPage->d->inspector->d->remoteFrontend) { // crash Sorry, m_inspectedWebPage->d->inspector->d is NULL 297973 4 71460 kling 2010-10-22 07:58:43 -0700 Comment on attachment 71460 first try LGTM. 297988 5 commit-queue 2010-10-22 08:34:56 -0700 The commit-queue encountered the following flaky tests while processing attachment 71460: java/lc3/JSObject/ToObject-001.html Please file bugs against the tests. The author(s) of the test(s) are ap@webkit.org and ap@webkit.org. The commit-queue is continuing to process your patch. 297991 6 71460 commit-queue 2010-10-22 08:35:48 -0700 Comment on attachment 71460 first try Clearing flags on attachment: 71460 Committed r70308: <http://trac.webkit.org/changeset/70308> 297992 7 commit-queue 2010-10-22 08:35:53 -0700 All reviewed patches have been landed. Closing bug. 299721 8 suresh.voruganti 2010-10-26 12:40:49 -0700 Yi, do we need this patch for Qtwebkit 2.1 branch? 299727 9 max.hong.shen 2010-10-26 12:46:13 -0700 (In reply to comment #8) > Yi, do we need this patch for Qtwebkit 2.1 branch? We'd better to have it. Thanks! 303457 10 suresh.voruganti 2010-11-02 10:28:06 -0700 Please cherry pick the fix for Qtwebkit 2.1 branch 304073 11 ademar 2010-11-03 09:56:53 -0700 Revision r70308 cherry-picked into qtwebkit-2.1 with commit da8bfab <http://gitorious.org/webkit/qtwebkit/commit/da8bfab> 71460 2010-10-21 10:59:42 -0700 2010-10-22 08:35:47 -0700 first try 48079.patch text/plain 1943 max.hong.shen SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNzAyNDkpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTAtMjEgIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gSW5zcGVjdG9yQ2xpZW50UXQgY3Jhc2hlcyB3aGVuIGRlbGV0aW5nIGEgcXdlYnBhZ2Ug d2hpY2ggaGFzIGFuIGluc3BlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDgwNzkKKworICAgICAgICAqIEFwaS9xd2VicGFnZS5jcHA6CisgICAg ICAgIChRV2ViUGFnZVByaXZhdGU6On5RV2ViUGFnZVByaXZhdGUpOgorICAgICAgICAoUVdlYlBh Z2U6On5RV2ViUGFnZSk6CisKIDIwMTAtMTAtMjAgIEx1aXogQWdvc3RpbmkgIDxsdWl6LmFnb3N0 aW5pQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50b25pbyBHb21lcy4K SW5kZXg6IFdlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9x dC9BcGkvcXdlYnBhZ2UuY3BwCShyZXZpc2lvbiA3MDIzMykKKysrIFdlYktpdC9xdC9BcGkvcXdl YnBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMjMsNiArMzIzLDExIEBAIFFXZWJQYWdlUHJp dmF0ZTo6UVdlYlBhZ2VQcml2YXRlKFFXZWJQYWcKIAogUVdlYlBhZ2VQcml2YXRlOjp+UVdlYlBh Z2VQcml2YXRlKCkKIHsKKyAgICBpZiAoaW5zcGVjdG9yICYmIGluc3BlY3RvcklzSW50ZXJuYWxP bmx5KSB7CisgICAgICAgIC8vIFNpbmNlIHdlIGhhdmUgdG8gZGVsZXRlIGFuIGludGVybmFsIGlu c3BlY3RvciwKKyAgICAgICAgLy8gY2FsbCBzZXRJbnNwZWN0b3IoMCkgZGlyZWN0bHkgdG8gcHJl dmVudCBwb3RlbnRpYWwgY3Jhc2hlcworICAgICAgICBzZXRJbnNwZWN0b3IoMCk7CisgICAgfQog I2lmbmRlZiBRVF9OT19DT05URVhUTUVOVQogICAgIGRlbGV0ZSBjdXJyZW50Q29udGV4dE1lbnU7 CiAjZW5kaWYKQEAgLTMzMiw2ICszMzcsOSBAQCBRV2ViUGFnZVByaXZhdGU6On5RV2ViUGFnZVBy aXZhdGUoKQogICAgIGRlbGV0ZSBzZXR0aW5nczsKICAgICBkZWxldGUgcGFnZTsKICAgICAKKyAg ICBpZiAoaW5zcGVjdG9yKQorICAgICAgICBpbnNwZWN0b3ItPnNldFBhZ2UoMCk7CisKICNpZiBF TkFCTEUoTk9USUZJQ0FUSU9OUykKICAgICBOb3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdDo6 bm90aWZpY2F0aW9uUHJlc2VudGVyKCktPnJlbW92ZUNsaWVudCgpOwogI2VuZGlmCkBAIC0xNzYw LDE0ICsxNzY4LDYgQEAgUVdlYlBhZ2U6On5RV2ViUGFnZSgpCiAgICAgRnJhbWVMb2FkZXIgKmxv YWRlciA9IGQtPm1haW5GcmFtZS0+ZC0+ZnJhbWUtPmxvYWRlcigpOwogICAgIGlmIChsb2FkZXIp CiAgICAgICAgIGxvYWRlci0+ZGV0YWNoRnJvbVBhcmVudCgpOwotICAgIGlmIChkLT5pbnNwZWN0 b3IpIHsKLSAgICAgICAgLy8gU2luY2Ugd2UgaGF2ZSB0byBkZWxldGUgYW4gaW50ZXJuYWwgaW5z cGVjdG9yLAotICAgICAgICAvLyBjYWxsIHNldEluc3BlY3RvcigwKSBkaXJlY3RseSB0byBwcmV2 ZW50IHBvdGVudGlhbCBjcmFzaGVzCi0gICAgICAgIGlmIChkLT5pbnNwZWN0b3JJc0ludGVybmFs T25seSkKLSAgICAgICAgICAgIGQtPnNldEluc3BlY3RvcigwKTsKLSAgICAgICAgZWxzZQotICAg ICAgICAgICAgZC0+aW5zcGVjdG9yLT5zZXRQYWdlKDApOwotICAgIH0KICAgICBkZWxldGUgZDsK IH0KIAo=