48070 2010-10-21 08:29:43 -0700 [Qt] When doing rendering through tiling, it seems the tiles are not initialized before rendering 2010-10-21 13:31:33 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Major --- 1 benjamin webkit-unassigned benjamin commit-queue kenneth koivisto noam oldest_to_newest 297433 0 71441 benjamin 2010-10-21 08:29:43 -0700 Created attachment 71441 Simple application showing the issue When a page is not defining a background color, the rendering of the background is incorect when tiling is used. The attached file show a page not rendered correctly when tiling is enabled. 297493 1 71453 noam 2010-10-21 10:17:27 -0700 Created attachment 71453 Patch 297536 2 71465 noam 2010-10-21 11:48:26 -0700 Created attachment 71465 Patch Right now it's too complicated to autotest TBS. it's a whole different task that's mutually exclusive from this fix. 297589 3 71465 hausmann 2010-10-21 13:06:27 -0700 Comment on attachment 71465 Patch Good catch. One more of these cases where QPixmap's lack of default-initialization bites us somewhat. 297602 4 71465 commit-queue 2010-10-21 13:31:28 -0700 Comment on attachment 71465 Patch Clearing flags on attachment: 71465 Committed r70262: <http://trac.webkit.org/changeset/70262> 297603 5 commit-queue 2010-10-21 13:31:33 -0700 All reviewed patches have been landed. Closing bug. 71441 2010-10-21 08:29:43 -0700 2010-10-21 08:29:43 -0700 Simple application showing the issue main.cpp text/plain 429 benjamin I2luY2x1ZGUgPFF0V2ViS2l0PgojaW5jbHVkZSA8UXRHdWk+CgppbnQgbWFpbihpbnQgYXJnYywg Y2hhciAqYXJndltdKQp7CiAgICBRQXBwbGljYXRpb24gYXBwKGFyZ2MsIGFyZ3YpOwoKICAgIFFH cmFwaGljc1ZpZXcgdmlldzsKICAgIHZpZXcuc2hvdygpOwogICAgUUdyYXBoaWNzU2NlbmUgc2Nl bmU7CiAgICB2aWV3LnNldFNjZW5lKCZzY2VuZSk7CgogICAgUUdyYXBoaWNzV2ViVmlldyAqd2Vi VmlldyA9IG5ldyBRR3JhcGhpY3NXZWJWaWV3OwogICAgd2ViVmlldy0+c2V0SHRtbCgiPGlucHV0 PiIpOwogICAgd2ViVmlldy0+c2V0dGluZ3MoKS0+c2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6 VGlsZWRCYWNraW5nU3RvcmVFbmFibGVkLCB0cnVlKTsKICAgIHNjZW5lLmFkZEl0ZW0od2ViVmll dyk7CgogICAgcmV0dXJuIGFwcC5leGVjKCk7Cn0K 71453 2010-10-21 10:17:27 -0700 2010-10-21 11:48:26 -0700 Patch patch-48070.diff text/plain 3315 noam ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmNmODIxMC4uNTAwMWZjYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMC0yMSAgTm8nYW0gUm9zZW50 aGFsICA8bm9hbS5yb3NlbnRoYWxAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gV2hlbiBkb2luZyByZW5kZXJpbmcgdGhyb3Vn aCB0aWxpbmcsIGl0IHNlZW1zIHRoZSB0aWxlcyBhcmUgbm90IGluaXRpYWxpemVkIGJlZm9yZSBy ZW5kZXJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ4MDcwCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3Rz IHRoYXQgbG9va2VkIGNvcnJ1cHQgd2hlbiB0aWxlZCBiYWNraW5nIHN0b3JlIHdhcyBlbmFibGVk LgorCisgICAgICAgICogcGFnZS9GcmFtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZTo6 dGlsZWRCYWNraW5nU3RvcmVCYWNrZ3JvdW5kQ29sb3IpOgorICAgICAgICAqIHBhZ2UvRnJhbWUu aDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZUNsaWVudC5o OgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L1RpbGVRdC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpUaWxlOjp1cGRhdGVCYWNrQnVmZmVyKToKKwogMjAxMC0xMC0yMSAgWXVyeSBTZW1p a2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLiBSZXZl cnQgcjcwMjMyLiBDaHJvbWl1bSBjb21waWxhdGlvbiBmYWlsdXJlLgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9wYWdlL0ZyYW1lLmNwcCBiL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAKaW5kZXggMTg2ZDU2 NC4uOGYxYTNkMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAorKysgYi9XZWJD b3JlL3BhZ2UvRnJhbWUuY3BwCkBAIC04NzksNiArODc5LDE0IEBAIEludFJlY3QgRnJhbWU6OnRp bGVkQmFja2luZ1N0b3JlVmlzaWJsZVJlY3QoKQogICAgICAgICByZXR1cm4gSW50UmVjdCgpOwog ICAgIHJldHVybiBtX3BhZ2UtPmNocm9tZSgpLT5jbGllbnQoKS0+dmlzaWJsZVJlY3RGb3JUaWxl ZEJhY2tpbmdTdG9yZSgpOwogfQorCitDb2xvciBGcmFtZTo6dGlsZWRCYWNraW5nU3RvcmVCYWNr Z3JvdW5kQ29sb3IoKQoreworICAgIGlmICghbV92aWV3KQorICAgICAgICByZXR1cm4gQ29sb3Io KTsKKyAgICByZXR1cm4gbV92aWV3LT5iYXNlQmFja2dyb3VuZENvbG9yKCk7Cit9CisKICNlbmRp ZgogCiBTdHJpbmcgRnJhbWU6OmxheWVyVHJlZUFzVGV4dCgpIGNvbnN0CmRpZmYgLS1naXQgYS9X ZWJDb3JlL3BhZ2UvRnJhbWUuaCBiL1dlYkNvcmUvcGFnZS9GcmFtZS5oCmluZGV4IGI0OGY1Yzgu LmZhOTA1M2EgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9GcmFtZS5oCisrKyBiL1dlYkNvcmUv cGFnZS9GcmFtZS5oCkBAIC0yMzcsNiArMjM3LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAg ICAgICB2aXJ0dWFsIHZvaWQgdGlsZWRCYWNraW5nU3RvcmVQYWludEVuZChjb25zdCBWZWN0b3I8 SW50UmVjdD4mIHBhaW50ZWRBcmVhKTsKICAgICAgICAgdmlydHVhbCBJbnRSZWN0IHRpbGVkQmFj a2luZ1N0b3JlQ29udGVudHNSZWN0KCk7CiAgICAgICAgIHZpcnR1YWwgSW50UmVjdCB0aWxlZEJh Y2tpbmdTdG9yZVZpc2libGVSZWN0KCk7CisgICAgICAgIHZpcnR1YWwgQ29sb3IgdGlsZWRCYWNr aW5nU3RvcmVCYWNrZ3JvdW5kQ29sb3IoKTsKIAogICAgICAgICBPd25QdHI8VGlsZWRCYWNraW5n U3RvcmU+IG1fdGlsZWRCYWNraW5nU3RvcmU7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmVDbGllbnQuaCBiL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmVDbGllbnQuaAppbmRleCBjNTg0NWI5Li45 MmUyOWJiIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFja2lu Z1N0b3JlQ2xpZW50LmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tp bmdTdG9yZUNsaWVudC5oCkBAIC0zMCw2ICszMCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZv aWQgdGlsZWRCYWNraW5nU3RvcmVQYWludEVuZChjb25zdCBWZWN0b3I8SW50UmVjdD4mIHBhaW50 ZWRBcmVhKSA9IDA7CiAgICAgdmlydHVhbCBJbnRSZWN0IHRpbGVkQmFja2luZ1N0b3JlQ29udGVu dHNSZWN0KCkgPSAwOwogICAgIHZpcnR1YWwgSW50UmVjdCB0aWxlZEJhY2tpbmdTdG9yZVZpc2li bGVSZWN0KCkgPSAwOworICAgIHZpcnR1YWwgQ29sb3IgdGlsZWRCYWNraW5nU3RvcmVCYWNrZ3Jv dW5kQ29sb3IoKSA9IDA7CiB9OwogCiAjZWxzZQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9xdC9UaWxlUXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9U aWxlUXQuY3BwCmluZGV4IDk2Mjg0NDguLjA5NmNlMTQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvcXQvVGlsZVF0LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3F0L1RpbGVRdC5jcHAKQEAgLTk3LDkgKzk3LDEwIEBAIHZvaWQgVGlsZTo6dXBkYXRlQmFj a0J1ZmZlcigpCiAgICAgICAgIHJldHVybjsKIAogICAgIGlmICghbV9iYWNrQnVmZmVyKSB7Ci0g ICAgICAgIGlmICghbV9idWZmZXIpCisgICAgICAgIGlmICghbV9idWZmZXIpIHsKICAgICAgICAg ICAgIG1fYmFja0J1ZmZlciA9IG5ldyBRUGl4bWFwKG1fYmFja2luZ1N0b3JlLT5tX3RpbGVTaXpl LndpZHRoKCksIG1fYmFja2luZ1N0b3JlLT5tX3RpbGVTaXplLmhlaWdodCgpKTsKLSAgICAgICAg ZWxzZSB7CisgICAgICAgICAgICBtX2JhY2tCdWZmZXItPmZpbGwobV9iYWNraW5nU3RvcmUtPm1f Y2xpZW50LT50aWxlZEJhY2tpbmdTdG9yZUJhY2tncm91bmRDb2xvcigpKTsKKyAgICAgICAgfSBl bHNlIHsKICAgICAgICAgICAgIC8vIEN1cnJlbnRseSBhbGwgYnVmZmVycyBhcmUgdXBkYXRlZCBz eW5jaHJvbm91c2x5IGF0IHRoZSBzYW1lIHRpbWUgc28gdGhlcmUgaXMgbm8gcmVhbCBuZWVkCiAg ICAgICAgICAgICAvLyB0byBoYXZlIHNlcGFyYXRlIGJhY2sgYW5kIGZyb250IGJ1ZmZlcnMuIEp1 c3QgdXNlIHRoZSBleGlzdGluZyBidWZmZXIuCiAgICAgICAgICAgICBtX2JhY2tCdWZmZXIgPSBt X2J1ZmZlcjsK 71465 2010-10-21 11:48:26 -0700 2010-10-21 13:31:28 -0700 Patch patch-48070.diff text/plain 3313 noam ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmNmODIxMC4uNTAwMWZjYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMC0yMSAgTm8nYW0gUm9zZW50 aGFsICA8bm9hbS5yb3NlbnRoYWxAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gV2hlbiBkb2luZyByZW5kZXJpbmcgdGhyb3Vn aCB0aWxpbmcsIGl0IHNlZW1zIHRoZSB0aWxlcyBhcmUgbm90IGluaXRpYWxpemVkIGJlZm9yZSBy ZW5kZXJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ4MDcwCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBBdXRvLXRlc3RzIGZvciBUaWxlZCBCYWNr aW5nIFN0b3JlIHNob3VsZCBiZSBhZGRlZCwgc2VlIGJ1ZyA0ODA4MgorCisgICAgICAgICogcGFn ZS9GcmFtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZTo6dGlsZWRCYWNraW5nU3RvcmVC YWNrZ3JvdW5kQ29sb3IpOgorICAgICAgICAqIHBhZ2UvRnJhbWUuaDoKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZUNsaWVudC5oOgorICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL3F0L1RpbGVRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUaWxlOjp1cGRh dGVCYWNrQnVmZmVyKToKKwogMjAxMC0xMC0yMSAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLiBSZXZlcnQgcjcwMjMyLiBDaHJvbWl1 bSBjb21waWxhdGlvbiBmYWlsdXJlLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL0ZyYW1lLmNw cCBiL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAKaW5kZXggMTg2ZDU2NC4uZjc1YmM5OCAxMDA2NDQK LS0tIGEvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAorKysgYi9XZWJDb3JlL3BhZ2UvRnJhbWUuY3Bw CkBAIC04NzksNiArODc5LDEzIEBAIEludFJlY3QgRnJhbWU6OnRpbGVkQmFja2luZ1N0b3JlVmlz aWJsZVJlY3QoKQogICAgICAgICByZXR1cm4gSW50UmVjdCgpOwogICAgIHJldHVybiBtX3BhZ2Ut PmNocm9tZSgpLT5jbGllbnQoKS0+dmlzaWJsZVJlY3RGb3JUaWxlZEJhY2tpbmdTdG9yZSgpOwog fQorCitDb2xvciBGcmFtZTo6dGlsZWRCYWNraW5nU3RvcmVCYWNrZ3JvdW5kQ29sb3IoKSBjb25z dAoreworICAgIGlmICghbV92aWV3KQorICAgICAgICByZXR1cm4gQ29sb3IoKTsKKyAgICByZXR1 cm4gbV92aWV3LT5iYXNlQmFja2dyb3VuZENvbG9yKCk7Cit9CiAjZW5kaWYKIAogU3RyaW5nIEZy YW1lOjpsYXllclRyZWVBc1RleHQoKSBjb25zdApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL0Zy YW1lLmggYi9XZWJDb3JlL3BhZ2UvRnJhbWUuaAppbmRleCBiNDhmNWM4Li44ZDEwZDhlIDEwMDY0 NAotLS0gYS9XZWJDb3JlL3BhZ2UvRnJhbWUuaAorKysgYi9XZWJDb3JlL3BhZ2UvRnJhbWUuaApA QCAtMjM3LDYgKzIzNyw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdmlydHVhbCB2 b2lkIHRpbGVkQmFja2luZ1N0b3JlUGFpbnRFbmQoY29uc3QgVmVjdG9yPEludFJlY3Q+JiBwYWlu dGVkQXJlYSk7CiAgICAgICAgIHZpcnR1YWwgSW50UmVjdCB0aWxlZEJhY2tpbmdTdG9yZUNvbnRl bnRzUmVjdCgpOwogICAgICAgICB2aXJ0dWFsIEludFJlY3QgdGlsZWRCYWNraW5nU3RvcmVWaXNp YmxlUmVjdCgpOworICAgICAgICB2aXJ0dWFsIENvbG9yIHRpbGVkQmFja2luZ1N0b3JlQmFja2dy b3VuZENvbG9yKCkgY29uc3Q7CiAKICAgICAgICAgT3duUHRyPFRpbGVkQmFja2luZ1N0b3JlPiBt X3RpbGVkQmFja2luZ1N0b3JlOwogI2VuZGlmCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL1RpbGVkQmFja2luZ1N0b3JlQ2xpZW50LmggYi9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL1RpbGVkQmFja2luZ1N0b3JlQ2xpZW50LmgKaW5kZXggYzU4NDViOS4uNjA4N2VjMyAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZUNs aWVudC5oCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmVD bGllbnQuaApAQCAtMzAsNiArMzAsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHRpbGVk QmFja2luZ1N0b3JlUGFpbnRFbmQoY29uc3QgVmVjdG9yPEludFJlY3Q+JiBwYWludGVkQXJlYSkg PSAwOwogICAgIHZpcnR1YWwgSW50UmVjdCB0aWxlZEJhY2tpbmdTdG9yZUNvbnRlbnRzUmVjdCgp ID0gMDsKICAgICB2aXJ0dWFsIEludFJlY3QgdGlsZWRCYWNraW5nU3RvcmVWaXNpYmxlUmVjdCgp ID0gMDsKKyAgICB2aXJ0dWFsIENvbG9yIHRpbGVkQmFja2luZ1N0b3JlQmFja2dyb3VuZENvbG9y KCkgY29uc3QgPSAwOwogfTsKIAogI2Vsc2UKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvcXQvVGlsZVF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvVGls ZVF0LmNwcAppbmRleCA5NjI4NDQ4Li4wOTZjZTE0IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3F0L1RpbGVRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9xdC9UaWxlUXQuY3BwCkBAIC05Nyw5ICs5NywxMCBAQCB2b2lkIFRpbGU6OnVwZGF0ZUJhY2tC dWZmZXIoKQogICAgICAgICByZXR1cm47CiAKICAgICBpZiAoIW1fYmFja0J1ZmZlcikgewotICAg ICAgICBpZiAoIW1fYnVmZmVyKQorICAgICAgICBpZiAoIW1fYnVmZmVyKSB7CiAgICAgICAgICAg ICBtX2JhY2tCdWZmZXIgPSBuZXcgUVBpeG1hcChtX2JhY2tpbmdTdG9yZS0+bV90aWxlU2l6ZS53 aWR0aCgpLCBtX2JhY2tpbmdTdG9yZS0+bV90aWxlU2l6ZS5oZWlnaHQoKSk7Ci0gICAgICAgIGVs c2UgeworICAgICAgICAgICAgbV9iYWNrQnVmZmVyLT5maWxsKG1fYmFja2luZ1N0b3JlLT5tX2Ns aWVudC0+dGlsZWRCYWNraW5nU3RvcmVCYWNrZ3JvdW5kQ29sb3IoKSk7CisgICAgICAgIH0gZWxz ZSB7CiAgICAgICAgICAgICAvLyBDdXJyZW50bHkgYWxsIGJ1ZmZlcnMgYXJlIHVwZGF0ZWQgc3lu Y2hyb25vdXNseSBhdCB0aGUgc2FtZSB0aW1lIHNvIHRoZXJlIGlzIG5vIHJlYWwgbmVlZAogICAg ICAgICAgICAgLy8gdG8gaGF2ZSBzZXBhcmF0ZSBiYWNrIGFuZCBmcm9udCBidWZmZXJzLiBKdXN0 IHVzZSB0aGUgZXhpc3RpbmcgYnVmZmVyLgogICAgICAgICAgICAgbV9iYWNrQnVmZmVyID0gbV9i dWZmZXI7Cg==