48062 2010-10-21 04:21:29 -0700 Add cmn to branch32(reg, imm) on ARM 2010-10-27 06:48:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other All RESOLVED FIXED P2 Enhancement --- 1 loki webkit-unassigned barraclough commit-queue oldest_to_newest 297365 0 loki 2010-10-21 04:21:29 -0700 There is a missing optimization in the branch32(cond, reg, imm) function on ARM. The conditional comparison can be done with cmn if the imm value is negative and can fit into the cmn instruction. 297366 1 71423 loki 2010-10-21 04:25:10 -0700 Created attachment 71423 Add cmn to branch32(reg, imm) on ARM 300181 2 71423 commit-queue 2010-10-27 06:48:23 -0700 Comment on attachment 71423 Add cmn to branch32(reg, imm) on ARM Clearing flags on attachment: 71423 Committed r70642: <http://trac.webkit.org/changeset/70642> 300182 3 commit-queue 2010-10-27 06:48:28 -0700 All reviewed patches have been landed. Closing bug. 71423 2010-10-21 04:25:10 -0700 2010-10-27 06:48:22 -0700 Add cmn to branch32(reg, imm) on ARM 0001-Add-cmn-to-branch32-reg-imm-on-ARM.patch text/plain 2040 loki RnJvbSAyODBjYzA3MGUxNTc1MGM0OTcyOTMwNTkyMjU5YTUzOThmODY5NGFmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHYWJvciBMb2tpIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KRGF0 ZTogVGh1LCAyMSBPY3QgMjAxMCAxMzoyMzowNCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBj bW4gdG8gYnJhbmNoMzIocmVnLCBpbW0pIG9uIEFSTQoKU2lnbmVkLW9mZi1ieTogR2Fib3IgTG9r aSA8bG9raUBpbmYudS1zemVnZWQuaHU+Ci0tLQogSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAg ICAgICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIEphdmFTY3JpcHRDb3JlL2Fz c2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oIHwgICAgOSArKysrKysrLS0KIDIgZmlsZXMgY2hh bmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggOTVi ZjQ3NS4uNDFlN2JiYyAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBi L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTEwLTIxICBH YWJvciBMb2tpICA8bG9raUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBjbW4gdG8gYnJhbmNoMzIocmVnLCBpbW0pIG9uIEFS TQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDgwNjIK KworICAgICAgICBUaGUgY29uZGl0aW9uYWwgY29tcGFyaXNvbiBjYW4gYmUgZG9uZSB3aXRoIGNt biBpZiB0aGUgaW1tIHZhbHVlIGlzCisgICAgICAgIG5lZ2F0aXZlIGFuZCBjYW4gZml0IGludG8g dGhlIGNtbiBpbnN0cnVjdGlvbi4KKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxl ckFSTS5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlckFSTTo6YnJhbmNoMzIpOgorCiAy MDEwLTEwLTIwICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIEZpeCB0aGUgRUZMIGJ1aWxkLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvYXNzZW1i bGVyL01hY3JvQXNzZW1ibGVyQVJNLmggYi9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9B c3NlbWJsZXJBUk0uaAppbmRleCA1ZGU4YjM0Li40OWM4N2MwIDEwMDY0NAotLS0gYS9KYXZhU2Ny aXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAorKysgYi9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaApAQCAtNDAwLDggKzQwMCwxMyBAQCBwdWJs aWM6CiAgICAgICAgIGlmIChyaWdodC5tX2lzUG9pbnRlcikgewogICAgICAgICAgICAgbV9hc3Nl bWJsZXIubGRyX3VuX2ltbShBUk1SZWdpc3RlcnM6OlMwLCByaWdodC5tX3ZhbHVlKTsKICAgICAg ICAgICAgIG1fYXNzZW1ibGVyLmNtcF9yKGxlZnQsIEFSTVJlZ2lzdGVyczo6UzApOwotICAgICAg ICB9IGVsc2UKLSAgICAgICAgICAgIG1fYXNzZW1ibGVyLmNtcF9yKGxlZnQsIG1fYXNzZW1ibGVy LmdldEltbShyaWdodC5tX3ZhbHVlLCBBUk1SZWdpc3RlcnM6OlMwKSk7CisgICAgICAgIH0gZWxz ZSB7CisgICAgICAgICAgICBBUk1Xb3JkIHRtcCA9IG1fYXNzZW1ibGVyLmdldE9wMigtcmlnaHQu bV92YWx1ZSk7CisgICAgICAgICAgICBpZiAodG1wICE9IEFSTUFzc2VtYmxlcjo6SU5WQUxJRF9J TU0pCisgICAgICAgICAgICAgICAgbV9hc3NlbWJsZXIuY21uX3IobGVmdCwgdG1wKTsKKyAgICAg ICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBtX2Fzc2VtYmxlci5jbXBfcihsZWZ0LCBtX2Fz c2VtYmxlci5nZXRJbW0ocmlnaHQubV92YWx1ZSwgQVJNUmVnaXN0ZXJzOjpTMCkpOworICAgICAg ICB9CiAgICAgICAgIHJldHVybiBKdW1wKG1fYXNzZW1ibGVyLmptcChBUk1Db25kaXRpb24oY29u ZCksIHVzZUNvbnN0YW50UG9vbCkpOwogICAgIH0KIAotLSAKMS43LjAuNAoK