48035 2010-10-20 18:45:05 -0700 WebWindowFeatures has a faulty constructor for WebCore::WindowFeatures 2010-11-24 06:15:04 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 usaini08 webkit-unassigned commit-queue ossy tonikitoo usaini08 oldest_to_newest 297197 0 usaini08 2010-10-20 18:45:05 -0700 In WebWindowFeatures.h, in the constructor of WebWindowFeatures that takes in a WebCore::WindowFeatures, we set the xSet/ySet/widthSet/heightSet variables to the same as the values of the passed in object. However, we do not set the corresponding x,y,width, and height variables, and hence if one of those "Set" boolean variables are true, the corresponding underlying variables will not be initialized. This leads to broken code, especially since I know when an underlying popup is created, this implicit constructor is called to transform objects of type WebCore::WindowFeatures into a WebKit::WebWindowFeature. 297198 1 71380 usaini08 2010-10-20 18:46:29 -0700 Created attachment 71380 Fix for implicit constructor that translates between WebKit::WebWindowFeature and WebCore::WindowFeature 297528 2 71464 usaini08 2010-10-21 11:40:58 -0700 Created attachment 71464 patch created via svn-create-patch. I couldn't run the diff from the root directory strangely. Also, couldn't find where or if the prepare-ChangeLog script sent the file to disk as I couldn't find it. There were no obvious errors there. 297560 3 71470 usaini08 2010-10-21 12:24:49 -0700 Created attachment 71470 Review for patch to WebWindowFeatures.h that fixes a constructor call to keep WebWindowFeatures always in a valid state. Updated the patch to contain the ChangeLog after getting that to work properly. 298332 4 71470 ossy 2010-10-23 00:02:39 -0700 Comment on attachment 71470 Review for patch to WebWindowFeatures.h that fixes a constructor call to keep WebWindowFeatures always in a valid state. Please add a changelog entry with WebKitTools/Scripts/prepare-changelog, and then add a comment to the changelog why this change is needed. Additionally run svn-create-patch from the root of the WebKit directory and not from WebKit/chromium. It will make EWS bots happier. :) 298965 5 71770 usaini08 2010-10-25 10:53:09 -0700 Created attachment 71770 patch created via svn-create-patch. Sorry, had uploaded the wrong file. 299085 6 71770 tonikitoo 2010-10-25 13:32:02 -0700 Comment on attachment 71770 patch created via svn-create-patch. Looks sane to me. 300489 7 usaini08 2010-10-27 13:06:05 -0700 Hi Csaba, Could you look at this for commit? (Either thumbs up or down?) Thanks, Udam 300557 8 71770 commit-queue 2010-10-27 14:06:23 -0700 Comment on attachment 71770 patch created via svn-create-patch. Rejecting patch 71770 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', 71770]" exit_code: 2 Last 500 characters of output: or --strip option? The text leading up to this was: -------------------------- |Index: public/WebWindowFeatures.h |=================================================================== |--- public/WebWindowFeatures.h (revision 69808) |+++ public/WebWindowFeatures.h (working copy) -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Antonio Gomes', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/4755049 300857 9 tonikitoo 2010-10-27 21:20:33 -0700 > The text leading up to this was: > -------------------------- > |Index: public/WebWindowFeatures.h > |=================================================================== > |--- public/WebWindowFeatures.h (revision 69808) > |+++ public/WebWindowFeatures.h (working copy) please submit patch generated against WebKit trunk. 301397 10 72251 usaini08 2010-10-28 15:51:31 -0700 Created attachment 72251 patch run on trunk. I believe this should be right directory on the WebKit trunk. 304832 11 usaini08 2010-11-04 13:32:24 -0700 Hi Csaba, Could you look at this for commit again? Thanks, Udam 305139 12 72251 commit-queue 2010-11-04 21:47:57 -0700 Comment on attachment 72251 patch run on trunk. Clearing flags on attachment: 72251 Committed r71391: <http://trac.webkit.org/changeset/71391> 313262 13 ossy 2010-11-24 06:15:04 -0800 Close, because the patch was landed. 71380 2010-10-20 18:46:29 -0700 2010-10-21 11:13:40 -0700 Fix for implicit constructor that translates between WebKit::WebWindowFeature and WebCore::WindowFeature webwindowfeature.txt text/plain 7121 usaini08 SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2luZG93RmVhdHVyZXMuaA0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2luZG93RmVhdHVyZXMuaAkocmV2 aXNpb24gNjk4MDgpDQorKysgV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJXaW5kb3dGZWF0dXJl cy5oCSh3b3JraW5nIGNvcHkpDQpAQCAtMSwxMDQgKzEsMTA4IEBADQotLyoNCi0gKiBDb3B5cmln aHQgKEMpIDIwMTAgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4NCi0gKg0KLSAqIFJl ZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Ig d2l0aG91dA0KLSAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRo ZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUNCi0gKiBtZXQ6DQotICoNCi0gKiAgICAgKiBSZWRp c3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdo dA0KLSAqIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcg ZGlzY2xhaW1lci4NCi0gKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVz dCByZXByb2R1Y2UgdGhlIGFib3ZlDQotICogY29weXJpZ2h0IG5vdGljZSwgdGhpcyBsaXN0IG9m IGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lcg0KLSAqIGluIHRoZSBkb2N1 bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUNCi0gKiBk aXN0cmlidXRpb24uDQotICogICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBu b3IgdGhlIG5hbWVzIG9mIGl0cw0KLSAqIGNvbnRyaWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBlbmRv cnNlIG9yIHByb21vdGUgcHJvZHVjdHMgZGVyaXZlZCBmcm9tDQotICogdGhpcyBzb2Z0d2FyZSB3 aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4NCi0gKg0KLSAqIFRISVMg U09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVJTIEFORCBDT05UUklC VVRPUlMNCi0gKiAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMs IElOQ0xVRElORywgQlVUIE5PVA0KLSAqIExJTUlURUQgVE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJ RVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUg0KLSAqIEEgUEFSVElDVUxBUiBQ VVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUDQot ICogT1dORVIgT1IgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJF Q1QsIElOQ0lERU5UQUwsDQotICogU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFM IERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVA0KLSAqIExJTUlURUQgVE8sIFBST0NVUkVNRU5U IE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLA0KLSAqIERBVEEs IE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5E IE9OIEFOWQ0KLSAqIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNU UklDVCBMSUFCSUxJVFksIE9SIFRPUlQNCi0gKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RI RVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UNCi0gKiBPRiBUSElTIFNP RlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdF Lg0KLSAqLw0KLQ0KLSNpZm5kZWYgV2ViV2luZG93RmVhdHVyZXNfaA0KLSNkZWZpbmUgV2ViV2lu ZG93RmVhdHVyZXNfaA0KLQ0KLSNpbmNsdWRlICJXZWJDb21tb24uaCINCi0jaW5jbHVkZSAiV2Vi U3RyaW5nLmgiDQotI2luY2x1ZGUgIldlYlZlY3Rvci5oIg0KLQ0KLSNpZiBXRUJLSVRfSU1QTEVN RU5UQVRJT04NCi0jaW5jbHVkZSAiV2luZG93RmVhdHVyZXMuaCINCi0jZW5kaWYNCi0NCi1uYW1l c3BhY2UgV2ViS2l0IHsNCi0NCi1zdHJ1Y3QgV2ViV2luZG93RmVhdHVyZXMgew0KLSAgICBmbG9h dCB4Ow0KLSAgICBib29sIHhTZXQ7DQotICAgIGZsb2F0IHk7DQotICAgIGJvb2wgeVNldDsNCi0g ICAgZmxvYXQgd2lkdGg7DQotICAgIGJvb2wgd2lkdGhTZXQ7DQotICAgIGZsb2F0IGhlaWdodDsN Ci0gICAgYm9vbCBoZWlnaHRTZXQ7DQotDQotICAgIGJvb2wgbWVudUJhclZpc2libGU7DQotICAg IGJvb2wgc3RhdHVzQmFyVmlzaWJsZTsNCi0gICAgYm9vbCB0b29sQmFyVmlzaWJsZTsNCi0gICAg Ym9vbCBsb2NhdGlvbkJhclZpc2libGU7DQotICAgIGJvb2wgc2Nyb2xsYmFyc1Zpc2libGU7DQot ICAgIGJvb2wgcmVzaXphYmxlOw0KLQ0KLSAgICBib29sIGZ1bGxzY3JlZW47DQotICAgIGJvb2wg ZGlhbG9nOw0KLSAgICBXZWJWZWN0b3I8V2ViU3RyaW5nPiBhZGRpdGlvbmFsRmVhdHVyZXM7DQot DQotICAgIFdlYldpbmRvd0ZlYXR1cmVzKCkNCi0gICAgICAgIDogeFNldChmYWxzZSkNCi0gICAg ICAgICwgeVNldChmYWxzZSkNCi0gICAgICAgICwgd2lkdGhTZXQoZmFsc2UpDQotICAgICAgICAs IGhlaWdodFNldChmYWxzZSkNCi0gICAgICAgICwgbWVudUJhclZpc2libGUodHJ1ZSkNCi0gICAg ICAgICwgc3RhdHVzQmFyVmlzaWJsZSh0cnVlKQ0KLSAgICAgICAgLCB0b29sQmFyVmlzaWJsZSh0 cnVlKQ0KLSAgICAgICAgLCBsb2NhdGlvbkJhclZpc2libGUodHJ1ZSkNCi0gICAgICAgICwgc2Ny b2xsYmFyc1Zpc2libGUodHJ1ZSkNCi0gICAgICAgICwgcmVzaXphYmxlKHRydWUpDQotICAgICAg ICAsIGZ1bGxzY3JlZW4oZmFsc2UpDQotICAgICAgICAsIGRpYWxvZyhmYWxzZSkNCi0gICAgew0K LSAgICB9DQotDQotDQotI2lmIFdFQktJVF9JTVBMRU1FTlRBVElPTg0KLSAgICBXZWJXaW5kb3dG ZWF0dXJlcyhjb25zdCBXZWJDb3JlOjpXaW5kb3dGZWF0dXJlcyYgZikNCi0gICAgICAgIDogeFNl dChmLnhTZXQpDQotICAgICAgICAsIHlTZXQoZi55U2V0KQ0KLSAgICAgICAgLCB3aWR0aFNldChm LndpZHRoU2V0KQ0KLSAgICAgICAgLCBoZWlnaHRTZXQoZi5oZWlnaHRTZXQpDQotICAgICAgICAs IG1lbnVCYXJWaXNpYmxlKGYubWVudUJhclZpc2libGUpDQotICAgICAgICAsIHN0YXR1c0JhclZp c2libGUoZi5zdGF0dXNCYXJWaXNpYmxlKQ0KLSAgICAgICAgLCB0b29sQmFyVmlzaWJsZShmLnRv b2xCYXJWaXNpYmxlKQ0KLSAgICAgICAgLCBsb2NhdGlvbkJhclZpc2libGUoZi5sb2NhdGlvbkJh clZpc2libGUpDQotICAgICAgICAsIHNjcm9sbGJhcnNWaXNpYmxlKGYuc2Nyb2xsYmFyc1Zpc2li bGUpDQotICAgICAgICAsIHJlc2l6YWJsZShmLnJlc2l6YWJsZSkNCi0gICAgICAgICwgZnVsbHNj cmVlbihmLmZ1bGxzY3JlZW4pDQotICAgICAgICAsIGRpYWxvZyhmLmRpYWxvZykNCi0gICAgICAg ICwgYWRkaXRpb25hbEZlYXR1cmVzKGYuYWRkaXRpb25hbEZlYXR1cmVzKQ0KLSAgICB7DQotICAg IH0NCi0jZW5kaWYNCi19Ow0KLQ0KLX0gLy8gbmFtZXNwYWNlIFdlYktpdA0KLQ0KLSNlbmRpZg0K Ky8qDQorICogQ29weXJpZ2h0IChDKSAyMDEwIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2 ZWQuDQorICoNCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5 IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQNCisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQg cHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlDQorICogbWV0Og0KKyAq DQorICogICAgICogUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRo ZSBhYm92ZSBjb3B5cmlnaHQNCisgKiBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFu ZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuDQorICogICAgICogUmVkaXN0cmlidXRpb25zIGlu IGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQ0KKyAqIGNvcHlyaWdodCBub3Rp Y2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIN CisgKiBpbiB0aGUgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVk IHdpdGggdGhlDQorICogZGlzdHJpYnV0aW9uLg0KKyAqICAgICAqIE5laXRoZXIgdGhlIG5hbWUg b2YgR29vZ2xlIEluYy4gbm9yIHRoZSBuYW1lcyBvZiBpdHMNCisgKiBjb250cmlidXRvcnMgbWF5 IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQ0KKyAq IHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24u DQorICoNCisgKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9M REVSUyBBTkQgQ09OVFJJQlVUT1JTDQorICogIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1Q TElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QNCisgKiBMSU1JVEVEIFRPLCBUSEUg SU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1INCisg KiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwg VEhFIENPUFlSSUdIVA0KKyAqIE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFO WSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLA0KKyAqIFNQRUNJQUwsIEVYRU1QTEFSWSwg T1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QNCisgKiBMSU1JVEVE IFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9G IFVTRSwNCisgKiBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhP V0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkNCisgKiBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVS IElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUDQorICogKElOQ0xVRElORyBO RUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNF DQorICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElU WSBPRiBTVUNIIERBTUFHRS4NCisgKi8NCisNCisjaWZuZGVmIFdlYldpbmRvd0ZlYXR1cmVzX2gN CisjZGVmaW5lIFdlYldpbmRvd0ZlYXR1cmVzX2gNCisNCisjaW5jbHVkZSAiV2ViQ29tbW9uLmgi DQorI2luY2x1ZGUgIldlYlN0cmluZy5oIg0KKyNpbmNsdWRlICJXZWJWZWN0b3IuaCINCisNCisj aWYgV0VCS0lUX0lNUExFTUVOVEFUSU9ODQorI2luY2x1ZGUgIldpbmRvd0ZlYXR1cmVzLmgiDQor I2VuZGlmDQorDQorbmFtZXNwYWNlIFdlYktpdCB7DQorDQorc3RydWN0IFdlYldpbmRvd0ZlYXR1 cmVzIHsNCisgICAgZmxvYXQgeDsNCisgICAgYm9vbCB4U2V0Ow0KKyAgICBmbG9hdCB5Ow0KKyAg ICBib29sIHlTZXQ7DQorICAgIGZsb2F0IHdpZHRoOw0KKyAgICBib29sIHdpZHRoU2V0Ow0KKyAg ICBmbG9hdCBoZWlnaHQ7DQorICAgIGJvb2wgaGVpZ2h0U2V0Ow0KKw0KKyAgICBib29sIG1lbnVC YXJWaXNpYmxlOw0KKyAgICBib29sIHN0YXR1c0JhclZpc2libGU7DQorICAgIGJvb2wgdG9vbEJh clZpc2libGU7DQorICAgIGJvb2wgbG9jYXRpb25CYXJWaXNpYmxlOw0KKyAgICBib29sIHNjcm9s bGJhcnNWaXNpYmxlOw0KKyAgICBib29sIHJlc2l6YWJsZTsNCisNCisgICAgYm9vbCBmdWxsc2Ny ZWVuOw0KKyAgICBib29sIGRpYWxvZzsNCisgICAgV2ViVmVjdG9yPFdlYlN0cmluZz4gYWRkaXRp b25hbEZlYXR1cmVzOw0KKw0KKyAgICBXZWJXaW5kb3dGZWF0dXJlcygpDQorICAgICAgICA6IHhT ZXQoZmFsc2UpDQorICAgICAgICAsIHlTZXQoZmFsc2UpDQorICAgICAgICAsIHdpZHRoU2V0KGZh bHNlKQ0KKyAgICAgICAgLCBoZWlnaHRTZXQoZmFsc2UpDQorICAgICAgICAsIG1lbnVCYXJWaXNp YmxlKHRydWUpDQorICAgICAgICAsIHN0YXR1c0JhclZpc2libGUodHJ1ZSkNCisgICAgICAgICwg dG9vbEJhclZpc2libGUodHJ1ZSkNCisgICAgICAgICwgbG9jYXRpb25CYXJWaXNpYmxlKHRydWUp DQorICAgICAgICAsIHNjcm9sbGJhcnNWaXNpYmxlKHRydWUpDQorICAgICAgICAsIHJlc2l6YWJs ZSh0cnVlKQ0KKyAgICAgICAgLCBmdWxsc2NyZWVuKGZhbHNlKQ0KKyAgICAgICAgLCBkaWFsb2co ZmFsc2UpDQorICAgIHsNCisgICAgfQ0KKw0KKw0KKyNpZiBXRUJLSVRfSU1QTEVNRU5UQVRJT04N CisgICAgV2ViV2luZG93RmVhdHVyZXMoY29uc3QgV2ViQ29yZTo6V2luZG93RmVhdHVyZXMmIGYp DQorICAgICAgICA6IHgoZi54KQ0KKyAgICAgICAgLCB4U2V0KGYueFNldCkNCisgICAgICAgICwg eShmLnkpDQorICAgICAgICAsIHlTZXQoZi55U2V0KQ0KKyAgICAgICAgLCB3aWR0aChmLndpZHRo KQ0KKyAgICAgICAgLCB3aWR0aFNldChmLndpZHRoU2V0KQ0KKyAgICAgICAgLCBoZWlnaHQoZi5o ZWlnaHQpDQorICAgICAgICAsIGhlaWdodFNldChmLmhlaWdodFNldCkNCisgICAgICAgICwgbWVu dUJhclZpc2libGUoZi5tZW51QmFyVmlzaWJsZSkNCisgICAgICAgICwgc3RhdHVzQmFyVmlzaWJs ZShmLnN0YXR1c0JhclZpc2libGUpDQorICAgICAgICAsIHRvb2xCYXJWaXNpYmxlKGYudG9vbEJh clZpc2libGUpDQorICAgICAgICAsIGxvY2F0aW9uQmFyVmlzaWJsZShmLmxvY2F0aW9uQmFyVmlz aWJsZSkNCisgICAgICAgICwgc2Nyb2xsYmFyc1Zpc2libGUoZi5zY3JvbGxiYXJzVmlzaWJsZSkN CisgICAgICAgICwgcmVzaXphYmxlKGYucmVzaXphYmxlKQ0KKyAgICAgICAgLCBmdWxsc2NyZWVu KGYuZnVsbHNjcmVlbikNCisgICAgICAgICwgZGlhbG9nKGYuZGlhbG9nKQ0KKyAgICAgICAgLCBh ZGRpdGlvbmFsRmVhdHVyZXMoZi5hZGRpdGlvbmFsRmVhdHVyZXMpDQorICAgIHsNCisgICAgfQ0K KyNlbmRpZg0KK307DQorDQorfSAvLyBuYW1lc3BhY2UgV2ViS2l0DQorDQorI2VuZGlmDQo= 71464 2010-10-21 11:40:58 -0700 2010-10-21 19:58:16 -0700 patch created via svn-create-patch. windowfeatures.txt text/plain 650 usaini08 SW5kZXg6IHB1YmxpYy9XZWJXaW5kb3dGZWF0dXJlcy5oDQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gcHVibGlj L1dlYldpbmRvd0ZlYXR1cmVzLmgJKHJldmlzaW9uIDY5ODA4KQorKysgcHVibGljL1dlYldpbmRv d0ZlYXR1cmVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTgxLDkgKzgxLDEzIEBAIHN0cnVjdCBXZWJX aW5kb3dGZWF0dXJlcyB7CiAKICNpZiBXRUJLSVRfSU1QTEVNRU5UQVRJT04KICAgICBXZWJXaW5k b3dGZWF0dXJlcyhjb25zdCBXZWJDb3JlOjpXaW5kb3dGZWF0dXJlcyYgZikKLSAgICAgICAgOiB4 U2V0KGYueFNldCkKKyAgICAgICAgOiB4KGYueCkKKyAgICAgICAgLCB4U2V0KGYueFNldCkKKyAg ICAgICAgLCB5KGYueSkKICAgICAgICAgLCB5U2V0KGYueVNldCkKKyAgICAgICAgLCB3aWR0aChm LndpZHRoKQogICAgICAgICAsIHdpZHRoU2V0KGYud2lkdGhTZXQpCisgICAgICAgICwgaGVpZ2h0 KGYuaGVpZ2h0KQogICAgICAgICAsIGhlaWdodFNldChmLmhlaWdodFNldCkKICAgICAgICAgLCBt ZW51QmFyVmlzaWJsZShmLm1lbnVCYXJWaXNpYmxlKQogICAgICAgICAsIHN0YXR1c0JhclZpc2li bGUoZi5zdGF0dXNCYXJWaXNpYmxlKQo= 71470 2010-10-21 12:24:49 -0700 2010-10-23 00:02:38 -0700 Review for patch to WebWindowFeatures.h that fixes a constructor call to keep WebWindowFeatures always in a valid state. windowfeatures.txt text/plain 650 usaini08 SW5kZXg6IHB1YmxpYy9XZWJXaW5kb3dGZWF0dXJlcy5oDQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gcHVibGlj L1dlYldpbmRvd0ZlYXR1cmVzLmgJKHJldmlzaW9uIDY5ODA4KQorKysgcHVibGljL1dlYldpbmRv d0ZlYXR1cmVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTgxLDkgKzgxLDEzIEBAIHN0cnVjdCBXZWJX aW5kb3dGZWF0dXJlcyB7CiAKICNpZiBXRUJLSVRfSU1QTEVNRU5UQVRJT04KICAgICBXZWJXaW5k b3dGZWF0dXJlcyhjb25zdCBXZWJDb3JlOjpXaW5kb3dGZWF0dXJlcyYgZikKLSAgICAgICAgOiB4 U2V0KGYueFNldCkKKyAgICAgICAgOiB4KGYueCkKKyAgICAgICAgLCB4U2V0KGYueFNldCkKKyAg ICAgICAgLCB5KGYueSkKICAgICAgICAgLCB5U2V0KGYueVNldCkKKyAgICAgICAgLCB3aWR0aChm LndpZHRoKQogICAgICAgICAsIHdpZHRoU2V0KGYud2lkdGhTZXQpCisgICAgICAgICwgaGVpZ2h0 KGYuaGVpZ2h0KQogICAgICAgICAsIGhlaWdodFNldChmLmhlaWdodFNldCkKICAgICAgICAgLCBt ZW51QmFyVmlzaWJsZShmLm1lbnVCYXJWaXNpYmxlKQogICAgICAgICAsIHN0YXR1c0JhclZpc2li bGUoZi5zdGF0dXNCYXJWaXNpYmxlKQo= 71770 2010-10-25 10:53:09 -0700 2010-10-27 14:06:23 -0700 patch created via svn-create-patch. webwindowfeatures.txt text/plain 1495 usaini08 SW5kZXg6IENoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIENoYW5nZUxvZwkocmV2aXNpb24gNzAy NTMpCisrKyBDaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0x MC0yMSAgdXNhaW5pICA8dXNhaW5pMDhAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYldpbmRvd0ZlYXR1cmVzIGhhcyBhIGZhdWx0 eSBjb25zdHJ1Y3RvciBmb3IgV2ViQ29yZTo6V2luZG93RmVhdHVyZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4MDM1CisKKyAgICAgICAgKiBXZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYldpbmRvd0ZlYXR1cmVzLmg6CisgICAgICAgIChXZWJLaXQ6 OldlYldpbmRvd0ZlYXR1cmVzOjpXZWJXaW5kb3dGZWF0dXJlcyk6IHVwZGF0ZWQgdGhlIGNvbnN0 cnVjdG9yCisgICAgICAgIHRoYXQgdGFrZXMgaW4gYSBXZWJDb3JlOjpXaW5kb3dGZWF0dXJlIGFu ZCBoYWQgaXQgY29weSBhbGwgdGhlIHZhcmlhYmxlcworICAgICAgICBvdmVyIHByb3Blcmx5IHNv IHRoYXQgYWZ0ZXIgY2FsbGluZyB0aGUgY29uc3RydWN0b3IgV2ViV2luZG93RmVhdHVyZXMgaXMK KyAgICAgICAgYWx3YXlzIGluIGEgdmFsaWQgc3RhdGUuCisKIDIwMTAtMTAtMjEgIFBhdmVsIEZl bGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVy eSBTZW1pa2hhdHNreS4KSW5kZXg6IHB1YmxpYy9XZWJXaW5kb3dGZWF0dXJlcy5oDQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09DQotLS0gV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJXaW5kb3dGZWF0dXJlcy5oCShyZXZp c2lvbiA2OTgwOCkKKysrIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2luZG93RmVhdHVyZXMu aAkod29ya2luZyBjb3B5KQpAQCAtODEsOSArODEsMTMgQEAgc3RydWN0IFdlYldpbmRvd0ZlYXR1 cmVzIHsKIAogI2lmIFdFQktJVF9JTVBMRU1FTlRBVElPTgogICAgIFdlYldpbmRvd0ZlYXR1cmVz KGNvbnN0IFdlYkNvcmU6OldpbmRvd0ZlYXR1cmVzJiBmKQotICAgICAgICA6IHhTZXQoZi54U2V0 KQorICAgICAgICA6IHgoZi54KQorICAgICAgICAsIHhTZXQoZi54U2V0KQorICAgICAgICAsIHko Zi55KQogICAgICAgICAsIHlTZXQoZi55U2V0KQorICAgICAgICAsIHdpZHRoKGYud2lkdGgpCiAg ICAgICAgICwgd2lkdGhTZXQoZi53aWR0aFNldCkKKyAgICAgICAgLCBoZWlnaHQoZi5oZWlnaHQp CiAgICAgICAgICwgaGVpZ2h0U2V0KGYuaGVpZ2h0U2V0KQogICAgICAgICAsIG1lbnVCYXJWaXNp YmxlKGYubWVudUJhclZpc2libGUpCiAgICAgICAgICwgc3RhdHVzQmFyVmlzaWJsZShmLnN0YXR1 c0JhclZpc2libGUpCg== 72251 2010-10-28 15:51:31 -0700 2010-11-04 21:47:57 -0700 patch run on trunk. WebWindowFeaturesPatch.txt text/plain 1651 usaini08 SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA3MDgxOCkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMC0yOCAgdXNh aW5pICA8dXNhaW5pMDhAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYldpbmRvd0ZlYXR1cmVzIGhhcyBhIGZhdWx0eSBjb25zdHJ1 Y3RvciBmb3IgV2ViQ29yZTo6V2luZG93RmVhdHVyZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4MDM1CisKKyAgICAgICAgKiBwdWJsaWMvV2ViV2lu ZG93RmVhdHVyZXMuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViV2luZG93RmVhdHVyZXM6OldlYldp bmRvd0ZlYXR1cmVzKTogdXBkYXRlZCB0aGUgY29uc3RydWN0b3IKKyAgICAgICAgdGhhdCB0YWtl cyBpbiBhIFdlYkNvcmU6OldpbmRvd0ZlYXR1cmUgYW5kIGhhZCBpdCBjb3B5IGFsbCB0aGUgdmFy aWFibGVzCisgICAgICAgIG92ZXIgcHJvcGVybHkgc28gdGhhdCBhZnRlciBjYWxsaW5nIHRoZSBj b25zdHJ1Y3RvciBXZWJXaW5kb3dGZWF0dXJlcyBpcworICAgICAgICBhbHdheXMgaW4gYSB2YWxp ZCBzdGF0ZS4gQmVmb3JlLCB0aGUgeCx5LHdpZHRoLGhlaWdodCBib29sZWFucyBtYXkgYmUgdHJ1 ZSwgYnV0CisgICAgICAgIHRoZSBjb3JyZXNwb25kaW5nIGludCB2YWx1ZXMgd291bGQgbm90IGJl IHVwZGF0ZWQuCisKIDIwMTAtMTAtMjggIEtpbnVrbyBZYXN1ZGEgIDxraW51a29AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpJbmRleDogV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJXaW5kb3dGZWF0dXJlcy5oDQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJXaW5kb3dGZWF0dXJlcy5oCShyZXZpc2lvbiA3MDgxNykKKysr IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2luZG93RmVhdHVyZXMuaAkod29ya2luZyBjb3B5 KQpAQCAtODEsOSArODEsMTMgQEAgc3RydWN0IFdlYldpbmRvd0ZlYXR1cmVzIHsKIAogI2lmIFdF QktJVF9JTVBMRU1FTlRBVElPTgogICAgIFdlYldpbmRvd0ZlYXR1cmVzKGNvbnN0IFdlYkNvcmU6 OldpbmRvd0ZlYXR1cmVzJiBmKQotICAgICAgICA6IHhTZXQoZi54U2V0KQorICAgICAgICA6IHgo Zi54KQorICAgICAgICAsIHhTZXQoZi54U2V0KQorICAgICAgICAsIHkoZi55KQogICAgICAgICAs IHlTZXQoZi55U2V0KQorICAgICAgICAsIHdpZHRoKGYud2lkdGgpCiAgICAgICAgICwgd2lkdGhT ZXQoZi53aWR0aFNldCkKKyAgICAgICAgLCBoZWlnaHQoZi5oZWlnaHQpCiAgICAgICAgICwgaGVp Z2h0U2V0KGYuaGVpZ2h0U2V0KQogICAgICAgICAsIG1lbnVCYXJWaXNpYmxlKGYubWVudUJhclZp c2libGUpCiAgICAgICAgICwgc3RhdHVzQmFyVmlzaWJsZShmLnN0YXR1c0JhclZpc2libGUpCg==