48009 2010-10-20 14:50:53 -0700 [Chromium] fast/repaint/renderer-destruction-by-invalidateSelection-crash needs image rebaseline for linux 2010-10-21 03:33:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jparent jparent abarth commit-queue tony oldest_to_newest 297044 0 jparent 2010-10-20 14:50:53 -0700 [Chromium] fast/repaint/renderer-destruction-by-invalidateSelection-crash needs image rebaseline for linux 297050 1 jparent 2010-10-20 14:56:47 -0700 Was incorrectly rebaselined in r61912 (massive rebaseline that was addressing scrollbar changes, but there are no scrollbars in this image) See http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png?rev=61911 vs http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png?rev=61912 297060 2 71346 jparent 2010-10-20 15:06:06 -0700 Created attachment 71346 Patch 297065 3 tony 2010-10-20 15:19:02 -0700 Should there be a change to test_expectations? It looks like the text output needs an update too? 297066 4 jparent 2010-10-20 15:20:35 -0700 No, the test still has a race condition, causing it to fail sporadically on both windows and linux (which is the text change you are seeing). It isn't correct to rebaseline that part. 297339 5 commit-queue 2010-10-21 03:32:44 -0700 The commit-queue encountered the following flaky tests while processing attachment 71346: http/tests/websocket/tests/multiple-connections.html Please file bugs against the tests. The author(s) of the test(s) have been CCed on this bug. The commit-queue is continuing to process your patch. 297340 6 71346 commit-queue 2010-10-21 03:33:42 -0700 Comment on attachment 71346 Patch Clearing flags on attachment: 71346 Committed r70224: <http://trac.webkit.org/changeset/70224> 297341 7 commit-queue 2010-10-21 03:33:48 -0700 All reviewed patches have been landed. Closing bug. 71346 2010-10-20 15:06:06 -0700 2010-10-21 03:33:42 -0700 Patch bug-48009-20101020150606.patch text/plain 5841 jparent SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwMTgxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMTAtMjAgIEp1bGllIFBhcmVudCAgPGpw YXJlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtDaHJvbWl1bV0gZmFzdC9yZXBhaW50L3JlbmRlcmVyLWRlc3RydWN0aW9u LWJ5LWludmFsaWRhdGVTZWxlY3Rpb24tY3Jhc2ggbmVlZHMgaW1hZ2UgcmViYXNlbGluZSBmb3Ig bGludXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4 MDA5CisKKyAgICAgICAgV2FzIGluY29ycmVjdGx5IHJlYmFzZWxpbmVkIGluIHI2MTkxMiAobWFz c2l2ZSByZWJhc2VsaW5lIGZvciAKKyAgICAgICAgc2Nyb2xsYmFyIGNoYW5nZXMsIGJ1dCB0aGlz IHRlc3QgaGFzIG5vIHNjcm9sbGJhcnMpLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0t bGludXgvZmFzdC9yZXBhaW50L3JlbmRlcmVyLWRlc3RydWN0aW9uLWJ5LWludmFsaWRhdGVTZWxl Y3Rpb24tY3Jhc2gtZXhwZWN0ZWQuY2hlY2tzdW06CisgICAgICAgICogcGxhdGZvcm0vY2hyb21p dW0tbGludXgvZmFzdC9yZXBhaW50L3JlbmRlcmVyLWRlc3RydWN0aW9uLWJ5LWludmFsaWRhdGVT ZWxlY3Rpb24tY3Jhc2gtZXhwZWN0ZWQucG5nOgorCiAyMDEwLTEwLTIwICBLZW5uZXRoIFJ1c3Nl bGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCB0ZXN0IGV4cGVjdGF0 aW9ucyB1cGRhdGUuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1saW51eC9m YXN0L3JlcGFpbnQvcmVuZGVyZXItZGVzdHJ1Y3Rpb24tYnktaW52YWxpZGF0ZVNlbGVjdGlvbi1j cmFzaC1leHBlY3RlZC5jaGVja3N1bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9jaHJvbWl1bS1saW51eC9mYXN0L3JlcGFpbnQvcmVuZGVyZXItZGVzdHJ1Y3Rpb24tYnktaW52 YWxpZGF0ZVNlbGVjdGlvbi1jcmFzaC1leHBlY3RlZC5jaGVja3N1bQkocmV2aXNpb24gNzAxODAp CisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1saW51eC9mYXN0L3JlcGFpbnQvcmVu ZGVyZXItZGVzdHJ1Y3Rpb24tYnktaW52YWxpZGF0ZVNlbGVjdGlvbi1jcmFzaC1leHBlY3RlZC5j aGVja3N1bQkod29ya2luZyBjb3B5KQpAQCAtMSArMSBAQAotMjVlMTU5OTUwNTMxN2QyZWVkNjhh NGI0OTRkYzVjYzUKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCis2NzkyZTQ0NTU3NzQ1NDFk NTlkMjVjNTMwMzI5MzhiZApcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKSW5kZXg6IExheW91 dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLWxpbnV4L2Zhc3QvcmVwYWludC9yZW5kZXJlci1kZXN0 cnVjdGlvbi1ieS1pbnZhbGlkYXRlU2VsZWN0aW9uLWNyYXNoLWV4cGVjdGVkLnBuZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09CkNhbm5vdCBkaXNwbGF5OiBmaWxlIG1hcmtlZCBhcyBhIGJpbmFyeSB0eXBlLgpzdm46bWlt ZS10eXBlID0gaW1hZ2UvcG5nCgppVkJPUncwS0dnb0FBQUFOU1VoRVVnQUFBeUFBQUFKWUNBSUFB QUFWRkJVbkFBQUxmVWxFUVZSNG5PM2NNVzdUWUFDRzRRUVZSVUpJCnpLUkxVZTlRTVliRFpPUVdi QnlFbFpVdXpjQVJxcTVNalF4TEpKaWlnc0lOMGlLOVRxVHdQS3M5Zk9NcjI3K251OTF1QWdCQTU5 bXgKQndBQW5CcUJCUUFRRTFnQUFER0JCUUFRRTFnQUFER0JCUUFRRTFnQUFER0JCUUFRTzl0L2VY dS8ycTVYaHhqQytHYnp4ZXg4Y2V3VgpBSEQ2cG52KzVMNjlYMzM3OG41NHVEamdIa1owOFhKNHZm aW9zUUJnYlB1ZVlHM1hxKysvMy95YUw0ZGhPTmdnUm5KMWRmWGk1NmZ0CitrWmdBY0RZSG5sRk9K bE1obUZZTHBjSG1NS29OcHZOdysyeFJ3REEvK0dwSDdsUHA5TlJkd0FBbkF5bkNBRUFZZ0lMQUNB bXNBQUEKWWdJTEFDQW1zQUFBWWdJTEFDQW1zQUFBWWdJTEFDQW1zQUFBWWdJTEFDQW1zQUFBWWdJ TEFDQW1zQUFBWWdJTEFDQW1zQUFBWWs4TgpyTjF1TitvT0FJQ1RjZmJvSFplWGw1dk41Z0JUQUFC T3c3N0FtczBYODd2UHI1NWZQOXhlSDJ3UTQvbno0K3ZzN1lkanJ3Q0EwemZkCi8rNXZlNy9hcm04 T3RvWlJ6ZWJ2WnVlTFk2OEFnTlAzU0dBQkFQQ3ZuQ0lFQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFD QUlnSkxBQ0EKbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNB bU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQwpBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdK TEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKCkxBQ0FtTUFD QUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0Ft TUFDQUlnSkxBQ0EKbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pM QUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQwpBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNB SWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKCkxBQ0Ft TUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxB Q0FtTUFDQUlnSkxBQ0EKbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJ Z0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQwpBSWdKTEFDQW1NQUNBSWdKTEFDQW1N QUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKCkxB Q0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUln SkxBQ0FtTUFDQUlnSkxBQ0EKbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1B Q0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQwpBSWdKTEFDQW1NQUNBSWdKTEFD QW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdK CkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFD QUlnSkxBQ0FtTUFDQUlnSkxBQ0EKbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNB bU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQwpBSWdKTEFDQW1NQUNBSWdK TEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNB SWdKCkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0Ft TUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0EKbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pM QUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQwpBSWdKTEFDQW1NQUNB SWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1N QUNBSWdKCkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxB Q0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0EKbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJ Z0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQwpBSWdKTEFDQW1N QUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFD QW1NQUNBSWdKCkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUln SkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0EKbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1B Q0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQwpBSWdKTEFD QW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdK TEFDQW1NQUNBSWdKCkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFD QUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0EKbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNB bU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQwpBSWdK TEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNB SWdKTEFDQW1NQUNBSWdKCkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0Ft TUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0EKbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pM QUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQwpB SWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1N QUNBSWdKTEFDQW1NQUNBSWdKCkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxB Q0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0EKbU1BQ0FJZ0pMQUNBbU1BQ0FJ Z0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1B QwpBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFD QW1NQUNBSWdKTEFDQW1NQUNBSWdKCkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUln SkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0EKbU1BQ0FJZ0pMQUNBbU1B Q0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNB bU1BQwpBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdK TEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKCkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFD QUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0EKbU1BQ0FJZ0pMQUNB bU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pM QUNBbU1BQwpBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNB SWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKCkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0Ft TUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0EKbU1BQ0FJZ0pM QUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJ Z0pMQUNBbU1BQwpBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1N QUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKCkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxB Q0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0FtTUFDQUlnSkxBQ0EKbU1BQ0FJ Z0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1BQ0FJZ0pMQUNBbU1B Q0FJZ0pMQUNBbU1BQwpBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFD QW1NQUNBSWdKTEFDQW1NQUNBSWdKTEFDQW1NQUNBSWdKCkxBQ0FtTUFDQUlnSkxBQ0EyRitWYmtz K0dBQ2FHZ0FBQUFCSlJVNUVya0pnZ2c9PQoK