48005 2010-10-20 13:47:09 -0700 chromium_gpu port of new-run-webkit-tests must do Linux -> Win expectations fallback 2010-10-20 14:36:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr kbr abarth dpranke eric jamesr webkit.review.bot oldest_to_newest 296995 0 kbr 2010-10-20 13:47:09 -0700 The normal Chromium port of new-run-webkit-tests, when run on Linux, searches first the Linux directory for test expectations and then the Windows directory. The chromium-gpu port needs to do the same within the scope of the chromium-gpu directories. 296999 1 71333 kbr 2010-10-20 13:48:39 -0700 Created attachment 71333 Patch 297000 2 jamesr 2010-10-20 13:50:57 -0700 So on chromium linux with gpu it'll go: chromium-gpu-linux chromium-gpu-win chromium-gpu chromium-linux chromium-win chromium mac (alongside test) ? 297005 3 kbr 2010-10-20 13:53:51 -0700 (In reply to comment #2) > So on chromium linux with gpu it'll go: > > chromium-gpu-linux > chromium-gpu-win > chromium-gpu > chromium-linux > chromium-win > chromium > mac > (alongside test) > > ? Yes, that's right. Dirk and I discussed this last night and this is the intended and desired behavior. 297007 4 kbr 2010-10-20 13:54:57 -0700 Committed r70175: <http://trac.webkit.org/changeset/70175> 297013 5 71333 dpranke 2010-10-20 14:06:13 -0700 Comment on attachment 71333 Patch change looks good to me, although I'm not a reviewer. 297029 6 webkit.review.bot 2010-10-20 14:36:08 -0700 http://trac.webkit.org/changeset/70175 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: http/tests/xmlhttprequest/origin-whitelisting-removal.html 71333 2010-10-20 13:48:39 -0700 2010-10-20 14:06:13 -0700 Patch expectations-path-2.patch text/plain 1468 kbr SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwMTcxKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTAtMjAgIEtlbm5ldGggUnVzc2VsbCAg PGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGNocm9taXVtX2dwdSBwb3J0IG9mIG5ldy1ydW4td2Via2l0LXRlc3RzIG11c3Qg ZG8gTGludXggLT4gV2luIGV4cGVjdGF0aW9ucyBmYWxsYmFjaworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDgwMDUKKworICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fZ3B1LnB5OgorCiAyMDEwLTEwLTIw ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RXJpYyBTZWlkZWwuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L2Nocm9taXVtX2dwdS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2dwdS5weQkocmV2aXNpb24g NzAxNjkpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2Nocm9taXVtX2dwdS5weQkod29ya2luZyBjb3B5KQpAQCAtOTAsNyArOTAsOCBAQCBjbGFzcyBD aHJvbWl1bUdwdUxpbnV4UG9ydChjaHJvbWl1bV9saW51CiAgICAgICAgIGNocm9taXVtX2xpbnV4 LkNocm9taXVtTGludXhQb3J0Ll9faW5pdF9fKHNlbGYsICoqa3dhcmdzKQogCiAgICAgZGVmIGJh c2VsaW5lX3NlYXJjaF9wYXRoKHNlbGYpOgotICAgICAgICByZXR1cm4gKG1hcChzZWxmLl93ZWJr aXRfYmFzZWxpbmVfcGF0aCwgWydjaHJvbWl1bS1ncHUtbGludXgnLCAnY2hyb21pdW0tZ3B1J10p ICsKKyAgICAgICAgIyBNaW1pYyB0aGUgTGludXggLT4gV2luIGV4cGVjdGF0aW9ucyBmYWxsYmFj ayBpbiB0aGUgb3JkaW5hcnkgQ2hyb21pdW0gcG9ydC4KKyAgICAgICAgcmV0dXJuIChtYXAoc2Vs Zi5fd2Via2l0X2Jhc2VsaW5lX3BhdGgsIFsnY2hyb21pdW0tZ3B1LWxpbnV4JywgJ2Nocm9taXVt LWdwdS13aW4nLCAnY2hyb21pdW0tZ3B1J10pICsKICAgICAgICAgICAgICAgICBjaHJvbWl1bV9s aW51eC5DaHJvbWl1bUxpbnV4UG9ydC5iYXNlbGluZV9zZWFyY2hfcGF0aChzZWxmKSkKIAogICAg IGRlZiBwYXRoX3RvX3Rlc3RfZXhwZWN0YXRpb25zX2ZpbGUoc2VsZik6Cg==