47981 2010-10-20 06:23:20 -0700 [NRWT] Get child process number from environment variable 2010-10-21 02:35:21 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 rgabor webkit-unassigned abecsi commit-queue dino dpranke eric ojan ossy pol tony wsiegrist oldest_to_newest 296757 0 rgabor 2010-10-20 06:23:20 -0700 Get the child process number from an environment variable if it exists. It would be useful for buildbots. 296766 1 71284 rgabor 2010-10-20 06:33:25 -0700 Created attachment 71284 proposed patch 296768 2 ossy 2010-10-20 06:37:47 -0700 (In reply to comment #1) > Created an attachment (id=71284) [details] > proposed patch LGTM. ;) 296811 3 71284 ojan 2010-10-20 08:33:08 -0700 Comment on attachment 71284 proposed patch I don't have a problem with this, but how is an environment variable easier than just passing something on the commandline? 296815 4 ossy 2010-10-20 08:38:31 -0700 (In reply to comment #3) > (From update of attachment 71284 [details]) > I don't have a problem with this, but how is an environment variable easier than just passing something on the commandline? If you would like to add/modify a commandline parameter on the buildbot, you have to modify the buildbot master config and ask Bill to update the buildbot master. But you can easily set an environment variable locally. 296835 5 eric 2010-10-20 09:30:50 -0700 I guess. Always feels strange to have environment variables for these sorts of things. I assume the command-line wins out over the environment variable. If you have concerns like this you could also have the buildbot run some wrapper script that you can control more easily. 296883 6 rgabor 2010-10-20 11:35:22 -0700 (In reply to comment #5) > I guess. Always feels strange to have environment variables for these sorts of things. > > I assume the command-line wins out over the environment variable. > > If you have concerns like this you could also have the buildbot run some wrapper script that you can control more easily. Yes, the command-line is the primary. Now we run all of our buildbots with different and custom environment and these kind of options are not port or platform specifics so we can't set them on the buildbot master. The wrapper is not good because the buildbot master will "call" the original script not your wrapper. So I think that's the simplest way to set different child process number on buildbots like WEBKIT_WAIT_FOR_HTTPD in ORWT to set http lock and BUILD_WEBKIT_ARGS in build-webkit script. 296896 7 71284 commit-queue 2010-10-20 11:54:41 -0700 Comment on attachment 71284 proposed patch Rejecting patch 71284 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 71284]" exit_code: 2 Cleaning working directory Updating working directory Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Full output: http://queues.webkit.org/results/4534020 296901 8 71284 eric 2010-10-20 11:57:36 -0700 Comment on attachment 71284 proposed patch I think this was a false rejection from a run-away commit-node. 296986 9 71284 dpranke 2010-10-20 13:39:24 -0700 Comment on attachment 71284 proposed patch The patch looks good to me as well, although I'm not a reviewer. As with others, I'm not generally a fan of environmental variables, but it sounds like it is useful here. Ideally there'd be a comment next to this line in the code about *why* we're looking at the variable (since it's easily settable on the bots, unlike the command line) 297146 10 commit-queue 2010-10-20 17:01:11 -0700 The commit-queue encountered the following flaky tests while processing attachment 71284: transitions/transition-end-event-transform.html http/tests/appcache/fail-on-update-2.html Please file bugs against the tests. The author(s) of the test(s) have been CCed on this bug. The commit-queue is continuing to process your patch. 297312 11 71284 commit-queue 2010-10-21 02:35:14 -0700 Comment on attachment 71284 proposed patch Clearing flags on attachment: 71284 Committed r70217: <http://trac.webkit.org/changeset/70217> 297313 12 commit-queue 2010-10-21 02:35:21 -0700 All reviewed patches have been landed. Closing bug. 71284 2010-10-20 06:33:25 -0700 2010-10-21 02:35:14 -0700 proposed patch environ.patch text/plain 1412 rgabor SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwMDU2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTAtMTkgIEdhYm9yIFJhcGNzYW55aSAg PHJnYWJvckBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW05SV1RdIEdldCBjaGlsZCBwcm9jZXNzIG51bWJlciBmcm9tIGFu IGVudmlyb25tZW50IHZhcmlhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00Nzk4MQorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weToKKwogMjAxMC0xMC0xOCAgSm9jZWx5biBUdXJjb3R0 ZSAgPGpvY2VseW4udHVyY290dGVAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFu ZHJlYXMgS2xpbmcuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkJKHJldmlzaW9uIDcw MDU0KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dl YmtpdF90ZXN0cy5weQkod29ya2luZyBjb3B5KQpAQCAtMTQzNiw3ICsxNDM2LDggQEAgZGVmIF9z ZXRfdXBfZGVyaXZlZF9vcHRpb25zKHBvcnRfb2JqLCBvcAogCiAgICAgaWYgbm90IG9wdGlvbnMu Y2hpbGRfcHJvY2Vzc2VzOgogICAgICAgICAjIEZJWE1FOiBJbnZlc3RpZ2F0ZSBwZXJmL2ZsYWtp bmVzcyBpbXBhY3Qgb2YgdXNpbmcgY3B1X2NvdW50ICsgMS4KLSAgICAgICAgb3B0aW9ucy5jaGls ZF9wcm9jZXNzZXMgPSBzdHIocG9ydF9vYmouZGVmYXVsdF9jaGlsZF9wcm9jZXNzZXMoKSkKKyAg ICAgICAgb3B0aW9ucy5jaGlsZF9wcm9jZXNzZXMgPSBvcy5lbnZpcm9uLmdldCgiV0VCS0lUX1RF U1RfQ0hJTERfUFJPQ0VTU0VTIiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBzdHIocG9ydF9vYmouZGVmYXVsdF9jaGlsZF9wcm9jZXNzZXMoKSkpCiAK ICAgICBpZiBub3Qgb3B0aW9ucy5jb25maWd1cmF0aW9uOgogICAgICAgICBvcHRpb25zLmNvbmZp Z3VyYXRpb24gPSBwb3J0X29iai5kZWZhdWx0X2NvbmZpZ3VyYXRpb24oKQo=