47972 2010-10-20 00:25:55 -0700 [GTK] use gtk_widget_hide instead of gtk_widget_hide_all in the fullscreen video conroller 2010-10-20 00:53:09 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned xan.lopez oldest_to_newest 296671 0 pnormand 2010-10-20 00:25:55 -0700 hide_all has been deprecated in GTK+3, we should use gtk_widget_hide instead 296677 1 71260 pnormand 2010-10-20 00:43:33 -0700 Created attachment 71260 proposed patch 296681 2 71260 xan.lopez 2010-10-20 00:45:30 -0700 Comment on attachment 71260 proposed patch r=me 296689 3 pnormand 2010-10-20 00:53:09 -0700 Committed r70133: <http://trac.webkit.org/changeset/70133> 71260 2010-10-20 00:43:33 -0700 2010-10-20 00:45:30 -0700 proposed patch proposed-patch.patch text/plain 2004 pnormand RnJvbSBiMmMzMjk2NGFhYjM5MzQxZjM1NDQ3MjU0ZTU5Nzc4YTk1MDU4MDcyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDIwIE9jdCAyMDEwIDA5OjQ0OjI2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDExICsrKysrKysrKysrCiAuLi4vV2ViQ29yZVN1cHBvcnQvRnVs bHNjcmVlblZpZGVvQ29udHJvbGxlci5jcHAgICB8ICAgIDQgKystLQogMiBmaWxlcyBjaGFuZ2Vk LCAxMyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9n dGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggZDE5OTAyYy4uM2ZkZmM0 NyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMC0yMCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBu b3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW0dUS10gdXNlIGd0a193aWRnZXRfaGlkZSBpbnN0ZWFkIG9mIGd0a193aWRn ZXRfaGlkZV9hbGwgaW4gdGhlIGZ1bGxzY3JlZW4gdmlkZW8gY29ucm9sbGVyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Nzk3MgorCisgICAgICAgICog V2ViQ29yZVN1cHBvcnQvRnVsbHNjcmVlblZpZGVvQ29udHJvbGxlci5jcHA6CisgICAgICAgIChG dWxsc2NyZWVuVmlkZW9Db250cm9sbGVyOjpoaWRlSHVkKToKKyAgICAgICAgKEZ1bGxzY3JlZW5W aWRlb0NvbnRyb2xsZXI6OmV4aXRGdWxsc2NyZWVuKToKKwogMjAxMC0xMC0xOSAgSm9vbmUgSHVy ICA8am9vbmVAa2xkcC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29u LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9GdWxsc2NyZWVuVmlkZW9D b250cm9sbGVyLmNwcCBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRnVsbHNjcmVlblZpZGVv Q29udHJvbGxlci5jcHAKaW5kZXggMzAyZjAyOC4uMTU4YTNiOCAxMDA2NDQKLS0tIGEvV2ViS2l0 L2d0ay9XZWJDb3JlU3VwcG9ydC9GdWxsc2NyZWVuVmlkZW9Db250cm9sbGVyLmNwcAorKysgYi9X ZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Z1bGxzY3JlZW5WaWRlb0NvbnRyb2xsZXIuY3BwCkBA IC0yMTMsNyArMjEzLDcgQEAgdm9pZCBGdWxsc2NyZWVuVmlkZW9Db250cm9sbGVyOjpoaWRlSHVk KCkKICAgICBHZGtDdXJzb3IqIGN1cnNvciA9IGJsYW5rQ3Vyc29yKCk7CiAgICAgZ2RrX3dpbmRv d19zZXRfY3Vyc29yKHdpbmRvdywgY3Vyc29yKTsKIAotICAgIGd0a193aWRnZXRfaGlkZV9hbGwo bV9odWRXaW5kb3cpOworICAgIGd0a193aWRnZXRfaGlkZShtX2h1ZFdpbmRvdyk7CiAKICAgICBp ZiAobV9wcm9ncmVzc0JhclVwZGF0ZUlkKSB7CiAgICAgICAgIGdfc291cmNlX3JlbW92ZShtX3By b2dyZXNzQmFyVXBkYXRlSWQpOwpAQCAtMzUwLDcgKzM1MCw3IEBAIHZvaWQgRnVsbHNjcmVlblZp ZGVvQ29udHJvbGxlcjo6ZXhpdEZ1bGxzY3JlZW4oKQogICAgIGlmIChtX21lZGlhRWxlbWVudC0+ cGxhdGZvcm1NZWRpYSgpLnR5cGUgPT0gV2ViQ29yZTo6UGxhdGZvcm1NZWRpYTo6R1N0cmVhbWVy R1dvcmxkVHlwZSkKICAgICAgICAgbV9tZWRpYUVsZW1lbnQtPnBsYXRmb3JtTWVkaWEoKS5tZWRp YS5nc3RyZWFtZXJHV29ybGQtPmV4aXRGdWxsc2NyZWVuKCk7CiAKLSAgICBndGtfd2lkZ2V0X2hp ZGVfYWxsKG1fd2luZG93KTsKKyAgICBndGtfd2lkZ2V0X2hpZGUobV93aW5kb3cpOwogCiAgICAg Z3RrX3dpZGdldF9kZXN0cm95KG1faHVkV2luZG93KTsKICAgICBtX2h1ZFdpbmRvdyA9IDA7Ci0t IAoxLjcuMi4z