4797 2005-09-01 15:19:37 -0700 leaks of DOMStringImpl called from HTMLTokenizer::processToken, seen running webkit tests 2005-09-06 19:35:17 -0700 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 sullivan darin oldest_to_newest 18199 0 sullivan 2005-09-01 15:19:37 -0700 This bug is also in Radar as <rdar://4231952> This is split off from 4665. This is one of the many leaks found with these steps: 1. Build a development build of tip-of-tree WebKit 2. use run-webkit-tests --leaks Leak: 0x1d3fbb20 size=176 0x00540068 0x00690073 0x00200076 0x00650072 .T.h.i.s. .v.e.r 0x00790020 0x006c006f 0x006e0067 0x00200070 .y. .l.o.n.g. .p 0x00610072 0x00610067 0x00720061 0x00700068 .a.r.a.g.r.a.p.h 0x00200073 0x0068006f 0x0075006c 0x00640020 . .s.h.o.u.l.d. 0x00680061 0x00760065 0x00200061 0x00200062 .h.a.v.e. .a. .b 0x00690067 0x00200066 0x00690072 0x00730074 .i.g. .f.i.r.s.t 0x0020006c 0x00650074 0x00740065 0x0072000a . .l.e.t.t.e.r.. 0x00200020 0x00200020 0x00200020 0x00200077 . . . . . . . .w ... Call stack: [thread 239f]: | 0x0 | start | _start | main | dumpRenderTree | -[NSRunLoop runMode:beforeDate:] | CFRunLoopRunSpecific | __CFRunLoopRun | __CFRunLoopDoSources0 | _sendCallbacks | -[NSURLConnection(NSURLConnectionInternal) _sendCallbacks] | -[NSURLConnection (NSURLConnectionInternal) _sendDidReceiveDataCallback] | -[WebLoader connection:didReceiveData:lengthReceived:] | -[WebMainResourceLoader didReceiveData:lengthReceived:] | -[WebLoader didReceiveData:lengthReceived:] | - [WebMainResourceLoader addData:] | -[WebDataSource(WebPrivate) _receivedData:] | - [WebHTMLRepresentation receivedData:withDataSource:] | -[WebBridge receivedData:textEncodingName:] | -[WebCoreBridge addData:] | KWQKHTMLPart::addData(char const*, int) | KHTMLPart::write(char const*, int) | khtml::HTMLTokenizer::write(khtml::TokenizerString const&, bool) | khtml::HTMLTokenizer::processToken() | DOM::DOMStringImpl::DOMStringImpl[in-charge] (QChar const*, unsigned) | DOM::DOMStringImpl::DOMStringImpl[unified](QChar const*, unsigned) | khtml::main_thread_malloc(unsigned long) | malloc This one still occurs in tip of tree, though most of the bugs in 4665 have been fixed. I see it (at least sometimes) in leaks output from fast/dom/outerText and in fast/dom/outerText-no-element. 18776 1 3776 darin 2005-09-05 17:25:40 -0700 Created attachment 3776 fix for leak in setOuterText -- one call to removeChild that I missed 18777 2 3776 sullivan 2005-09-05 17:33:20 -0700 Comment on attachment 3776 fix for leak in setOuterText -- one call to removeChild that I missed whitespace looks wrong for textNext->parentNode()->removeChild() line, but r=me 18786 3 3777 darin 2005-09-05 22:10:32 -0700 Created attachment 3777 revised patch that fixes even more removeChild and replaceChild leaks 18812 4 3777 sullivan 2005-09-06 09:44:45 -0700 Comment on attachment 3777 revised patch that fixes even more removeChild and replaceChild leaks I had a couple of comments on IRC. 18813 5 darin 2005-09-06 09:46:38 -0700 Note to self: the "replaceChild(s, foot, exceptioncode);" needs to use "f" instead of "foot" when landing. 18940 6 darin 2005-09-06 19:35:17 -0700 Checked in a fix that should fix the leak described in this bug, as well as two others. The three bugs are bug 4795, bug 4796, and bug 4797. 3776 2005-09-05 17:25:40 -0700 2005-09-05 22:10:48 -0700 fix for leak in setOuterText -- one call to removeChild that I missed SetOuterTextLeakPatch.txt text/plain 694 darin SW5kZXg6IGtodG1sL2h0bWwvaHRtbF9lbGVtZW50aW1wbC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls ZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwvaHRtbC9odG1sX2VsZW1lbnRpbXBsLmNwcCx2CnJl dHJpZXZpbmcgcmV2aXNpb24gMS4xMDQKZGlmZiAtcCAtdSAtcjEuMTA0IGtodG1sL2h0bWwvaHRt bF9lbGVtZW50aW1wbC5jcHAKLS0tIGtodG1sL2h0bWwvaHRtbF9lbGVtZW50aW1wbC5jcHAJMyBT ZXAgMjAwNSAyMzowOTo1OSAtMDAwMAkxLjEwNAorKysga2h0bWwvaHRtbC9odG1sX2VsZW1lbnRp bXBsLmNwcAk2IFNlcCAyMDA1IDAwOjI2OjM5IC0wMDAwCkBAIC00NDcsNyArNDQ3LDkgQEAgdm9p ZCBIVE1MRWxlbWVudEltcGw6OnNldE91dGVyVGV4dChjb25zdAogCXQtPmFwcGVuZERhdGEodGV4 dE5leHQtPmRhdGEoKSwgZXhjZXB0aW9uKTsKICAgICAgICAgaWYgKGV4Y2VwdGlvbikKICAgICAg ICAgICAgIHJldHVybjsKKyAgICAgICAgdGV4dE5leHQtPnJlZigpOwogCXRleHROZXh0LT5wYXJl bnROb2RlKCktPnJlbW92ZUNoaWxkKHRleHROZXh0LCBleGNlcHRpb24pOworICAgICAgICB0ZXh0 TmV4dC0+ZGVyZWYoKTsKICAgICAgICAgaWYgKGV4Y2VwdGlvbikKICAgICAgICAgICAgIHJldHVy bjsKICAgICB9Cg== 3777 2005-09-05 22:10:32 -0700 2005-09-06 09:44:45 -0700 revised patch that fixes even more removeChild and replaceChild leaks LeakPatch.txt text/plain 5840 darin SW5kZXg6IGtodG1sL2h0bWwvaHRtbF9lbGVtZW50aW1wbC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls ZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwvaHRtbC9odG1sX2VsZW1lbnRpbXBsLmNwcCx2CnJl dHJpZXZpbmcgcmV2aXNpb24gMS4xMDQKZGlmZiAtcCAtdSAtcjEuMTA0IGtodG1sL2h0bWwvaHRt bF9lbGVtZW50aW1wbC5jcHAKLS0tIGtodG1sL2h0bWwvaHRtbF9lbGVtZW50aW1wbC5jcHAJMyBT ZXAgMjAwNSAyMzowOTo1OSAtMDAwMAkxLjEwNAorKysga2h0bWwvaHRtbC9odG1sX2VsZW1lbnRp bXBsLmNwcAk2IFNlcCAyMDA1IDA1OjEwOjU4IC0wMDAwCkBAIC0zNzEsOSArMzcxLDkgQEAgdm9p ZCBIVE1MRWxlbWVudEltcGw6OnNldE91dGVySFRNTChjb25zdAogICAgICAgICByZXR1cm47CiAg ICAgfQogICAgIAotICAgIGlmIChwYXJlbnROb2RlKCkpIHsKLSAgICAgICAgcGFyZW50Tm9kZSgp LT5yZXBsYWNlQ2hpbGQoZnJhZ21lbnQsIHRoaXMsIGV4Y2VwdGlvbik7Ci0gICAgfQorICAgIHJl ZigpOworICAgIHBhcmVudC0+cmVwbGFjZUNoaWxkKGZyYWdtZW50LCB0aGlzLCBleGNlcHRpb24p OworICAgIGRlcmVmKCk7CiB9CiAKIApAQCAtNDIxLDcgKzQyMSw5IEBAIHZvaWQgSFRNTEVsZW1l bnRJbXBsOjpzZXRPdXRlclRleHQoY29uc3QKICAgICB9CiAKICAgICBUZXh0SW1wbCAqdCA9IG5l dyBUZXh0SW1wbChkb2NQdHIoKSwgdGV4dCk7CisgICAgcmVmKCk7CiAgICAgcGFyZW50LT5yZXBs YWNlQ2hpbGQodCwgdGhpcywgZXhjZXB0aW9uKTsKKyAgICBkZXJlZigpOwogICAgIGlmIChleGNl cHRpb24pCiAgICAgICAgIHJldHVybjsKIApAQCAtNDMyLDkgKzQzNCw3IEBAIHZvaWQgSFRNTEVs ZW1lbnRJbXBsOjpzZXRPdXRlclRleHQoY29uc3QKIAl0ZXh0UHJldi0+YXBwZW5kRGF0YSh0LT5k YXRhKCksIGV4Y2VwdGlvbik7CiAgICAgICAgIGlmIChleGNlcHRpb24pCiAgICAgICAgICAgICBy ZXR1cm47Ci0gICAgICAgIHQtPnJlZigpOwotCXQtPnBhcmVudE5vZGUoKS0+cmVtb3ZlQ2hpbGQo dCwgZXhjZXB0aW9uKTsKLSAgICAgICAgdC0+ZGVyZWYoKTsKKwl0LT5yZW1vdmUoZXhjZXB0aW9u KTsKICAgICAgICAgaWYgKGV4Y2VwdGlvbikKICAgICAgICAgICAgIHJldHVybjsKIAl0ID0gdGV4 dFByZXY7CkBAIC00NDcsNyArNDQ3LDcgQEAgdm9pZCBIVE1MRWxlbWVudEltcGw6OnNldE91dGVy VGV4dChjb25zdAogCXQtPmFwcGVuZERhdGEodGV4dE5leHQtPmRhdGEoKSwgZXhjZXB0aW9uKTsK ICAgICAgICAgaWYgKGV4Y2VwdGlvbikKICAgICAgICAgICAgIHJldHVybjsKLQl0ZXh0TmV4dC0+ cGFyZW50Tm9kZSgpLT5yZW1vdmVDaGlsZCh0ZXh0TmV4dCwgZXhjZXB0aW9uKTsKKwl0ZXh0TmV4 dC0+cmVtb3ZlKGV4Y2VwdGlvbik7CiAgICAgICAgIGlmIChleGNlcHRpb24pCiAgICAgICAgICAg ICByZXR1cm47CiAgICAgfQpJbmRleDoga2h0bWwvaHRtbC9odG1sX3RhYmxlaW1wbC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwvaHRtbC9odG1sX3RhYmxl aW1wbC5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNjIKZGlmZiAtcCAtdSAtcjEuNjIga2h0 bWwvaHRtbC9odG1sX3RhYmxlaW1wbC5jcHAKLS0tIGtodG1sL2h0bWwvaHRtbF90YWJsZWltcGwu Y3BwCTMxIEF1ZyAyMDA1IDE1OjM2OjEyIC0wMDAwCTEuNjIKKysrIGtodG1sL2h0bWwvaHRtbF90 YWJsZWltcGwuY3BwCTYgU2VwIDIwMDUgMDU6MTA6NTkgLTAwMDAKQEAgLTg4LDEzICs4OCwxNCBA QCBib29sIEhUTUxUYWJsZUVsZW1lbnRJbXBsOjpjaGVja0RURChjb25zCiBOb2RlSW1wbCogSFRN TFRhYmxlRWxlbWVudEltcGw6OnNldENhcHRpb24oIEhUTUxUYWJsZUNhcHRpb25FbGVtZW50SW1w bCAqYyApCiB7CiAgICAgaW50IGV4Y2VwdGlvbmNvZGUgPSAwOwotICAgIE5vZGVJbXBsKiByOwot ICAgIGlmKHRDYXB0aW9uKSB7Ci0gICAgICAgIHJlcGxhY2VDaGlsZCAoIGMsIHRDYXB0aW9uLCBl eGNlcHRpb25jb2RlICk7CisgICAgTm9kZUltcGwgKnI7CisgICAgaWYgKE5vZGVJbXBsICpvYyA9 IHRDYXB0aW9uKSB7CisgICAgICAgIG9jLT5yZWYoKTsKKyAgICAgICAgcmVwbGFjZUNoaWxkKGMs IG9jLCBleGNlcHRpb25jb2RlKTsKKyAgICAgICAgb2MtPmRlcmVmKCk7CiAgICAgICAgIHIgPSBj OwotICAgIH0KLSAgICBlbHNlCi0gICAgICAgIHIgPSBpbnNlcnRCZWZvcmUoIGMsIGZpcnN0Q2hp bGQoKSwgZXhjZXB0aW9uY29kZSApOworICAgIH0gZWxzZQorICAgICAgICByID0gaW5zZXJ0QmVm b3JlKGMsIGZpcnN0Q2hpbGQoKSwgZXhjZXB0aW9uY29kZSk7CiAgICAgdENhcHRpb24gPSBjOwog ICAgIHJldHVybiByOwogfQpAQCAtMTAyLDE4ICsxMDMsMTggQEAgTm9kZUltcGwqIEhUTUxUYWJs ZUVsZW1lbnRJbXBsOjpzZXRDYXB0aQogTm9kZUltcGwqIEhUTUxUYWJsZUVsZW1lbnRJbXBsOjpz ZXRUSGVhZCggSFRNTFRhYmxlU2VjdGlvbkVsZW1lbnRJbXBsICpzICkKIHsKICAgICBpbnQgZXhj ZXB0aW9uY29kZSA9IDA7Ci0gICAgTm9kZUltcGwqIHI7Ci0gICAgaWYoaGVhZCkgewotICAgICAg ICByZXBsYWNlQ2hpbGQoIHMsIGhlYWQsIGV4Y2VwdGlvbmNvZGUgKTsKKyAgICBOb2RlSW1wbCAq cjsKKyAgICBpZiAoTm9kZUltcGwgKmggPSBoZWFkKSB7CisgICAgICAgIGgtPnJlZigpOworICAg ICAgICByZXBsYWNlQ2hpbGQocywgaCwgZXhjZXB0aW9uY29kZSk7CisgICAgICAgIGgtPmRlcmVm KCkKICAgICAgICAgciA9IHM7Ci0gICAgfQotICAgIGVsc2UgaWYoIGZvb3QgKQotICAgICAgICBy ID0gaW5zZXJ0QmVmb3JlKCBzLCBmb290LCBleGNlcHRpb25jb2RlICk7Ci0gICAgZWxzZSBpZigg Zmlyc3RCb2R5ICkKLSAgICAgICAgciA9IGluc2VydEJlZm9yZSggcywgZmlyc3RCb2R5LCBleGNl cHRpb25jb2RlICk7CisgICAgfSBlbHNlIGlmIChmb290KQorICAgICAgICByID0gaW5zZXJ0QmVm b3JlKHMsIGZvb3QsIGV4Y2VwdGlvbmNvZGUpOworICAgIGVsc2UgaWYgKGZpcnN0Qm9keSkKKyAg ICAgICAgciA9IGluc2VydEJlZm9yZShzLCBmaXJzdEJvZHksIGV4Y2VwdGlvbmNvZGUpOwogICAg IGVsc2UKLSAgICAgICAgciA9IGFwcGVuZENoaWxkKCBzLCBleGNlcHRpb25jb2RlICk7Ci0KKyAg ICAgICAgciA9IGFwcGVuZENoaWxkKHMsIGV4Y2VwdGlvbmNvZGUpOwogICAgIGhlYWQgPSBzOwog ICAgIHJldHVybiByOwogfQpAQCAtMTIyLDEzICsxMjMsMTUgQEAgTm9kZUltcGwqIEhUTUxUYWJs ZUVsZW1lbnRJbXBsOjpzZXRURm9vdAogewogICAgIGludCBleGNlcHRpb25jb2RlID0gMDsKICAg ICBOb2RlSW1wbCogcjsKLSAgICBpZihmb290KSB7Ci0gICAgICAgIHJlcGxhY2VDaGlsZCAoIHMs IGZvb3QsIGV4Y2VwdGlvbmNvZGUgKTsKKyAgICBpZiAoTm9kZUltcGwgKmYgPSBmb290KSB7Cisg ICAgICAgIGYtPnJlZigpOworICAgICAgICByZXBsYWNlQ2hpbGQocywgZm9vdCwgZXhjZXB0aW9u Y29kZSk7CisgICAgICAgIGYtPmRlcmVmKCk7CiAgICAgICAgIHIgPSBzOwotICAgIH0gZWxzZSBp ZiggZmlyc3RCb2R5ICkKLSAgICAgICAgciA9IGluc2VydEJlZm9yZSggcywgZmlyc3RCb2R5LCBl eGNlcHRpb25jb2RlICk7CisgICAgfSBlbHNlIGlmIChmaXJzdEJvZHkpCisgICAgICAgIHIgPSBp bnNlcnRCZWZvcmUocywgZmlyc3RCb2R5LCBleGNlcHRpb25jb2RlKTsKICAgICBlbHNlCi0gICAg ICAgIHIgPSBhcHBlbmRDaGlsZCggcywgZXhjZXB0aW9uY29kZSApOworICAgICAgICByID0gYXBw ZW5kQ2hpbGQocywgZXhjZXB0aW9uY29kZSk7CiAgICAgZm9vdCA9IHM7CiAgICAgcmV0dXJuIHI7 CiB9CkBAIC0xMzcsMTYgKzE0MCwxNCBAQCBOb2RlSW1wbCogSFRNTFRhYmxlRWxlbWVudEltcGw6 OnNldFRCb2R5CiB7CiAgICAgaW50IGV4Y2VwdGlvbmNvZGUgPSAwOwogICAgIE5vZGVJbXBsKiBy OwotCiAgICAgcy0+cmVmKCk7Ci0gICAgaWYoZmlyc3RCb2R5KSB7Ci0gICAgICAgIHJlcGxhY2VD aGlsZCAoIHMsIGZpcnN0Qm9keSwgZXhjZXB0aW9uY29kZSApOwotICAgICAgICBmaXJzdEJvZHkt PmRlcmVmKCk7CisgICAgaWYgKE5vZGVJbXBsICpmYiA9IGZpcnN0Qm9keSkgeworICAgICAgICBy ZXBsYWNlQ2hpbGQocywgZmIsIGV4Y2VwdGlvbmNvZGUpOworICAgICAgICBmYi0+ZGVyZWYoKTsK ICAgICAgICAgciA9IHM7CiAgICAgfSBlbHNlCi0gICAgICAgIHIgPSBhcHBlbmRDaGlsZCggcywg ZXhjZXB0aW9uY29kZSApOworICAgICAgICByID0gYXBwZW5kQ2hpbGQocywgZXhjZXB0aW9uY29k ZSk7CiAgICAgZmlyc3RCb2R5ID0gczsKLQogICAgIHJldHVybiByOwogfQogCkluZGV4OiBraHRt bC94bWwvZG9tX25vZGVpbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2Vi Q29yZS9raHRtbC94bWwvZG9tX25vZGVpbXBsLmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4x ODQKZGlmZiAtcCAtdSAtcjEuMTg0IGtodG1sL3htbC9kb21fbm9kZWltcGwuY3BwCi0tLSBraHRt bC94bWwvZG9tX25vZGVpbXBsLmNwcAk0IFNlcCAyMDA1IDA5OjU1OjA3IC0wMDAwCTEuMTg0Cisr KyBraHRtbC94bWwvZG9tX25vZGVpbXBsLmNwcAk2IFNlcCAyMDA1IDA1OjExOjAxIC0wMDAwCkBA IC0yMzYsMTMgKzIzNiwxMiBAQCBOb2RlSW1wbCAqTm9kZUltcGw6OmFwcGVuZENoaWxkKCBOb2Rl SW1wCiAKIHZvaWQgTm9kZUltcGw6OnJlbW92ZShpbnQgJmV4Y2VwdGlvbmNvZGUpCiB7Ci0gICAg ZXhjZXB0aW9uY29kZSA9IDA7Ci0gICAgaWYgKCFwYXJlbnROb2RlKCkpIHsKKyAgICByZWYoKTsK KyAgICBpZiAoTm9kZUltcGwgKnAgPSBwYXJlbnROb2RlKCkpCisgICAgICAgIHAtPnJlbW92ZUNo aWxkKHRoaXMsIGV4Y2VwdGlvbmNvZGUpOworICAgIGVsc2UKICAgICAgICAgZXhjZXB0aW9uY29k ZSA9IERPTUV4Y2VwdGlvbjo6SElFUkFSQ0hZX1JFUVVFU1RfRVJSOwotICAgICAgICByZXR1cm47 Ci0gICAgfQotICAgIAotICAgIHBhcmVudE5vZGUoKS0+cmVtb3ZlQ2hpbGQodGhpcywgZXhjZXB0 aW9uY29kZSk7CisgICAgZGVyZWYoKTsKIH0KIAogYm9vbCBOb2RlSW1wbDo6aGFzQ2hpbGROb2Rl cyggICkgY29uc3QKQEAgLTI4Nyw3ICsyODYsNyBAQCB2b2lkIE5vZGVJbXBsOjpub3JtYWxpemUg KCkKICAgICAgICAgICAgIGlmIChleGNlcHRpb25jb2RlKQogICAgICAgICAgICAgICAgIHJldHVy bjsKIAotICAgICAgICAgICAgcmVtb3ZlQ2hpbGQobmV4dENoaWxkLGV4Y2VwdGlvbmNvZGUpOwor ICAgICAgICAgICAgbmV4dENoaWxkLT5yZW1vdmUoZXhjZXB0aW9uY29kZSk7CiAgICAgICAgICAg ICBpZiAoZXhjZXB0aW9uY29kZSkKICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0K QEAgLTMwMiw3ICszMDEsNyBAQCB2b2lkIE5vZGVJbXBsOjpub3JtYWxpemUgKCkKICAgICBpZiAo Y2hpbGQgJiYgIWNoaWxkLT5uZXh0U2libGluZygpICYmIGNoaWxkLT5pc1RleHROb2RlKCkpIHsK ICAgICAgICAgVGV4dEltcGwgKnRleHQgPSBzdGF0aWNfY2FzdDxUZXh0SW1wbCo+KGNoaWxkKTsK ICAgICAgICAgaWYgKHRleHQtPmRhdGEoKS5pc0VtcHR5KCkpCi0gICAgICAgICAgICByZW1vdmVD aGlsZChjaGlsZCwgZXhjZXB0aW9uY29kZSk7CisgICAgICAgICAgICBjaGlsZC0+cmVtb3ZlKGV4 Y2VwdGlvbmNvZGUpOwogICAgIH0KIH0KIAo=