47960 2010-10-19 18:04:22 -0700 ASSERTION FAILURE: !m_adoptionIsRequired for the WebFrame under the InjectedBundlePageLoaderClient::didClearWindowObjectForFrame callback 2010-10-20 14:35:50 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jberlin jberlin abarth aroben eric jberlin sam webkit.review.bot oldest_to_newest 296573 0 jberlin 2010-10-19 18:04:22 -0700 frame->init() in the WebFrame constructor causes the InjectedBundlePageLoaderClient::didClearWindowObjectForFrame callback to be called with a reference to the WebFrame (at which point the WebFrame has not yet been adopted). We should fix this by moving the frame->init() call into the WebFrame::create method. 296581 1 71238 jberlin 2010-10-19 18:11:26 -0700 Created attachment 71238 Move initializing the coreFrame into the WebFrame create method and out of the WebFrame constructor 296808 2 71238 ggaren 2010-10-20 08:21:16 -0700 Comment on attachment 71238 Move initializing the coreFrame into the WebFrame create method and out of the WebFrame constructor r=me 296810 3 71238 jberlin 2010-10-20 08:32:23 -0700 Comment on attachment 71238 Move initializing the coreFrame into the WebFrame create method and out of the WebFrame constructor Committed in r70148 http://trac.webkit.org/changeset/70148 296833 4 webkit.review.bot 2010-10-20 09:26:38 -0700 http://trac.webkit.org/changeset/70148 might have broken Leopard Intel Release (Tests) The following tests are not passing: fast/workers/storage/interrupt-database-sync.html 296838 5 jberlin 2010-10-20 09:34:52 -0700 (In reply to comment #4) > http://trac.webkit.org/changeset/70148 might have broken Leopard Intel Release (Tests) > The following tests are not passing: > fast/workers/storage/interrupt-database-sync.html Pretty unlikely, as we don't build WebKit2 stuff on Leopard. 297027 6 webkit.review.bot 2010-10-20 14:35:50 -0700 http://trac.webkit.org/changeset/70173 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: http/tests/xmlhttprequest/origin-whitelisting-removal.html 71238 2010-10-19 18:11:26 -0700 2010-10-20 08:32:23 -0700 Move initializing the coreFrame into the WebFrame create method and out of the WebFrame constructor fixAssertionFailureUnderDidClearWindowObjectForFrame.patch text/plain 1948 jberlin SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDExMykKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTAtMTAtMTkgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB U1NFUlRJT04gRkFJTFVSRTogIW1fYWRvcHRpb25Jc1JlcXVpcmVkIGZvciB0aGUgV2ViRnJhbWUg dW5kZXIgdGhlCisgICAgICAgIEluamVjdGVkQnVuZGxlUGFnZUxvYWRlckNsaWVudDo6ZGlkQ2xl YXJXaW5kb3dPYmplY3RGb3JGcmFtZSBjYWxsYmFjay4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3OTYwCisKKyAgICAgICAgRG8gbm90IHRyeSB0byBp bml0aWFsaXplIHRoZSBjb3JlRnJhbWUgKHdoaWNoIHJlc3VsdHMgaW4gdGhlCisgICAgICAgIElu amVjdGVkQnVuZGxlUGFnZUxvYWRlckNsaWVudDo6ZGlkQ2xlYXJXaW5kb3dPYmplY3RGb3JGcmFt ZSBiZWluZyBjYWxsZWQpIHVudGlsIGFmdGVyIHRoZQorICAgICAgICBXZWJGcmFtZSBjb25zdHJ1 Y3RvciBoYXMgcmV0dXJuZWQgYW5kIHRoZSBXZWJGcmFtZSBoYXMgYmVlbiBhZG9wdGVkLgorCisg ICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkZyYW1lLmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViRnJhbWU6OmNyZWF0ZSk6CisgICAgICAgIE1vdmVkIHRoZSBjYWxsIHRvIGluaXQgdGhl IGNvcmVGcmFtZSBoZXJlIC4uLgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZTo6V2ViRnJhbWUp OgorICAgICAgICAuLi4gZnJvbSBoZXJlLgorCiAyMDEwLTEwLTE5ICBBbmRlcnMgQ2FybHNzb24g IDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4K SW5kZXg6IFdlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkZyYW1lLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJGcmFtZS5jcHAJKHJldmlzaW9uIDcw MDk5KQorKysgV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViRnJhbWUuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC04NSwxMCArODUsMTIgQEAgUGFzc1JlZlB0cjxXZWJGcmFtZT4gV2ViRnJhbWU6 OmNyZWF0ZVN1YgogUGFzc1JlZlB0cjxXZWJGcmFtZT4gV2ViRnJhbWU6OmNyZWF0ZShXZWJQYWdl KiBwYWdlLCBjb25zdCBTdHJpbmcmIGZyYW1lTmFtZSwgSFRNTEZyYW1lT3duZXJFbGVtZW50KiBv d25lckVsZW1lbnQpCiB7CiAgICAgUmVmUHRyPFdlYkZyYW1lPiBmcmFtZSA9IGFkb3B0UmVmKG5l dyBXZWJGcmFtZShwYWdlLCBmcmFtZU5hbWUsIG93bmVyRWxlbWVudCkpOwotICAgIAorCiAgICAg Ly8gQWRkIGV4cGxpY3QgcmVmKCkgdGhhdCB3aWxsIGJlIGJhbGFuY2VkIGluIFdlYkZyYW1lTG9h ZGVyQ2xpZW50OjpmcmFtZUxvYWRlckRlc3Ryb3llZCgpLgogICAgIGZyYW1lLT5yZWYoKTsKLSAg ICAKKworICAgIGZyYW1lLT5jb3JlRnJhbWUoKS0+aW5pdCgpOworCiAgICAgcmV0dXJuIGZyYW1l LnJlbGVhc2UoKTsKIH0KIApAQCAtMTEyLDggKzExNCw2IEBAIFdlYkZyYW1lOjpXZWJGcmFtZShX ZWJQYWdlKiBwYWdlLCBjb25zdAogICAgICAgICBvd25lckVsZW1lbnQtPmRvY3VtZW50KCktPmZy YW1lKCktPnRyZWUoKS0+YXBwZW5kQ2hpbGQoZnJhbWUpOwogICAgIH0KIAotICAgIGZyYW1lLT5p bml0KCk7Ci0KICNpZm5kZWYgTkRFQlVHCiAgICAgd2ViRnJhbWVDb3VudGVyLmluY3JlbWVudCgp OwogI2VuZGlmCg==