47945 2010-10-19 16:17:23 -0700 [Qt] Wrong null check in PopupMenuQt 2010-10-20 06:18:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Qt P3 Normal --- 1 luiz luiz ademar commit-queue oldest_to_newest 296505 0 luiz 2010-10-19 16:17:23 -0700 Wrong null check in PopupMenuQt 296511 1 71220 luiz 2010-10-19 16:24:11 -0700 Created attachment 71220 patch 296691 2 71220 commit-queue 2010-10-20 01:05:13 -0700 Comment on attachment 71220 patch Clearing flags on attachment: 71220 Committed r70134: <http://trac.webkit.org/changeset/70134> 296692 3 commit-queue 2010-10-20 01:05:18 -0700 All reviewed patches have been landed. Closing bug. 296756 4 ademar 2010-10-20 06:18:07 -0700 Removing block:39121, as there's no such check in qtwebkit-2.1. The if clause was introduced as part of the refactoring done on trunk. 71220 2010-10-19 16:24:11 -0700 2010-10-20 01:05:13 -0700 patch 0001-Qt-Wrong-null-check-in-PopupMenuQt.patch text/plain 1531 luiz RnJvbSBmZGExMjVkYjk5NGI4M2EyY2IwNzIzMjJiOWFmZDY1ZGUxMmQ3MjI0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdWl6IEFnb3N0aW5pIDxsdWl6LmFnb3N0aW5pQG9wZW5ib3Nz YS5vcmc+CkRhdGU6IFR1ZSwgMTkgT2N0IDIwMTAgMjA6MjA6MjYgLTAzMDAKU3ViamVjdDogW1BB VENIXSBbUXRdIFdyb25nIG51bGwgY2hlY2sgaW4gUG9wdXBNZW51UXQKIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Nzk0NQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCgpXcm9uZyBudWxsIGNoZWNrIGluIFBvcHVwTWVudVF0LgoKKiBXZWJDb3JlU3VwcG9ydC9Q b3B1cE1lbnVRdC5jcHA6CihXZWJDb3JlOjpQb3B1cE1lbnVRdDo6aGlkZSk6Ci0tLQogV2ViS2l0 L3F0L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiBX ZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUG9wdXBNZW51UXQuY3BwIHwgICAgMiArLQogMiBmaWxl cyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDk2YmFlNWUu LmIxYzQ1MjYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L3F0 L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTEwLTE5ICBMdWl6IEFnb3N0aW5pICA8 bHVpei5hZ29zdGluaUBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gV3JvbmcgbnVsbCBjaGVjayBpbiBQb3B1cE1lbnVR dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc5NDUK KworICAgICAgICBXcm9uZyBudWxsIGNoZWNrIGluIFBvcHVwTWVudVF0LgorCisgICAgICAgICog V2ViQ29yZVN1cHBvcnQvUG9wdXBNZW51UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9wdXBN ZW51UXQ6OmhpZGUpOgorCiAyMDEwLTEwLTE4ICBWaWF0Y2hlc2xhdiBPc3RhcGVua28gIDxvc3Rh cGVua28udmlhdGNoZXNsYXZAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IExhc3ps byBHb21ib3MuCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUG9wdXBNZW51 UXQuY3BwIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1BvcHVwTWVudVF0LmNwcAppbmRleCA1 NmEwZmFjLi45YjM0OTU1IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUG9w dXBNZW51UXQuY3BwCisrKyBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Qb3B1cE1lbnVRdC5j cHAKQEAgLTEyNyw3ICsxMjcsNyBAQCB2b2lkIFBvcHVwTWVudVF0OjpkaWRIaWRlKCkKIAogdm9p ZCBQb3B1cE1lbnVRdDo6aGlkZSgpCiB7Ci0gICAgaWYgKCFtX3BvcHVwKQorICAgIGlmIChtX3Bv cHVwKQogICAgICAgICBtX3BvcHVwLT5oaWRlKCk7CiB9CiAKLS0gCjEuNy4yLjIKCg==